1 2010-10-29 Darin Adler <darin@apple.com>
3 Reviewed by Sam Weinig.
5 Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
6 https://bugs.webkit.org/show_bug.cgi?id=48574
8 * webkit/webkitprivate.h:
9 * webkit/webkitwebbackforwardlist.cpp:
10 (webkit_web_back_forward_list_dispose):
11 (webkit_web_back_forward_list_new_with_web_view):
12 (webkit_web_back_forward_list_go_forward):
13 (webkit_web_back_forward_list_go_back):
14 (webkit_web_back_forward_list_contains_item):
15 (webkit_web_back_forward_list_go_to_item):
16 (webkit_web_back_forward_list_get_forward_list_with_limit):
17 (webkit_web_back_forward_list_get_back_list_with_limit):
18 (webkit_web_back_forward_list_get_back_item):
19 (webkit_web_back_forward_list_get_current_item):
20 (webkit_web_back_forward_list_get_forward_item):
21 (webkit_web_back_forward_list_get_nth_item):
22 (webkit_web_back_forward_list_get_back_length):
23 (webkit_web_back_forward_list_get_forward_length):
24 (webkit_web_back_forward_list_get_limit):
25 (webkit_web_back_forward_list_set_limit):
26 (webkit_web_back_forward_list_add_item):
27 (webkit_web_back_forward_list_clear):
29 * webkit/webkitwebview.cpp:
30 (webkit_web_view_set_maintains_back_forward_list):
31 (webkit_web_view_get_back_forward_list):
32 Use BackForwardListImpl.
34 2010-10-29 Alexey Proskuryakov <ap@apple.com>
36 Reviewed by Darin Adler.
38 https://bugs.webkit.org/show_bug.cgi?id=48576
39 Let WebKit2 client know when a frame is a frameset
41 Added a blank implementation of the new FrameLoaderClient method.
43 * WebCoreSupport/FrameLoaderClientGtk.h:
44 * WebCoreSupport/FrameLoaderClientGtk.cpp:
45 (WebKit::FrameLoaderClient::dispatchDidBecomeFrameset):
47 2010-10-29 Alejandro G. Castro <alex@igalia.com>
49 Reviewed by Martin Robinson.
51 [GTK] Add the GtkScrollablePolicy property to the webview
52 https://bugs.webkit.org/show_bug.cgi?id=48357
54 Added the GtkScrollablePolicy properties to the webview widget, it
55 is now required for GtkScrollable widgets in GTK+ 3.x.
57 * webkit/webkitprivate.h:
58 * webkit/webkitwebview.cpp:
59 (setHorizontalScrollPolicy): Added.
60 (setVerticalScrollPolicy): Added.
61 (getHorizontalScrollPolicy): Added.
62 (getVerticalScrollPolicy): Added.
63 (webkit_web_view_get_property):
64 (webkit_web_view_set_property):
65 (webkit_web_view_class_init):
67 2010-10-28 Sergio Villar Senin <svillar@igalia.com>
69 Reviewed by Martin Robinson.
71 [GTK] WebKitWebFrame's load-status is not properly notified to the tests
72 https://bugs.webkit.org/show_bug.cgi?id=48048
74 "frame-created" signal must be issued before loading any data,
75 that way clients can correctly capture all the loading related
76 signals for that frame.
78 * WebCoreSupport/FrameLoaderClientGtk.cpp:
79 (WebKit::FrameLoaderClient::createFrame):
81 2010-10-27 Mario Sanchez Prada <msanchez@igalia.com>
83 Reviewed by Martin Robinson.
85 getTextAtOffset returns incorrect results if a link includes text and an image
86 https://bugs.webkit.org/show_bug.cgi?id=47365
88 New test to make sure this bug is actually fixed.
91 (testWebkitAtkLinksWithInlineImages): New test.
92 (main): Added new test.
94 2010-10-26 Antonio Gomes <agomes@rim.com>
96 Reviewed by Martin Robinson.
98 [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)
99 https://bugs.webkit.org/show_bug.cgi?id=48199
101 Implemented an initial version of the DumpRenderTreeSupportGtk class.
102 The main idea is that it groups together the bodies of many LayoutTestController
103 methods, so they can directly access WebCore features. This way we eliminate the
104 need of adding APIs to WebKitGTK just to expand its test coverage through DRT.
106 The DumpRenderTreeSupportGtk class so far includes a getter and setter for the WebKitTabToLinksPreferenceKey
107 property as a sample implementation. Also it makes it possible to unskip fast/events/tab-focus-anchor.html and
108 to fix stderr messages from all 22 spatial-navigation tests in fast/events/spatial-navigation.
110 * WebCoreSupport/ChromeClientGtk.cpp:
111 (WebKit::ChromeClient::tabsToLinks):
112 * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added.
113 (DumpRenderTreeSupportGtk::DumpRenderTreeSupportGtk):
114 (DumpRenderTreeSupportGtk::~DumpRenderTreeSupportGtk):
115 (DumpRenderTreeSupportGtk::setDumpRenderTreeModeEnabled):
116 (DumpRenderTreeSupportGtk::dumpRenderTreeModeEnabled): Getter to the WebKitTabToLinksPreferenceKey property.
117 (DumpRenderTreeSupportGtk::setLinksIncludedInFocusChain): Setter to the WebKitTabToLinksPreferenceKey property.
118 (DumpRenderTreeSupportGtk::linksIncludedInFocusChain):
119 * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added.
121 2010-10-26 Jenn Braithwaite <jennb@chromium.org>
123 Reviewed by Dmitry Titov.
125 Resource tracking failure when trying to move a frame between documents
126 https://bugs.webkit.org/show_bug.cgi?id=44713
128 * WebCoreSupport/FrameLoaderClientGtk.cpp:
129 (WebKit::FrameLoaderClient::transferLoadingResourceFromPage):
131 * WebCoreSupport/FrameLoaderClientGtk.h:
133 2010-10-26 Mario Sanchez Prada <msanchez@igalia.com>
135 Reviewed by Chris Fleizach.
137 [Gtk] Layout tables should indicate that they are not data tables via an object attribute
138 https://bugs.webkit.org/show_bug.cgi?id=35422
140 New unit test to check the 'layout-guess' attribute in tables.
143 (atkAttributeSetAttributeNameHasValue): New, looks for a attribute
144 with a specific value, by the name of attribute.
145 (atkAttributeSetContainsAttributeName): New, just checks whether
146 an attribute with a specified name is present in the set.
147 (atkAttributeSetAttributeHasValue): Modified to relay on the new
148 function atkAttributeSetAttributeNameHasValue().
149 (testWebkitAtkLayoutAndDataTables): New test.
150 (main): Added the new test.
152 2010-10-26 Xan Lopez <xlopez@igalia.com>
154 Reviewed by Martin Robinson.
156 [GTK] Port to new GtkScrollable interface in GTK+ 3.x
157 https://bugs.webkit.org/show_bug.cgi?id=48202
159 Use the new GtkScrollable interface when compiling against GTK+
162 * webkit/webkitwebview.cpp:
163 (setHorizontalAdjustment):
164 (setVerticalAdjustment):
165 (getHorizontalAdjustment):
166 (getVerticalAdjustment):
167 (webkit_web_view_get_property):
168 (webkit_web_view_set_property):
169 (webkit_web_view_class_init):
171 2010-10-22 Sam Weinig <sam@webkit.org>
173 Reviewed by Anders Carlsson.
175 WebKit2 needs to pass the current event modifier flags when requesting a new window
176 https://bugs.webkit.org/show_bug.cgi?id=48140
178 * WebCoreSupport/ChromeClientGtk.cpp:
179 (WebKit::ChromeClient::createWindow):
180 * WebCoreSupport/ChromeClientGtk.h:
181 * WebCoreSupport/FrameLoaderClientGtk.cpp:
182 (WebKit::FrameLoaderClient::dispatchCreatePage):
183 * WebCoreSupport/FrameLoaderClientGtk.h:
184 Add NavigationAction parameter.
186 2010-10-20 Philippe Normand <pnormand@igalia.com>
188 Reviewed by Xan Lopez.
190 [GTK] use gtk_widget_hide instead of gtk_widget_hide_all in the fullscreen video conroller
191 https://bugs.webkit.org/show_bug.cgi?id=47972
193 * WebCoreSupport/FullscreenVideoController.cpp:
194 (FullscreenVideoController::hideHud):
195 (FullscreenVideoController::exitFullscreen):
197 2010-10-19 Joone Hur <joone@kldp.org>
199 Reviewed by Martin Robinson.
201 [GTK] Needs fixing mistyped comments in the API documentation
202 https://bugs.webkit.org/show_bug.cgi?id=47656
204 Fixed mistyped comments in the API documenentation.
206 * webkit/webkitwebsettings.cpp: Fixed a mistyped comment in the the section block.
207 * webkit/webkitwebwindowfeatures.cpp: Fixed a mistyped comment in the section block.
209 2010-10-18 Xan Lopez <xlopez@igalia.com>
211 Reviewed by Martin Robinson.
213 * NEWS: update for 1.3.5 release.
214 * docs/webkitgtk-sections.txt: add new APIs.
216 2010-10-18 Pavel Feldman <pfeldman@chromium.org>
218 Reviewed by Simon Fraser.
220 Web Inspector: [crash] when Inspector Open in CSSStyleSelector::loadPendingImages().
221 https://bugs.webkit.org/show_bug.cgi?id=46224
223 * WebCoreSupport/InspectorClientGtk.cpp:
224 (WebKit::InspectorClient::sendMessageToFrontend):
226 2010-10-14 Antonio Gomes <agomes@rim.com>
228 Reviewed by Martin Robinson and Xan Lopez.
230 [Gtk]: DRT does not support frame flattening testing
231 https://bugs.webkit.org/show_bug.cgi?id=38650
233 Implement enable-frame-flattening API for Gtk+.
235 * webkit/webkitwebsettings.cpp:
236 (webkit_web_settings_class_init):
237 (webkit_web_settings_set_property):
238 (webkit_web_settings_get_property):
239 (webkit_web_settings_copy):
240 * webkit/webkitwebview.cpp:
241 (webkit_web_view_update_settings):
242 (webkit_web_view_settings_notify):
244 2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
246 Reviewed by Dirk Schulze.
248 Replace some String::format() usages by StringConcatenate in WebKit
249 https://bugs.webkit.org/show_bug.cgi?id=47714
251 * WebCoreSupport/FrameLoaderClientGtk.cpp:
252 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
253 * webkit/webkitwebsettings.cpp:
257 2010-10-14 Joone Hur <joone@kldp.org>
259 Reviewed by Andreas Kling.
261 [GTK] google.co.kr was missed when checking Google domains
262 https://bugs.webkit.org/show_bug.cgi?id=47652
264 WebKitGtk+ maintains a list of Google domains for working well with Google sites.
265 Add google.co.kr also to the list to be checked with other Google domains.
267 * WebCoreSupport/FrameLoaderClientGtk.cpp:
268 (WebKit::initializeDomainsList): Added google.co.kr.
270 2010-10-13 Sergio Villar Senin <svillar@igalia.com>
272 Reviewed by Martin Robinson.
274 WebKitGtk+ to use the new API from the imported SoupURILoader code
276 [GTK] Add HTTP caching support
277 https://bugs.webkit.org/show_bug.cgi?id=44261
279 ResourceHandleInternal m_msg is now called m_soupMessage.
281 * webkit/webkitdownload.cpp:
282 (webkit_download_new_with_handle):
283 (webkit_download_start):
285 2010-10-13 Xan Lopez <xlopez@igalia.com>
287 Reviewed by Gustavo Noronha.
289 [GTK] Remove more warnings from the g-i scanner run
290 https://bugs.webkit.org/show_bug.cgi?id=47255
292 Fixes almost all warnings coming from the g-i scanner.
294 * webkit/webkitsecurityorigin.cpp: Rename parameter names in
295 gtk-doc blurb to the actual name of the parameter.
296 * webkit/webkitsoupauthdialog.c: ditto.
297 (webkit_soup_auth_dialog_class_init): Write missing doc for the
298 'current-toplevel' signal.
299 * webkit/webkitsoupauthdialog.h: Rename signal parameter to its
301 * webkit/webkitwebdatabase.cpp: Rename parameter names in
302 gtk-doc blurb to the actual name of the parameter.
303 * webkit/webkitwebinspector.cpp: ditto.
304 (webkit_web_inspector_class_init): ditto.
305 * webkit/webkitwebview.cpp: ditto.
306 (webkit_web_view_class_init): ditto.
307 * webkit/webkitwebview.h: Rename the parameter names to be in sync
308 with the ones we use in the function definition.
310 2010-10-12 Sheriff Bot <webkit.review.bot@gmail.com>
312 Unreviewed, rolling out r69589.
313 http://trac.webkit.org/changeset/69589
314 https://bugs.webkit.org/show_bug.cgi?id=47547
316 Wrong patch landed from a bug with two patches (Requested by
317 mrobinson on #webkit).
319 * webkit/webkitdownload.cpp:
320 (webkit_download_new_with_handle):
321 (webkit_download_start):
323 2010-10-12 Sergio Villar Senin <svillar@igalia.com>
325 Reviewed by Martin Robinson.
327 [GTK] Add HTTP caching support
328 https://bugs.webkit.org/show_bug.cgi?id=44261
330 ResourceHandle's m_msg renamed to m_soupMsg and it's also now a PlatformRefPtr
332 * webkit/webkitdownload.cpp:
333 (webkit_download_new_with_handle):
334 (webkit_download_start):
336 2010-10-09 Carlos Garcia Campos <cgarcia@igalia.com>
338 Reviewed by Xan Lopez.
340 [GTK] Removed unused callback in webkitwebview
341 https://bugs.webkit.org/show_bug.cgi?id=47092
343 In webkit_web_view_forward_context_menu_event() a callback is
344 connected for the destroy signal of the popup menu, however we
345 reuse the same menu always, holding a ref to it, so it's not
346 destroyed when withdrawn by the user.
348 * webkit/webkitwebview.cpp:
349 (webkit_web_view_forward_context_menu_event):
351 2010-10-08 Martin Robinson <mrobinson@igalia.com>
353 Reviewed by Xan Lopez.
355 [GTK] Remove duplicate code in WebKit/gtk/WebCoreSupport/DragClientGtk.cpp
356 https://bugs.webkit.org/show_bug.cgi?id=47367
358 Remove as much duplicate code as possible from DragClientGtk. Most of this code
359 is GTK2/GTK3 independent, so only the bits that aren't should be protected by
362 * WebCoreSupport/DragClientGtk.cpp:
363 (WebKit::dragIconWindowDrawEventCallback): Modified the name of this callback
364 so that it is shared between build types.
365 (WebKit::DragClient::DragClient): Updated the signal connectors to reflect the change above.
366 (WebKit::DragClient::~DragClient): The build types share the callback name, so remove
368 (WebKit::DragClient::drawDragIconWindow): Changed the name of this method and make it
369 independent of the build type.
370 * WebCoreSupport/DragClientGtk.h: Update method declaration and remove #ifdefs.
372 2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
374 Reviewed by Xan Lopez.
376 [GTK] Use draw instead of expose_event in WebView when building with gtk3
377 https://bugs.webkit.org/show_bug.cgi?id=47338
379 * webkit/webkitwebview.cpp:
380 (webkit_web_view_expose_event):
381 (webkit_web_view_draw):
382 (webkit_web_view_class_init):
384 2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
386 Reviewed by Xan Lopez.
388 [GTK] Don't use GtkObject
389 https://bugs.webkit.org/show_bug.cgi?id=47090
391 GtkObject has been removed in gtk3.
393 * WebCoreSupport/EditorClientGtk.cpp:
394 (WebKit::EditorClient::generateEditorCommands):
395 * WebCoreSupport/FullscreenVideoController.cpp:
396 (FullscreenVideoController::createHud):
398 2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
400 Reviewed by Xan Lopez.
402 [GTK] Fix the build for GTK+ 3
403 https://bugs.webkit.org/show_bug.cgi?id=47249
405 Use GdkVisual instead of GdkColormap. GdkColormap has been removed
408 * webkit/webkitwebview.cpp:
409 (webkit_web_view_realize):
411 2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
413 Reviewed by Xan Lopez.
415 [GTK] Fix the build for GTK+ 3
416 https://bugs.webkit.org/show_bug.cgi?id=47249
418 Do not use GdkDrawable deprecated API. Some methods of GdkDrawable
419 are deprecated in gtk2 and have been removed in gtk3. Equivalent
420 API has been added to GdkWindow.
422 * tests/testcopyandpaste.c:
423 (runPasteTestCallback):
424 * webkit/webkitwebview.cpp:
425 (webkit_web_view_button_press_event):
427 2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
429 Reviewed by Xan Lopez.
431 [GTK] Use draw signal instead of expose_event in DragClientGtk when building with gtk3
432 https://bugs.webkit.org/show_bug.cgi?id=47326
434 * WebCoreSupport/DragClientGtk.cpp:
435 (WebKit::dragIconWindowDrawCallback):
436 (WebKit::DragClient::DragClient):
437 (WebKit::DragClient::~DragClient):
438 (WebKit::DragClient::startDrag):
439 (WebKit::DragClient::dragIconWindowDraw):
440 * WebCoreSupport/DragClientGtk.h:
442 2010-10-07 Carlos Garcia Campos <cgarcia@igalia.com>
444 Reviewed by Xan Lopez.
446 [GTK] Fix the build for GTK+ 3
447 https://bugs.webkit.org/show_bug.cgi?id=47249
449 Don't use gtk_size_request_get_size(). It has been removed,
450 gtk_widget_get_preferred_size() should be used instead
452 * webkit/webkitwebview.cpp:
453 (PopupMenuPositionFunc):
455 2010-10-06 Sheriff Bot <webkit.review.bot@gmail.com>
457 Unreviewed, rolling out r69201.
458 http://trac.webkit.org/changeset/69201
459 https://bugs.webkit.org/show_bug.cgi?id=47279
461 This change broke the WebKitGTK+ build for GTK+ 2.0.
462 (Requested by mrobinson on #webkit).
464 * tests/testcopyandpaste.c:
465 (runPasteTestCallback):
466 * webkit/webkitwebview.cpp:
467 (webkit_web_view_button_press_event):
469 2010-10-06 Carlos Garcia Campos <cgarcia@igalia.com>
471 Reviewed by Xan Lopez.
473 Port to gtk+3 (2.91.0)
474 https://bugs.webkit.org/show_bug.cgi?id=47249
476 Do not use GdkDrawable deprecated API
478 Some methods of GdkDrawable are deprecated in gtk2 and have been
479 remmoved in gtk3. Equivalent API has been added to GdkWindow.
481 * tests/testcopyandpaste.c:
482 (runPasteTestCallback):
483 * webkit/webkitwebview.cpp:
484 (webkit_web_view_button_press_event):
486 2010-09-28 Jenn Braithwaite <jennb@chromium.org>
488 Reviewed by Dmitry Titov.
490 Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
491 https://bugs.webkit.org/show_bug.cgi?id=46663
493 * WebCoreSupport/FrameLoaderClientGtk.cpp:
494 (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument):
495 * WebCoreSupport/FrameLoaderClientGtk.h:
497 2010-09-27 Mario Sanchez Prada <msanchez@igalia.com>
499 Reviewed by Chris Fleizach.
501 [Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items
502 https://bugs.webkit.org/show_bug.cgi?id=45381
504 Updated test to match the new exposure of list item markers.
506 Also, added some extra assertions in that test to make sure the
507 accessible objects associated to the items implement AtkText.
510 (testWebkitAtkListsOfItems):
513 2010-09-27 Philippe Normand <pnormand@igalia.com>
515 Reviewed by Martin Robinson.
517 [GTK] Doesn't build with gtk+ 2.14
518 https://bugs.webkit.org/show_bug.cgi?id=46565
520 Fixed the build for GTK+ 2.14. Don't use gdk_window_get_cursor()
521 for that GTK+ version as I found no acceptable way to work-around
524 * WebCoreSupport/FullscreenVideoController.cpp:
525 (FullscreenVideoController::showHud):
526 (FullscreenVideoController::hideHud):
527 (FullscreenVideoController::enterFullscreen):
529 2010-09-26 Jenn Braithwaite <jennb@chromium.org>
531 Reviewed by Adam Barth.
533 GTK client needs updating when live iframe element is moved
535 https://bugs.webkit.org/show_bug.cgi?id=46300
537 Test: fast/frames/iframe-reparenting-adopt-node.html
539 * WebCoreSupport/FrameLoaderClientGtk.cpp:
540 (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument):
541 Update the webView for the frame to match the parent frame's
544 2010-09-24 Martin Robinson <mrobinson@igalia.com>
546 Reviewed by Gustavo Noronha Silva.
548 [GTK] opening local files on win32
549 https://bugs.webkit.org/show_bug.cgi?id=31066
551 Add tests that check the mime type returned by local files loaded via file URLs.
553 * tests/testmimehandling.c:
554 (testRemoteMimeType): Added.
555 (testLocalMimeType): Added.
556 (main): Run tests by using g_test_add_data_func with either
557 testRemoteMimeType or testLocalMimeType.
559 2010-09-23 Martin Robinson <mrobinson@igalia.com>
561 Reviewed by Nate Chapin.
563 [GTK] Some tests from r68174 fail on the GTK+ bots
564 https://bugs.webkit.org/show_bug.cgi?id=46396
566 Fix since version number in this new WebKitWebSettings property.
568 * webkit/webkitwebsettings.cpp:
569 (webkit_web_settings_class_init): Fix the since version number.
571 2010-09-23 Nate Chapin <japhet@chromium.org>
573 Unreviewed, build fix.
575 Add a missing comma in webkitwebsettings.cpp.
577 * webkit/webkitwebsettings.cpp:
579 2010-09-23 Nate Chapin <japhet@chromium.org>
581 Reviewed by Darin Fisher.
583 Add hyperlink auditing settings (i.e., <a ping>).
584 https://bugs.webkit.org/show_bug.cgi?id=30458
586 * webkit/webkitwebsettings.cpp:
587 (webkit_web_settings_class_init):
588 (webkit_web_settings_set_property):
589 (webkit_web_settings_get_property):
590 (webkit_web_settings_copy):
591 * webkit/webkitwebview.cpp:
592 (webkit_web_view_update_settings):
593 (webkit_web_view_settings_notify):
595 2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>
597 Reviewed by Martin Robinson.
599 [GTK] Replace instances of g_timeout_add() with g_idle_add() in testatk.c
600 https://bugs.webkit.org/show_bug.cgi?id=46284
602 Use g_idle_add() whenever g_timeout_add() was being used.
604 This is desired because it's better to rely on the main loop to
605 decide when it's a good moment to execute the task (when idle)
606 than manually setting a timeout, which also sets a minimum amount
607 of time needed to get the function executed.
610 (testWekitAtkTextSelections):
611 (testWebkitAtkGetExtents):
612 (testWebkitAtkListsOfItems):
615 2010-09-22 Mario Sanchez Prada <msanchez@igalia.com>
617 Reviewed by Martin Robinson.
619 [Gtk] object:text-changed events should be emitted for entries and password text
620 https://bugs.webkit.org/show_bug.cgi?id=25898
622 New unit test to make sure text-changed signals are emitted
625 (textChangedCb): New. Signal handler for the
626 text-changed::insert and text-changed::delete signals.
627 (checkTextChangesAndBailOut): New. Source function to check
628 the global result of the test and quit from the main loop.
629 (testWebkitAtkTextChangedNotifications): New test.
632 2010-09-22 Martin Robinson <mrobinson@igalia.com>
634 Reviewed by Xan Lopez.
636 Added information about drop shadow improvements to the NEWS file.
638 * NEWS: Added information about drop shadow improvements.
640 2010-09-21 Xan Lopez <xlopez@igalia.com>
642 Reviewed by Martin Robinson.
644 [GTK] Fix transfer annotations for WebKitGTK+ static API
645 https://bugs.webkit.org/show_bug.cgi?id=46244
647 Deal with all the warnings related to transfer issues. Mostly the
648 problem was the transfer being missing, but there were also typos
649 in the function name or missing ':' at the end of the function
652 * webkit/webkitdownload.cpp:
653 * webkit/webkitnetworkrequest.cpp:
654 * webkit/webkitnetworkresponse.cpp:
655 * webkit/webkitsecurityorigin.cpp:
656 * webkit/webkitwebdatabase.cpp:
657 * webkit/webkitwebdatasource.cpp:
658 * webkit/webkitwebframe.cpp:
659 * webkit/webkitwebhistoryitem.cpp:
660 * webkit/webkitwebinspector.cpp:
661 * webkit/webkitwebresource.cpp:
662 * webkit/webkitwebsettings.cpp:
663 * webkit/webkitwebview.cpp:
664 (webkit_web_view_class_init):
665 (webkit_web_view_get_main_frame):
667 2010-09-21 Xan Lopez <xlopez@igalia.com>
669 Reviewed by Gustavo Noronha.
671 Update for 1.3.4 release.
675 2010-09-17 Darin Adler <darin@apple.com>
677 Reviewed by Sam Weinig.
679 REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
680 https://bugs.webkit.org/show_bug.cgi?id=42863
682 * webkit/webkitwebview.cpp:
683 (webkit_web_view_get_zoom_level):
684 (webkit_web_view_apply_zoom_level):
685 (webkit_web_view_set_full_content_zoom):
686 Call functions on Frame instead of FrameView.
688 2010-09-16 Martin Robinson <mrobinson@igalia.com>
690 Reviewed by Xan Lopez.
692 [GTK] Implement dissolveDragImageToFraction
693 https://bugs.webkit.org/show_bug.cgi?id=45826
695 To support full alpha in the drag icon, changed the drag icon to be a
696 GtkWindow with an RGBA colormap. Added logic to support painting the drag
697 image to this window during the expose event.
699 * WebCoreSupport/DragClientGtk.cpp:
700 (WebKit::dragIconWindowExposeEventCallback): Added.
701 (WebKit::DragClient::DragClient): Initialize the new drag icon window.
702 (WebKit::DragClient::~DragClient): Disconnect the expose event signal.
703 (WebKit::DragClient::startDrag): Resize the drag icon window the appropriate size and
704 if necessary, set its colormap.
705 (WebKit::DragClient::dragIconWindowExposeEvent): Added.
706 * WebCoreSupport/DragClientGtk.h: Added new member and method declarations.
708 2010-09-14 Philippe Normand <pnormand@igalia.com>
710 Reviewed by Eric Carlson and Martin Robinson.
712 [GTK] eventSender.contextClick() should return the contents of the context menu
713 https://bugs.webkit.org/show_bug.cgi?id=39102
715 New private WebView API to retrieve the context-menu widget. This
718 * webkit/webkitprivate.h:
719 * webkit/webkitwebview.cpp:
720 (webkit_web_view_get_context_menu):
722 2010-09-16 Alejandro G. Castro <alex@igalia.com>
724 Reviewed by Xan Lopez.
726 GTK+ 3.x. updates, gtk_widget_size_request is deprecated and
727 "activate-slider" style property for scrollbars is gone.
729 * webkit/webkitwebview.cpp:
730 (PopupMenuPositionFunc):
732 2010-09-15 Martin Robinson <mrobinson@igalia.com>
734 Reviewed by David Levin.
736 [GTK] [REGRESSION] r67591 broke the testwebbackforwardlist API test and introduced a memory leak
737 https://bugs.webkit.org/show_bug.cgi?id=45865
739 When initializing the backForwardList private member of the WebView, do
740 so with adoptPlatformRef to prevent a memory leak.
742 * webkit/webkitwebview.cpp:
743 (webkit_web_view_init): Initialize member with adoptPlatformRef.
745 2010-09-15 Martin Robinson <mrobinson@igalia.com>
747 Reviewed by Eric Seidel.
749 [Gtk] Use GOwnPtr for code that needs it
750 https://bugs.webkit.org/show_bug.cgi?id=21594
752 Convert as reference counted private members of WebKitWebView to
753 smart pointers as possible. This removes a lot of unecessary manual
754 memory management. Also convert some pointer members away from pointer
755 types, now that we are sure their destructors are called.
757 * WebCoreSupport/ContextMenuClientGtk.cpp:
758 (WebKit::inputMethodsMenuItem): Updated to reflect PlatformRefPtr changes.
759 * WebCoreSupport/DragClientGtk.cpp:
760 (WebKit::DragClient::startDrag): Ditto.
761 * WebCoreSupport/EditorClientGtk.cpp:
762 (WebKit::EditorClient::setInputMethodState): Ditto.
763 (WebKit::EditorClient::respondToChangedSelection): Ditto.
764 (WebKit::EditorClient::handleInputMethodKeydown): Ditto.
765 (WebKit::EditorClient::handleInputMethodMousePress): Ditto.
766 (WebKit::EditorClient::EditorClient): Ditto.
767 (WebKit::EditorClient::~EditorClient): Ditto.
768 * WebCoreSupport/FrameLoaderClientGtk.cpp:
769 (WebKit::postCommitFrameViewSetup): Ditto.
770 * webkit/webkitprivate.h: Ditto.
771 * webkit/webkitwebview.cpp: Ditto.
772 (destroy_menu_cb): Ditto.
773 (webkit_web_view_forward_context_menu_event): Ditto.
774 (webkit_web_view_key_release_event): Ditto.
775 (webkit_web_view_button_press_event): Ditto.
776 (webkit_web_view_button_release_event): Ditto.
777 (webkit_web_view_focus_in_event): Ditto.
778 (webkit_web_view_focus_out_event): Ditto.
779 (webkit_web_view_realize): Ditto.
780 (webkit_web_view_set_scroll_adjustments): Ditto.
781 (webkit_web_view_dispose): Changed all g_object_unref calls to
782 PlatformRefPtr.clear(). Although this will also be done by the manual
783 call to the WebKitWebViewPrivate destructor, the order that these
784 fields are zero'd in is still very sensitive.
785 (webkit_web_view_finalize): Updated to reflect PlatformRefPtr changes.
786 (webViewGetDPI): Ditto.
787 (webkit_web_view_screen_changed): Ditto.
788 (webkit_web_view_drag_end): Ditto.
789 (webkit_web_view_drag_data_get): Ditto.
790 (doDragLeaveLater): Ditto.
791 (webkit_web_view_drag_leave): Ditto.
792 (webkit_web_view_drag_motion): Ditto.
793 (webkit_web_view_drag_data_received): Ditto.
794 (webkit_web_view_drag_drop): Ditto.
795 (webkit_web_view_get_im_context): Ditto.
796 (webkit_web_view_update_settings): Ditto.
797 (webkit_web_view_init): Ditto.
798 (webkit_web_view_set_settings): Ditto.
799 (webkit_web_view_get_settings): Ditto.
800 (webkit_web_view_get_inspector): Ditto.
801 (webkit_web_view_set_window_features): Ditto.
802 (webkit_web_view_get_window_features): Ditto.
803 (webkit_web_view_get_back_forward_list): Ditto.
804 (webkit_web_view_zoom_in): Ditto.
805 (webkit_web_view_zoom_out): Ditto.
806 (webkit_web_view_add_resource): Ditto.
807 (webkit_web_view_get_resource): Ditto.
808 (webkit_web_view_get_main_resource): Ditto.
809 (webkit_web_view_clear_resources): Ditto.
810 (webkit_web_view_get_subresources): Ditto.
812 2010-09-14 Martin Robinson <mrobinson@igalia.com>
814 Reviewed by Xan Lopez.
816 [GTK] fast/events/keydown-numpad-keys.html produces many GLib warnings
817 https://bugs.webkit.org/show_bug.cgi?id=45775
819 Handle the toggle-overwrite signal on the GtkTextView used for generating editing
820 commands. Ignore this signals, as the default handler assumes that the GtkTextView
821 has a layout and this one does not.
823 * WebCoreSupport/EditorClientGtk.cpp:
824 (WebKit::toggleOverwriteCallback): Added. Cancels the default handler.
825 (WebKit::EditorClient::EditorClient): Attach a handler for toggle-overwrite.
827 2010-09-14 Pavel Feldman <pfeldman@chromium.org>
829 Reviewed by Yury Semikhatsky.
831 Web Inspector: Provide network-based load timing.
832 Before this change, inspector used timers taken from
833 within WebCore notifications (that are by definition
834 synchronous and serialized). As a result, timing was
835 affected by the routines running on the main thread
836 (JavaScript and such).
837 https://bugs.webkit.org/show_bug.cgi?id=45664
839 * webkit/webkitdownload.cpp:
840 (DownloadClient::didFinishLoading):
842 2010-09-15 Sheriff Bot <webkit.review.bot@gmail.com>
844 Unreviewed, rolling out r67551.
845 http://trac.webkit.org/changeset/67551
846 https://bugs.webkit.org/show_bug.cgi?id=45816
848 "Plugin tests fail" (Requested by yurys on #webkit).
850 * webkit/webkitdownload.cpp:
851 (DownloadClient::didFinishLoading):
853 2010-09-14 Pavel Feldman <pfeldman@chromium.org>
855 Reviewed by Yury Semikhatsky.
857 Web Inspector: Provide network-based load timing.
858 Before this change, inspector used timers taken from
859 within WebCore notifications (that are by definition
860 synchronous and serialized). As a result, timing was
861 affected by the routines running on the main thread
862 (JavaScript and such).
863 https://bugs.webkit.org/show_bug.cgi?id=45664
865 * webkit/webkitdownload.cpp:
866 (DownloadClient::didFinishLoading):
868 2010-09-13 Enrica Casucci <enrica@apple.com>
870 Reviewed by Sam Weinig.
872 Paste should be implemented in WebCore like Copy and Cut for Mac also.
873 https://bugs.webkit.org/show_bug.cgi?id=45494
874 <rdar://problem/7660537>
876 On the Mac platform, the implementation of the paste operation is all done
877 at the WebKit level. In order to support it on WebKit2 it is necessary to
878 refactor the code and move this functionality at the level of WebCore like
879 we already have on Windows.
880 The original code relies on some in AppKit functions that call back into
881 WebKit causing problems in WebKit2. All this functionality has been moved
882 at the level of the editor client where it can be dealt with appropriately.
884 * WebCoreSupport/FrameLoaderClientGtk.cpp:
885 (WebKit::FrameLoaderClient::canShowMIMETypeAsHTML): Added stub.
886 * WebCoreSupport/FrameLoaderClientGtk.h:
888 2010-09-13 Mario Sanchez Prada <msanchez@igalia.com>
890 Reviewed by Martin Robinson.
892 [GTK] Provide unit tests for AtkText's text selection functions
893 https://bugs.webkit.org/show_bug.cgi?id=43919
895 New tests to check getting, setting and removing text selections
898 (testWekitAtkTextSelections): New unit tests to check all the text
899 selection related functions altogether through a single test
903 Make sure that code dependant on getting information from the
904 clipboard gets executed only when there's a GDK window associated
905 to the webview widget, as that's not the case when executing the
906 unit tests (the wedbview is not inside of any toplevel window) and
907 will make the tests crash if not taken into account.
909 * WebCoreSupport/EditorClientGtk.cpp:
910 (WebKit::EditorClient::respondToChangedSelection):
912 2010-09-11 Xan Lopez <xlopez@igalia.com>
914 Reviewed by Martin Robinson.
916 [GTK] Make introspection work with g-o-i 0.9.5
917 https://bugs.webkit.org/show_bug.cgi?id=45590
919 Use new type syntax and bump version number of the gir file.
923 2010-09-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
925 Reviewed by Darin Adler.
927 Add NetworkingContext to avoid layer violations
928 https://bugs.webkit.org/show_bug.cgi?id=42292
930 * webkit/webkitdownload.cpp:
931 (webkit_download_start):
932 * webkit/webkitprivate.cpp:
933 (currentToplevelCallback):
935 2010-09-10 Sam Weinig <sam@webkit.org>
939 * webkit/webkitwebview.cpp:
940 (webkit_web_view_set_full_content_zoom):
942 2010-09-10 Sam Weinig <sam@webkit.org>
944 Reviewed by Darin Adler.
946 Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
947 Precursor to <rdar://problem/7660657>
948 https://bugs.webkit.org/show_bug.cgi?id=45522
950 * webkit/webkitwebview.cpp:
951 (webkit_web_view_get_zoom_level):
952 (webkit_web_view_apply_zoom_level):
953 (webkit_web_view_set_full_content_zoom):
955 2010-09-10 Mario Sanchez Prada <msanchez@igalia.com>
957 Reviewed by Gustavo Noronha Silva.
959 [GTK] Fix warnings because of bad assignments in testatk.c
960 https://bugs.webkit.org/show_bug.cgi?id=45538
962 Use AtkObject and AtkText instances properly in the code.
965 (testWebkitAtkListsOfItems):
967 2010-09-10 Adam Barth <abarth@webkit.org>
969 Reviewed by Darin Fisher.
971 Move code from WebKit-layer to DocumentLoader
972 https://bugs.webkit.org/show_bug.cgi?id=45569
974 * WebCoreSupport/FrameLoaderClientGtk.cpp:
975 (WebKit::FrameLoaderClient::committedLoad):
977 2010-09-10 Adam Barth <abarth@webkit.org>
979 Reviewed by Eric Seidel.
981 Main resource bytes shouldn't bounce through FrameLoader
982 https://bugs.webkit.org/show_bug.cgi?id=45496
984 Now return the bytes to the DocumentLoader.
986 * WebCoreSupport/FrameLoaderClientGtk.cpp:
987 (WebKit::FrameLoaderClient::committedLoad):
989 2010-09-10 Martin Robinson <mrobinson@igalia.com>
991 Reviewed by Xan Lopez.
993 [GTK] Placement new / manual destructor invocation should be used on private GObject memory
994 https://bugs.webkit.org/show_bug.cgi?id=45550
996 GLib allocates and deallocates GObject private data structs itself. When
997 those structs contain C++ members, their constructors and destructors are not
998 called. This is not only dangerous, it makes RefPtr-type smart pointers much
999 less useful. We can fix this problem by calling placement new on the private
1000 data struct during instance initialization and calling the destructor during
1003 This patch takes that approach and switches plain char* members of
1004 WebKitWebView (with manual memory allocation) to use CString.
1006 * webkit/webkitprivate.h: Switch char* members to CString.
1007 * webkit/webkitwebview.cpp:
1008 (webkit_web_view_finalize): Manually call the destructor on the private
1009 data. Remove manual deallocation of members which are now CString.
1010 (webkit_web_view_query_tooltip): Update to reflect CString change.
1011 (webkit_web_view_init): Use placement new to initialize C++ members of
1012 the private data section.
1013 (webkit_web_view_get_encoding): Update to reflect CString change.
1014 (webkit_web_view_get_custom_encoding): Ditto.
1015 (webkit_web_view_add_resource): Ditto.
1016 (webkit_web_view_get_resource): Ditto.
1017 (webkit_web_view_clear_resources): Ditto.
1018 (webkit_web_view_set_tooltip_text): Ditto.
1019 (webkit_web_view_get_icon_uri): Ditto.
1021 2010-09-10 Gustavo Noronha Silva <gns@gnome.org>
1023 Reviewed by Martin Robinson.
1025 [GTK] Google sites do not like WebKitGTK+
1026 https://bugs.webkit.org/show_bug.cgi?id=39617
1028 Special-case Google domains, and spoof User-Agent when talking to
1029 them, to stop being treated as a second-class citizen.
1031 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1032 (WebKit::initializeDomainsList):
1033 (WebKit::isGoogleDomain):
1034 (WebKit::FrameLoaderClient::userAgent): If enable-site-specific-quirks
1035 is enabled, send the standard WebKit User-Agent string, disregarding the
1036 custom one set by the browser for Google domains.
1037 * webkit/webkitprivate.h:
1038 * webkit/webkitwebsettings.cpp:
1039 (webkitPlatform): Fix style, and simplify.
1040 (webkitOSVersion): Ditto.
1041 (webkitUserAgent): Add the Version/x.y string Safari has been
1042 using since Safari 2.2.
1044 2010-09-10 Xan Lopez <xlopez@igalia.com>
1046 Reviewed by Martin Robinson.
1048 Fix compilation with GTK+ 3.x.
1050 GDK key macros were renamed from GDK_FOO to GDK_KEY_FOO, we need
1051 to include the compat header provided if we want to keep using the
1054 * WebCoreSupport/FullscreenVideoController.cpp: include GtkVersioning.h
1056 2010-09-08 Darin Adler <darin@apple.com>
1058 Reviewed by Adam Barth.
1060 Move functions from Frame to Editor as planned
1061 https://bugs.webkit.org/show_bug.cgi?id=45218
1063 * webkit/webkitwebview.cpp:
1064 (webkit_web_view_set_highlight_text_matches):
1065 (webkit_web_view_get_selected_text):
1066 (webkit_web_view_set_editable):
1067 Changed call sites to use editor().
1069 2010-09-09 Philippe Normand <pnormand@igalia.com>
1071 Reviewed by Martin Robinson.
1073 [GTK] testmimehandling falsely succeeds testing Ogg mime type
1074 https://bugs.webkit.org/show_bug.cgi?id=45349
1076 Make this actually test an ogg file request instead of pdf and
1077 changed the expected result to match libsoup content-sniffing
1078 result in the case of ogg/vorbis file.
1080 * tests/testmimehandling.c:
1081 (mime_type_policy_decision_requested_cb):
1084 2010-09-08 Mario Sanchez Prada <msanchez@igalia.com>
1086 Reviewed by Martin Robinson.
1088 [Gtk] A list item's number/bullet should not be a child of that list item
1089 https://bugs.webkit.org/show_bug.cgi?id=45190
1091 New unit test added.
1094 (testWebkitAtkListsOfItems): New test to check ordered/unordered
1095 list of items are properly exposed to AT technologies.
1098 2010-09-07 Martin Robinson <mrobinson@igalia.com>
1100 Reviewed by Xan Lopez.
1102 [GTK] Fix some feature guards
1103 https://bugs.webkit.org/show_bug.cgi?id=45302
1105 * webkit/webkitprivate.h: Add ENABLE(VIDEO) guards for video specific members.
1107 2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
1109 Reviewed by Darin Adler.
1111 Add NetworkingContext to avoid layer violations
1112 https://bugs.webkit.org/show_bug.cgi?id=42292
1114 Add GTK's specific implementation of FrameNetworkingContext.
1116 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1117 (WebKit::FrameLoaderClient::createNetworkingContext):
1118 * WebCoreSupport/FrameLoaderClientGtk.h:
1120 2010-09-03 Xan Lopez <xlopez@igalia.com>
1122 Reviewed by Gustavo Noronha.
1124 Dialog separators are gone in GTK+ 3.x.
1126 * webkit/webkitsoupauthdialog.c:
1129 2010-09-02 Yury Semikhatsky <yurys@chromium.org>
1131 Reviewed by Pavel Feldman.
1133 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
1134 https://bugs.webkit.org/show_bug.cgi?id=44230
1136 * WebCoreSupport/InspectorClientGtk.cpp:
1137 (WebKit::notifyWebViewDestroyed):
1138 (WebKit::InspectorFrontendClient::destroyInspectorWindow):
1139 (WebKit::InspectorFrontendClient::closeWindow):
1140 (WebKit::InspectorFrontendClient::disconnectFromBackend):
1141 * WebCoreSupport/InspectorClientGtk.h:
1143 2010-08-31 Dave Hyatt <hyatt@apple.com>
1145 Reviewed by Sam Weinig.
1147 https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
1148 the former can occur in more places without having to do the latter.
1150 * webkit/webkitwebview.cpp:
1151 (webkit_web_view_expose_event):
1153 2010-08-31 Martin Robinson <mrobinson@igalia.com>
1155 Reviewed by Gustavo Noronha Silva.
1157 [GTK] Isolate all GTK+ typedefs into one file
1158 https://bugs.webkit.org/show_bug.cgi?id=44900
1160 * WebCoreSupport/EditorClientGtk.h: Remove GTK+ typedefs.
1161 * WebCoreSupport/FullscreenVideoController.h: Ditto.
1163 2010-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1165 Reviewed by Martin Robinson.
1167 Preparations for the 1.3.4 release.
1170 * docs/webkitgtk-docs.sgml:
1172 2010-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1174 Unreviewed. Minor documentation typo fix.
1176 * webkit/webkitwebview.cpp:
1178 2010-08-30 Alejandro G. Castro <alex@igalia.com>
1180 Reviewed by Martin Robinson.
1182 [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
1184 https://bugs.webkit.org/show_bug.cgi?id=44787
1186 We have replaced GtkVersioning.cpp with GtkVersioning.c and
1187 created a function (getDefaultGDKPointerDevice) to get the pointer
1188 of the window with the new APIs. We added that function to DRT and
1189 copyandpaste unit test.
1191 * tests/testcopyandpaste.c:
1192 (runPasteTestCallback):
1194 2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
1196 Unreviewed, rolling out r66198.
1197 http://trac.webkit.org/changeset/66198
1198 https://bugs.webkit.org/show_bug.cgi?id=44856
1200 It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
1202 * WebCoreSupport/InspectorClientGtk.cpp:
1203 (WebKit::notifyWebViewDestroyed):
1204 (WebKit::InspectorFrontendClient::destroyInspectorWindow):
1205 (WebKit::InspectorFrontendClient::closeWindow):
1206 * WebCoreSupport/InspectorClientGtk.h:
1208 2010-08-27 Yury Semikhatsky <yurys@chromium.org>
1210 Reviewed by Pavel Feldman.
1212 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
1213 https://bugs.webkit.org/show_bug.cgi?id=44230
1215 * WebCoreSupport/InspectorClientGtk.cpp:
1216 (WebKit::notifyWebViewDestroyed):
1217 (WebKit::InspectorFrontendClient::destroyInspectorWindow):
1218 (WebKit::InspectorFrontendClient::closeWindow):
1219 (WebKit::InspectorFrontendClient::disconnectFromBackend):
1220 * WebCoreSupport/InspectorClientGtk.h:
1222 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
1224 Unreviewed. Revert r66103 since Qt tests are failing.
1226 * WebCoreSupport/InspectorClientGtk.cpp:
1227 (WebKit::notifyWebViewDestroyed):
1228 (WebKit::InspectorFrontendClient::destroyInspectorWindow):
1229 (WebKit::InspectorFrontendClient::closeWindow):
1230 * WebCoreSupport/InspectorClientGtk.h:
1232 2010-08-26 Yury Semikhatsky <yurys@chromium.org>
1234 Reviewed by Pavel Feldman.
1236 REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
1237 https://bugs.webkit.org/show_bug.cgi?id=44230
1239 * WebCoreSupport/InspectorClientGtk.cpp:
1240 (WebKit::notifyWebViewDestroyed):
1241 (WebKit::InspectorFrontendClient::destroyInspectorWindow):
1242 (WebKit::InspectorFrontendClient::closeWindow):
1243 (WebKit::InspectorFrontendClient::disconnectFromBackend):
1244 * WebCoreSupport/InspectorClientGtk.h:
1246 2010-08-26 Gustavo Noronha Silva <gns@gnome.org>
1248 Reviewed by Martin Robinson.
1250 [GTK] WebKitGTK+ needs proper introspection annotation for most types and methods
1251 https://bugs.webkit.org/show_bug.cgi?id=44565
1253 Add documentation and introspection specific information to a few
1254 getter and setter methods.
1256 * webkit/webkitwebview.cpp:
1258 2010-08-25 Martin Robinson <mrobinson@igalia.com>
1260 Reviewed by Gustavo Noronha Silva.
1262 confirm dialog should show OK/Cancel instead of Yes/No for consistency
1263 https://bugs.webkit.org/show_bug.cgi?id=32877
1265 Change the button labels for the fallback confirmation dialog to be
1268 * webkit/webkitwebview.cpp:
1269 (webkit_web_view_script_dialog):
1271 2010-08-25 Martin Robinson <mrobinson@igalia.com>
1273 Reviewed by Gustavo Noronha Silva.
1275 Cairo and EFL port shouldn't depend on glib.
1276 https://bugs.webkit.org/show_bug.cgi?id=44354
1278 Replace occurrences of GRefPtr and adoptGRef with PlatformRefPtr and
1281 * WebCoreSupport/ChromeClientGtk.cpp:
1282 (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
1283 * WebCoreSupport/DragClientGtk.cpp:
1284 (WebKit::DragClient::startDrag):
1285 * WebCoreSupport/EditorClientGtk.h:
1286 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1287 (WebKit::FrameLoaderClient::dispatchWillSendRequest):
1288 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
1289 (WebKit::FrameLoaderClient::createPlugin):
1290 * WebCoreSupport/FullscreenVideoController.h:
1291 * WebCoreSupport/InspectorClientGtk.cpp:
1292 (WebKit::InspectorClient::populateSetting):
1293 (WebKit::InspectorClient::storeSetting):
1294 * webkit/webkitdownload.cpp:
1295 (webkit_download_error):
1296 * webkit/webkitnetworkrequest.cpp:
1297 (webkit_network_request_new_with_core_request):
1298 * webkit/webkitnetworkresponse.cpp:
1299 (webkit_network_response_new_with_core_response):
1301 2010-08-24 Xan Lopez <xlopez@igalia.com>
1303 Reviewed by Martin Robinson.
1305 Set a device to the event struct when building with GTK+ 3.x, it's
1308 * tests/testcopyandpaste.c:
1309 (runPasteTestCallback):
1311 2010-08-24 Martin Robinson <mrobinson@igalia.com>
1315 * tests/testkeyevents.c:
1316 (key_press_event_cb):
1317 (key_release_event_cb):
1319 2010-08-24 Martin Robinson <mrobinson@igalia.com>
1321 Reviewed by Xan Lopez.
1323 [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1324 https://bugs.webkit.org/show_bug.cgi?id=44534
1326 Fix an issue where a GdkEvent* is treated like a GdkEvent.
1328 * tests/testkeyevents.c:
1329 (key_press_event_cb):
1330 (key_release_event_cb):
1332 2010-08-24 Martin Robinson <mrobinson@igalia.com>
1334 Reviewed by Xan Lopez.
1336 [GTK] GTK3: EventSender and API tests should use gdk_event_new when synthesizing events
1337 https://bugs.webkit.org/show_bug.cgi?id=44534
1339 * tests/testcopyandpaste.c:
1340 (runPasteTestCallback): Switch to using gdk_event_new and also reference the GdkWindow.
1341 when setting it on the event. It is dereferenced by gdk_event_free(...).
1342 * tests/testhittestresult.c:
1343 (load_status_cb): Switch to using gdk_event_new.
1345 2010-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1347 Rubber-stamped by Xan Lopez.
1349 Do not initialize the GSettings object in webkit_init - the other
1350 call sites are always called in the main thread so this is
1353 * webkit/webkitprivate.cpp:
1356 2010-08-20 Martin Robinson <mrobinson@igalia.com>
1358 Reviewed by Pavel Feldman.
1360 Web Inspector: Inspector tests were disabled for GTK.
1361 https://bugs.webkit.org/show_bug.cgi?id=43977
1363 Allow setting the inspector resources path via an environment variables
1364 and add a method, inspectorFilesPath, to the WebKit InspectorClient that
1365 encapsulates this logic.
1367 * WebCoreSupport/InspectorClientGtk.cpp:
1368 (WebKit::InspectorClient::openInspectorFrontend): Use the new inspectorFilesPath method to
1369 get the path to the resource.
1370 (WebKit::InspectorClient::inspectorFilesPath): Added.
1371 (WebKit::InspectorFrontendClient::localizedStringsURL): Use inspectorFilesPath method.
1372 * WebCoreSupport/InspectorClientGtk.h: Add method and member variables for caching the result.
1374 2010-08-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1376 Reviewed by Kenneth Rohde Christiansen.
1378 [Gtk] Enable view mode media feature layout test
1379 https://bugs.webkit.org/show_bug.cgi?id=43278
1381 Add the view-mode property, to control the WebCore page's viewMode.
1383 * docs/webkitgtk-sections.txt:
1384 * webkit/webkitwebview.cpp:
1385 (webkit_web_view_get_property):
1386 (webkit_web_view_set_property):
1387 (webkit_web_view_class_init):
1388 (webkit_web_view_set_view_mode):
1389 (webkit_web_view_get_view_mode):
1390 * webkit/webkitwebview.h:
1392 2010-08-19 Philippe Normand <pnormand@igalia.com>
1394 Reviewed by Gustavo Noronha Silva.
1396 [GStreamer] GTK XOverlay support in GStreamerGWorld
1397 https://bugs.webkit.org/show_bug.cgi?id=39474
1399 New FullscreenVideoController object, private in the webview. It
1400 is created when the user presses the fullscreen button of the
1401 video controls. Video is displayed in fullscreen, controls are
1402 displayed when the user moves the mouse and when the video is
1403 paused. There's also basic keyboard shortcuts support: F/f to
1404 leave fullscreen, space to toggle play/pause and up/down to
1407 * WebCoreSupport/ChromeClientGtk.cpp:
1408 (WebKit::ChromeClient::supportsFullscreenForNode):
1409 (WebKit::ChromeClient::enterFullscreenForNode):
1410 (WebKit::ChromeClient::exitFullscreenForNode):
1411 * WebCoreSupport/ChromeClientGtk.h:
1412 * WebCoreSupport/FullscreenVideoController.cpp: Added.
1414 (onFullscreenGtkMotionNotifyEvent):
1415 (onFullscreenGtkActiveNotification):
1416 (onFullscreenGtkConfigureEvent):
1417 (onFullscreenGtkDestroy):
1418 (togglePlayPauseActivated):
1419 (exitFullscreenActivated):
1420 (progressBarUpdateCallback):
1421 (timeScaleButtonPressed):
1422 (timeScaleButtonReleased):
1423 (timeScaleValueChanged):
1424 (volumeValueChanged):
1425 (playerVolumeChangedCallback):
1426 (playerMuteChangedCallback):
1427 (FullscreenVideoController::FullscreenVideoController):
1428 (FullscreenVideoController::~FullscreenVideoController):
1429 (FullscreenVideoController::setMediaElement):
1430 (FullscreenVideoController::gtkConfigure):
1431 (FullscreenVideoController::showHud):
1432 (FullscreenVideoController::hideHud):
1433 (onFullscreenGtkKeyPressEvent):
1434 (FullscreenVideoController::enterFullscreen):
1435 (FullscreenVideoController::updateHudPosition):
1436 (FullscreenVideoController::exitOnUserRequest):
1437 (FullscreenVideoController::exitFullscreen):
1438 (FullscreenVideoController::canPlay):
1439 (FullscreenVideoController::play):
1440 (FullscreenVideoController::pause):
1441 (FullscreenVideoController::playStateChanged):
1442 (FullscreenVideoController::togglePlay):
1443 (FullscreenVideoController::volume):
1444 (FullscreenVideoController::muted):
1445 (FullscreenVideoController::setVolume):
1446 (FullscreenVideoController::volumeChanged):
1447 (FullscreenVideoController::muteChanged):
1448 (FullscreenVideoController::currentTime):
1449 (FullscreenVideoController::setCurrentTime):
1450 (FullscreenVideoController::duration):
1451 (FullscreenVideoController::percentLoaded):
1452 (FullscreenVideoController::beginSeek):
1453 (FullscreenVideoController::doSeek):
1454 (FullscreenVideoController::endSeek):
1456 (FullscreenVideoController::updateHudProgressBar):
1457 (FullscreenVideoController::createHud):
1458 * WebCoreSupport/FullscreenVideoController.h: Added.
1459 (FullscreenVideoController::mediaElement):
1460 * webkit/webkitprivate.cpp:
1461 (webkit_web_view_enter_fullscreen):
1462 (webkit_web_view_exit_fullscreen):
1463 * webkit/webkitprivate.h:
1465 2010-08-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1467 Reviewed by Martin Robinson.
1469 [GTK] WebBackForwardList's new_with_web_view should not be public
1470 https://bugs.webkit.org/show_bug.cgi?id=43802
1472 Deprecate the constructor. The introspection annotation has been
1473 fixed in a previous commit.
1475 * webkit/webkitwebbackforwardlist.cpp:
1477 2010-08-17 Ilya Tikhonovsky <loislo@chromium.org>
1479 Reviewed by Yury Semikhatsky.
1481 Web Inspector: replace hand written InspectorBackendStub.js with generated one.
1482 https://bugs.webkit.org/show_bug.cgi?id=43791
1484 * WebCoreSupport/InspectorClientGtk.cpp:
1485 (WebKit::InspectorClient::openInspectorFrontend):
1487 2010-08-18 Sheriff Bot <webkit.review.bot@gmail.com>
1489 Unreviewed, rolling out r65595.
1490 http://trac.webkit.org/changeset/65595
1491 https://bugs.webkit.org/show_bug.cgi?id=44161
1493 qt build failed (Requested by loislo on #webkit).
1495 * WebCoreSupport/InspectorClientGtk.cpp:
1496 (WebKit::InspectorClient::openInspectorFrontend):
1498 2010-08-17 Ilya Tikhonovsky <loislo@chromium.org>
1500 Reviewed by Yury Semikhatsky.
1502 Web Inspector: replace hand written InspectorBackendStub.js by generated one.
1503 https://bugs.webkit.org/show_bug.cgi?id=43791
1505 * WebCoreSupport/InspectorClientGtk.cpp:
1506 (WebKit::InspectorClient::openInspectorFrontend):
1508 2010-08-17 Xan Lopez <xlopez@igalia.com>
1510 Reviewed by Gustavo Noronha.
1512 Fix the builds when HAVE_GSETTINGS is defined.
1514 * webkit/webkitprivate.cpp:
1515 (isSchemaAvailable):
1516 (inspectorGSettings):
1518 2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
1520 Reviewed by Darin Adler.
1522 Add NetworkingContext to avoid layer violations
1523 https://bugs.webkit.org/show_bug.cgi?id=42292
1525 Preparation: Just add the files to the build system.
1527 * WebCoreSupport/FrameNetworkingContextGtk.h: Added.
1528 Placeholder with tentative code that might be changed when landing
1531 2010-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1533 Reviewed by Martin Robinson.
1535 WebBackForwardList.get_{back|forward}_list_with_limit not introspectable
1536 https://bugs.webkit.org/show_bug.cgi?id=43054
1538 Annotate WebKitWebBackForwardList and the function that is used to fetch it from
1539 the WebKitWebView. More will follow.
1541 * webkit/webkitwebbackforwardlist.cpp: Annotations, and small
1542 improvements to the docs.
1543 * webkit/webkitwebbackforwardlist.h: Couple empty lines missing.
1544 * webkit/webkitwebview.cpp:
1546 2010-08-17 Martin Robinson <mrobinson@igalia.com>
1548 Reviewed by Gustavo Noronha Silva.
1550 [GTK] Clean up WebCore/platform/graphics/gtk/ImageGtk.cpp
1551 https://bugs.webkit.org/show_bug.cgi?id=44069
1553 * WebCoreSupport/InspectorClientGtk.cpp:
1554 (WebKit::InspectorClient::openInspectorFrontend): Switched to using the new WEBKITGTK_API_VERSION_STRING define.
1555 * webkit/webkitprivate.cpp:
1556 (inspectorGSettings): Ditto.
1558 2010-08-17 Sheriff Bot <webkit.review.bot@gmail.com>
1560 Unreviewed, rolling out r65500.
1561 http://trac.webkit.org/changeset/65500
1562 https://bugs.webkit.org/show_bug.cgi?id=44108
1564 Qt bots failed to compile. (Requested by loislo on #webkit).
1566 * WebCoreSupport/InspectorClientGtk.cpp:
1567 (WebKit::InspectorClient::openInspectorFrontend):
1569 2010-08-17 Ilya Tikhonovsky <loislo@chromium.org>
1571 Reviewed by Yury Semikhatsky.
1573 Web Inspector: replace hand written InspectorBackendStub.js by generated one.
1574 https://bugs.webkit.org/show_bug.cgi?id=43791
1576 * WebCoreSupport/InspectorClientGtk.cpp:
1577 (WebKit::InspectorClient::openInspectorFrontend):
1579 2010-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1581 Reviewed by Martin Robinson.
1583 [GTK] GSettings support adds annoying warnings on systems with older glib versions
1584 https://bugs.webkit.org/show_bug.cgi?id=44056
1586 Use #ifdef instead of #if for HAVE_GSETTINGS to avoid warnings
1587 when it is not defined.
1589 * WebCoreSupport/InspectorClientGtk.cpp:
1590 * webkit/webkitprivate.cpp:
1592 * webkit/webkitprivate.h:
1594 2010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1596 Really add a missing file. I wish I would remember running git add
1597 on them after applying a patch =(.
1599 * org.webkitgtk.gschema.xml.in: Added.
1601 2010-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1603 Reviewed by Martin Robinson.
1605 [GTK] Use GSettings to save/restore Web Inspector settings
1606 https://bugs.webkit.org/show_bug.cgi?id=43512
1608 Use GSettings to save/restore settings used by the Web Inspector.
1609 A few helper functions were added to have settings that use
1610 boolean values be actual booleans, and also to conform with the
1611 GSettings naming requirements for keys.
1613 * WebCoreSupport/InspectorClientGtk.cpp:
1614 (WebKit::toGSettingName):
1615 (WebKit::truthStringFromVariant):
1616 (WebKit::variantFromTruthString):
1617 (WebKit::InspectorClient::populateSetting):
1618 (WebKit::InspectorClient::storeSetting):
1619 * org.webkit.gtk.gschema.xml: Added.
1620 * webkit/webkitprivate.cpp:
1621 (inspectorGSettings):
1623 * webkit/webkitprivate.h:
1625 2010-08-11 Joone Hur <joone@kldp.org>
1627 Reviewed by Martin Robinson.
1629 [GTK] Last Hangul letter is typed again when a composition is finished with mouse press
1630 https://bugs.webkit.org/show_bug.cgi?id=40518
1632 When a mouse press fires during a IME composition, the current composition character
1633 can be entered twice at the previous editing position and a new editing position.
1634 Because the IME commit signal is emitted after the mouse press event.
1635 This patch allows to prevent the commit signal during a composition when a mouse press fires.
1637 * WebCoreSupport/EditorClientGtk.cpp:
1638 (WebKit::imContextCommitted):
1639 (WebKit::EditorClient::handleInputMethodKeydown): Allow to accept the next composition commit.
1640 (WebKit::EditorClient::handleInputMethodMousePress): Added for handling IME when a mouse press fires.
1641 (WebKit::EditorClient::EditorClient): Initialize m_preventNextCompositionCommit
1642 * WebCoreSupport/EditorClientGtk.h:
1643 (WebKit::EditorClient::preventNextCompositionCommit): Added for checking whether skipping a commit.
1644 * webkit/webkitwebview.cpp:
1645 (webkit_web_view_button_press_event): Call handleInputMethodMousePress()
1647 2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1649 Reviewed by Martin Robinson.
1651 Small improvement to the documentation of the geolocation-policy-decision-requested
1652 signal, stating more clearly what is expected from the handler.
1654 * webkit/webkitwebview.cpp:
1655 (webkit_web_view_class_init):
1657 2010-08-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1659 Reviewed by Martin Robinson.
1661 [GTK] Geolocation policy decision object leaking
1662 https://bugs.webkit.org/show_bug.cgi?id=43884
1664 Use GRefPtr on the policy decision object to fix the leak.
1666 * WebCoreSupport/ChromeClientGtk.cpp:
1667 (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
1669 2010-08-10 Chris Marrin <cmarrin@apple.com>
1671 Reviewed by Oliver Hunt.
1673 Add suspendAnimations/resumeAnimation API to DRT
1674 https://bugs.webkit.org/show_bug.cgi?id=43733
1678 * webkit/webkitprivate.h:
1679 * webkit/webkitwebframe.cpp:
1680 (webkit_web_frame_suspend_animations):
1681 (webkit_web_frame_resume_animations):
1683 2010-08-10 Gavin Barraclough <barraclough@apple.com>
1685 Rubber stamped by Sam Weinig.
1687 Bug 43786 - Move AtomicStringHash from WebCore to WTF
1688 Also remove deprecated string headers from WebCore/platform/text.
1690 * gdom/ConvertToGCharPrivate.h:
1692 2010-08-06 Gavin Barraclough <barraclough@apple.com>
1694 Rubber stamped by Sam Weinig
1696 Bug 43594 - Add string forwards to Forward.h
1697 This allows us to remove forward declarations for these classes from
1698 WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
1700 * WebCoreSupport/InspectorClientGtk.h:
1702 2010-08-09 Martin Robinson <mrobinson@igalia.com>
1704 Reviewed by Xan Lopez.
1706 [gtk] gtk_im_context_focus_in() should only be called when an input-able element has focus
1707 https://bugs.webkit.org/show_bug.cgi?id=43602
1709 Only call gtk_im_context_focus_in() when we focus a frame which is currently in
1712 * webkit/webkitwebview.cpp:
1713 (webkit_web_view_focus_in_event): Conditionalize call to gtk_im_context_focus_in().
1715 2010-08-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1717 Reviewed by Xan Lopez.
1719 Use the new paths, and also fix the path for localizedStrings.
1721 * WebCoreSupport/InspectorClientGtk.cpp:
1722 (WebKit::InspectorClient::openInspectorFrontend):
1723 (WebKit::InspectorFrontendClient::localizedStringsURL):
1725 2010-08-06 Jessie Berlin <jberlin@apple.com>
1727 Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
1730 * WebCoreSupport/InspectorClientGtk.h:
1732 2010-08-05 Xan Lopez <xlopez@igalia.com>
1734 Reviewed by Gustavo Noronha.
1736 [GTK] Use correct path for Inspector data files in GTK+3.x builds
1737 https://bugs.webkit.org/show_bug.cgi?id=43445
1739 Use the right data path for inspector files when building with
1742 * WebCoreSupport/InspectorClientGtk.cpp:
1743 (WebKit::InspectorClient::openInspectorFrontend):
1745 2010-08-03 Daniel Bates <dbates@rim.com>
1747 Fix misspelled word 'teh' in the description of the XSS Auditor setting.
1749 * webkit/webkitwebsettings.cpp:
1750 (webkit_web_settings_class_init):
1752 2010-08-03 Xan Lopez <xlopez@igalia.com>
1754 Reviewed by Gustavo Noronha.
1756 [GTK] Fix DOM event dispatch
1757 https://bugs.webkit.org/show_bug.cgi?id=40847
1759 Test DOM event dispatch.
1761 * tests/testdomdomwindow.c:
1762 (load_event_callback):
1763 (test_dom_domview_signals):
1765 (load_status_callback):
1766 (test_dom_domview_dispatch_event):
1769 2010-08-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1771 Reviewed by Xan Lopez.
1773 [GTK] Does not paint the node highlight used by the inspector
1774 https://bugs.webkit.org/show_bug.cgi?id=43429
1776 Implement highlighting the nodes when using the inspector.
1778 * WebCoreSupport/InspectorClientGtk.cpp:
1779 (WebKit::InspectorClient::highlight):
1780 (WebKit::InspectorClient::hideHighlight):
1781 * webkit/webkitwebview.cpp:
1782 (webkit_web_view_expose_event):
1784 2010-08-03 Xan Lopez <xlopez@igalia.com>
1786 Reviewed by Gustavo Noronha.
1788 Update unit tests now that string parameters are 'const char*'.
1790 * tests/testdomdocument.c:
1791 (test_dom_document_title):
1792 (test_dom_document_get_elements_by_tag_name):
1793 (test_dom_document_get_elements_by_class_name):
1794 (test_dom_document_get_element_by_id):
1795 * tests/testdomnode.c:
1796 (test_dom_node_insertion):
1798 2010-08-02 Martin Robinson <mrobinson@igalia.com>
1800 Reviewed by Xan Lopez.
1802 [GTK] DRT implement execCommand()
1803 https://bugs.webkit.org/show_bug.cgi?id=35351
1805 * webkit/webkitprivate.h: Add some private methods for the DRT which enable
1806 LayoutTestController.execCommand and LayoutTestController.isCommandEnabled:
1807 webkit_web_view_execute_core_command_by_name and webkit_web_view_is_command_enabled.
1808 * webkit/webkitwebview.cpp:
1809 (webkit_web_view_execute_core_command_by_name): added.
1810 (webkit_web_view_is_command_enabled): Added.
1812 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
1814 Reviewed by Darin Fisher.
1816 PopupMenu refactoring in preparation to WebKit2
1817 https://bugs.webkit.org/show_bug.cgi?id=42592
1819 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
1820 instances, concrete classes that inherit from ChromeClient needed to be changed to
1821 implement the new methods.
1823 * WebCoreSupport/ChromeClientGtk.cpp:
1824 (WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
1825 (WebKit::ChromeClient::createPopupMenu):
1826 (WebKit::ChromeClient::createSearchPopupMenu):
1827 * WebCoreSupport/ChromeClientGtk.h:
1829 2010-08-02 Martin Robinson <mrobinson@igalia.com>
1831 Reviewed by Xan Lopez.
1833 [GTK] Create a frame-created signal
1834 https://bugs.webkit.org/show_bug.cgi?id=43284
1836 Add a frame-created signal, which will allow developers to track
1837 the beginning of a frame lifecycle and attach signal handlers to
1840 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1841 (WebKit::FrameLoaderClient::createFrame): Emit the frame-created signal.
1842 * tests/testwebframe.c: Add a test which verifies that the correct number of
1843 frame-created signals is fired when a page with iframes loads.
1844 (createFrameSignalTestFrameCreatedCallback): Added.
1845 (createFrameSignalTestTimeout): Added.
1846 (test_webkit_web_frame_created_signal): Added.
1847 (main): Add a reference to the new test.
1848 * webkit/webkitprivate.h: De-normalize webkit_web_frame_init_with_web_view into
1849 the one place that it is used, so that the frame-created signal may be fired there.
1850 * webkit/webkitwebframe.cpp: Remove webkit_web_frame_init_with_web_view.
1851 * webkit/webkitwebview.cpp:
1852 (webkit_web_view_class_init): Add the frame-created signal declaration.
1854 2010-08-02 Mario Sanchez Prada <msanchez@igalia.com>
1856 Reviewed by Chris Fleizach.
1858 [GTK] Implement support for get_character_extents and get_range_extents
1859 https://bugs.webkit.org/show_bug.cgi?id=25677
1861 Added new unit tests to check get_character_extents and
1862 get_range_extents functions for the ATK_TEXT interface
1864 Based on a previous patch by Joanmarie Diggs.
1867 (test_webkit_atk_get_extents):
1870 2010-08-02 Jeremy Orlow <jorlow@chromium.org>
1872 Speculative revert of 64425 due to Chromium instability
1873 https://bugs.webkit.org/show_bug.cgi?id=43347
1875 * WebCoreSupport/ChromeClientGtk.cpp:
1876 * WebCoreSupport/ChromeClientGtk.h:
1878 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
1880 Reviewed by Darin Fisher.
1882 PopupMenu refactoring in preparation to WebKit2
1883 https://bugs.webkit.org/show_bug.cgi?id=42592
1885 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
1886 instances, concrete classes that inherit from ChromeClient needed to be changed to
1887 implement the new methods.
1889 * WebCoreSupport/ChromeClientGtk.cpp:
1890 (WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
1891 (WebKit::ChromeClient::createPopupMenu):
1892 (WebKit::ChromeClient::createSearchPopupMenu):
1893 * WebCoreSupport/ChromeClientGtk.h:
1895 2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
1897 Unreviewed, rolling out r64422.
1898 http://trac.webkit.org/changeset/64422
1899 https://bugs.webkit.org/show_bug.cgi?id=43304
1901 Build fixes are needed for Snow Leopard and Windows.
1902 (Requested by lca on #webkit).
1904 * WebCoreSupport/ChromeClientGtk.cpp:
1905 * WebCoreSupport/ChromeClientGtk.h:
1907 2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
1909 Reviewed by Darin Fisher.
1911 PopupMenu refactoring in preparation to WebKit2
1912 https://bugs.webkit.org/show_bug.cgi?id=42592
1914 As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
1915 instances, concrete classes that inherit from ChromeClient needed to be changed to
1916 implement the new methods.
1918 * WebCoreSupport/ChromeClientGtk.cpp:
1919 (WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
1920 (WebKit::ChromeClient::createPopupMenu):
1921 (WebKit::ChromeClient::createSearchPopupMenu):
1922 * WebCoreSupport/ChromeClientGtk.h:
1924 2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
1926 Reviewed by David Kilzer.
1928 Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
1929 https://bugs.webkit.org/show_bug.cgi?id=40627
1931 * WebCoreSupport/ChromeClientGtk.cpp:
1932 (WebKit::ChromeClient::reachedApplicationCacheOriginQuota):
1933 * WebCoreSupport/ChromeClientGtk.h:
1934 2010-07-26 Steve Block <steveblock@google.com>
1936 Reviewed by Jeremy Orlow.
1938 Page clients should be passed to Page constructor via structure of pointers
1939 https://bugs.webkit.org/show_bug.cgi?id=42834
1941 * webkit/webkitwebview.cpp:
1942 (webkit_web_view_init):
1944 2010-07-16 Zhe Su <suzhe@chromium.org>
1946 Reviewed by Darin Adler.
1948 REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
1949 https://bugs.webkit.org/show_bug.cgi?id=42253
1951 Dummy implementation of EditorClient::willSetInputMethodState.
1953 * WebCoreSupport/EditorClientGtk.cpp:
1954 (WebKit::EditorClient::willSetInputMethodState):
1955 * WebCoreSupport/EditorClientGtk.h:
1957 2010-07-16 Nate Chapin <japhet@chromium.org>
1959 Reviewed by Darin Fisher.
1961 Uncomment an assert that broke due to r63100.
1963 https://bugs.webkit.org/show_bug.cgi?id=42298
1965 * tests/testwebview.c:
1967 2010-07-14 Sam Weinig <sam@webkit.org>
1969 Reviewed by Darin Adler.
1971 Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
1972 Make changing Cursors work in WebKit2.
1974 * WebCoreSupport/ChromeClientGtk.cpp:
1975 (WebKit::ChromeClient::setCursor):
1976 * WebCoreSupport/ChromeClientGtk.h:
1977 Change prototype to match new one.
1979 2010-07-12 Martin Robinson <mrobinson@igalia.com>
1981 Reviewed by Gustavo Noronha Silva.
1983 [GTK] r63100 broke the testwebview test
1984 https://bugs.webkit.org/show_bug.cgi?id=42114
1986 * tests/testwebview.c: Disable a failing assertion in test_webkit_web_view_adjustments
1987 until we can get to the bottom of the failure.
1989 2010-07-12 Xan Lopez <xlopez@igalia.com>
1991 Reviewed by Gustavo Noronha.
1997 2010-07-12 Xan Lopez <xlopez@igalia.com>
1999 Reviewed by Gustavo Noronha.
2001 Fix compilation with sealed GTK+.
2003 * webkit/webkitwebview.cpp:
2004 (webkit_web_view_drag_motion):
2005 (webkit_web_view_drag_data_received):
2006 (webkit_web_view_drag_drop):
2008 2010-07-11 Martin Robinson <mrobinson@igalia.com>
2010 Reviewed by Xan Lopez.
2012 [GTK] WebKitWebView should support drops
2013 https://bugs.webkit.org/show_bug.cgi?id=39843
2015 Add support for dropping content onto GTK+ WebViews.
2017 * webkit/webkitprivate.h:
2018 Add a DroppingContext struct to keep track of drop data while the drop is
2019 in progress. Have WebKitWebView keep a map of GdkDragContexts to DroppingContexts.
2020 * webkit/webkitwebview.cpp: Add necessary includes and globalPointForClientPoint helper.
2021 (webkit_web_view_popup_menu_handler): Use globalPointForClientPoint helper.
2022 (webkit_web_view_dispose): Properly clean up droppingContexts member.
2023 (webkit_web_view_finalize): Delete droppingContext member.
2024 (globalPointForClientPoint): Added.
2025 (doDragLeaveLater): Added.
2026 (webkit_web_view_drag_leave): Added.
2027 (webkit_web_view_drag_motion): Added.
2028 (webkit_web_view_drag_data_received): Added.
2029 (webkit_web_view_drag_drop): Added.
2030 (webkit_web_view_class_init): Connect new drop signal handlers to the widget definition.
2031 (webkit_web_view_init): Set up the widget as a drop destination and initialize droppingContexts.
2033 2010-07-07 Sam Weinig <sam@webkit.org>
2035 Reviewed by Anders Carlsson.
2037 Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
2038 Add basic piping for BackForwardControllerClient.
2040 * webkit/webkitwebview.cpp:
2041 (webkit_web_view_init):
2043 2010-06-19 Ilya Tikhonovsky <loislo@chromium.org>
2045 Reviewed by Yury Semikhatsky.
2047 WebInspector: js function name was fixed.
2048 dispatchMessageToFrontend -> dispatchMessageFromBackend.
2049 https://bugs.webkit.org/show_bug.cgi?id=40675
2051 * WebCoreSupport/InspectorClientGtk.cpp:
2052 (WebKit::InspectorClient::sendMessageToFrontend):
2054 2010-06-23 Martin Robinson <mrobinson@igalia.com>
2056 Reviewed by Gustavo Noronha Silva.
2058 [GTK] Separate DerivedSources per-project
2059 https://bugs.webkit.org/show_bug.cgi?id=41109
2061 Separate WebKitGTK+ DerivedSources into per-project subdirectories to prepare
2062 for properly building WebKit2.
2064 * webkitmarshal.list: Touch this file to force a rebuild of the marshaling code.
2066 2010-07-01 Xan Lopez <xlopez@igalia.com>
2068 Reviewed by Gustavo Noronha.
2070 [GTK] Stop using GdkRegion in 3.x mode
2071 https://bugs.webkit.org/show_bug.cgi?id=41463
2073 Make us compile without using GdkRegion, since it's gone from GTK+
2076 * WebCoreSupport/ChromeClientGtk.cpp:
2077 (WebKit::ChromeClient::scroll):
2078 * webkit/webkitwebview.cpp:
2079 (webkit_web_view_expose_event):
2081 2010-07-01 Martin Robinson <mrobinson@igalia.com>
2083 Reviewed by Xan Lopez.
2085 [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
2086 https://bugs.webkit.org/show_bug.cgi?id=40333
2088 Convert draggingDataObjects to a pointer. The constructor and destructor of the
2089 HashMap should be called explicitly. GObject memory allocation does not do this.
2091 * WebCoreSupport/DragClientGtk.cpp:
2092 (WebKit::DragClient::startDrag):
2093 * webkit/webkitprivate.h:
2094 * webkit/webkitwebview.cpp:
2095 (webkit_web_view_dispose):
2096 (webkit_web_view_drag_end):
2097 (webkit_web_view_drag_data_get):
2098 (webkit_web_view_init):
2100 2010-06-30 Martin Robinson <mrobinson@igalia.com>
2102 Unreviewed, rolling out r62226.
2103 http://trac.webkit.org/changeset/62226
2104 https://bugs.webkit.org/show_bug.cgi?id=40333
2106 This change caused 13 new crashers.
2108 * WebCoreSupport/DragClientGtk.cpp:
2109 (WebKit::DragClient::startDrag):
2110 * webkit/webkitprivate.h:
2111 * webkit/webkitwebview.cpp:
2112 (webkit_web_view_dispose):
2113 (webkit_web_view_drag_end):
2114 (webkit_web_view_drag_data_get):
2115 (webkit_web_view_init):
2117 2010-06-30 Martin Robinson <mrobinson@igalia.com>
2119 Reviewed by Xan Lopez.
2121 [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
2122 https://bugs.webkit.org/show_bug.cgi?id=40333
2124 Convert draggingDataObjects to a pointer. The constructor and destructor of the
2125 HashMap should be called explicitly. GObject memory allocation does not do this.
2127 * WebCoreSupport/DragClientGtk.cpp:
2128 (WebKit::DragClient::startDrag):
2129 * webkit/webkitprivate.h:
2130 * webkit/webkitwebview.cpp:
2131 (webkit_web_view_dispose):
2132 (webkit_web_view_drag_end):
2133 (webkit_web_view_drag_data_get):
2134 (webkit_web_view_init):
2136 2010-06-30 Xan Lopez <xlopez@igalia.com>
2138 Reviewed by Gustavo Noronha.
2140 [GTK] Unit test for DOM insertion methods
2141 https://bugs.webkit.org/show_bug.cgi?id=40495
2143 Add unit test for webkit_dom_node_remove_child.
2145 * tests/testdomnode.c:
2146 (test_dom_node_insertion):
2148 2010-06-30 Xan Lopez <xlopez@igalia.com>
2150 Reviewed by Gustavo Noronha.
2152 [GTK] Unit test for DOM insertion methods
2153 https://bugs.webkit.org/show_bug.cgi?id=40495
2155 Add unit tests for node insertion and replacement methods.
2157 * tests/testdomnode.c:
2158 (test_dom_node_insertion):
2161 2010-06-30 Mario Sanchez Prada <msanchez@igalia.com>
2163 Reviewed by Xan Lopez.
2165 [GTK] Random failure on 'testdownload' unit test
2166 https://bugs.webkit.org/show_bug.cgi?id=38256
2168 Make sure the set_filename function is called after handling the
2169 'download-requested' signal for the asynchronous test. This change
2170 is needed because it could happen, with the current code, that the
2171 set_filename () function got called too early in the mainloop,
2172 therefore screwing the tests because the 'theDownload' global
2173 variable wouldn't be properly set yet.
2175 With this modification we ensure the set_filename() function gets
2176 called always after handling the download-requested signal,
2177 therefore avoiding potentialproblems.
2179 * tests/testdownload.c:
2181 (handle_download_requested_cb):
2182 (download_requested_cb):
2183 (download_requested_asynch_cb):
2184 (test_webkit_download_perform):
2186 2010-06-30 José Millán Soto <jmillan@igalia.com>
2188 Reviewed by Xan Lopez.
2190 [Gtk] Text attributes not exposed
2191 https://bugs.webkit.org/show_bug.cgi?id=25528
2193 Added new tests for accessible text attributes
2197 (compAtkAttributeName):
2198 (atkAttributeSetAttributeHasValue):
2199 (atkAttributeSetAreEqual):
2200 (testWebkitAtkTextAttributes):
2203 2010-06-28 Xan Lopez <xlopez@igalia.com>
2205 Reviewed by Gustavo Noronha.
2211 2010-06-28 Xan Lopez <xlopez@igalia.com>
2213 Reviewed by Gustavo Noronha.
2215 [GTK] Does not compile with -DGSEAL_ENABLE
2216 https://bugs.webkit.org/show_bug.cgi?id=37851
2218 Fix build with GSEAL enabled.
2220 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2221 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
2222 * webkit/webkitsoupauthdialog.c:
2225 2010-06-28 Xan Lopez <xlopez@igalia.com>
2227 Reviewed by Gustavo Noronha.
2229 [GTK] Add support for GTK+3
2230 https://bugs.webkit.org/show_bug.cgi?id=41253
2232 Adapt build system to 3.x support, allow the JSCore gir and webkit
2233 pc files to be configurable at build time for different API
2236 * JSCore-1.0.gir: Removed.
2237 * JSCore.gir.in: Added.
2238 * docs/GNUmakefile.am:
2241 2010-06-25 Mario Sanchez Prada <msanchez@igalia.com>
2243 Reviewed by Xan Lopez.
2245 [Gtk] Implement atk_table_get_column_header
2246 https://bugs.webkit.org/show_bug.cgi?id=30896
2248 Replace g_timeout_add() with g_idle_add().
2251 (test_webkit_atk_get_text_at_offset_forms):
2252 (test_webkit_atk_get_text_at_offset):
2253 (test_webkit_atk_get_text_at_offset_newlines):
2254 (test_webkit_atk_get_text_at_offset_textarea):
2255 (test_webkit_atk_get_text_at_offset_text_input):
2256 (testWebkitAtkGetTextInParagraphAndBodySimple):
2257 (testWebkitAtkGetTextInParagraphAndBodyModerate):
2258 (testWebkitAtkGetTextInTable):
2259 (testWebkitAtkGetHeadersInTable):
2261 2010-06-25 Mario Sanchez Prada <msanchez@igalia.com>
2263 Reviewed by Xan Lopez.
2265 [Gtk] Implement atk_table_get_column_header
2266 https://bugs.webkit.org/show_bug.cgi?id=30896
2268 Added new test to check whether the implementation of
2269 get_column_headers() and get_row_headers() works ok.
2272 (testWebkitAtkGetHeadersInTable):
2275 2010-06-25 Martin Robinson <mrobinson@igalia.com>
2277 Reviewed by Xan Lopez.
2279 [GTK] Pasteboard code does not take into account the nil character when getting and setting markup/netscape-url data
2280 https://bugs.webkit.org/show_bug.cgi?id=41221
2282 Add a test for this issue which simulates a paste keyboard event into an editable
2283 body. The pasteboard should contain a markup portion containing a null terminator.
2285 * tests/testcopyandpaste.c:
2287 (test_info_destroy):
2289 (runPasteTestCallback):
2290 (window_object_cleared_callback):
2291 (pasting_test_get_data_callback):
2292 (pasting_test_clear_data_callback):
2293 (test_pasting_markup):
2296 2010-06-24 Martin Robinson <mrobinson@igalia.com>
2298 Reviewed by Xan Lopez.
2300 [GTK] Cannot change the selection via the keyboard
2301 https://bugs.webkit.org/show_bug.cgi?id=41162
2303 Fix issue where the selection could not be extended via the keyboard by
2304 adjusting the logic guarding against inserting text in non-editable nodes.
2306 * WebCoreSupport/EditorClientGtk.cpp:
2307 (WebKit::EditorClient::handleKeyboardEvent):
2308 Allow editor commands that do not insert text in non-editable nodes. This
2309 fixes keyboard selection extension in non-editable nodes. Move the existing
2310 check to after the execution of any editor commands.
2312 2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
2314 Reviewed by Adam Barth.
2316 Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
2317 https://bugs.webkit.org/show_bug.cgi?id=39041
2319 * webkit/webkitwebview.cpp:
2320 (webkit_web_view_update_settings):
2321 (webkit_web_view_settings_notify):
2322 (webkit_get_cache_model):
2324 2010-06-16 Martin Robinson <mrobinson@igalia.com>
2326 Reviewed by Gustavo Noronha Silva.
2328 [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
2329 https://bugs.webkit.org/show_bug.cgi?id=40600
2331 * WebCoreSupport/DragClientGtk.cpp:
2332 (WebKit::DragClient::startDrag): Reset the click count after a drag starts.
2333 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2334 (WebKit::postCommitFrameViewSetup): Reset the click count after a load is committed.
2335 * webkit/webkitprivate.h: Move static click counting variables to be per-view.
2336 * webkit/webkitwebview.cpp:
2337 (getEventTime): Added.
2338 (webkit_web_view_button_press_event): If the event time is zero, use the current time.
2339 (webkit_web_view_finalize): Clean up click counting member.
2340 (webkit_web_view_init): Initialize click counting member.
2342 2010-06-15 Xan Lopez <xlopez@igalia.com>
2344 Fix compilation with older GTK+.
2346 * WebCoreSupport/ChromeClientGtk.cpp:
2347 (WebKit::ChromeClient::pageRect):
2349 2010-06-15 Xan Lopez <xlopez@igalia.com>
2351 Reviewed by Gustavo Noronha.
2353 [GTK] Does not compile with -DGSEAL_ENABLE
2354 https://bugs.webkit.org/show_bug.cgi?id=37851
2356 Fix compilation with GSEAL_ENABLE.
2358 * WebCoreSupport/ChromeClientGtk.cpp:
2359 (WebKit::ChromeClient::pageRect):
2360 (WebKit::ChromeClient::contentsSizeChanged):
2361 * tests/testdomnode.c:
2362 (test_dom_node_insertion):
2363 * webkit/webkitwebview.cpp:
2364 (webkit_web_view_realize):
2365 (webkit_web_view_script_dialog):
2366 (webkit_web_view_drag_end):
2367 (webkit_web_view_init):
2369 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
2371 Unreviewed build fix.
2373 This is a fix for flaky inspector tests at gtk-debug bots.
2375 * WebCoreSupport/InspectorClientGtk.cpp:
2376 (WebKit::InspectorFrontendClient::destroyInspectorWindow):
2378 2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
2380 Reviewed by Pavel Feldman.
2382 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
2383 data from inspected page to WebInspector as JSON string via http. The native
2384 serialization to JSON string is supported by InspectorValue's classes. This patch
2385 has the implementation of sendMessageToFrontend function. WebKit version of it still
2386 uses ScriptFunctionCall and will be switched to another transport a little bit later.
2387 https://bugs.webkit.org/show_bug.cgi?id=40134
2389 * WebCoreSupport/InspectorClientGtk.cpp:
2390 (WebKit::InspectorClient::releaseFrontendPage):
2391 (WebKit::InspectorClient::sendMessageToFrontend):
2392 * WebCoreSupport/InspectorClientGtk.h:
2394 2010-06-10 Eric Seidel <eric@webkit.org>
2396 Reviewed by Adam Barth.
2398 Reduce FrameView.h includes to speed up build times
2399 https://bugs.webkit.org/show_bug.cgi?id=40408
2401 * webkit/webkitwebinspector.cpp:
2402 - Include RenderLayer.h
2404 2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
2406 Unreviewed, rolling out r60889.
2407 http://trac.webkit.org/changeset/60889
2408 https://bugs.webkit.org/show_bug.cgi?id=40365
2410 gtk bot has some kind of memory corruption (Requested by
2413 * WebCoreSupport/InspectorClientGtk.cpp:
2414 (WebKit::InspectorClient::InspectorClient):
2415 (WebKit::InspectorClient::openInspectorFrontend):
2416 (WebKit::InspectorFrontendClient::InspectorFrontendClient):
2417 (WebKit::InspectorFrontendClient::destroyInspectorWindow):
2418 * WebCoreSupport/InspectorClientGtk.h:
2420 2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
2422 Reviewed by Pavel Feldman.
2424 WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
2425 data from inspected page to WebInspector as JSON string via http. The native
2426 serialization to JSON string is supported by InspectorValue's classes. This patch
2427 has the implementation of sendMessageToFrontend function. WebKit version of it still
2428 uses ScriptFunctionCall and will be switched to another transport a little bit later.
2429 https://bugs.webkit.org/show_bug.cgi?id=40134
2431 * WebCoreSupport/InspectorClientGtk.cpp:
2432 (WebKit::InspectorClient::releaseFrontendPage):
2433 (WebKit::InspectorClient::sendMessageToFrontend):
2434 * WebCoreSupport/InspectorClientGtk.h:
2436 2010-06-08 Xan Lopez <xlopez@igalia.com>
2438 Reviewed by Gustavo Noronha.
2440 [GTK] Unit testing for WebKitDOMNode hierarchy walk
2441 https://bugs.webkit.org/show_bug.cgi?id=40171
2443 Add some DOM node unit testing.
2445 * tests/testdomnode.c: Added.
2447 (dom_node_fixture_setup):
2448 (dom_node_fixture_teardown):
2449 (test_dom_node_hierarchy_navigation):
2452 2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
2454 Reviewed by Ojan Vafai and Darin Adler.
2456 Refactor platform dependent editing behavior code out of Settings
2457 https://bugs.webkit.org/show_bug.cgi?id=39854
2459 EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
2460 EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
2462 * webkit/webkitprivate.cpp:
2464 * webkit/webkitprivate.h:
2465 * webkit/webkitwebview.cpp:
2466 (webkit_web_view_update_settings):
2467 (webkit_web_view_settings_notify):
2469 2010-06-08 Xan Lopez <xlopez@igalia.com>
2471 Reviewed by Gustavo Noronha.
2473 [GTK] Add inner-node property to WebKitHitTestResult
2474 https://bugs.webkit.org/show_bug.cgi?id=40131
2476 Add a 'inner-node' property to WebKitHitTestResult, carrying the
2477 DOM node where the hit test happened.
2479 * tests/testhittestresult.c:
2481 * webkit/webkithittestresult.cpp:
2482 (webkit_hit_test_result_get_property):
2483 (webkit_hit_test_result_set_property):
2484 (webkit_hit_test_result_class_init):
2485 * webkit/webkitprivate.cpp:
2488 2010-06-07 Martin Robinson <mrobinson@igalia.com>
2490 Reviewed by Xan Lopez.
2492 [GTK] gtk_widget_get_window should replace widget->window
2493 https://bugs.webkit.org/show_bug.cgi?id=40180
2495 Replace uses of widget->window with gtk_widget_get_window.
2497 * WebCoreSupport/ChromeClientGtk.cpp:
2498 (WebKit::ChromeClient::invalidateContentsAndWindow): Replace widget->window uses.
2499 (WebKit::ChromeClient::scroll): Ditto.
2500 (WebKit::widgetScreenPosition): Ditto.
2501 * WebCoreSupport/DragClientGtk.cpp: Move gtk_widget_get_window define to GtkVersioning.h.
2502 * webkit/webkitwebview.cpp:
2503 (webkit_web_view_popup_menu_handler): Replace widget->window uses.
2504 (webkit_web_view_button_press_event): Ditto.
2506 2010-06-04 Martin Robinson <mrobinson@igalia.com>
2508 Reviewed by Xan Lopez.
2510 [GTK] Drag gesture can take mouse grab indefinitely
2511 https://bugs.webkit.org/show_bug.cgi?id=32840
2513 Initiate drag events with the current GTK+ event instead of synthesizing
2514 an event. Something about synthesized events is causing a drag freeze in
2517 * WebCoreSupport/DragClientGtk.cpp:
2518 (WebKit::DragClient::startDrag): Start the drag with the current GTK+ event.
2520 2010-06-03 Sheriff Bot <webkit.review.bot@gmail.com>
2522 Unreviewed, rolling out r60632.
2523 http://trac.webkit.org/changeset/60632
2524 https://bugs.webkit.org/show_bug.cgi?id=40143
2526 This change broke the 64-bit bots. (Requested by mrobinson on
2529 * WebCoreSupport/DragClientGtk.cpp:
2530 (WebKit::DragClient::DragClient):
2531 (WebKit::DragClient::startDrag):
2532 * WebCoreSupport/DragClientGtk.h:
2534 2010-06-03 Martin Robinson <mrobinson@igalia.com>
2536 Reviewed by Xan Lopez.
2538 [GTK] Drag gesture can take mouse grab indefinitely
2539 https://bugs.webkit.org/show_bug.cgi?id=32840
2541 Start GTK+ drags with the previous mouse button down event instead of
2542 synthesizing the event. The synthesized event was not completely valid
2543 and froze some drags indefinitely.
2545 * WebCoreSupport/DragClientGtk.cpp:
2546 (WebKit::buttonPressEvent): Added.
2547 (WebKit::DragClient::DragClient):
2548 Connect to the 'button-press-event' signal of the WebView.
2549 (WebKit::DragClient::startDrag):
2550 Instead of synthesizing a button press event use the last real one.
2551 * WebCoreSupport/DragClientGtk.h:
2552 (WebKit::DragClient::setLastButtonPressEvent): Added.
2554 2010-06-01 Xan Lopez <xlopez@igalia.com>
2556 Reviewed by Gustavo Noronha.
2558 Memory Leak: The main resource of page is not free.
2559 https://bugs.webkit.org/show_bug.cgi?id=39973
2561 Fix refcount tracking of the main resource. Patch by Genhua Liu.
2563 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2564 (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
2566 2010-06-01 Xan Lopez <xlopez@igalia.com>
2568 Reviewed by Gustavo Noronha.
2570 Fix-up for previous leak fix, the identifier was not always duped.
2572 * webkit/webkitprivate.h:
2573 * webkit/webkitwebview.cpp:
2574 (webkit_web_view_add_resource):
2576 2010-06-01 Xan Lopez <xlopez@igalia.com>
2578 Reviewed by Gustavo Noronha.
2582 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2583 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
2585 2010-06-01 Martin Robinson <mrobinson@igalia.com>
2587 Reviewed by Xan Lopez.
2589 [GTK] Double clicks cause three button press events
2590 https://bugs.webkit.org/show_bug.cgi?id=38853
2592 Handle click counting much like the Windows port. GTK+ only
2593 counts triple-clicks natively, so use GTK+ double-click settings
2594 to count clicks with even larger click counts. Also filter the
2595 extra GDK_BUTTON_PRESS before GDK_{2,3}BUTTON_PRESS events using
2598 * webkit/webkitwebview.cpp:
2599 (webkit_web_view_button_press_event): Count clicks manually. Filter extra events.
2601 2010-05-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2603 Reviewed by Xan Lopez.
2605 [GTK] Missing links to documentation of general functions
2606 https://bugs.webkit.org/show_bug.cgi?id=39964
2608 Add global functions section, and move those functions that are
2609 currently in WebKitWebView's source file to the bottom, along with
2612 * docs/webkitgtk-docs.sgml:
2613 * docs/webkitgtk-sections.txt:
2614 * webkit/webkitwebview.cpp:
2615 (webkit_web_view_get_dom_document):
2616 (webkit_get_default_session):
2618 2010-05-31 Martin Robinson <mrobinson@igalia.com>
2620 Reviewed by Gustavo Noronha Silva.
2622 [GTK] Text copied from a WebView cannot be pasted into gnome-terminal
2623 https://bugs.webkit.org/show_bug.cgi?id=39827
2625 Add a test to prevent regressions for this issue.
2627 * tests/testcopyandpaste.c: Added.
2629 (test_info_destroy):
2630 (copy_and_paste_fixture_setup):
2631 (copy_and_paste_fixture_teardown):
2634 (test_copy_and_paste):
2637 2010-05-27 Gustavo Noronha Silva <gns@gnome.org>
2639 Update documentation control files, and fix Since tags for 1.3.1.
2641 * docs/webkitgtk-docs.sgml:
2642 * docs/webkitgtk-sections.txt:
2643 * webkit/webkitwebbackforwardlist.cpp:
2644 * webkit/webkitwebview.cpp:
2646 2010-05-27 Xan Lopez <xlopez@igalia.com>
2648 Reviewed by Gustavo Noronha.
2650 Update for 1.3.1 release.
2654 2010-05-27 Martin Robinson <mrobinson@igalia.com>
2656 Reviewed by Xan Lopez.
2658 [GTK] Dragging onto the desktop causes a critical GLib warning
2659 https://bugs.webkit.org/show_bug.cgi?id=39718
2661 Only increment the window reference count if it is not null during drag-end
2664 * webkit/webkitwebview.cpp:
2665 (webkit_web_view_drag_end): Guard against null window values.
2667 2010-05-26 Xan Lopez <xlopez@igalia.com>
2669 Reviewed by Gustavo Noronha.
2671 [GTK] Add support for DOM events in the GObject DOM bindings
2672 https://bugs.webkit.org/show_bug.cgi?id=38844
2674 Test DOMWindow signals.
2676 * tests/testdomdomwindow.c: Added.
2678 (dom_domview_fixture_setup):
2679 (dom_domview_fixture_teardown):
2683 (load_event_callback):
2684 (test_dom_domview_signals):
2687 2010-05-24 Darin Adler <darin@apple.com>
2689 Reviewed by Eric Seidel.
2691 Move view-related functions from Frame to FrameView
2692 https://bugs.webkit.org/show_bug.cgi?id=39366
2694 * webkit/webkitwebview.cpp:
2695 (webkit_web_view_set_editable): Remove call to empty function
2696 removeEditngStyleFromBodyElement.
2697 (webkit_web_view_get_zoom_level): Call functions on FrameView.
2698 (webkit_web_view_apply_zoom_level): Ditto.
2700 2010-05-22 Martin Robinson <mrobinson@igalia.com>
2702 Reviewed by Xan Lopez.
2704 [GTK] webkit_web_view_drag_end should call EventHandler::dragSourceEndedAt
2705 https://bugs.webkit.org/show_bug.cgi?id=39465
2707 Properly call EventHandler::dragSourceEndedAt so that dragEnd events are processed in the DOM.
2708 dragSourceEndedAt is responsible for calling the dragEnd DOM event as well as cleaning up assets
2709 (such as the Clipboard) associated with the drag source.
2711 * webkit/webkitwebview.cpp:
2712 (webkit_web_view_drag_end): Remember to call dragSourceEndedAt here.
2714 2010-05-22 Martin Robinson <mrobinson@igalia.com>
2716 Reviewed by Xan Lopez.
2718 [GTK] WebKit/gtk/WebCoreSupport/DragClientGtk::startDrag should use the Clipboard::sourceOperation
2719 https://bugs.webkit.org/show_bug.cgi?id=39459
2721 * WebCoreSupport/DragClientGtk.cpp:
2722 (WebKit::DragClient::startDrag):
2723 Use Clipboard::sourceOperation instead of trying to figure out the GdkDragAction
2724 manually. The DOM may have changed the appropriate list of actions anyhow.
2726 2010-05-21 Steve Block <steveblock@google.com>
2728 Reviewed by Jeremy Orlow.
2730 Add DeviceOrientation and DeviceOrientationClient
2731 https://bugs.webkit.org/show_bug.cgi?id=39479
2733 * webkit/webkitwebview.cpp:
2734 (webkit_web_view_init):
2736 2010-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
2738 Unreviewed, rolling out r59240.
2739 http://trac.webkit.org/changeset/59240
2740 https://bugs.webkit.org/show_bug.cgi?id=39377
2742 "Might cause crashes in GTK+ bots" (Requested by xan_ on
2745 * WebCoreSupport/ContextMenuClientGtk.cpp:
2746 (WebKit::inputMethodsMenuItem):
2747 * WebCoreSupport/EditorClientGtk.cpp:
2748 (WebKit::EditorClient::setInputMethodState):
2749 (WebKit::EditorClient::respondToChangedSelection):
2750 (WebKit::EditorClient::handleInputMethodKeydown):
2751 (WebKit::EditorClient::EditorClient):
2752 (WebKit::EditorClient::~EditorClient):
2753 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2754 (WebKit::postCommitFrameViewSetup):
2755 * webkit/webkitprivate.h:
2756 * webkit/webkitwebview.cpp:
2758 (webkit_web_view_forward_context_menu_event):
2759 (webkit_web_view_key_release_event):
2760 (webkit_web_view_button_release_event):
2761 (webkit_web_view_focus_in_event):
2762 (webkit_web_view_focus_out_event):
2763 (webkit_web_view_realize):
2764 (webkit_web_view_set_scroll_adjustments):
2765 (webkit_web_view_dispose):
2766 (webkit_web_view_finalize):
2768 (webkit_web_view_screen_changed):
2769 (webkit_web_view_query_tooltip):
2770 (webkit_web_view_get_im_context):
2771 (webkit_web_view_update_settings):
2772 (webkit_web_view_init):
2773 (webkit_web_view_set_settings):
2774 (webkit_web_view_get_settings):
2775 (webkit_web_view_get_inspector):
2776 (webkit_web_view_set_window_features):
2777 (webkit_web_view_get_window_features):
2778 (webkit_web_view_get_back_forward_list):
2779 (webkit_web_view_zoom_in):
2780 (webkit_web_view_zoom_out):
2781 (webkit_web_view_get_encoding):
2782 (webkit_web_view_get_custom_encoding):
2783 (webkit_web_view_add_resource):
2784 (webkit_web_view_get_resource):
2785 (webkit_web_view_get_main_resource):
2786 (webkit_web_view_clear_resources):
2787 (webkit_web_view_get_subresources):
2788 (webkit_web_view_set_tooltip_text):
2789 (webkit_web_view_get_icon_uri):
2791 2010-05-18 Martin Robinson <mrobinson@igalia.com>
2793 Reviewed by Xan Lopez.
2795 [GTK] DragClientGtk::startDrag leaks GdkEvents
2796 https://bugs.webkit.org/show_bug.cgi?id=39322
2798 * WebCoreSupport/DragClientGtk.cpp:
2799 (WebKit::DragClient::startDrag): Properly clean up allocated GdkEvent.
2801 2010-05-12 Martin Robinson <mrobinson@igalia.com>
2803 Reviewed by Xan Lopez.
2805 [Gtk] Use GOwnPtr for code that needs it
2806 https://bugs.webkit.org/show_bug.cgi?id=21594
2808 Convert many uses of raw pointers to GRefPtr and GOwnPtr in WebKitWebView.
2810 * WebCoreSupport/ContextMenuClientGtk.cpp:
2811 (WebKit::inputMethodsMenuItem):
2812 * WebCoreSupport/EditorClientGtk.cpp:
2813 (WebKit::EditorClient::setInputMethodState):
2814 (WebKit::EditorClient::respondToChangedSelection):
2815 (WebKit::EditorClient::handleInputMethodKeydown):
2816 (WebKit::EditorClient::EditorClient):
2817 (WebKit::EditorClient::~EditorClient):
2818 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2819 (WebKit::postCommitFrameViewSetup):
2820 * webkit/webkitprivate.h:
2821 * webkit/webkitwebview.cpp:
2823 (webkit_web_view_forward_context_menu_event):
2824 (webkit_web_view_key_release_event):
2825 (webkit_web_view_button_release_event):
2826 (webkit_web_view_focus_in_event):
2827 (webkit_web_view_focus_out_event):
2828 (webkit_web_view_realize):
2829 (webkit_web_view_set_scroll_adjustments):
2830 (webkit_web_view_dispose):
2831 (webkit_web_view_finalize):
2833 (webkit_web_view_screen_changed):
2834 (webkit_web_view_query_tooltip):
2835 (webkit_web_view_get_im_context):
2836 (webkit_web_view_update_settings):
2837 (webkit_web_view_init):
2838 (webkit_web_view_set_settings):
2839 (webkit_web_view_get_settings):
2840 (webkit_web_view_get_inspector):
2841 (webkit_web_view_set_window_features):
2842 (webkit_web_view_get_window_features):
2843 (webkit_web_view_get_back_forward_list):
2844 (webkit_web_view_zoom_in):
2845 (webkit_web_view_zoom_out):
2846 (webkit_web_view_get_encoding):
2847 (webkit_web_view_get_custom_encoding):
2848 (webkit_web_view_add_resource):
2849 (webkit_web_view_get_resource):
2850 (webkit_web_view_get_main_resource):
2851 (webkit_web_view_clear_resources):
2852 (webkit_web_view_get_subresources):
2853 (webkit_web_view_set_tooltip_text):
2854 (webkit_web_view_get_icon_uri):
2856 2010-05-11 Martin Robinson <mrobinson@igalia.com>
2858 Reviewed by Xan Lopez.
2860 [Gtk] Doesn't support gtk-key-themes
2861 https://bugs.webkit.org/show_bug.cgi?id=28257
2863 Add support for GTK+ key themes.
2865 * WebCoreSupport/EditorClientGtk.cpp:
2866 (WebKit::backspaceCallback): Added.
2867 (WebKit::cutClipboardCallback): Added.
2868 (WebKit::copyClipboardCallback): Added.
2869 (WebKit::pasteClipboardCallback): Added.
2870 (WebKit::selectAllCallback): Added.
2871 (WebKit::deleteFromCursorCallback): Added.
2872 (WebKit::moveCursorCallback): Added.
2873 (WebKit::EditorClient::generateEditorCommands): Added.
2874 (WebKit::EditorClient::executePendingEditorCommands): Added.
2875 (WebKit::EditorClient::handleKeyboardEvent): Derive editor commands both from internal text widget and a list of fallbacks.
2876 (WebKit::EditorClient::EditorClient): Add m_nativeWidget initializer.
2877 * WebCoreSupport/EditorClientGtk.h:
2878 (WebKit::EditorClient::addPendingEditorCommand): Add m_nativeWidget member.
2880 2010-05-06 Martin Robinson <mrobinson@webkit.org>
2882 Reviewed by Xan Lopez.
2884 Remove use of GOwnPtr to hold GObject types.
2885 https://bugs.webkit.org/show_bug.cgi?id=38669
2887 Change use of GOwnPtr to GRefPtr to types which are natively reference-counted.
2889 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2890 (WebKit::FrameLoaderClient::dispatchWillSendRequest): Change GOwnPtr to GRefPtr in some places.
2891 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto.
2892 * webkit/webkitnetworkrequest.cpp:
2893 (webkit_network_request_new_with_core_request): Ditto.
2894 * webkit/webkitnetworkresponse.cpp:
2895 (webkit_network_response_new_with_core_response): Ditto.
2896 * webkit/webkitprivate.cpp: Remove GOwnPtr reference counting template specialization.
2897 * webkit/webkitprivate.h: Ditto.
2899 2010-05-06 Martin Robinson <mrobinson@webkit.org>
2901 Reviewed by Gustavo Noronha Silva.
2903 [GTK] Enable DOM clipboard and drag-and-drop access
2904 https://bugs.webkit.org/show_bug.cgi?id=30623
2906 Convert dragging portion of drag-and-drop to use DataObjectGtk.
2908 * WebCoreSupport/DragClientGtk.cpp:
2909 (WebKit::DragClient::willPerformDragDestinationAction): Remove the notImplemented. It is implemented, it's just a no-op.
2910 (WebKit::DragClient::startDrag): Start the drag context via the ClipboardGtk and PasteboardHelper now.
2911 * WebCoreSupport/DragClientGtk.h: Small style fix.
2912 * webkit/webkitprivate.h: Add a HashMap of contexts and DataObjects here to to represent all current drag operations.
2913 * webkit/webkitwebview.cpp:
2914 (webkit_web_view_dispose): Clear all data objects during disposal.
2915 (webkit_web_view_drag_end): When a drag is over, just remove it from the map.
2916 (webkit_web_view_drag_data_get): To get the drag data, just grab it from the DataObject.
2918 2010-05-03 Abhishek Arya <inferno@chromium.org>
2920 Reviewed by Adam Barth.
2922 Add support for controlling clipboard access from javascript.
2923 Clipboard access from javascript is disabled by default.
2924 https://bugs.webkit.org/show_bug.cgi?id=27751
2926 * webkit/webkitwebsettings.cpp:
2927 (webkit_web_settings_class_init):
2928 (webkit_web_settings_set_property):
2929 (webkit_web_settings_get_property):
2930 (webkit_web_settings_copy):
2931 * webkit/webkitwebview.cpp:
2932 (webkit_web_view_update_settings):
2933 (webkit_web_view_settings_notify):
2935 2010-05-03 Jens Alfke <snej@chromium.org>
2937 Reviewed by Darin Fisher.
2939 [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
2940 https://bugs.webkit.org/show_bug.cgi?id=38397
2942 No tests (functionality is exposed only through native WebKit API.)
2944 * WebCoreSupport/FrameLoaderClientGtk.h:
2945 (WebKit::FrameLoaderClient::dispatchWillSendSubmitEvent):
2947 2010-05-01 Xan Lopez <xlopez@igalia.com>
2949 Reviewed by Oliver Hunt.
2951 [GTK] GObject DOM bindings
2952 https://bugs.webkit.org/show_bug.cgi?id=33590
2954 Test webkit_dom_document_get_links.
2956 * tests/testdomdocument.c:
2957 (test_dom_document_get_links):
2960 2010-04-29 Xan Lopez <xlopez@igalia.com>
2962 Reviewed by Gustavo Noronha.
2964 [GTK] GObject DOM bindings
2965 https://bugs.webkit.org/show_bug.cgi?id=33590
2967 Test webkit_dom_document_get_element_by_id;
2969 * tests/testdomdocument.c:
2970 (test_dom_document_get_element_by_id):
2973 2010-04-29 Xan Lopez <xlopez@igalia.com>
2975 Reviewed by Gustavo Noronha.
2977 [GTK] GObject DOM bindings
2978 https://bugs.webkit.org/show_bug.cgi?id=33590
2980 Test webkit_dom_document_get_elements_by_class_name.
2982 * tests/testdomdocument.c:
2983 (test_dom_document_get_elements_by_class_name):
2986 2010-04-29 Xan Lopez <xlopez@igalia.com>
2988 Reviewed by Gustavo Noronha.
2990 [GTK] GObject DOM bindings
2991 https://bugs.webkit.org/show_bug.cgi?id=33590
2993 Test webkit_dom_document_get_elements_by_tag_name.
2995 * tests/testdomdocument.c:
2996 (test_dom_document_get_elements_by_tag_name):
2999 2010-04-29 Xan Lopez <xlopez@igalia.com>
3001 Reviewed by Gustavo Noronha.
3003 [GTK] GObject DOM bindings
3004 https://bugs.webkit.org/show_bug.cgi?id=33590
3006 Move WebKitDOMDocument unit tests to their own file.
3008 * tests/testdomdocument.c: Added.
3010 (dom_document_fixture_setup):
3011 (dom_document_fixture_teardown):
3012 (test_dom_document_title):
3014 * tests/testwebview.c:
3016 2010-04-29 Xan Lopez <xlopez@igalia.com>
3018 Reviewed by Gustavo Noronha.
3020 [GTK] GObject DOM bindings
3021 https://bugs.webkit.org/show_bug.cgi?id=33590
3023 Include <webkit/webkitdom.h> in the main webkit.h header.
3027 2010-04-25 Sam Weinig <sam@webkit.org>
3029 Reviewed by Maciej Stachowiak.
3031 Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
3032 Disentangle initializing the main thread from initializing threading
3034 * webkit/webkitprivate.cpp:
3035 (webkit_init): Add call to initializeMainThread.
3037 2010-04-22 Dave Moore <davemoore@chromium.org>
3039 Reviewed by Dimitri Glazkov.
3041 Added notification when the favicons for a page are changed
3043 The Document object will notify the frame loader, which will
3044 notify the client. Implementations of FrameLoaderClient will
3045 have to add one method; dispatchDidChangeIcons().
3047 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3048 (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
3049 * WebCoreSupport/FrameLoaderClientGtk.h:
3051 2010-04-22 Xan Lopez <xlopez@igalia.com>
3053 Reviewed by Gustavo Noronha.
3055 [GTK] GObject DOM bindings
3056 https://bugs.webkit.org/show_bug.cgi?id=33590
3058 Add webkit_web_view_get_document to retrieve the WebKitDOMDocument
3059 from a WebKitWebView, and a very simple test for it.
3061 * tests/testwebview.c:
3062 * webkit/webkitwebview.cpp:
3063 (webkit_web_view_get_document):
3064 * webkit/webkitwebview.h:
3066 2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
3068 Reviewed by Xan Lopez.
3070 [Gtk] Evaluate and create tests for all the AtkRole's implemented by
3072 https://bugs.webkit.org/show_bug.cgi?id=34449
3074 Expand testatkroles to test ATK_ROLE_COMBO_BOX.
3076 * tests/testatkroles.c:
3077 (test_webkit_atk_get_role_combobox):
3080 2010-04-22 Diego Escalante Urrelo <descalante@igalia.com>
3082 Reviewed by Xan Lopez.
3084 [Gtk] Evaluate and create tests for all the AtkRole's implemented by
3086 https://bugs.webkit.org/show_bug.cgi?id=34449
3088 Expand testatkroles to test ATK_ROLE_SEPARATOR.
3090 * tests/testatkroles.c:
3091 (test_webkit_atk_get_role_separator):
3094 2010-04-22 Adam Barth <abarth@webkit.org>
3096 Unreviewed, rolling out r58069.
3097 http://trac.webkit.org/changeset/58069
3098 https://bugs.webkit.org/show_bug.cgi?id=27751
3100 Broke compile on Windows.
3102 * webkit/webkitwebsettings.cpp:
3103 (webkit_web_settings_class_init):
3104 (webkit_web_settings_set_property):
3105 (webkit_web_settings_get_property):
3106 (webkit_web_settings_copy):
3107 * webkit/webkitwebview.cpp:
3108 (webkit_web_view_update_settings):
3109 (webkit_web_view_settings_notify):
3111 2010-04-22 Abhishek Arya <inferno@chromium.org>
3113 Reviewed by Adam Barth.
3115 Add support for controlling clipboard access from javascript.
3116 Clipboard access from javascript is disabled by default.
3117 https://bugs.webkit.org/show_bug.cgi?id=27751
3119 * webkit/webkitwebsettings.cpp:
3120 (webkit_web_settings_class_init):
3121 (webkit_web_settings_set_property):
3122 (webkit_web_settings_get_property):
3123 (webkit_web_settings_copy):
3124 * webkit/webkitwebview.cpp:
3125 (webkit_web_view_update_settings):
3126 (webkit_web_view_settings_notify):
3128 2010-04-21 Jakub Wieczorek <jwieczorek@webkit.org>
3130 Reviewed by Darin Adler.
3132 List item markers are not always updated after changes in the DOM.
3133 https://bugs.webkit.org/show_bug.cgi?id=37060
3135 * webkit/webkitprivate.h:
3136 * webkit/webkitwebframe.cpp:
3137 (webkit_web_frame_marker_text_for_list_item): Add a private API to get the marker text for a list item.
3139 2010-04-21 Diego Escalante Urrelo <descalante@igalia.com>
3141 Reviewed by Xan Lopez.
3143 [Gtk] Evaluate and create tests for all the AtkRole's implemented by
3145 https://bugs.webkit.org/show_bug.cgi?id=34449
3147 Expand testatkroles to test ATK_ROLE_FORM.
3149 * tests/testatkroles.c:
3150 (test_webkit_atk_get_role_form):
3153 2010-04-20 Adam Barth <abarth@webkit.org>
3155 Reviewed by Eric Seidel.
3157 Factor DocumentWriter out of FrameLoader
3158 https://bugs.webkit.org/show_bug.cgi?id=37175
3160 Update these callsites because the method moved to DocumentWriter.
3162 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3163 (WebKit::FrameLoaderClient::committedLoad):
3164 (WebKit::FrameLoaderClient::finishedLoading):
3165 * webkit/webkitwebview.cpp:
3166 (webkit_web_view_get_encoding):
3168 2010-04-20 Kent Tamura <tkent@chromium.org>
3170 Reviewed by Darin Adler.
3172 Change a parameter type of chooseIconForFiles()
3173 https://bugs.webkit.org/show_bug.cgi?id=37504
3175 * WebCoreSupport/ChromeClientGtk.cpp:
3176 (WebKit::ChromeClient::chooseIconForFiles):
3177 * WebCoreSupport/ChromeClientGtk.h:
3179 2010-04-20 Martin Robinson <mrobinson@webkit.org>
3181 Reviewed by Gustavo Noronha Silva.
3183 [GTK] Enable DOM clipboard and drag-and-drop access
3184 https://bugs.webkit.org/show_bug.cgi?id=30623
3186 Move most of the PasteboardHelper logic into WebCore. This helps
3187 prepare for WebKit2 and leads to a clearer separation of concerns
3188 between the WebKit and WebCore layers.
3190 * WebCoreSupport/EditorClientGtk.cpp:
3191 (WebKit::collapseSelection): Converted this logic to a GClosure callback.
3192 (WebKit::EditorClient::respondToChangedSelection): Collapse selection via GClosure now.
3193 * WebCoreSupport/PasteboardHelperGtk.cpp: Moved most of the code to WebCore.
3194 (WebKit::PasteboardHelperGtk::PasteboardHelperGtk): This constructor just initializes the target list.
3195 (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk): The destructor no longer needs to free the target list.
3196 (WebKit::PasteboardHelperGtk::getIdForTargetType): Added, virtual method for getting target ids.
3197 (WebKit::PasteboardHelperGtk::usePrimarySelectionClipboard): Added, virtual method for querying current clipboard.
3198 * WebCoreSupport/PasteboardHelperGtk.h: Update method list to reflect reduced functionality.
3200 2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>
3202 Reviewed by Xan Lopez.
3204 [Gtk] Evaluate and create tests for all the AtkRole's implemented by
3206 https://bugs.webkit.org/show_bug.cgi?id=34449
3208 Expand testatkroles to test ATK form roles.
3210 * tests/testatkroles.c:
3211 (test_webkit_atk_get_role_check_box):
3212 (test_webkit_atk_get_role_entry):
3213 (test_webkit_atk_get_role_label):
3214 (test_webkit_atk_get_role_listbox):
3215 (test_webkit_atk_get_role_password_text):
3216 (test_webkit_atk_get_role_push_button):
3217 (test_webkit_atk_get_role_radio_button):
3220 2010-04-19 Diego Escalante Urrelo <descalante@igalia.com>
3222 Reviewed by Xan Lopez.
3224 [Gtk] Evaluate and create tests for all the AtkRole's implemented by
3226 https://bugs.webkit.org/show_bug.cgi?id=34449
3228 Add testatkroles to test ATK non form roles.
3230 * tests/testatkroles.c: Added.
3232 (atk_roles_fixture_setup):
3233 (atk_roles_fixture_teardown):
3234 (get_child_and_test_role):
3235 (test_webkit_atk_get_role_document_frame):
3236 (test_webkit_atk_get_role_heading):
3237 (test_webkit_atk_get_role_image):
3238 (test_webkit_atk_get_role_link):
3239 (test_webkit_atk_get_role_list_and_item):
3240 (test_webkit_atk_get_role_paragraph):
3241 (test_webkit_atk_get_role_section):
3242 (test_webkit_atk_get_role_table):
3245 2010-04-17 Alejandro G. Castro <alex@igalia.com>
3247 Reviewed by Xan Lopez.
3249 We have to initialize the timer attribute after destroying it, not
3250 doing it was causing crashes in some situations.
3252 * webkit/webkitdownload.cpp:
3253 (webkit_download_finalize):
3255 2010-04-13 Timothy Hatcher <timothy@apple.com>
3257 Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3258 And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
3260 SecurityOrigin needs a way to remove individual OriginAccessEntries
3261 https://bugs.webkit.org/show_bug.cgi?id=37449
3263 Reviewed by Dave Hyatt.
3265 * webkit/webkitprivate.cpp:
3266 (webkit_white_list_access_from_origin):
3267 (webkit_reset_origin_access_white_lists):
3269 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
3271 Unreviewed, rolling out r57468.
3272 http://trac.webkit.org/changeset/57468
3273 https://bugs.webkit.org/show_bug.cgi?id=37433
3275 Broke the world... Must have applied the patch wrong
3276 (Requested by abarth on #webkit).
3278 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3279 (WebKit::FrameLoaderClient::committedLoad):
3280 (WebKit::FrameLoaderClient::finishedLoading):
3281 * webkit/webkitwebview.cpp:
3282 (webkit_web_view_get_encoding):
3284 2010-04-11 Adam Barth <abarth@webkit.org>
3286 Reviewed by Eric Seidel.
3288 Factor DocumentWriter out of FrameLoader
3289 https://bugs.webkit.org/show_bug.cgi?id=37175
3291 Update these callsites because the method moved to DocumentWriter.
3293 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3294 (WebKit::FrameLoaderClient::committedLoad):
3295 (WebKit::FrameLoaderClient::finishedLoading):
3296 * webkit/webkitwebview.cpp:
3297 (webkit_web_view_get_encoding):
3299 2010-04-07 Andrey Kosyakov <caseq@chromium.org>
3301 Reviewed by Yury Semikhatsky.
3303 Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
3304 https://bugs.webkit.org/show_bug.cgi?id=36949
3306 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3307 * WebCoreSupport/FrameLoaderClientGtk.h:
3309 2010-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3311 Reviewed by Holger Freyther.
3313 [GTK] webkit_get_default_session() should make sure webkit_init() is called
3314 https://bugs.webkit.org/show_bug.cgi?id=36754
3316 Make sure global functions that do not require a WebKitWebView to
3317 be created call webkit_init() before doing their job. Also add an
3318 API test to check for that.
3320 * tests/testglobals.c: Added.
3321 (test_globals_default_session):
3323 * webkit/webkitwebview.cpp:
3324 (webkit_get_default_session):
3325 (webkit_set_cache_model):
3326 (webkit_get_cache_model):
3328 2010-03-31 Marcus Bulach <bulach@chromium.org>
3330 Reviewed by Jeremy Orlow.
3332 Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
3333 https://bugs.webkit.org/show_bug.cgi?id=35031
3335 * WebCoreSupport/ChromeClientGtk.cpp:
3336 (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame):
3337 * WebCoreSupport/ChromeClientGtk.h:
3339 2010-03-30 Gavin Barraclough <barraclough@apple.com>
3341 Rubber stamped by Sam Weinig.
3343 https://bugs.webkit.org/show_bug.cgi?id=36866
3346 * WebCoreSupport/ChromeClientGtk.cpp:
3347 * WebCoreSupport/ContextMenuClientGtk.cpp:
3348 * WebCoreSupport/EditorClientGtk.cpp:
3349 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3350 * WebCoreSupport/InspectorClientGtk.cpp:
3351 * gdom/ConvertToGCharPrivate.h:
3352 * webkit/webkitdownload.cpp:
3353 * webkit/webkithittestresult.cpp:
3354 * webkit/webkitnetworkrequest.cpp:
3355 * webkit/webkitprivate.h:
3356 * webkit/webkitsecurityorigin.cpp:
3357 * webkit/webkitwebdatabase.cpp:
3358 * webkit/webkitwebframe.cpp:
3359 * webkit/webkitwebhistoryitem.cpp:
3360 (webkit_web_history_item_finalize):
3361 (webkit_web_history_item_get_target):
3362 * webkit/webkitwebresource.cpp:
3363 * webkit/webkitwebsettings.cpp:
3364 * webkit/webkitwebview.cpp:
3366 2010-03-28 Alexey Proskuryakov <ap@apple.com>
3368 Build fix. Include WindowsKeyboardCodes.h instead of KeyboardCodes.h.
3370 * WebCoreSupport/EditorClientGtk.cpp:
3372 2010-03-27 Sergio Villar Senin <svillar@igalia.com>
3374 Reviewed by Eric Seidel.
3376 FrameLoader emits onload-event when handling
3377 dispatchDidHandleOnloadEvents
3379 [GTK] Improve reporting of frame loader callbacks in DRT
3380 https://bugs.webkit.org/show_bug.cgi?id=36454
3382 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3383 (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents):
3384 implemented, now it emits onload-event signal
3385 * webkit/webkitwebview.cpp: added onload-event signal
3387 2010-03-25 Sergio Villar SenÃn <svillar@igalia.com>
3389 Reviewed by Xan Lopez.
3391 Added new API webkit_web_back_forward_list_clear. This function
3392 clears the back forward list
3394 [GTK] http/history tests are failing
3395 https://bugs.webkit.org/show_bug.cgi?id=36173
3397 * tests/testwebbackforwardlist.c:
3398 (test_webkit_web_back_forward_list_clear):
3399 (main): added new unit test for the new API
3400 * webkit/webkitwebbackforwardlist.cpp:
3401 (webkit_web_back_forward_list_clear):
3402 * webkit/webkitwebbackforwardlist.h: new function that clears the
3405 2010-03-24 Kent Tamura <tkent@chromium.org>
3407 Reviewed by Darin Adler.
3409 Make Icon::createIconForFiles() optional.
3410 https://bugs.webkit.org/show_bug.cgi?id=35072
3412 - Rename iconForFiles() to chooseIconForFiles().
3413 - Call Icon::createIconForFiles() from chooseIconForFiles().
3415 * WebCoreSupport/ChromeClientGtk.cpp:
3416 * WebCoreSupport/ChromeClientGtk.h:
3418 2010-03-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3420 Reviewed by Holger Freyther.
3422 [GTK] Does not build with latest GTK+ development release
3423 https://bugs.webkit.org/show_bug.cgi?id=36398
3425 Fix building with newest GTK+ versions.
3427 * WebCoreSupport/ChromeClientGtk.cpp:
3428 (WebKit::ChromeClient::windowRect):
3429 (WebKit::ChromeClient::setWindowRect):
3430 (WebKit::ChromeClient::unfocus):
3431 (WebKit::ChromeClient::canTakeFocus):
3432 (WebKit::ChromeClient::contentsSizeChanged):
3433 * webkit/webkitprivate.cpp:
3434 (currentToplevelCallback):
3435 * webkit/webkitwebframe.cpp:
3436 (webkit_web_frame_print_full):
3437 (webkit_web_frame_print):
3438 * webkit/webkitwebview.cpp:
3439 (webkit_web_view_grab_focus):
3440 (webkit_web_view_focus_in_event):
3441 (webkit_web_view_script_dialog):
3443 2010-03-18 Philip Chimento <philip.chimento@gmail.com>
3445 Reviewed by Oliver Hunt.
3447 Setting the GObject WebKitWebView property 'window-features' to NULL
3449 https://bugs.webkit.org/show_bug.cgi?id=36144
3451 * tests/testwebview.c: Add unit test for this bug.
3452 * webkit/webkitwebview.cpp: Don't allow the 'window-features' property
3454 * webkit/webkitwebwindowfeatures.cpp:
3455 (webkit_web_window_features_equal): Don't examine the members of either
3456 web_window_features argument if either is NULL, just return that they
3457 are not equal. Additionally, if they are the same object, return that
3460 2010-03-16 Xan Lopez <xlopez@igalia.com>
3462 Reviewed by Gustavo Noronha.
3464 Update for 1.1.90 release.
3468 2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3470 Fix one too many empty lines in documentation of
3471 window-obejct-cleared signal, which caused the documentation to be
3472 rendered funny. Thanks to Martin Robinson for noticing.
3474 * webkit/webkitwebview.cpp:
3476 2010-03-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3478 Unreviewed. Add missing symbol to GeoLocation documentation
3481 * docs/webkitgtk-sections.txt:
3483 2010-03-16 Martin Robinson <mrobinson@webkit.org>
3485 Reviewed by Xan Lopez.
3487 can't input korean into lower all input box except adress input box in webkit gtk launcher
3488 https://bugs.webkit.org/show_bug.cgi?id=32290
3490 Make the GTK+ EditorClient properly handle different types of input module
3491 behavior such as commit and preedit signals that happen outside of key event
3492 filtering and multiple times in a row. Filter keyup events as well as keydown
3493 events and call gtk_im_context_focus_{in/out} when the WebView focus changes.
3495 Added tests for this behavior to the GTK+ unit tests.
3497 * WebCoreSupport/EditorClientGtk.cpp:
3498 (WebKit::imContextCommitted): Handle this signal properly when it happens outside of
3499 key event filtering.
3500 (WebKit::imContextPreeditChanged): Immediately update the preedit state and do not reject
3501 empty preedits, so that cancellation works properly.
3502 (WebKit::EditorClient::updatePendingComposition): Add this method, which handles the
3503 situation where a commit signal happens when there is still a pending commit.
3504 (WebKit::EditorClient::shouldBeginEditing): Clear pending composition state before editing
3506 (WebKit::EditorClient::shouldEndEditing): Clear pending composition state before editing ends.
3507 (WebKit::EditorClient::handleKeyboardEvent): No longer special case preedits which happen during
3508 key event filtering. When confirming a pending composition use insertText instead of confirmComposition.
3509 (WebKit::EditorClient::handleInputMethodKeydown):
3510 * WebCoreSupport/EditorClientGtk.h: Make pendingComposition a member, so that multiple WebViews
3512 (WebKit::EditorClient::webView): Added.
3513 (WebKit::EditorClient::treatContextCommitAsKeyEvent): Added.
3514 (WebKit::EditorClient::clearPendingComposition): Added.
3515 * tests/testkeyevents.c:
3516 (test_keypress_events_load_status_cb):
3518 (setup_keyevent_test):
3519 (test_keypress_events):
3520 (element_text_equal_to):
3521 (test_ime_load_status_cb):
3524 * webkit/webkitwebview.cpp:
3525 (webkit_web_view_key_release_event):
3526 (webkit_web_view_focus_in_event):
3528 2010-03-16 Yury Semikhatsky <yurys@chromium.org>
3530 Reviewed by Pavel Feldman.
3532 Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
3534 Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
3535 https://bugs.webkit.org/show_bug.cgi?id=35036
3537 * WebCoreSupport/InspectorClientGtk.cpp:
3538 (WebKit::notifyWebViewDestroyed):
3539 (WebKit::InspectorClient::InspectorClient):
3540 (WebKit::InspectorClient::inspectorDestroyed):
3541 (WebKit::InspectorClient::openInspectorFrontend):
3542 (WebKit::InspectorClient::highlight):
3543 (WebKit::InspectorClient::hideHighlight):
3544 (WebKit::InspectorClient::populateSetting):
3545 (WebKit::InspectorClient::storeSetting):
3546 (WebKit::InspectorFrontendClient::InspectorFrontendClient):
3547 (WebKit::InspectorFrontendClient::~InspectorFrontendClient):
3548 (WebKit::InspectorFrontendClient::destroyInspectorWindow):
3549 (WebKit::InspectorFrontendClient::localizedStringsURL):
3550 (WebKit::InspectorFrontendClient::hiddenPanels):
3551 (WebKit::InspectorFrontendClient::bringToFront):
3552 (WebKit::InspectorFrontendClient::closeWindow):
3553 (WebKit::InspectorFrontendClient::attachWindow):
3554 (WebKit::InspectorFrontendClient::detachWindow):
3555 (WebKit::InspectorFrontendClient::setAttachedWindowHeight):
3556 (WebKit::InspectorFrontendClient::inspectedURLChanged):
3557 * WebCoreSupport/InspectorClientGtk.h:
3559 2010-03-15 Joanmarie Diggs <joanmarie.diggs@gmail.com>
3561 Reviewed by Holger Freyther.
3563 https://bugs.webkit.org/show_bug.cgi?id=35502
3564 [Gtk] Objects of ATK_ROLE_TABLE should not implement AtkText
3566 New test to be sure we do not accidentally implement AtkText for tables
3569 (testWebkitAtkGetTextInTable):
3572 2010-03-09 Philippe Normand <pnormand@igalia.com>
3574 Reviewed by Holger Freyther.
3576 [GTK] GTK_WIDGET_IS_SENSITIVE is deprecated in GTK+ 2.20
3577 https://bugs.webkit.org/show_bug.cgi?id=35909
3579 * webkit/webkitwebview.cpp: GTK_WIDGET_IS_SENSITIVE has been
3580 deprecated in gtk 2.20. Use gtk_widget_is_sensitive when available.
3582 2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3584 Rubber-stamped by Kenneth Rohde Christiansen.
3586 Misc documentation fixes. Fixes (almost) all warnings emitted by
3587 the documentation build process. Only the broken references to JSC
3590 * webkit/webkitsecurityorigin.cpp:
3591 * webkit/webkitwebbackforwardlist.cpp:
3592 * webkit/webkitwebdatasource.cpp:
3593 * webkit/webkitwebframe.cpp:
3594 * webkit/webkitwebhistoryitem.cpp:
3595 * webkit/webkitwebinspector.cpp:
3596 (webkit_web_inspector_class_init):
3597 * webkit/webkitwebsettings.cpp:
3598 (webkit_web_settings_class_init):
3599 * webkit/webkitwebview.cpp:
3600 (DNDContentsRequest::webkit_web_view_class_init):
3602 2010-03-11 Anders Carlsson <andersca@apple.com>
3604 Reviewed by David Hyatt.
3606 Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
3608 * WebCoreSupport/ChromeClientGtk.cpp:
3609 * WebCoreSupport/ChromeClientGtk.h:
3611 2010-03-09 Philippe Normand <pnormand@igalia.com>
3613 Reviewed by Gustavo Noronha Silva.
3615 [GTK] testkeyevents doesn't stop if input event injection fails
3616 https://bugs.webkit.org/show_bug.cgi?id=35922
3618 * tests/testkeyevents.c:
3619 (load_status_cb): Added a safeguard to exit from the test if the
3620 input event injection failed.
3622 2010-03-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3624 Unreviewed. Documentation control files update for 1.1.23.
3626 * docs/webkitgtk-docs.sgml:
3628 2010-03-08 Csaba Osztrogonác <ossy@webkit.org>
3630 [GTK] Unreviewed buildfix after r55688.
3632 * webkit/webkitdownload.cpp:
3633 (webkit_download_start):
3635 2010-03-02 Adam Treat <atreat@rim.com>
3637 Reviewed by Dave Hyatt.
3639 Adapt the gtk port to the refactoring of repaint methods.
3641 https://bugs.webkit.org/show_bug.cgi?id=34214
3643 * WebCoreSupport/ChromeClientGtk.cpp:
3644 * WebCoreSupport/ChromeClientGtk.h:
3646 2010-03-08 Eric Uhrhane <ericu@chromium.org>
3648 Reviewed by David Levin.
3650 Remove the now-redundant Settings fields for the Database
3651 https://bugs.webkit.org/show_bug.cgi?id=35763
3653 No new tests; this code isn't called.
3655 * webkit/webkitwebview.cpp: Remove the calls into Settings.
3656 (DNDContentsRequest::webkit_web_view_update_settings):
3657 (DNDContentsRequest::webkit_web_view_settings_notify):
3659 2010-03-06 Arno Renevier <arno@renevier.net>
3661 Reviewed by Eric Seidel.
3663 [Gtk] GEOLOCATION_POLICY_DECISION_CANCELLED unused
3664 https://bugs.webkit.org/show_bug.cgi?id=35803
3666 * webkit/webkitwebview.cpp:
3667 (DNDContentsRequest::webkit_web_view_class_init):
3669 2010-03-03 Antonio Gomes <tonikitoo@webkit.org>
3671 Reviewed by Gustavo Noronha.
3672 Patch by Antonio Gomes <tonikitoo@webkit.org>
3674 [Gtk] Add 'enable-spatial-navigation' setting for toggle Spatial Navigation on/off
3675 https://bugs.webkit.org/show_bug.cgi?id=35701
3677 * webkit/webkitwebsettings.cpp:
3678 (webkit_web_settings_class_init):
3679 (webkit_web_settings_set_property):
3680 (webkit_web_settings_get_property):
3681 (webkit_web_settings_copy):
3682 * webkit/webkitwebview.cpp:
3683 (DNDContentsRequest::webkit_web_view_update_settings):
3684 (DNDContentsRequest::webkit_web_view_settings_notify):
3686 2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch>
3688 Reviewed by Xan Lopez.
3690 Miscellaneous little fixes for the windows build of webkit-gtk
3691 https://bugs.webkit.org/show_bug.cgi?id=35640
3693 * webkit/webkitdownload.cpp: Windows headers define ERROR
3694 which breaks the build. Undef ERROR if it is defined.
3696 2010-03-03 Philippe Normand <pnormand@igalia.com>
3698 Unreviewed, build fix after r55452.
3700 * webkit/webkitwebview.cpp:
3701 (DNDContentsRequest::webkit_web_view_settings_notify): added missing braces.
3703 2010-03-02 Eric Uhrhane <ericu@chromium.org>
3705 Reviewed by David Levin.
3707 Move database enable bit fully out of settings
3708 This is stage one of a three-stage commit [webkit, then chromium, then
3709 webkit again]. In this change I'm adding calls to
3710 Database::setIsAvailable inside Settings::setDatabaseEnabled and
3711 anywhere else that called it, and switching webkit fully over to using
3712 that flag [added in a previous checkin]. Phase two will remove
3713 Chromium's use of Settings for the Database, and phase three will remove
3714 the Setting for the Database enable entirely, leaving only
3715 Database::isAvailable/setIsAvailable.
3717 No new tests; tested by existing storage tests.
3719 https://bugs.webkit.org/show_bug.cgi?id=35310
3721 * webkit/webkitwebview.cpp: Add calls to Database::setIsAvailable
3722 (DNDContentsRequest::webkit_web_view_update_settings):
3723 (DNDContentsRequest::webkit_web_view_settings_notify):
3725 2010-03-02 Arno Renevier <arno@renevier.net>
3727 Reviewed by Gustavo Noronha Silva.
3729 [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame
3730 https://bugs.webkit.org/show_bug.cgi?id=35210
3732 * WebCoreSupport/ChromeClientGtk.cpp:
3733 * WebCoreSupport/ChromeClientGtk.h:
3734 * docs/webkitgtk-sections.txt:
3736 * webkit/webkitdefines.h:
3737 * webkit/webkitgeolocationpolicydecision.cpp: Added.
3738 (webkit_geolocation_policy_decision_class_init):
3739 (webkit_geolocation_policy_decision_init):
3740 (webkit_geolocation_policy_decision_new):
3741 (webkit_geolocation_policy_allow):
3742 (webkit_geolocation_policy_deny):
3743 * webkit/webkitgeolocationpolicydecision.h: Added.
3744 * webkit/webkitprivate.h:
3745 * webkit/webkitwebview.cpp:
3746 (DNDContentsRequest::webkit_web_view_class_init):
3747 * webkitmarshal.list:
3749 2010-03-01 José Millán Soto <jmillan@igalia.com>
3751 Reviewed by Gustavo Noronha Silva.
3753 [GTK] Right click does not activate text entry
3754 https://bugs.webkit.org/show_bug.cgi?id=29177
3756 Makes the frame handle the mouse click event before sending the
3759 * webkit/webkitwebview.cpp:
3760 (PopupMenuPositionFunc):
3761 Function created to make the popup menu appear in the correct position, especially
3762 when invoked from the keyboard.
3763 (webkit_web_view_forward_context_menu_event):
3764 Mouse click event is sent to frame before creating context menu,
3765 PopupMenuPositionFunc used to determine the position where the menu should appear.
3766 (webkit_web_view_popup_menu_handler):
3767 Improved focused node position detection. Event button set to right button.
3769 2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
3771 Reviewed by Adam Barth.
3773 Adapt to the new ZoomMode enum.
3774 https://bugs.webkit.org/show_bug.cgi?id=35347
3776 * webkit/webkitwebview.cpp:
3777 (DNDContentsRequest::webkit_web_view_apply_zoom_level):
3779 2010-03-01 Kalle Vahlman <zuh@iki.fi>
3781 Reviewed by Gustavo Noronha Silva.
3783 Queue a resize when either of the content dimensions change
3784 https://bugs.webkit.org/show_bug.cgi?id=35489
3786 The check for size changes only queued a resize if both of the content
3787 dimensions change, leaving the widget size out-of-sync if eg. only the
3790 * WebCoreSupport/ChromeClientGtk.cpp:
3792 2009-12-04 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3794 Reviewed by Xan Lopez.
3796 [GTK] Needs proper reporting of frame loader callbacks, in DRT
3797 https://bugs.webkit.org/show_bug.cgi?id=32170
3799 Add new signal to report when the document load is finished for a
3802 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3803 (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad):
3804 * webkit/webkitwebview.cpp:
3805 (webkit_web_view_class_init):
3807 2010-02-26 Antonio Gomes <tonikitoo@webkit.org>
3809 Complementary commit of r55300. Missing "notify::" to signal name.
3811 * tests/testwebview.c:
3812 (test_webkit_web_view_grab_focus):
3814 2010-02-26 Antonio Gomes <tonikitoo@webkit.org>
3816 Reviewed by Xan Lopez.
3817 Patch by Antonio Gomes <tonikitoo@webkit.org>
3819 [GTK] Make webkit_web_view_grab_focus to active focus controller.
3820 https://bugs.webkit.org/show_bug.cgi?id=35402
3822 When programatically setting focus to an element in an inner document,
3823 calling "hasFocus()" from this document returns FALSE, because
3824 document's FocusController is not activated. It does not happen
3825 if |document| is the main document.
3827 Making webkit_web_view_grab_focus to actually activate the FocusController,
3830 * tests/testwebview.c:
3832 (test_webkit_web_view_grab_focus):
3833 * webkit/webkitwebview.cpp:
3834 (webkit_web_view_grab_focus):
3836 2010-02-26 Alejandro G. Castro <alex@igalia.com>
3840 Reverted last patch (r55295), it causes problems with the frames.
3842 * WebCoreSupport/ChromeClientGtk.cpp:
3844 2010-02-19 Alejandro G. Castro <alex@igalia.com>
3846 Reviewed by Xan Lopez.
3848 [GTK] Some region checks in scroll are not required
3849 https://bugs.webkit.org/show_bug.cgi?id=35142
3851 Removes some of the operations checking the moved and invalidated
3852 regions when scrolling, it is done already in
3853 gdk_window_move_region.
3855 * WebCoreSupport/ChromeClientGtk.cpp:
3857 2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3859 Reviewed by Xan Lopez.
3861 [Gtk] crashed when destroying
3862 https://bugs.webkit.org/show_bug.cgi?id=31271
3864 NULL-check the page before relaying the focus out event, since
3865 this might happen when destroying the widget without destroying
3866 its parent, and we currently crash.
3868 * tests/testwebview.c:
3870 (test_webkit_web_view_destroy):
3872 * webkit/webkitwebview.cpp:
3873 (webkit_web_view_focus_in_event):
3875 2010-02-24 Krzysztof Kotlenga <pocek@users.sf.net>
3877 Reviewed by Gustavo Noronha Silva.
3879 [Gtk] Creation of a WebkitWebView widget is very slow
3880 https://bugs.webkit.org/show_bug.cgi?id=30032
3882 * WebCoreSupport/EditorClientGtk.cpp:
3883 (WebKit::EditorClient::ignoreWordInSpellDocument): Change 'langs' to 'dicts'
3884 to reflect the fact that the list just holds Enchant dictionaries now.
3885 (WebKit::EditorClient::learnWord): Ditto.
3886 (WebKit::EditorClient::checkSpellingOfString): Ditto.
3887 (WebKit::EditorClient::getGuessesForWord): Ditto.
3888 * webkit/webkitprivate.h: Remove the now unused SpellLanguage struct.
3889 * webkit/webkitwebsettings.cpp: Change function call to reflect new
3890 webkit_web_settings_get_enchant_dicts name.
3891 (get_enchant_broker): Add this method which returns the enchant broker singleton.
3892 (free_spell_checking_language): The list contents have changed, so change
3893 the way each element is freed.
3894 (webkit_web_settings_finalize): Change to reflect 'spell_checking_languages_list'
3895 to 'enchant_dicts' member name change.
3896 (webkit_web_settings_set_property): Use the broker singleton here instead of making
3897 a new one for each language. The Enchant dictionary is now the list payload.
3898 (webkit_web_settings_copy): More name-change updates.
3899 (webkit_web_settings_get_enchant_dicts): Ditto.
3901 2010-02-23 Leandro Pereira <leandro@profusion.mobi>
3903 Reviewed by Gustavo Noronha Silva.
3905 Fixes references to GOwnPtr and GRefPtr so the GTK+ port builds
3907 http://webkit.org/b/35084
3909 * WebKit/gtk/webkit/webkitwebview.cpp:
3911 2010-02-23 Shinichiro Hamaji <hamaji@chromium.org>
3913 Reviewed by Eric Seidel.
3915 [Gtk] Implement layoutTestController.numberOfPages
3916 https://bugs.webkit.org/show_bug.cgi?id=35228
3918 * webkit/webkitprivate.h:
3919 * webkit/webkitwebframe.cpp:
3920 (webkit_web_frame_number_of_pages):
3922 2010-02-23 José Millán Soto <jmillan@igalia.com>
3924 Reviewed by Xan Lopez.
3926 [Gtk] Server message not shown on http authentication
3927 https://bugs.webkit.org/show_bug.cgi?id=34219
3929 * webkit/webkitsoupauthdialog.c:
3931 Server message is displayed, messageLabel and message variables were
3932 renamed to avoid confusion.
3934 2010-02-23 Steve Block <steveblock@google.com>
3936 Reviewed by Darin Adler.
3938 Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
3939 https://bugs.webkit.org/show_bug.cgi?id=34962
3941 This method is required so that a Geolocation object can cancel an
3942 asynchronous permission request. This allows the chrome client to cancel
3943 any UI it is showing for the permission request.
3945 * WebCoreSupport/ChromeClientGtk.h:
3946 (WebKit::ChromeClient::cancelGeolocationPermissionRequestForFrame):
3948 2010-02-23 Xan Lopez <xlopez@igalia.com>
3950 Reviewed by Gustavo Noronha.
3952 Do not do unnecessary work during size_allocate.
3954 FrameView::resize will already queue a layout, so there's no need
3955 to force one ourselves. On top of that, the layout function
3956 already adjusts the view size when needed, so there's no need to
3957 do that manually either. No change in the layout tests or unit
3960 * webkit/webkitwebview.cpp:
3961 (webkit_web_view_size_allocate):
3963 2010-02-22 Xan Lopez <xlopez@igalia.com>
3965 Reviewed by Gustavo Noronha.
3971 2010-02-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
3973 Reviewed by Xan Lopez.
3975 [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
3976 https://bugs.webkit.org/show_bug.cgi?id=35093
3978 Update the flags that are stored in the request, when the response
3981 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3982 (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
3984 2010-02-20 Gustavo Noronha Silva <gns@gnome.org>
3986 Unreviewed. Trivial fix - unnecessary variable got added by
3989 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3990 (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
3992 2010-02-18 Diego Escalante Urrelo <descalante@igalia.com>
3994 Reviewed by Gustavo Noronha Silva.
3996 [GTK] WebKitDownload documentation is incomplete
3997 https://bugs.webkit.org/show_bug.cgi?id=35018
3999 Concretely the error signal was undocumented. Also two relevant enums
4002 * docs/webkitgtk-sections.txt:
4003 * docs/webkitgtk.types:
4004 * webkit/webkitdownload.cpp:
4005 (webkit_download_class_init):
4007 2010-02-17 Dmitry Titov <dimich@chromium.org>
4009 Reviewed by David Levin, Darin Fisher, Simon Hausmann.
4011 When a live iframe element is moved between pages, it still depends on the old page.
4012 https://bugs.webkit.org/show_bug.cgi?id=34382
4014 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4015 (WebKit::FrameLoaderClient::didTransferChildFrameToNewDocument):
4016 Added empty implementation of a new virtual method.
4018 * WebCoreSupport/FrameLoaderClientGtk.h:
4020 2010-02-17 Kent Tamura <tkent@chromium.org>
4022 Reviewed by Eric Seidel.
4024 Introduces new Icon loading interface in order to support
4025 asynchronous loading.
4026 https://bugs.webkit.org/show_bug.cgi?id=32054
4028 Add an empty implementation of ChromeClient::iconForFiles().
4030 * WebCoreSupport/ChromeClientGtk.cpp:
4031 (WebKit::ChromeClient::iconForFiles):
4032 * WebCoreSupport/ChromeClientGtk.h:
4034 2010-02-17 Xan Lopez <xlopez@igalia.com>
4036 Reviewed by Gustavo Noronha.
4038 Rename 'enable-java' setting to 'enable-java-applet', since it
4039 only controls whether <applet> is supported or not instead of
4040 whether all Java content is supported or not.
4042 * webkit/webkitwebsettings.cpp:
4043 (webkit_web_settings_class_init):
4044 (webkit_web_settings_set_property):
4045 (webkit_web_settings_get_property):
4046 (webkit_web_settings_copy):
4047 * webkit/webkitwebview.cpp:
4048 (DNDContentsRequest::webkit_web_view_update_settings):
4049 (DNDContentsRequest::webkit_web_view_settings_notify):
4051 2010-02-17 Xan Lopez <xlopez@igalia.com>
4053 Reviewed by Gustavo Noronha.
4055 [Linux] Webkit incompatible with Java plugins
4056 https://bugs.webkit.org/show_bug.cgi?id=24912
4058 Implement FrameLoaderClient::createJavaAppletWidget.
4060 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4061 (WebKit::FrameLoaderClient::createJavaAppletWidget):
4063 2010-02-17 Xan Lopez <xlopez@igalia.com>
4065 Reviewed by Gustavo Noronha.
4067 [Linux] Webkit incompatible with Java plugins
4068 https://bugs.webkit.org/show_bug.cgi?id=24912
4070 Add a WebKitWebSetting to enable/disable the Java plugin support.
4072 * webkit/webkitwebsettings.cpp:
4073 (webkit_web_settings_class_init):
4074 (webkit_web_settings_set_property):
4075 (webkit_web_settings_get_property):
4076 (webkit_web_settings_copy):
4077 * webkit/webkitwebview.cpp:
4078 (webkit_web_view_update_settings):
4079 (webkit_web_view_settings_notify):
4081 2010-02-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4083 Reviewed by Xan Lopez.
4085 Test that data URIs that cause downloads to be started do not crash.
4087 * tests/testdownload.c:
4088 (mime_type_policy_decision_requested_cb):
4089 (idle_quit_loop_cb):
4090 (test_webkit_download_data):
4093 2010-02-17 Philippe Normand <pnormand@igalia.com>
4095 Reviewed by Xan Lopez.
4097 Missing property warning after r54873
4098 https://bugs.webkit.org/show_bug.cgi?id=35023
4100 Add a new WebKitWebSettings setting, 'enable-file-access-from-file-uris', set to
4101 FALSE by default, that when enabled will assign each file:// URI
4102 their own security domain.
4104 * webkit/webkitwebsettings.cpp:
4105 (webkit_web_settings_class_init):
4106 (webkit_web_settings_set_property):
4107 (webkit_web_settings_get_property):
4108 (webkit_web_settings_copy):
4110 2010-02-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4112 Reviewed by Xan Lopez.
4114 Check if the handle has a SoupMessage before trying to use
4115 it. This will be the case in non-HTTP(S) URLs.
4117 * webkit/webkitdownload.cpp:
4118 (webkit_download_new_with_handle):
4119 (webkit_download_start):
4121 2010-02-16 Xan Lopez <xlopez@igalia.com>
4123 Reviewed by Gustavo Noronha.
4125 Add a new WebKitWebSettings setting, 'auto-resize-window', set to
4126 FALSE by default, that when enabled will apply any resizes or
4127 moves done by a page through various DOM methods (moveTo,
4128 resizeTo, moveBy, resizeBy).
4130 * WebCoreSupport/ChromeClientGtk.cpp:
4131 * webkit/webkitwebsettings.cpp:
4132 (webkit_web_settings_class_init):
4133 (webkit_web_settings_set_property):
4134 (webkit_web_settings_get_property):
4135 (webkit_web_settings_copy):
4137 2010-02-15 Emilio Pozuelo Monfort <pochu27@gmail.com>
4139 Reviewed by Gustavo Noronha Silva.
4141 [GTK] Fails to build on GNU/Hurd because of PATH_MAX usage
4142 https://bugs.webkit.org/show_bug.cgi?id=34920
4144 Use dynamic allocation instead of fixed PATH_MAX size buffers to
4145 fix the build on GNU/Hurd, where PATH_MAX is undefined.
4147 * tests/testmimehandling.c:
4149 * tests/testwebview.c:
4152 2010-02-14 Diego Escalante Urrelo <descalante@igalia.com>
4154 Reviewed by Gustavo Noronha Silva.
4156 [gtk] WebKitDownload's currentSize property is guint, should be guint64
4157 https://bugs.webkit.org/show_bug.cgi?id=34829
4159 Actually use a guint64 for current-size property in WebKitDownload, we
4160 were using a guint which is likely the cause for wrong sizes for files
4163 * webkit/webkitdownload.cpp:
4165 2010-02-09 Gustavo Noronha Silva <gns@gnome.org>
4167 Reviewed by Xan Lopez.
4169 [GTK] Hits assertion on history back, with page cache enabled, in specific conditions
4170 https://bugs.webkit.org/show_bug.cgi?id=34773
4172 Make sure cached frames have their scrollbars disconnected from
4173 the WebView's adjustments.
4175 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4176 (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):
4178 2010-02-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4180 Reviewed by Xan Lopez.
4182 [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
4183 https://bugs.webkit.org/show_bug.cgi?id=34754
4185 Test that lower, and upper bounds are kept when goibg back with
4186 page cache enabled, and disabled. Page cache behaviour is still a
4187 bit broken (see FIXME).
4189 * tests/testwebview.c:
4192 (do_test_webkit_web_view_adjustments):
4193 (test_webkit_web_view_adjustments):
4196 2010-02-09 Xan Lopez <xlopez@igalia.com>
4198 Reviewed by Gustavo Noronha.
4200 [GTK] Set GtkAdjustments on our FrameView when loading a page in the PageCache
4201 https://bugs.webkit.org/show_bug.cgi?id=34754
4203 Set the Gtk Adjustments of the FrameViews when they are restored
4204 from the PageCache too. Right we only do it for the newly created
4205 FrameViews in transitionToCommittedForNewPage, but we it also
4206 needs to be done in the equilavent transition method for cached
4209 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4210 (WebKit::postCommitFrameViewSetup):
4211 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
4212 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
4214 2010-02-08 Xan Lopez <xlopez@igalia.com>
4216 Reviewed by Gustavo Noronha.
4218 [GTK] Implement FrameLoaderClient::hasWebView
4219 https://bugs.webkit.org/show_bug.cgi?id=34682
4221 Used for sanity-check ASSERTS in the FrameLoader code.
4223 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4224 (WebKit::FrameLoaderClient::hasWebView):
4226 2010-02-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4228 Reviewed by Xan Lopez.
4234 2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
4236 Reviewed by Gustavo Noronha Silva.
4238 [Gtk] Implement layoutTestController.pageNumberForElementById
4239 https://bugs.webkit.org/show_bug.cgi?id=34572
4241 * webkit/webkitprivate.h:
4242 * webkit/webkitwebframe.cpp:
4243 (webkit_web_frame_page_number_for_element_by_id):
4245 2010-02-04 Christian Dywan <christian@twotoasts.de>
4247 Reviewed by Gustavo Noronha Silva.
4249 [GTK] Add and cleanup return values of signals in view and frame
4250 https://bugs.webkit.org/show_bug.cgi?id=33484
4252 Add missing and cleanup return values of web frame and web view signals.
4254 * webkit/webkitwebframe.cpp:
4255 (webkit_web_frame_class_init):
4256 * webkit/webkitwebview.cpp:
4257 (DNDContentsRequest::webkit_web_view_class_init):
4259 2010-02-02 Gustavo Noronha Silva <gns@gnome.org>
4261 Reviewed by Xan Lopez.
4263 Changes in 1.1.20, and documentation control files update.
4266 * docs/webkitgtk-docs.sgml:
4268 2010-02-02 Martin Robinson <martin.james.robinson@gmail.com>
4270 Reviewed by Gustavo Noronha Silva.
4272 [GTK] When selection changes selections in other WebView are not collapsed
4273 https://bugs.webkit.org/show_bug.cgi?id=34043
4275 Collapse the selection of a WebView even when the new selection owner is
4278 * WebCoreSupport/PasteboardHelperGtk.cpp:
4279 (WebKit::clearClipboardContentsCallback): Only clear the DataObject we are setting
4280 is not the same as the one referenced in this callback. Use the same behavior for
4281 collapsing the selection.
4282 (WebKit::PasteboardHelperGtk::writeClipboardContents): Instead of recording a boolean
4283 record the actual data used while writing to the clipboard.
4285 2010-01-27 Martin Robinson <mrobinson@webkit.org>
4287 Reviewed by Gustavo Noronha Silva.
4289 [GTK] Expose the IM context via the API
4290 https://bugs.webkit.org/show_bug.cgi?id=33327
4292 Expose the GtkIMMultiContext as a property of WebKitWebView. This will
4293 allow embedders to generate the input method context menu entries and
4294 make testing certain IM context behavior possible.
4296 * webkit/webkitwebview.cpp:
4297 (webkit_web_view_get_property):
4298 (DNDContentsRequest::webkit_web_view_get_im_context):
4299 (DNDContentsRequest::webkit_web_view_class_init):
4301 2010-01-19 Joanmarie Diggs <joanmarie.diggs@gmail.com>
4303 Reviewed by Xan Lopez.
4305 https://bugs.webkit.org/show_bug.cgi?id=30883
4306 [Gtk] Implement AtkText for HTML elements which contain text
4308 Adds two news tests.
4311 (testWebkitAtkGetTextInParagraphAndBodySimple):
4312 (testWebkitAtkGetTextInParagraphAndBodyModerate):
4315 2010-01-19 Gustavo Noronha Silva <gns@gnome.org>
4317 Unreviewed. Changes to the test I forgot to make after a last
4318 minute change before landing 53294 - this causes make distcheck to
4321 * tests/testloading.c:
4322 (load_error_status_changed_cb):
4323 (test_loading_error):
4325 2010-01-19 Gustavo Noronha Silva <gns@gnome.org>
4327 Reviewed by Xan Lopez.
4329 News items for 1.1.19.
4333 2010-01-19 Gustavo Noronha Silva <gns@gnome.org>
4335 Reviewed by Xan Lopez.
4337 [GTK] More crashes related to the clipboard management
4338 https://bugs.webkit.org/show_bug.cgi?id=33746
4340 Pass the WebKitWebView object (which is a GObject, thus
4341 ref-counted) to the clipboard functions instead of passing the
4342 Page - this allows us to explicitely protect the object inbetween
4343 the clipboard call and its callbacks, which fixes the crash.
4345 * WebCoreSupport/EditorClientGtk.cpp:
4346 (WebKit::EditorClient::respondToChangedSelection):
4347 * WebCoreSupport/PasteboardHelperGtk.cpp:
4348 (WebKit::getClipboardContentsCallback):
4349 (WebKit::clearClipboardContentsCallback):
4350 (WebKit::PasteboardHelperGtk::writeClipboardContents):
4352 2010-01-15 Alejandro G. Castro <alex@igalia.com>
4354 Reviewed by Xan Lopez.
4356 Original patch by David Ronis <david.ronis@mcgill.ca>
4358 Upgrade 1.1.17->1.1.18 fails: GTK_WIDGET_TOPLEVEL' was not declared in this scope
4359 https://bugs.webkit.org/show_bug.cgi?id=33486
4361 Deprecated symbols replaced for gtk+ versions over 2.18.
4363 * WebCoreSupport/ChromeClientGtk.cpp:
4364 (WebKit::ChromeClient::windowRect):
4365 * webkit/webkitprivate.cpp:
4366 (currentToplevelCallback):
4367 * webkit/webkitwebframe.cpp:
4368 (webkit_web_frame_print_full):
4369 (webkit_web_frame_print):
4370 * webkit/webkitwebview.cpp:
4371 (webkit_web_view_focus_in_event):
4373 2010-01-14 Gustavo Noronha Silva <gns@gnome.org>
4375 Reviewed by Eric Seidel.
4377 [GTK] Crashes cleaning clipboard contents, with page cache enabled
4378 https://bugs.webkit.org/show_bug.cgi?id=32900
4380 Null-check the focus controller to avoid crashing. Could not find
4381 a way to reproduce this consistently, thus no test.
4383 * WebCoreSupport/PasteboardHelperGtk.cpp:
4384 (WebKit::clearClipboardContentsCallback):
4386 2010-01-14 Gustavo Noronha Silva <gns@gnome.org>
4388 Reviewed by Oliver Hunter.
4390 [GTK] couple fixes for signal emissions, and property notifications
4391 https://bugs.webkit.org/show_bug.cgi?id=33428
4393 Do not emit signals and property notifications for error
4394 pages. The notifications are not really useful for anything, you
4395 can get them back by overriding the error pages, and it avoids a
4398 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4399 (WebKit::FrameLoaderClient::FrameLoaderClient):
4400 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
4401 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
4402 (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
4403 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
4404 (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
4405 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
4406 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
4407 * WebCoreSupport/FrameLoaderClientGtk.h:
4408 * tests/testloading.c:
4409 (load_error_status_changed_cb):
4410 (test_loading_error):
4412 2010-01-14 Martin Robinson <martin.james.robinson@gmail.com>
4414 Reviewed by Xan Lopez.
4416 [GTK] Enable DOM clipboard and drag-and-drop access
4417 https://bugs.webkit.org/show_bug.cgi?id=30623
4419 Use DataObjectGtk when setting and clearing pasteboard data on
4420 the GDK_SELECTION_PRIMARY clipboard.
4422 * WebCoreSupport/EditorClientGtk.cpp:
4423 (WebKit::EditorClient::respondToChangedSelection):
4424 (WebKit::EditorClient::EditorClient):
4425 * WebCoreSupport/EditorClientGtk.h:
4426 * WebCoreSupport/PasteboardHelperGtk.cpp:
4427 (WebKit::fillSelectionData):
4428 (WebKit::targetListForDataObject):
4429 (WebKit::getClipboardContentsCallback):
4430 (WebKit::clearClipboardContentsCallback):
4431 (WebKit::PasteboardHelperGtk::writeClipboardContents):
4432 * WebCoreSupport/PasteboardHelperGtk.h:
4434 2010-01-14 Alejandro G. Castro <alex@igalia.com>
4436 Reviewed by Xan Lopez.
4438 Review the tooltip implementation
4439 https://bugs.webkit.org/show_bug.cgi?id=32819
4441 Change the GTK tooltip implementation to avoid the workaround that
4442 we are currently using. Now we use a new private API to set the
4443 text and all the tooltip handling is done in the webview widget.
4445 * WebCoreSupport/ChromeClientGtk.cpp:
4446 * webkit/webkitprivate.h:
4447 * webkit/webkitwebview.cpp:
4448 (webkit_web_view_set_tooltip_text): Added, new private API.
4449 (webkit_web_view_query_tooltip): Added
4451 2010-01-09 Gustavo Noronha Silva <gns@gnome.org>
4453 Reviewed by Xan Lopez.
4455 [GTK] couple fixes for signal emissions, and property notifications
4456 https://bugs.webkit.org/show_bug.cgi?id=33428
4458 Fix commitedLoad being called where it should not, causing it to
4459 be called one time too many in some cases. We now match Qt's and
4460 Mac's behavior here.
4462 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4463 (WebKit::FrameLoaderClient::finishedLoading):
4464 * tests/testloading.c:
4465 (load_error_status_changed_cb):
4467 2010-01-08 Gustavo Noronha Silva <gns@gnome.org>
4469 Reviewed by Xan Lopez.
4471 [GTK] loading test should use SoupServer instead of actual sites
4472 https://bugs.webkit.org/show_bug.cgi?id=33353
4474 Make all the loading tests use SoupServer, instead of fetching
4475 stuff from the Internet.
4477 * tests/testloading.c:
4480 (test_loading_status):
4481 (test_loading_error):
4482 (test_loading_cancelled):
4483 (load_wentback_status_changed_cb):
4485 (test_loading_goback):
4488 2010-01-06 Joanmarie Diggs <joanmarie.diggs@gmail.com>
4490 Reviewed by Xan Lopez.
4492 https://bugs.webkit.org/show_bug.cgi?id=30883
4493 [Gtk] Implement AtkText for HTML elements which contain text
4496 (test_webkit_atk_get_text_at_offset):
4497 (test_webkit_atk_get_text_at_offset_forms):
4498 (test_webkit_atk_get_text_at_offset_newlines):
4500 2010-01-05 Gustavo Noronha Silva <gns@gnome.org>
4502 Updated docs for 1.1.18 release.
4504 * docs/webkitgtk-docs.sgml:
4505 * docs/webkitgtk-sections.txt:
4507 2010-01-05 Xan Lopez <xlopez@igalia.com>
4509 Update for 1.1.18 release.
4513 2010-01-04 Maciej Stachowiak <mjs@apple.com>
4515 Reviewed by Darin Fisher.
4517 Reorganize, document and rename OS() platform macros.
4518 https://bugs.webkit.org/show_bug.cgi?id=33198
4520 Adapt to name changes.
4522 * webkit/webkitwebsettings.cpp:
4523 (webkit_get_user_agent):
4525 2010-01-04 Maciej Stachowiak <mjs@apple.com>
4527 Reviewed by Adam Barth.
4529 Reorganize, document and rename CPU() platform macros.
4530 https://bugs.webkit.org/show_bug.cgi?id=33145
4532 * webkit/webkitwebsettings.cpp:
4533 (webkit_get_user_agent):
4535 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4537 Reviewed by Xan Lopez.
4539 Remove emission of signal that does not exist.
4541 * WebCoreSupport/InspectorClientGtk.cpp:
4542 (WebKit::InspectorClient::inspectorDestroyed):
4543 (WebKit::InspectorClient::webViewDestroyed):
4545 2009-12-20 Xan Lopez <xlopez@igalia.com>
4547 Reviewed by Gustavo Noronha.
4549 Unset the adjustments in our FrameView when detaching from
4550 parent. Fixes some crashers when transitioning to a new page from
4553 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4554 (WebKit::FrameLoaderClient::detachedFromParent2):
4556 2009-12-20 Xan Lopez <xlopez@igalia.com>
4558 Rubber-stamped by Gustavo Noronha.
4560 Disable the page cache by default since:
4562 - It was previously off by default.
4563 - There are still some issues when enabling it.
4565 * webkit/webkitwebsettings.cpp:
4566 (webkit_web_settings_class_init):
4568 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4570 Reviewed by Xan Lopez.
4572 Provides a new API to copy WebKitWebHistoryItem objects.
4574 * webkit/webkitwebhistoryitem.cpp:
4575 (webkit_web_history_item_copy):
4576 * webkit/webkitwebhistoryitem.h:
4578 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4580 Reviewed by Xan Lopez.
4582 Make sure we get the URI that is being loaded when updating
4583 WebKitWebFrame's knowledge of it. This was causing problems now
4584 that page cache is enabled.
4586 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4587 (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
4588 * tests/testloading.c:
4589 (load_goback_status_changed_cb):
4590 (load_wentback_status_changed_cb):
4591 (test_loading_goback):
4594 2009-12-20 Alejandro G. Castro <alex@igalia.com>
4596 Reviewed by Xan Lopez.
4598 [GTK] Cache control APIs
4599 https://bugs.webkit.org/show_bug.cgi?id=24001
4601 Original patch by Bobby Powers <bobby@laptop.org>
4603 Added new API to specify cache models for GTK port.
4605 * webkit/webkitprivate.cpp:
4606 (webkit_init): set a default cache model.
4607 * webkit/webkitwebview.cpp:
4608 * webkit/webkitwebview.h:
4609 (webkit_set_cache_model): Added function.
4610 (webkit_get_cache_model): Added function.
4612 2009-12-20 Xan Lopez <xlopez@igalia.com>
4614 Revert the previous patch, it introduces some failures in the
4617 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4618 (WebKit::FrameLoaderClient::committedLoad):
4619 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
4621 2009-12-20 Xan Lopez <xlopez@igalia.com>
4623 Reviewed by Gustavo Noronha.
4625 [GTK] crash when loading new page
4626 https://bugs.webkit.org/show_bug.cgi?id=32752
4628 Wait until the document is attached to adjust our alignments,
4629 since we need to make sure the FrameView in the document content
4630 render object matches the newly created FrameView for the new
4631 page, otherwise we'll try to relayout the wrong view.
4633 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4634 (WebKit::FrameLoaderClient::committedLoad):
4635 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
4637 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4639 Reviewed by Xan Lopez.
4641 Create a new WebKitDataSource object when attaching to a frame, if
4642 one does not exist. This may happen when we are fetching data from
4645 * WebCoreSupport/DocumentLoaderGtk.cpp:
4646 (WebKit::DocumentLoader::attachToFrame):
4647 (WebKit::DocumentLoader::unrefDataSource):
4649 2009-12-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4651 Rubber-stamped by Xan Lopez.
4653 Make sure the text encoding machinery is initialized from the main
4654 frame, before opening the icon database.
4656 * webkit/webkitprivate.cpp:
4659 2009-12-19 Alejandro G. Castro <alex@igalia.com>
4661 Reviewed by Xan Lopez.
4663 Fixed the problem when pasting in the same window with the
4664 middle-button, now we store a reference to the range instead of
4665 requesting it every time, and we do not release it until the
4666 clipboard is requested.
4667 https://bugs.webkit.org/show_bug.cgi?id=28153
4669 * WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:
4670 * WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
4672 2009-12-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4674 Reviewed by Xan Lopez.
4676 Protect download objects when reporting errors, to make sure the
4677 download stays alive between the status change notification, and
4678 the error signal emission.
4680 * webkit/webkitdownload.cpp:
4681 (webkit_download_error):
4683 2009-12-18 Xan Lopez <xlopez@igalia.com>
4685 Reviewed by Gustavo Noronha.
4687 Fix gtk-doc of webkit_web_resource_new.
4689 * webkit/webkitwebresource.cpp:
4691 2009-12-18 Adam Roben <aroben@apple.com>
4695 * webkit/webkitprivate.cpp: Added #include.
4697 2009-12-18 Kalle Vahlman <kalle.vahlman@movial.com> and Alejandro G. Castro <alex@igalia.com>
4699 Reviewed by Gustavo Noronha Silva.
4701 [GTK] Add enable-page-cache property to WebSettings for disabling the Page Cache
4703 * webkit/webkitwebsettings.cpp:
4704 (_WebKitWebSettingsPrivate::):
4705 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
4706 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
4707 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
4708 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
4709 * webkit/webkitwebview.cpp:
4711 2009-12-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4713 Reviewed by Xan Lopez.
4715 More make distcheck fixes. Use a more robust solution to making
4716 sure we are in the correct directory for running these tests.
4718 * tests/testmimehandling.c:
4720 * tests/testwebview.c:
4723 2009-12-17 Christian Dywan <christian@twotoasts.de>
4725 Reviewed by Gustavo Noronha Silva.
4727 [GTK] Don't assume downloads are always synchronous
4728 http://bugs.webkit.org/show_bug.cgi?id=32359
4730 * tests/testdownload.c:
4731 (download_requested_cb):
4733 (test_webkit_download_perform):
4734 (test_webkit_download_synch):
4735 (test_webkit_download_asynch):
4736 (main): Test downloads synchronously and asynchronously.
4737 * webkit/webkitwebview.cpp:
4738 (webkit_web_view_class_init):
4739 (webkit_web_view_request_download): Only try to start a requested
4740 download if the destination URI is set and clarify the documentation.
4742 2009-12-17 Christian Dywan <christian@twotoasts.de>
4744 Reviewed by Xan Lopez.
4746 Deprecate the title-changed signal of WebKitWebFrame.
4748 * webkit/webkitwebframe.cpp:
4749 (webkit_web_frame_class_init):
4751 2009-12-17 Martin Robinson <martin.james.robinson@gmail.com>
4753 Reviewed by Gustavo Noronha Silva.
4755 [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs
4756 https://bugs.webkit.org/show_bug.cgi?id=21599
4758 Convert a use of GOwnPtr for a reference counted type to GRefPtr.
4760 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4761 (WebKit::FrameLoaderClient::createPlugin):
4763 2009-12-17 Evan Martin <evan@chromium.org>
4765 Reviewed by Xan Lopez.
4767 Expose the page workarounds ("quirks") setting to the GTK+ WebKit API.
4769 * webkit/webkitwebsettings.cpp:
4770 (webkit_web_settings_class_init):
4771 (webkit_web_settings_set_property):
4772 (webkit_web_settings_get_property):
4773 (webkit_web_settings_copy):
4774 * webkit/webkitwebview.cpp:
4775 (webkit_web_view_update_settings):
4777 2009-12-16 Dan Winship <danw@gnome.org>
4779 Reviewed by Gustavo Noronha Silva.
4781 Content-Encoding support
4783 https://bugs.webkit.org/show_bug.cgi?id=522772
4785 * webkit/webkitprivate.cpp:
4786 (webkit_init): add a SoupContentDecoder feature to the session
4788 2009-12-16 Christian Dywan <christian@twotoasts.de>
4790 Reviewed by Gustavo Noronha Silva.
4792 Deprecate the old loading signals load-started, load-committed,
4793 load-finished, load-progress-changed and change unit tests to use
4794 load-status instead.
4796 * tests/testmimehandling.c:
4797 (idle_quit_loop_cb):
4798 (test_mime_type): use notify::load-status
4799 * tests/testwebdatasource.c:
4800 (notify_load_status_unreachable_cb):
4801 (notify_load_status_cb):
4802 (test_webkit_web_data_source):
4803 (test_webkit_web_data_source_unreachable_uri): Remove uses of
4804 g_main_loop_is_running. It's an error if the loop is wrongly terminated.
4805 * tests/testwebresource.c:
4806 (notify_load_status_cb):
4807 (test_web_resource_loading):
4808 (notify_load_status_sub_cb):
4809 (test_web_resource_sub_resource_loading): use notify::load-status
4810 * tests/testwebview.c:
4811 (idle_quit_loop_cb):
4812 (test_webkit_web_view_icon_uri):
4813 * tests/testwindow.c:
4814 (notify_load_status_cb):
4815 (test_webkit_window_scrollbar_policy): use notify::load-status
4816 * webkit/webkitwebframe.cpp:
4817 (webkit_web_frame_class_init):
4818 * webkit/webkitwebview.cpp:
4819 (webkit_web_view_class_init): Deprecate old load signals.
4821 2009-12-16 Christian Dywan <christian@twotoasts.de>
4823 Reviewed by Gustavo Noronha Silva.
4825 Take into account favicon.ico in the webresource test.
4827 * tests/testwebresource.c:
4828 (test_web_resource_sub_resource_loading):
4830 2009-12-16 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4832 Rubber-stamped by Xan Lopez.
4834 Add tab_key_cycles_through_elements to copies of
4837 * webkit/webkitwebsettings.cpp:
4838 (webkit_web_settings_copy):
4840 2009-12-16 Martin Robinson <martin.james.robinson@gmail.com>
4842 Reviewed by Gustavo Noronha Silva.
4844 [GTK] webkit_web_navigation_action_get_button() documentation
4845 https://bugs.webkit.org/show_bug.cgi?id=25555
4847 Small documentation improvement for webkit_web_navigation_action_get_button.
4849 * webkit/webkitwebnavigationaction.cpp:
4851 2009-12-13 Sam Weinig <sam@webkit.org>
4853 Reviewed by Dan Bernstein.
4855 Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
4856 Add client based Geolocation provider
4858 Add first cut of a client based Geolocation provider. This is guarded by
4859 ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
4860 GeolocationControllerClient interface that no-one currently implements,
4861 but will in a subsequent patch.
4863 * webkit/webkitwebview.cpp:
4864 (webkit_web_view_init):
4866 2009-12-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4868 Reviewed by Xan Lopez.
4870 New setting to allow applications to completely suppress the
4871 default context menu that is generated by WebKit. This allows them
4872 to still pass the event to the default handler without needing to
4873 use ugly hacks such as handling populate-popup, and removing all
4874 the items from the default context menu.
4876 * webkit/webkitwebsettings.cpp:
4877 (webkit_web_settings_class_init):
4878 (webkit_web_settings_set_property):
4879 (webkit_web_settings_get_property):
4880 (webkit_web_settings_copy):
4881 * webkit/webkitwebview.cpp:
4882 (webkit_web_view_forward_context_menu_event):
4884 2009-12-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4886 Reviewed by Xan Lopez.
4888 Also give the right click event to the frame's event handler, if
4889 there WebCore decides to not generate the default context
4890 menu. This fixes some pages that handle right-button clicks for
4891 things other than context menu creation.
4893 * webkit/webkitwebview.cpp:
4894 (webkit_web_view_forward_context_menu_event):
4896 2009-12-13 Christian Dywan <christian@twotoasts.de>
4898 Reviewed by Holger Freyther.
4900 http://bugs.webkit.org/show_bug.cgi?id=31014
4901 [Gtk] Build fails with gtk+-2.10 (no tested with older releases)
4903 Guard GTK+ 2.12 specific tooltip code with #ifdef.
4905 * WebCoreSupport/ChromeClientGtk.cpp:
4906 (WebKit::ChromeClient::mouseDidMoveOverElement):
4908 2009-12-11 Christian Dywan <christian@twotoasts.de>
4910 Reviewed by Eric Seidel.
4912 [GTK] Build with --disable-svg is broken
4913 http://bugs.webkit.org/show_bug.cgi?id=32361
4915 * webkit/webkitwebframe.cpp:
4916 (webkit_web_frame_pause_svg_animation): Fix ENABLE(SVG) guards.
4918 2009-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4920 Reviewed by Xan Lopez.
4922 Add a missing null-check, that is causing some crash reports.
4924 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4925 (WebKit::FrameLoaderClient::committedLoad):
4927 2009-12-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4929 Reviewed by Xan Lopez.
4931 [GTK] Should provide an API to control the IconDatabase
4932 https://bugs.webkit.org/show_bug.cgi?id=32334
4934 First step towards a full IconDatabase API. This provides
4935 notification for pages with favicons, and lets clients handle
4938 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4939 (WebKit::FrameLoaderClient::registerForIconNotification):
4940 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
4941 * tests/resources/blank.ico: Added.
4942 * tests/testwebview.c: Added.
4944 (idle_quit_loop_cb):
4945 (icon_uri_changed_cb):
4947 (test_webkit_web_view_icon_uri):
4949 * webkit/webkitprivate.cpp:
4950 (closeIconDatabaseOnExit):
4952 * webkit/webkitprivate.h:
4953 * webkit/webkitwebview.cpp:
4954 (webkit_web_view_get_property):
4955 (webkit_web_view_finalize):
4956 (webkit_web_view_class_init):
4957 (webkit_web_view_get_icon_uri):
4958 * webkit/webkitwebview.h:
4960 2009-12-08 Christian Dywan <christian@twotoasts.de>
4962 Reviewed by Gustavo Noronha Silva.
4964 Point out the meaning of "Content-Disposition" when implementing the
4965 mime-type-policy-decision-requested signal.
4967 * webkit/webkitwebview.cpp:
4968 (webkit_web_view_class_init):
4970 2009-12-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
4972 Reviewed by Xan Lopez.
4974 [GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
4975 https://bugs.webkit.org/show_bug.cgi?id=32247
4977 Provide a way for applications to respect Content-Disposition, by
4978 fetching the WebKitNetworkResponse from the frame during
4979 mime-type-policy-decision-requested.
4981 * WebCoreSupport/FrameLoaderClientGtk.cpp:
4982 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Download
4983 content when Content-Disposition is attachment.
4984 * tests/testmimehandling.c:
4986 (mime_type_policy_decision_requested_cb):
4987 * tests/testwebframe.c:
4988 (test_webkit_web_frame_response):
4990 * webkit/webkitprivate.cpp:
4992 * webkit/webkitwebframe.cpp:
4993 (webkit_web_frame_get_network_response):
4994 * webkit/webkitwebframe.h:
4996 2009-12-07 Gyuyoung Kim <gyuyoung@gmail.com>
4998 Reviewed by Eric Seidel.
5000 https://bugs.webkit.org/show_bug.cgi?id=32024
5001 [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER
5003 Fix build errors when javascript-debugger is disabled on GTK
5005 * webkit/webkitwebinspector.cpp:
5006 (webkit_web_inspector_set_property):
5007 (webkit_web_inspector_get_property):
5009 2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>
5011 Reviewed by Xan Lopez.
5013 https://bugs.webkit.org/show_bug.cgi?id=25415
5014 [GTK][ATK] Please implement support for get_text_at_offset
5016 Eliminate the segfaults which occur when accessing the text interface now
5017 implemented by text controls.
5020 (test_webkit_atk_get_text_at_offset_textarea):
5021 (test_webkit_atk_get_text_at_offset_text_input):
5024 2009-12-06 Gustavo Noronha Silva <gns@gnome.org>
5026 Reviewed by Xan Lopez.
5028 New test to make sure we do not regress this feature anymore. All
5029 test files were created by me.
5031 [GTK] REGRESSION: webkit thinks it can render PDFs
5032 https://bugs.webkit.org/show_bug.cgi?id=32183
5034 * tests/resources/test.html: Added.
5035 * tests/resources/test.ogg: Added.
5036 * tests/resources/test.pdf: Added.
5037 * tests/resources/test.txt: Added.
5038 * tests/testmimehandling.c: Added.
5040 (idle_quit_loop_cb):
5041 (mime_type_policy_decision_requested_cb):
5049 2009-12-05 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5051 Reviewed by Xan Lopez.
5053 Use a better URI for the unreachable test. localhost:80 is very
5056 * tests/testwebdatasource.c:
5057 (load_finished_unreachable_cb):
5058 (test_webkit_web_data_source_unreachable_uri):
5060 2009-12-03 Brady Eidson <beidson@apple.com>
5062 Reviewed by Sam Weinig.
5064 <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
5066 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5067 (WebKit::FrameLoaderClient::dispatchDidPushStateWithinPage):
5068 (WebKit::FrameLoaderClient::dispatchDidReplaceStateWithinPage):
5069 (WebKit::FrameLoaderClient::dispatchDidPopStateWithinPage):
5070 * WebCoreSupport/FrameLoaderClientGtk.h:
5072 2009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
5074 Reviewed by Timothy Hatcher.
5076 Web Inspector: Simplify the settings support in inspector controller.
5078 https://bugs.webkit.org/show_bug.cgi?id=32076
5080 * WebCoreSupport/InspectorClientGtk.cpp:
5081 (WebKit::InspectorClient::populateSetting):
5082 (WebKit::InspectorClient::storeSetting):
5083 * WebCoreSupport/InspectorClientGtk.h:
5085 2009-12-03 Ben Murdoch <benm@google.com>
5087 Reviewed by Brady Eidson.
5089 [Android] The FrameLoaderClient is unaware of BackForwardList changes.
5090 https://bugs.webkit.org/show_bug.cgi?id=31914
5092 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5093 (WebKit::FrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
5094 (WebKit::FrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
5095 (WebKit::FrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
5096 * WebCoreSupport/FrameLoaderClientGtk.h:
5098 2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
5100 Reviewed by Simon Fraser.
5102 Add SVG animation test framework with 'snapshot' functionality
5103 https://bugs.webkit.org/show_bug.cgi?id=31897
5105 Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
5106 forwarding the call to SVGDocumentExtensions, if SVG is enabled.
5108 Implemented just like the existing pauseAnimation* methods for CSS animations.
5110 * webkit/webkitprivate.h:
5111 * webkit/webkitwebframe.cpp:
5112 (webkit_web_frame_pause_svg_animation):
5114 2009-11-30 Xan Lopez <xlopez@igalia.com>
5116 Reviewed by Gustavo Noronha.
5118 Prepare for 1.1.17 release.
5121 * docs/webkitgtk-docs.sgml:
5122 * docs/webkitgtk-sections.txt:
5123 * webkit/webkitwebsettings.cpp:
5124 (webkit_web_settings_class_init):
5126 2009-11-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
5128 Reviewed by Oliver Hunt.
5130 Move GOwnPtr* from wtf to wtf/gtk
5131 https://bugs.webkit.org/show_bug.cgi?id=31793
5133 * webkit/webkitwebview.cpp: Change the path for GOwnPtr.h.
5135 2009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com>
5137 Reviewed by Xan Lopez.
5139 https://bugs.webkit.org/show_bug.cgi?id=25415
5140 [GTK][ATK] Please implement support for get_text_at_offset
5142 When building up the pango layout from text boxes, only append a
5143 newline char after verifying there are no more boxes on this line.
5146 (test_webkit_atk_get_text_at_offset_newlines):
5149 2009-11-19 Pavel Feldman <pfeldman@chromium.org>
5151 Reviewed by Gustavo Noronha Silva.
5153 Web Inspector: Implement "show inspector" in WebKit GTK
5154 API and enable console tests.
5156 https://bugs.webkit.org/show_bug.cgi?id=31669
5158 * webkit/webkitwebinspector.cpp:
5159 (webkit_web_inspector_show):
5160 * webkit/webkitwebinspector.h:
5162 2009-11-18 Martin Robinson <martin.james.robinson@gmail.com>
5164 Reviewed by Gustavo Noronha.
5166 [GTK] Tab key does not cycle through elements by default
5167 https://bugs.webkit.org/show_bug.cgi?id=31505
5169 Properly localize documentation strings for the
5170 tab-key-cycles-through-elements property.
5172 * webkit/webkitwebsettings.cpp:
5173 (webkit_web_settings_class_init):
5175 2009-11-17 Martin Robinson <martin.james.robinson@gmail.com>
5177 Reviewed by Gustavo Noronha.
5179 [GTK] Tab key does not cycle through elements by default
5180 https://bugs.webkit.org/show_bug.cgi?id=31505
5182 Ensure that WebKitWebSettings tab-key-cycles-through-elements
5183 property is true by default with the G_PARAM_CONSTRUCT_FLAG.
5185 * webkit/webkitwebsettings.cpp:
5186 (webkit_web_settings_class_init):
5188 2009-11-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5190 Reviewed by Xan Lopez.
5192 [GTK] Failing test media/video-document-types.html
5193 https://bugs.webkit.org/show_bug.cgi?id=31352
5195 Match what Mac has been doing since r36001: cancel the main load,
5196 and handle failures caused by 'will be handled by plugin' errors.
5198 Covered by test media/video-document-types.html
5200 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5201 (WebKit::FrameLoaderClient::committedLoad):
5202 (WebKit::FrameLoaderClient::shouldFallBack):
5204 2009-11-17 Pavel Feldman <pfeldman@chromium.org>
5206 Reviewed by Timothy Hatcher.
5208 Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
5209 - Updated DRT to show/close inspector for all tests under /inspector
5210 - Introduced LayoutTestController::setTimelineProfilingEnabled and
5211 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
5212 - Removed reload on each inspector test
5213 - Renamed fast/inspector to fast/inspector-support in order not to trigger
5214 inspector for those.
5215 - Reimplemented timeline tests in order to get rid of reload there.
5216 - Moved tests that don't require harness into the fast group.
5218 https://bugs.webkit.org/show_bug.cgi?id=31472
5220 * webkit/webkitwebinspector.cpp:
5221 (webkit_web_inspector_class_init):
5222 (webkit_web_inspector_set_property):
5223 (webkit_web_inspector_get_property):
5225 2009-11-13 Adam Roben <aroben@apple.com>
5227 Update for changes to FrameLoaderClient
5229 Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
5230 window objects in isolated worlds are cleared
5232 Reviewed by Dave Hyatt.
5234 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5235 (WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
5236 * WebCoreSupport/FrameLoaderClientGtk.h:
5237 Replaced windowObjectCleared with this function. Does nothing if the
5238 passed-in world is not the mainThreadNormalWorld().
5240 2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
5242 Reviewed by Darin Adler.
5244 externalRepresentation should take Frame as the argument
5245 https://bugs.webkit.org/show_bug.cgi?id=31393
5247 No new tests as this is just a refactoring.
5249 * webkit/webkitwebframe.cpp:
5250 (webkit_web_frame_dump_render_tree):
5252 2009-11-11 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5254 Reviewed by Holger Freyther.
5256 Should not print javascript console messages to stdout
5257 https://bugs.webkit.org/show_bug.cgi?id=31346
5259 * webkit/webkitwebview.cpp:
5260 (webkit_web_view_real_console_message): Print console messages to
5261 stderr instead, using the recommended method (a g_log variant).
5263 2009-11-11 Philippe Normand <pnormand@igalia.com>
5265 Reviewed by Xan Lopez.
5267 https://bugs.webkit.org/show_bug.cgi?id=30221
5268 [GTK] fails to load media embedded in iframe element
5270 The FrameLoader can show Media if the audio/video support is
5271 enabled at compile time.
5273 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5274 (WebKit::FrameLoaderClient::canShowMIMEType):
5276 2009-11-10 Martin Robinson <martin.james.robinson@gmail.com>
5278 Reviewed by Jan Alonzo.
5280 [GTK] Remove WebSocket configuration from WebKitWebSettings
5281 https://bugs.webkit.org/show_bug.cgi?id=31244
5283 Remove non-functional enable-web-sockets property from WebKitWebSettings.
5285 * webkit/webkitwebsettings.cpp:
5286 (webkit_web_settings_class_init):
5287 (webkit_web_settings_set_property):
5288 (webkit_web_settings_get_property):
5289 (webkit_web_settings_copy):
5291 2009-11-09 Martin Robinson <martin.james.robinson@gmail.com>
5293 Reviewed by Jan Alonzo.
5295 [GTK] Expose Page::tabKeyCyclesThroughElements in the API
5296 https://bugs.webkit.org/show_bug.cgi?id=30482
5298 Expose Page::tabKeyCyclesThroughElements as a property of
5301 * webkit/webkitwebsettings.cpp:
5302 (webkit_web_settings_class_init):
5303 (webkit_web_settings_set_property):
5304 (webkit_web_settings_get_property):
5305 * webkit/webkitwebview.cpp:
5306 (webkit_web_view_update_settings):
5307 (webkit_web_view_settings_notify):
5309 2009-11-04 Martin Robinson <martin.james.robinson@gmail.com>
5311 Reviewed by Jan Alonzo.
5313 [GTK] Enable DOM clipboard and drag-and-drop access
5314 https://bugs.webkit.org/show_bug.cgi?id=30623
5316 Move handling of target list to PasteboardHelperGtk.
5318 * WebCoreSupport/PasteboardHelperGtk.cpp:
5319 (WebKit::PasteboardHelperGtk::PasteboardHelperGtk):
5320 (WebKit::PasteboardHelperGtk::~PasteboardHelperGtk):
5321 (WebKit::PasteboardHelperGtk::fullTargetList):
5322 * WebCoreSupport/PasteboardHelperGtk.h:
5323 * webkit/webkitprivate.cpp:
5324 (WebKit::pasteboardHelperInstance):
5326 * webkit/webkitprivate.h:
5327 * webkit/webkitwebview.cpp:
5328 (webkit_web_view_dispose):
5329 (webkit_web_view_init):
5330 (webkit_web_view_get_copy_target_list):
5331 (webkit_web_view_get_paste_target_list):
5333 2009-10-30 Evan Stade <estade@chromium.org>
5335 Reviewed by David Levin.
5337 Notify the chrome when the focused node has changed.
5338 https://bugs.webkit.org/show_bug.cgi?id=30832
5340 Added stub implementation for new ChromeClient function.
5342 * WebCoreSupport/ChromeClientGtk.cpp:
5343 (WebKit::ChromeClient::focusedNodeChanged):
5344 * WebCoreSupport/ChromeClientGtk.h:
5346 2009-10-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5348 Unreviewed. Trivial fix - move public API declaration into the
5349 public subsection of the doc.
5351 * docs/webkitgtk-sections.txt:
5353 2009-10-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5355 Reviewed by Jan Alonzo.
5357 [GTK] API to start inspector for a WebView
5358 https://bugs.webkit.org/show_bug.cgi?id=22551
5360 Provide a simple, coordinates-based API to start the inspector.
5362 * WebCoreSupport/InspectorClientGtk.cpp:
5363 (WebKit::InspectorClient::createPage): Use files from the source
5364 tree when running from the top of the source directory.
5365 (WebKit::InspectorClient::localizedStringsURL): Ditto.
5366 * webkit/webkitprivate.h:
5367 * webkit/webkitwebinspector.cpp:
5368 (webkit_web_inspector_inspect_coordinates):
5369 (webkit_web_inspector_close):
5370 (webkit_web_inspector_execute_script):
5371 * webkit/webkitwebinspector.h:
5373 2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
5375 Reviewed by Darin Adler.
5377 Provide a way to get counter values with layoutTestContoller
5378 https://bugs.webkit.org/show_bug.cgi?id=30555
5380 * webkit/webkitprivate.h:
5381 * webkit/webkitwebframe.cpp:
5382 (webkit_web_frame_counter_value_for_element_by_id):
5384 2009-10-28 Joe Mason <jmason@rim.com>
5386 Reviewed by Adam Treat.
5388 Call the shared FrameLoader::defaultObjectContentType instead of
5389 copying code into FrameLoaderClient::objectContentType. This causes no
5392 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5393 (WebKit::FrameLoaderClient::objectContentType):
5395 2009-10-28 Xan Lopez <xlopez@igalia.com>
5397 Reviewed by Jan Alonzo.
5399 [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
5400 https://bugs.webkit.org/show_bug.cgi?id=25897
5402 Update test to also check that entries implement the AtkText
5406 (run_get_text_tests):
5407 (test_webkit_atk_get_text_at_offset_forms):
5408 (test_webkit_atk_get_text_at_offset):
5411 2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5413 Unreviewed. Update documentation control files for 1.1.16.
5415 * docs/webkitgtk-docs.sgml:
5416 * docs/webkitgtk-sections.txt:
5418 2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5420 Reviewed by Xan Lopez.
5422 https://bugs.webkit.org/show_bug.cgi?id=30759
5423 [GTK] Should use WebKitNetworkResponse, and expose it
5425 WebKitDownload now uses our WebKitNetworkResponse instead of using
5426 ResourceResponse directly. By exposing the response, like we do
5427 with the request, we give our users the ability to look at the
5428 response headers, status code, and so on, through the SoupMessage
5431 * webkit/webkitdownload.cpp:
5432 (webkit_download_dispose):
5433 (webkit_download_finalize):
5434 (webkit_download_get_property):
5435 (webkit_download_set_property):
5436 (webkit_download_class_init):
5437 (webkit_download_get_network_response):
5438 (webkit_download_set_response):
5439 (webkit_download_get_total_size):
5440 (webkit_download_get_progress):
5441 (webkit_download_received_data):
5442 * webkit/webkitdownload.h:
5444 2009-10-26 Xan Lopez <xlopez@igalia.com>
5446 Reviewed by Gustavo Noronha.
5448 Update for 1.1.16 release.
5452 2009-10-22 Gavin Barraclough <barraclough@apple.com>
5454 Reviewed by NOBODY (build fix).
5455 Build fix following bug #30696.
5457 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5458 (WebKit::FrameLoaderClient::windowObjectCleared):
5459 * webkit/webkitwebframe.cpp:
5460 (webkit_web_frame_get_global_context):
5462 2009-10-22 Alejandro G. Castro <alex@igalia.com>
5464 Reviewed by Xan Lopez.
5466 m_webView should be private attribute of the EditorClientGtk.
5467 https://bugs.webkit.org/show_bug.cgi?id=30664
5469 * WebKit/gtk/WebCoreSupport/EditorClientGtk.h:
5471 2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
5473 Reviewed by David Levin.
5475 Removed WebSocket runtime settings.
5476 https://bugs.webkit.org/show_bug.cgi?id=29896
5478 WebSocket runtime configuration is supported by chromium/v8 only.
5480 * webkit/webkitwebview.cpp:
5481 (webkit_web_view_update_settings):
5482 (webkit_web_view_settings_notify):
5484 2009-10-19 Jan Michael Alonzo <jmalonzo@webkit.org>
5486 Reviewed by Alexey Proskuryakov.
5488 [Gtk] ApplicationCacheStorage error while compiling WebKit/gtk/webkit/webkitapplicationcache.cpp
5489 https://bugs.webkit.org/show_bug.cgi?id=30358
5491 Guard calls to cacheStorage() with ENABLE(OFFLINE_WEB_APPLICATIONS).
5493 * webkit/webkitapplicationcache.cpp:
5495 2009-10-19 Zan Dobersek <zandobersek@gmail.com>
5497 Reviewed by Gustavo Noronha.
5499 Add a settings to allow DOM pastes to be performed.
5501 * webkit/webkitwebsettings.cpp:
5502 (webkit_web_settings_class_init):
5503 (webkit_web_settings_set_property):
5504 (webkit_web_settings_get_property):
5505 (webkit_web_settings_copy):
5506 * webkit/webkitwebview.cpp:
5507 (webkit_web_view_update_settings):
5508 (webkit_web_view_settings_notify):
5510 2009-10-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5512 Unreviewed. Make WebKitHitTestResult actually appear in the
5513 documentation index.
5515 * docs/webkitgtk-docs.sgml:
5517 2009-10-15 Xan Lopez <xlopez@igalia.com>
5519 Reviewed by Gustavo Noronha.
5521 Protect WebSocket calls in case the feature is not compiled in.
5523 * webkit/webkitwebview.cpp:
5524 (webkit_web_view_update_settings):
5525 (webkit_web_view_settings_notify):
5527 2009-10-15 Zan Dobersek <zandobersek@gmail.com>
5529 Reviewed by Gustavo Noronha.
5531 Add a settings to enable support for experimental Web Sockets.
5532 Currently this comes in handy in layout tests.
5534 * webkit/webkitwebsettings.cpp:
5535 (webkit_web_settings_class_init):
5536 (webkit_web_settings_set_property):
5537 (webkit_web_settings_get_property):
5538 (webkit_web_settings_copy):
5539 * webkit/webkitwebview.cpp:
5540 (webkit_web_view_update_settings):
5541 (webkit_web_view_settings_notify):
5543 2009-10-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5545 Reviewed by Xan Lopez.
5547 page transition may crash webkit
5548 https://bugs.webkit.org/show_bug.cgi?id=29890
5550 There are actually cases in which a resource may be asked using
5551 webkit_web_view_get_resource after a new load has already been
5552 started, so protect ourselves from crashes in this case.
5554 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5555 (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
5556 * webkit/webkitwebview.cpp:
5557 (webkit_web_view_get_resource):
5559 2009-10-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5561 Rubber-stamped by Xan Lopez.
5563 Remove unnecessary self-include.
5565 * webkit/webkitsecurityorigin.h:
5567 2009-10-12 Christian Dywan <christian@twotoasts.de>
5569 Reviewed by Gustavo Noronha.
5571 [GTK] Crash when right-clicking misspelled word
5572 https://bugs.webkit.org/show_bug.cgi?id=29772
5574 Make sure the dictionary exist before adding it to the list of
5577 * WebCoreSupport/EditorClientGtk.cpp:
5578 (WebKit::EditorClient::checkSpellingOfString):
5579 * webkit/webkitwebsettings.cpp:
5580 (webkit_web_settings_set_property):
5582 2009-10-08 Adam Barth <abarth@webkit.org>
5584 Reviewed by Eric Seidel.
5586 Move executeScript from FrameLoader to ScriptController
5587 https://bugs.webkit.org/show_bug.cgi?id=30200
5591 * webkit/webkitwebview.cpp:
5592 (webkit_web_view_execute_script):
5594 2009-10-07 Xan Lopez <xlopez@igalia.com>
5598 * webkit/webkitwebpolicydecision.cpp:
5599 (webkit_web_policy_decision_use):
5600 (webkit_web_policy_decision_ignore):
5601 (webkit_web_policy_decision_download):
5603 2009-10-07 Adam Barth <abarth@webkit.org>
5605 Reviewed by Darin Adler.
5607 Factor PolicyChecker out of FrameLoader
5608 https://bugs.webkit.org/show_bug.cgi?id=30155
5610 Move the policy callback to the policy object.
5612 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5613 (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
5614 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
5615 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
5616 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
5618 2009-10-07 Martin Robinson <martin.james.robinson@gmail.com>
5620 [GTK] Segfault while testing fast/events/keydown-keypress-preventDefault.html
5621 https://bugs.webkit.org/show_bug.cgi?id=30121
5623 Clear previous preedit or pending composition before storing new ones.
5624 This can happen when a WebView receives a native keydown event without
5625 a matching keyup event or when preventDefault() is called on DOM keydown
5628 * WebCoreSupport/EditorClientGtk.cpp:
5629 (WebKit::setPendingComposition):
5630 (WebKit::setPendingPreedit):
5631 (WebKit::clearPendingIMData):
5632 (WebKit::imContextCommitted):
5633 (WebKit::imContextPreeditChanged):
5635 2009-10-06 Xan Lopez <xlopez@igalia.com>
5637 Reviewed by Eric Seidel.
5639 https://bugs.webkit.org/show_bug.cgi?id=25526
5640 [Gtk] Additional support is needed for caret browsing
5642 Remove special cases for caret browsing, they are now handled in
5643 cross-platform code.
5645 * WebCoreSupport/EditorClientGtk.cpp:
5646 (WebKit::EditorClient::handleKeyboardEvent):
5648 2009-10-06 Pavel Feldman <pfeldman@chromium.org>
5650 Reviewed by Timothy Hatcher.
5652 Web Inspector: close inspector client view on
5653 InspectorController::close API call.
5655 In order to run batch web inspector layout tests (and not affect
5656 subsequent tests) we should close inspector client's view upon
5657 InspectorController::close API call.
5659 https://bugs.webkit.org/show_bug.cgi?id=30009
5661 * WebCoreSupport/InspectorClientGtk.cpp:
5662 (WebKit::InspectorClient::createPage):
5664 2009-10-06 Alejandro G. Castro <alex@igalia.com>
5666 Reviewed by Xan Lopez.
5668 ASSERT executing the webhistory unittest in a debug build
5669 https://bugs.webkit.org/show_bug.cgi?id=28947
5671 We have to call g_object_new first to initialize webkit threading
5672 before creating the KURL.
5674 * WebKit/gtk/webkit/webkitwebhistoryitem.cpp:
5676 2009-10-06 José Millán Soto <fid@gpul.org>
5678 Reviewed by Xan Lopez.
5680 Header files of WebKitGTK do not comply with WebKit coding style (Patch attached)
5681 https://bugs.webkit.org/show_bug.cgi?id=30076
5683 Solves various issues in header files.
5685 * WebCoreSupport/DocumentLoaderGtk.h: Added "headed guards"
5686 * webkit/webkitdefines.h:
5687 * webkit/webkitdownload.h:
5688 * webkit/webkiterror.h:
5689 * webkit/webkithittestresult.h:
5690 * webkit/webkitnetworkrequest.h:
5691 * webkit/webkitnetworkresponse.h:
5692 * webkit/webkitprivate.h:
5693 * webkit/webkitsecurityorigin.h:
5694 * webkit/webkitsoupauthdialog.h:
5695 * webkit/webkitversion.h.in:
5696 * webkit/webkitwebbackforwardlist.h:
5697 * webkit/webkitwebdatabase.h:
5698 * webkit/webkitwebdatasource.h:
5699 * webkit/webkitwebframe.h:
5700 * webkit/webkitwebhistoryitem.h:
5701 * webkit/webkitwebinspector.h:
5702 * webkit/webkitwebnavigationaction.h:
5703 * webkit/webkitwebpolicydecision.h:
5704 * webkit/webkitwebresource.h:
5705 * webkit/webkitwebsettings.h:
5706 * webkit/webkitwebview.h:
5707 * webkit/webkitwebwindowfeatures.h:
5709 2009-10-03 Adam Barth <abarth@webkit.org>
5713 * webkit/webkitwebview.cpp:
5714 (webkit_web_view_go_back_or_forward):
5715 (webkit_web_view_can_go_back_or_forward):
5717 2009-10-03 Adam Barth <abarth@webkit.org>
5719 Unreviewed build fix.
5721 * webkit/webkitwebview.cpp:
5722 (webkit_web_view_go_back_or_forward):
5724 2009-10-03 Adam Barth <abarth@webkit.org>
5726 Reviewed by Sam Weinig.
5728 Factor PageController out of FrameLoader and Page
5729 https://bugs.webkit.org/show_bug.cgi?id=30037
5731 * webkit/webkitwebview.cpp:
5732 (webkit_web_view_can_go_back_or_forward):
5734 2009-10-01 Xan Lopez <xlopez@igalia.com>
5736 Reviewed by Gustavo Noronha.
5738 Set the type for the fake event, otherwise the test ASSERTs in
5741 * tests/testhittestresult.c:
5744 2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
5746 Reviewed by Xan Lopez.
5748 [GTK] GtkIMContext filtering interferes with DOM key events
5749 https://bugs.webkit.org/show_bug.cgi?id=28733
5751 Ensure that keyboard events filtered by the GtkIMContext still create
5752 the proper DOM events.
5754 * WebCoreSupport/EditorClientGtk.cpp:
5755 (WebKit::clearPendingIMData):
5756 (WebKit::imContextCommitted):
5757 (WebKit::imContextPreeditChanged):
5758 (WebKit::EditorClient::shouldBeginEditing):
5759 (WebKit::EditorClient::shouldEndEditing):
5760 (WebKit::interpretEditorCommandKeyEvent):
5761 (WebKit::handleCaretBrowsingKeyboardEvent):
5762 (WebKit::EditorClient::handleKeyboardEvent):
5763 (WebKit::EditorClient::handleInputMethodKeydown):
5764 * tests/testkeyevents.c: Added.
5766 (test_info_destroy):
5767 (key_event_fixture_setup):
5768 (key_event_fixture_teardown):
5769 (key_press_event_cb):
5770 (key_release_event_cb):
5776 2009-09-29 Xan Lopez <xlopez@igalia.com>
5778 Reviewed by Gustavo Noronha.
5780 Do not set a non-default parent window for child widgets. We are
5781 just doing the same than the default path does, and on top of that
5782 if the widget's window changes (for example, during DnD widgets
5783 are usually unrealized/realized) the child widget will we left
5784 pointing to a dead window.
5786 For examples of crashers caused by this see
5787 https://bugzilla.gnome.org/show_bug.cgi?id=596397 and
5788 https://bugzilla.gnome.org/show_bug.cgi?id=596398
5790 * webkit/webkitwebview.cpp:
5791 (webkit_web_view_container_add):
5793 2009-09-29 Xan Lopez <xlopez@igalia.com>
5795 Rubber-stamped by Eric Seidel.
5797 [Gtk] Crash when saving a password
5798 https://bugs.webkit.org/show_bug.cgi?id=28070
5800 Disconnect the 'got-headers' callback when we are done with
5801 it. The signal can be emitted more than once if the message is
5802 retransmitted, but each time that happens authData is created
5803 again and a new callback connected, so we have to get rid of the
5804 old one (which will crash because we free authData).
5806 * webkit/webkitsoupauthdialog.c:
5807 (save_password_callback):
5809 2009-09-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5811 Reviewed by Xan Lopez.
5813 Pop down the context menu when the page transitions to committed,
5814 to avoid keeping a context menu out of context.
5816 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5817 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
5818 * webkit/webkitprivate.h:
5819 * webkit/webkitwebview.cpp:
5821 (webkit_web_view_forward_context_menu_event):
5823 2009-09-24 Jon Honeycutt <jhoneycutt@apple.com>
5825 Reviewed by Alice Liu.
5827 * webkit/webkitwebview.cpp:
5828 (webkit_web_view_init):
5829 Pass 0 for new Page constructor argument.
5831 2009-09-24 Xan Lopez <xlopez@igalia.com>
5833 Reviewed by Gustavo Noronha and Jan Alonzo.
5834 [GTK] Add WEBKIT_LOAD_ERROR status
5835 https://bugs.webkit.org/show_bug.cgi?id=29644
5837 Add a new load-status enum value, WEBKIT_LOAD_FAILED, emitted when
5838 there's an error during the load process. This is needed if we
5839 want notify::load-status to be able to handle all situations,
5840 since WEBKIT_LOAD_FINISHED is not emitted when there's an error
5841 and we are lacking a notification of the load being stopped.
5843 * WebCoreSupport/FrameLoaderClientGtk.cpp:
5844 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
5845 * tests/testloading.c:
5846 (web_loading_fixture_setup):
5847 (load_error_status_changed_cb):
5849 (test_loading_error):
5850 (load_cancelled_cb):
5852 (load_cancelled_status_changed_cb):
5853 (test_loading_cancelled):
5855 * webkit/webkitwebframe.h:
5857 2009-09-24 Xan Lopez <xlopez@igalia.com>
5859 Revert r48697, since it broke key handling notification to GTK+.
5861 * WebCoreSupport/EditorClientGtk.cpp:
5862 (WebKit::imContextCommitted):
5863 (WebKit::imContextPreeditChanged):
5864 (WebKit::EditorClient::shouldBeginEditing):
5865 (WebKit::EditorClient::shouldEndEditing):
5866 (WebKit::interpretKeyEvent):
5867 (WebKit::handleEditingKeyboardEvent):
5868 (WebKit::EditorClient::handleKeyboardEvent):
5869 (WebKit::EditorClient::handleInputMethodKeydown):
5871 2009-09-23 Martin Robinson <martin.james.robinson@gmail.com>
5873 Reviewed by Xan Lopez.
5875 [GTK] REGRESSION: BitmapImage::getGdkPixbuf fails for non-square images
5876 https://bugs.webkit.org/show_bug.cgi?id=29654
5878 Ensure that even when GTKSimpleIMContext filters non-IME keystrokes,
5879 keyboard events are fired properly.
5881 * WebCoreSupport/EditorClientGtk.cpp:
5882 (WebKit::clearPendingIMData):
5883 (WebKit::imContextCommitted):
5884 (WebKit::imContextPreeditChanged):
5885 (WebKit::EditorClient::shouldBeginEditing):
5886 (WebKit::EditorClient::shouldEndEditing):
5887 (WebKit::interpretEditorCommandKeyEvent):
5888 (WebKit::handleCaretBrowsingKeyboardEvent):
5889 (WebKit::EditorClient::handleKeyboardEvent):
5890 (WebKit::EditorClient::handleInputMethodKeydown):
5892 2009-09-23 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5894 Reviewed by Xan Lopez.
5896 [GTK] need to dump number of pending unload handlers
5897 https://bugs.webkit.org/show_bug.cgi?id=29685
5899 * webkit/webkitprivate.h:
5900 * webkit/webkitwebframe.cpp:
5901 (webkit_web_frame_get_pending_unload_event_count): New function to
5904 2009-09-23 Jan Michael Alonzo <jmalonzo@webkit.org>
5906 Reviewed by Xan Lopez.
5908 Minor reorganization to the patch landed in
5909 http://trac.webkit.org/changeset/48670. Also move JSCore-1.0.gir
5910 in the gtk directory as that's only useful to the Gtk port at the
5913 * JSCore-1.0.gir: Renamed from JSCore-1.0.gir.
5915 2009-09-22 Xan Lopez <xlopez@igalia.com>
5917 Reviewed by Jan Alonzo.
5919 Hardcode element positions at 0,0 so that we know where to
5920 generate events to test WebKitHitTestResult.
5922 * tests/testhittestresult.c:
5924 (test_webkit_hit_test_result):
5927 2009-09-22 Xan Lopez <xlopez@igalia.com>
5929 Reviewed by Jan Alonzo.
5931 [GTK] WebKitHitTestResult is completely broken in gmail
5932 https://bugs.webkit.org/show_bug.cgi?id=29527
5934 We need to use the main or focused frame when doing the coordinate
5935 transformation instead of always using the main frame.
5937 * webkit/webkitwebview.cpp:
5938 (webkit_web_view_get_hit_test_result):
5940 2009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5942 Update documentation control files to 1.1.15.
5944 * docs/webkitgtk-docs.sgml:
5945 * docs/webkitgtk-sections.txt:
5947 2009-09-21 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
5949 Unreviewed docs build fix. Current CFLAGS and LIBS variables no
5950 longer bring gthread in.
5952 * docs/GNUmakefile.am:
5954 2009-09-21 Xan Lopez <xlopez@igalia.com>
5956 Reviewed by Gustavo Noronha.
5962 2009-09-20 Xan Lopez <xlopez@igalia.com>
5964 Reviewed by Gustavo Noronha.
5966 Small documentation fix.
5968 * webkit/webkithittestresult.cpp:
5970 2009-09-18 Xan Lopez <xlopez@igalia.com>
5974 Add missing file to the repository.
5976 * tests/testhittestresult.c: Added.
5978 (test_info_destroy):
5979 (hit_test_result_fixture_setup):
5980 (hit_test_result_fixture_teardown):
5982 (test_webkit_hit_test_result):
5985 2009-09-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
5987 [Gtk] Unreviewed build fix.
5989 * WebCoreSupport/ChromeClientGtk.cpp:
5990 (WebKit::ChromeClient::platformPageClient):
5992 2009-09-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
5994 Reviewed by Simon Hausmann.
5996 Make PlatformWindow return something else than PlatformWidget
5997 https://bugs.webkit.org/show_bug.cgi?id=29085
5999 Reflect the rename of platformWindow and it's return type.
6001 * WebCoreSupport/ChromeClientGtk.cpp:
6002 (WebKit::ChromeClient::platformPageClient):
6003 (WebKit::ChromeClient::runOpenPanel):
6004 * WebCoreSupport/ChromeClientGtk.h:
6005 * webkit/webkitprivate.cpp:
6006 (currentToplevelCallback):
6007 * webkit/webkitwebview.cpp:
6008 (webkit_web_view_popup_menu_handler):
6010 2009-09-18 Xan Lopez <xlopez@igalia.com>
6012 Reviewed by Jan Alonzo.
6014 Document webkit_web_view_stop_loading.
6016 * webkit/webkitwebview.cpp:
6018 2009-09-18 Xan Lopez <xlopez@igalia.com>
6020 Reviewed by Gustavo Noronha and Jan Alonzo.
6022 [GTK] context menu overriding API is very limited
6023 https://bugs.webkit.org/show_bug.cgi?id=27546
6025 Add webkit_web_view_get_hit_test_result, a function to get a hit
6026 test result from a GdkEventButton. Useful to let applications
6027 decide between several actions on button press depending on what
6030 * webkit/webkitwebview.cpp:
6031 (webkit_web_view_stop_loading):
6032 (documentPointForWindowPoint):
6033 (webkit_web_view_get_hit_test_result):
6034 * webkit/webkitwebview.h:
6036 2009-09-18 Xan Lopez <xlopez@igalia.com>
6038 Reviewed by Gustavo Noronha and Jan Alonzo.
6040 [GTK] context menu overriding API is very limited
6041 https://bugs.webkit.org/show_bug.cgi?id=27546
6043 Add WebKitHitTestResult, a wrapper over HitTestResult. It contains
6044 context information about a point in the web page.
6047 * webkit/webkitdefines.h:
6048 * webkit/webkithittestresult.cpp: Added.
6049 (webkit_hit_test_result_finalize):
6050 (webkit_hit_test_result_get_property):
6051 (webkit_hit_test_result_set_property):
6052 (webkit_hit_test_result_class_init):
6053 (webkit_hit_test_result_init):
6054 * webkit/webkithittestresult.h: Added.
6055 * webkit/webkitprivate.cpp:
6057 * webkit/webkitprivate.h:
6059 2009-09-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6061 Reviewed by Xan Lopez and Jan Alonzo.
6063 https://bugs.webkit.org/show_bug.cgi?id=29134
6064 [GTK] Add API to access sub resources
6066 Implement getting subresources, and improve testing of
6067 main, and sub resources loading.
6069 2009-09-11 Xan Lopez <xlopez@igalia.com>
6071 Reviewed by Jan Alonzo.
6073 [GTK] Use gtk_style_set_background instead of gdk_window_set_background
6074 https://bugs.webkit.org/show_bug.cgi?id=29173
6076 Use gtk_style_set_background instead of gdk_window_set_background,
6077 as suggested by the documentation. Also, use GTK_STATE_NORMAL
6078 directly, since that's the default state of a GtkWidget.
6080 * webkit/webkitwebview.cpp:
6081 (webkit_web_view_realize):
6083 2009-09-09 Zan Dobersek <zandobersek@gmail.com>
6085 Reviewed by Gustavo Noronha.
6087 [GTK] DumpRenderTree needs eventSender object and implementation
6088 https://bugs.webkit.org/show_bug.cgi?id=25990
6090 Creates a function that is accessible from the DumpRenderTree tool
6091 and calls the layout method on the frame view.
6093 * webkit/webkitprivate.h:
6094 * webkit/webkitwebframe.cpp:
6095 (webkit_web_frame_layout):
6097 2009-09-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6099 Reviewed by Xan Lopez.
6101 https://bugs.webkit.org/show_bug.cgi?id=29044
6102 [GTK] Should update suggested-filename when the response is received
6104 Set suggested filename also when the response only comes after the
6105 download has started.
6107 * webkit/webkitdownload.cpp:
6108 (webkit_download_set_response):
6109 (webkit_download_set_suggested_filename):
6110 * webkit/webkitwebview.cpp:
6111 (webkit_web_view_request_download):
6113 2009-09-08 Priit Laes <plaes@plaes.org>
6115 Reviewed by Gustavo Noronha.
6117 Fix up erroneus 'Since: @version@' tags in documentation.
6119 * webkit/webkitwebdatasource.cpp:
6120 * webkit/webkitwebresource.cpp:
6121 (webkit_web_resource_class_init):
6122 * webkit/webkitwebsettings.cpp:
6123 (webkit_web_settings_class_init):
6124 * webkit/webkitwebview.cpp:
6125 (webkit_web_view_class_init):
6126 * webkit/webkitwebwindowfeatures.cpp:
6128 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6130 Link new objects documents in the main document.
6132 * docs/webkitgtk-docs.sgml:
6134 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6136 Documentation control files updated for 1.1.14.
6138 * docs/webkitgtk-docs.sgml:
6139 * docs/webkitgtk-sections.txt:
6141 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6143 What's new for 1.1.14.
6147 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6149 Rubber-stamped by Xan Lopez.
6151 Use g_return_if_fail to check for the SoupURI creation, instead of
6152 printing a custom warning.
6154 * webkit/webkitnetworkrequest.cpp:
6155 (webkit_network_request_set_uri):
6157 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6159 Reviewed by Xan Lopez.
6161 https://bugs.webkit.org/show_bug.cgi?id=26854
6162 [GTK] Needs API to allow more control over outgoing requests
6164 Map the willSendRequest delegate to the 'resource-request-starting'
6165 signal, allowing more control of the resources that are fetched.
6167 Mapping willSendRequest properly requires an appropriate Response
6168 object, so we are introducing WebKitNetworkResponse, which works in a
6169 way similar to WebKitNetworkRequest.
6171 * WebCoreSupport/FrameLoaderClientGtk.cpp:
6172 (WebKit::FrameLoaderClient::dispatchWillSendRequest):
6173 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
6174 (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
6175 (WebKit::FrameLoaderClient::dispatchDidFailLoading):
6176 * tests/testnetworkresponse.c: Added.
6177 (test_network_response_create_destroy):
6178 (test_network_response_properties):
6180 * tests/testwebresource.c:
6181 (resource_request_starting_cb):
6183 (test_web_resource_loading):
6186 * webkit/webkitdefines.h:
6187 * webkit/webkitnetworkrequest.cpp:
6188 * webkit/webkitnetworkresponse.cpp: Added.
6189 (webkit_network_response_dispose):
6190 (webkit_network_response_finalize):
6191 (webkit_network_response_get_property):
6192 (webkit_network_response_set_property):
6193 (webkit_network_response_class_init):
6194 (webkit_network_response_init):
6195 (webkit_network_response_new_with_core_response):
6196 (webkit_network_response_new):
6197 (webkit_network_response_set_uri):
6198 (webkit_network_response_get_uri):
6199 (webkit_network_response_get_message):
6200 * webkit/webkitnetworkresponse.h: Added.
6201 * webkit/webkitprivate.cpp:
6203 (WTF::WebKitNetworkRequest):
6204 (WTF::WebKitNetworkResponse):
6205 (WTF::WebKitWebResource):
6206 * webkit/webkitprivate.h:
6207 * webkit/webkitwebresource.cpp:
6208 (webkit_web_resource_cleanup):
6209 (webkit_web_resource_finalize):
6210 (webkit_web_resource_class_init):
6211 (webkit_web_resource_set_property):
6212 (webkit_web_resource_get_uri):
6213 * webkit/webkitwebview.cpp:
6214 (webkit_web_view_class_init):
6215 * webkitmarshal.list:
6217 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6219 Reviewed by Jan Alonzo.
6221 https://bugs.webkit.org/show_bug.cgi?id=28979
6222 [GTK] Misc improvments to NetworkRequest
6224 Unref message in dispose, as it should be, not in finalize.
6226 * webkit/webkitnetworkrequest.cpp:
6227 (webkit_network_request_dispose):
6228 (webkit_network_request_finalize):
6229 (webkit_network_request_class_init):
6231 2009-09-07 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6233 Reviewed by Jan Alonzo.
6235 https://bugs.webkit.org/show_bug.cgi?id=28979
6236 [GTK] Misc improvments to NetworkRequest
6238 Bring documentation up-to-date with reality regarding NetworkRequest.
6240 * webkit/webkitnetworkrequest.cpp:
6242 2009-09-07 Xan Lopez <xlopez@igalia.com>
6244 Reviewed by Gustavo Noronha.
6246 Make the auth dialog usable when libsoup does not have a
6247 SoupPasswordManager, since it might go away in the next
6250 * webkit/webkitsoupauthdialog.c:
6251 (response_callback):
6252 (session_can_save_passwords):
6253 (session_authenticate):
6254 2009-09-06 Xan Lopez <xlopez@igalia.com>
6256 Reviewed by Gustavo Noronha.
6258 Update the unitests to latest changes wrt scrollbar policy.
6260 * tests/testwindow.c:
6261 (test_webkit_window_scrollbar_policy):
6263 2009-09-06 Martin Robinson <martin.james.robinson@gmail.com>
6265 Reviewed by Gustavo Noronha, Jan Alonzo and Xan Lopez.
6267 [Gtk] Expose a database API
6268 https://bugs.webkit.org/show_bug.cgi?id=27899
6270 Expose an HTML5 database API for GTK+.
6272 * WebCoreSupport/ChromeClientGtk.cpp:
6273 (WebKit::ChromeClient::print):
6275 * webkit/webkitdefines.h:
6276 * webkit/webkitprivate.cpp:
6278 * webkit/webkitprivate.h:
6279 * webkit/webkitsecurityorigin.cpp: Added.
6280 (webkit_security_origin_finalize):
6281 (webkit_security_origin_dispose):
6282 (webkit_security_origin_set_property):
6283 (webkit_security_origin_get_property):
6284 (webkit_security_origins):
6285 (webkit_security_origin_class_init):
6286 (webkit_security_origin_init):
6287 (webkit_security_origin_get_protocol):
6288 (webkit_security_origin_get_host):
6289 (webkit_security_origin_get_port):
6290 (webkit_security_origin_get_web_database_usage):
6291 (webkit_security_origin_get_web_database_quota):
6292 (webkit_security_origin_set_web_database_quota):
6293 (webkit_security_origin_get_all_web_databases):
6296 (webkit_security_origin_get_web_database):
6297 * webkit/webkitsecurityorigin.h: Added.
6298 * webkit/webkitwebdatabase.cpp: Added.
6299 (webkit_web_database_finalize):
6300 (webkit_web_database_dispose):
6301 (webkit_web_database_set_property):
6302 (webkit_web_database_get_property):
6303 (webkit_web_database_class_init):
6304 (webkit_web_database_init):
6305 (webkit_web_database_set_security_origin):
6306 (webkit_web_database_set_name):
6307 (webkit_web_database_get_security_origin):
6308 (webkit_web_database_get_name):
6309 (webkit_web_database_get_display_name):
6310 (webkit_web_database_get_expected_size):
6311 (webkit_web_database_get_size):
6312 (webkit_web_database_get_filename):
6313 (webkit_web_database_remove):
6314 (webkit_remove_all_web_databases):
6315 (webkit_get_web_database_directory_path):
6316 (webkit_set_web_database_directory_path):
6317 (webkit_get_default_web_database_quota):
6318 * webkit/webkitwebdatabase.h: Added.
6319 * webkit/webkitwebframe.cpp:
6320 (webkit_web_frame_new):
6321 (webkit_web_frame_get_focused_accessible_element):
6322 (webkit_web_frame_get_horizontal_scrollbar_policy):
6323 * webkit/webkitwebframe.h:
6324 * webkit/webkitwebview.cpp:
6325 (webkit_web_view_class_init):
6327 2009-09-03 Adam Barth <abarth@webkit.org>
6329 Reviewed by eric@webkit.org.
6331 https://bugs.webkit.org/show_bug.cgi?id=24696
6333 Stub implementations of mixed content methods of FrameLoaderClient.
6335 * WebCoreSupport/FrameLoaderClientGtk.cpp:
6336 (WebKit::FrameLoaderClient::didDisplayInsecureContent):
6337 (WebKit::FrameLoaderClient::didRunInsecureContent):
6338 * WebCoreSupport/FrameLoaderClientGtk.h:
6340 2009-09-03 Xan Lopez <xlopez@igalia.com>
6342 Reviewed by Gustavo Noronha.
6344 Access private member variables directly instead of using the
6347 * WebCoreSupport/FrameLoaderClientGtk.cpp:
6348 (WebKit::FrameLoaderClient::createFrame):
6349 (WebKit::FrameLoaderClient::windowObjectCleared):
6351 2009-09-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6353 Reviewed by Xan Lopez.
6355 Remove bogus asserts that break Debug builds at runtime.
6357 * WebCoreSupport/DocumentLoaderGtk.cpp:
6358 (WebKit::DocumentLoader::detachFromFrame):
6359 (WebKit::DocumentLoader::decreaseLoadCount):
6361 2009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org>
6363 Reviewed by Xan Lopez and Gustavo Noronha.
6365 [Gtk] Implement a WebDataSource for the gtk port
6366 https://bugs.webkit.org/show_bug.cgi?id=24758
6368 Add data source API getters to WebKitWebFrame.
6369 Also add WebKitWebDataSource unit test.
6371 * tests/testwebdatasource.c: Added.
6372 * webkit/webkitwebframe.cpp:
6373 * webkit/webkitwebframe.h:
6375 2009-09-02 Jan Michael Alonzo <jmalonzo@webkit.org>
6377 Reviewed by Xan Lopez and Gustavo Noronha.
6379 [Gtk] Implement a WebDataSource for the gtk port
6380 https://bugs.webkit.org/show_bug.cgi?id=24758
6382 Subclass DocumentLoader for Gtk and implement it under the WebKit
6383 namespace. Add WebKitWebDataSource implementation that closely
6384 follows the mac implementation of the API.
6386 * WebCoreSupport/DocumentLoaderGtk.cpp: Added.
6387 * WebCoreSupport/DocumentLoaderGtk.h: Added.
6388 * webkit/webkitwebdatasource.cpp: Added.
6389 * webkit/webkitwebdatasource.h: Added.
6391 2009-09-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6393 Reviewed by Xan Lopez.
6395 Avoid causing unexpected issues with window sizing when sites
6396 disable scrollbars completely.
6398 * WebCoreSupport/ChromeClientGtk.cpp:
6399 (WebKit::ChromeClient::scrollbarsModeDidChange):
6400 * tests/testwindow.c:
6401 (test_webkit_window_scrollbar_policy):
6402 * webkit/webkitwebframe.cpp:
6403 (webkit_web_frame_class_init):
6405 2009-09-01 Jan Michael Alonzo <jmalonzo@webkit.org>
6407 Reviewed by Xan Lopez and Gustavo Noronha.
6409 [Gtk] Implement a WebDataSource for the gtk port
6410 https://bugs.webkit.org/show_bug.cgi?id=24758
6412 Implement WebKitWebResource for the resource-related API for
6413 WebKitWebDataSource.
6417 2009-09-01 Xan Lopez <xlopez@igalia.com>
6419 Reviewed by Jan Alonzo.
6421 https://bugs.webkit.org/show_bug.cgi?id=28842
6422 [GTK] Do not emit extra FINISHED load-status signals
6424 Do not emit FINISHED load-status signals on our own, just rely on
6425 WebCore for that. Avoids emitting FINISHED several times when we
6428 * WebCoreSupport/FrameLoaderClientGtk.cpp:
6429 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
6430 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
6431 * tests/testloading.c:
6432 (web_loading_fixture_setup):
6433 (web_loading_fixture_teardown):
6435 (status_changed_cb):
6436 (test_loading_status):
6437 (load_error_status_changed_cb):
6439 (test_loading_error):
6441 * webkit/webkitwebframe.h:
6443 2009-08-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6445 Reviewed by Alexey Proskuryakov.
6447 https://bugs.webkit.org/show_bug.cgi?id=28466
6448 When downloading a file, two GET requests are sent to the HTTP server
6450 Support reusing a connection that is already ongoing, instead of
6451 cancelling the connection and creating another.
6453 * WebCoreSupport/FrameLoaderClientGtk.cpp:
6454 (WebKit::FrameLoaderClient::download):
6455 * webkit/webkitdownload.cpp:
6456 (webkit_download_new_with_handle):
6457 (webkit_download_start):
6458 * webkit/webkitprivate.h:
6459 * webkit/webkitwebview.cpp:
6460 (webkit_web_view_request_download):
6462 2009-08-31 Alexey Proskuryakov <ap@apple.com>
6466 This is also a behavior fix, at least on debug builds - a caller of
6467 webkit_web_history_item_new_with_data() could pass an URL that could cause an assertion
6470 * webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_new_with_data): Pass a null
6471 KURL as base to parse properly.
6473 2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6475 Reviewed by Holger Freyther.
6477 https://bugs.webkit.org/show_bug.cgi?id=25889
6478 [GTK] scrollbar policy for main frame is not implementable
6480 Add properties and a signal to report scrollbar policy changes to
6481 client code, and a default handler that does the right thing when
6482 using GtkScrolledWindow.
6484 * WebCoreSupport/ChromeClientGtk.cpp:
6485 (WebKit::ChromeClient::scrollbarsModeDidChange):
6486 * WebCoreSupport/ChromeClientGtk.h:
6487 * webkit/webkitwebframe.cpp:
6488 (webkit_web_frame_get_property):
6489 (webkit_web_frame_class_init):
6490 (webkit_web_frame_get_horizontal_scrollbar_policy):
6491 (webkit_web_frame_get_vertical_scrollbar_policy):
6492 * webkit/webkitwebframe.h:
6493 * tests/testwindow.c: Added.
6495 (test_webkit_window_scrollbar_policy):
6498 2009-08-28 Jan Michael Alonzo <jmalonzo@webkit.org>
6500 Reviewed by Gustavo Noronha and Xan Lopez.
6502 [Gtk] Add view source mode API
6503 https://bugs.webkit.org/show_bug.cgi?id=28805
6505 Implement setter and getter for "view source" mode.
6507 * webkit/webkitwebview.cpp:
6508 (webkit_web_view_set_view_source_mode):
6509 (webkit_web_frame_get_view_source_mode):
6510 * webkit/webkitwebview.h:
6512 2009-08-26 Xan Lopez <xlopez@igalia.com>
6514 Reviewed by Gustavo Noronha.
6516 https://bugs.webkit.org/show_bug.cgi?id=28738
6517 Expose undo/redo functionality in WebKitWebView
6519 Expose undo/redo functionality in WebKitWebView, keeping the
6520 default bindings as they were.
6522 * WebCoreSupport/EditorClientGtk.cpp:
6524 * webkit/webkitwebview.cpp:
6525 (webkit_web_view_real_undo):
6526 (webkit_web_view_real_redo):
6527 (webkit_web_view_class_init):
6528 (webkit_web_view_can_undo):
6529 (webkit_web_view_undo):
6530 (webkit_web_view_can_redo):
6531 (webkit_web_view_redo):
6532 * webkit/webkitwebview.h:
6534 2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6536 Reviewed by Xan Lopez.
6538 News about the 1.1.13 release.
6542 2009-08-24 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6544 Reviewed by Xan Lopez.
6546 Add new symbols, and an index of new symbols for the 1.1.13
6549 * docs/webkitgtk-docs.sgml:
6550 * docs/webkitgtk-sections.txt:
6552 2009-08-23 Xan Lopez <xlopez@igalia.com>
6554 Reviewed by Gustavo Noronha.
6556 Fix a couple of typos.
6558 * webkit/webkitwebsettings.cpp:
6559 (webkit_web_settings_class_init):
6561 2009-08-23 Xan Lopez <xlopez@igalia.com>
6563 Reviewed by Gustavo Noronha.
6565 Update editing-behavior property here too.
6567 * webkit/webkitwebview.cpp:
6568 (webkit_web_view_settings_notify):
6570 2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
6572 Rubberstamped by Gustavo Noronha.
6574 Fix regressions introduced by http://trac.webkit.org/changeset/47690.
6576 Update the setting whenever the property gets set.
6578 * webkit/webkitwebview.cpp:
6579 (webkit_web_view_settings_notify):
6581 2009-08-23 Jan Michael Alonzo <jmalonzo@webkit.org>
6583 Reviewed by Xan Lopez.
6585 [Gtk] API for disabling local file access to web URLs
6586 https://bugs.webkit.org/show_bug.cgi?id=28663
6588 Add a setting to enable or disable file access to web URLs. It's
6589 disabled by default for security reasons.
6591 * webkit/webkitwebsettings.cpp:
6592 (webkit_web_settings_class_init):
6593 (webkit_web_settings_set_property):
6594 (webkit_web_settings_get_property):
6595 (webkit_web_settings_copy):
6596 * webkit/webkitwebview.cpp:
6597 (webkit_web_view_update_settings):
6599 2009-08-22 Xan Lopez <xlopez@igalia.com>
6601 Reviewed by Jan Alonzo.
6603 https://bugs.webkit.org/show_bug.cgi?id=28154
6604 clicking below end of text in a textarea moves cursor to wrong position
6606 Expose the EditingBehavior setting and set it by default to Mac,
6607 since that what matches the GTK+ default behavior.
6609 * webkit/webkitprivate.cpp:
6611 * webkit/webkitprivate.h:
6612 * webkit/webkitwebsettings.cpp:
6613 (webkit_web_settings_class_init):
6614 (webkit_web_settings_set_property):
6615 (webkit_web_settings_get_property):
6616 (webkit_web_settings_copy):
6617 * webkit/webkitwebsettings.h:
6618 * webkit/webkitwebview.cpp:
6619 (webkit_web_view_update_settings):
6621 2009-08-20 Aaron Boodman <aa@chromium.org>
6623 Hopefully the last speculative build for gtk.
6625 * webkit/webkitprivate.cpp:
6626 (webkit_white_list_access_from_origin):
6627 * webkit/webkitprivate.h:
6629 2009-08-20 David Levin <levin@chromium.org>
6631 Another speculative build for gtk.
6633 * webkit/webkitprivate.cpp:
6634 (webkit_white_list_access_to_origin):
6636 2009-08-20 David Levin <levin@chromium.org>
6638 Speculative build for gtk.
6640 * webkit/webkitprivate.cpp:
6641 (webkit_white_list_access_to_origin):
6643 2009-08-19 Aaron Boodman <aa@chromium.org>
6647 * webkit/webkitprivate.h: "WEBKIT API" -> "WEBKIT_API"
6649 2009-08-19 Aaron Boodman <aa@chromium.org>
6651 Reviewed by David Levin.
6653 https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
6654 specify a more granular policy for cross-origin XHR access.
6656 * webkit/webkitprivate.cpp:
6657 (webkit_white_list_access_to_origin): Add API to manipulate origin access whitelists.
6658 (webkit_reset_origin_access_white_lists): Ditto.
6659 * webkit/webkitprivate.h: Ditto.
6661 2009-08-18 Xan Lopez <xlopez@igalia.com>
6663 Rubber-stamped by Holger Freyther.
6665 Remove an unneeded include.
6667 * WebCoreSupport/DragClientGtk.cpp:
6669 2009-08-18 Fumitoshi Ukai <ukai@chromium.org>
6671 Reviewed by Eric Seidel.
6673 https://bugs.webkit.org/show_bug.cgi?id=28443
6674 Fix build break with gtk older than 2.14.
6676 WebKit gtk port requires gtk 2.10 or later, but DragClientGtk.cpp
6677 uses gtk_widget_get_window that is introduced in 2.14.
6679 * WebCoreSupport/DragClientGtk.cpp:
6680 define gtk_widget_get_window for gtk older than 2.14.
6682 2009-08-18 Jan Michael Alonzo <jmalonzo@webkit.org>
6684 Reviewed by Oliver Hunt.
6686 [Gtk] crash when closing page from javascript
6687 https://bugs.webkit.org/show_bug.cgi?id=27439
6689 Do not unref the WebView in ChromeClientGtk::closeWindowSoon
6690 because (1) a create-web-view handler can return a NULL WebView,
6691 (2) the created WebView is owned by its containing widget, and (3)
6692 clients may not handle the close-web-view signal so this avoids
6693 unreffing a WebView more than once.
6695 * WebCoreSupport/ChromeClientGtk.cpp:
6696 (WebKit::ChromeClient::closeWindowSoon):
6697 * webkit/webkitwebview.cpp:
6698 (webkit_web_view_class_init):
6700 2009-08-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6702 Reviewed by Jan Alonzo.
6704 https://bugs.webkit.org/show_bug.cgi?id=19360
6705 Frags on current page don't generate "navigation-requested" events
6707 Fix order of parameters for the creation of SubstituteData object,
6708 so that normal data loads do not have an unreachable URL. Also
6709 remove a confusion about the purpose of the last parameter.
6711 * webkit/webkitwebframe.cpp:
6712 (webkit_web_frame_load_data):
6714 2009-08-18 Drew Wilson <atwilson@google.com>
6716 Reviewed by Eric Seidel.
6718 Need to extend DumpRenderTree to expose number of worker threads
6719 https://bugs.webkit.org/show_bug.cgi?id=28292
6721 * webkit/webkitprivate.h:
6722 * webkit/webkitworkers.cpp: Added.
6723 (webkit_worker_thread_count):
6724 Exposed WebCore::WorkerThread::workerThreadCount() for the gtk version of DumpRenderTree.
6726 2009-08-18 Xan Lopez <xlopez@igalia.com>
6728 Reviewed by Gustavo Noronha.
6730 Fix the ATK unit test.
6732 We now support line boundaries in the get_text functions, so we
6733 need to make sure the test has the layout we expect by giving it
6734 enough space to fit in one line.
6737 (test_webkit_atk_get_text_at_offset):
6739 2009-08-15 Zan Dobersek <zandobersek@gmail.com>
6741 Reviewed by Xan Lopez.
6743 Fix compiler warnings.
6745 * webkit/webkitwebview.cpp:
6746 (clipboard_contents_received):
6747 (webkit_web_view_drag_data_get):
6749 2009-08-14 Jiahua Huang <jhuangjiahua@gmail.com>
6751 Reviewed by Jan Alonzo.
6753 [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
6754 https://bugs.webkit.org/show_bug.cgi?id=27028
6756 Add a function in WebKit::PasteboardHelperGtk that will return the
6757 value of WEBKIT_WEB_VIEW_TARGET_INFO_HTML,
6758 and WebCore::clipboard_get_contents_cb will use that.
6760 * WebCoreSupport/PasteboardHelperGtk.cpp:
6761 (WebKit::PasteboardHelperGtk::getWebViewTargetInfoHtml):
6762 * WebCoreSupport/PasteboardHelperGtk.h:
6764 2009-08-14 Benjamin Otte <otte@gnome.org>
6766 Reviewed by Gustavo Noronha.
6768 Fix webkit_web_view_set_highlight_text_matches() so that highlighting
6769 works properly in documents with frames.
6771 * webkit/webkitwebview.cpp:
6772 (webkit_web_view_set_highlight_text_matches):
6774 2009-08-13 Zan Dobersek <zandobersek@gmail.com>
6776 Reviewed by Gustavo Noronha.
6778 [GTK] Drag and drop support
6779 https://bugs.webkit.org/show_bug.cgi?id=23642
6781 Adds support for drag actions in WebKitWebView and DragClient.
6783 Defines a support structure that can hold additional drag and drop data,
6784 such as selection data or target IDs (infos) and can be passed through
6787 Implements DragClient functions that gather start position of the drag
6788 and start the GTK drag.
6790 * WebCoreSupport/DragClientGtk.cpp:
6791 (WebKit::DragClient::DragClient):
6792 (WebKit::DragClient::willPerformDragSourceAction):
6793 (WebKit::DragClient::startDrag):
6794 (WebKit::DragClient::createDragImageForLink): A small style fix.
6795 * WebCoreSupport/DragClientGtk.h:
6796 * webkit/webkitwebview.cpp:
6797 (webkit_web_view_drag_end):
6798 (clipboard_contents_received): GtkClipboard callback.
6799 (webkit_web_view_drag_data_get):
6800 (webkit_web_view_class_init):
6801 (webkit_web_view_init):
6802 * webkit/webkitwebview.h: Add GTK selection targets.
6804 2009-08-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6806 Unreviewed build fix.
6808 Last-minute change on the new soup API to use the keyring was not
6809 reflected in our usage - the documentation says we should use
6810 g_slist_free, and soup_auth_free_saved_users doesn't exist.
6812 * webkit/webkitsoupauthdialog.c:
6813 (session_authenticate):
6815 2009-08-12 Xan Lopez <xlopez@igalia.com>
6817 Reviewed by Jan Alonzo.
6819 [GTK] Remove keyring optional features
6820 https://bugs.webkit.org/show_bug.cgi?id=28173
6822 Remove keyring support from our code and rely on libsoup to store
6823 the authentication data if the user requests that support in their
6824 application/library.
6826 * webkit/webkitsoupauthdialog.c:
6827 (response_callback):
6829 (session_authenticate):
6831 2009-08-11 Benjamin Otte <otte@gnome.org>
6833 Reviewed by Xan Lopez.
6835 When instructed to print an out-of-range page, print an empty page
6836 instead of crashing.
6838 * webkit/webkitwebframe.cpp:
6839 (draw_page_callback):
6841 2009-08-10 Brady Eidson <beidson@apple.com>
6845 * webkit/webkitdownload.cpp:
6846 (webkit_download_get_suggested_filename):
6848 2009-08-08 Xan Lopez <xlopez@igalia.com>
6850 Roll out r46928, since it wasn't done in accordance with the
6855 Remove the ChangeLog entry, since it was added at the bottom of
6858 * gdom/GdomDOMObject.h: Removed.
6859 * gdom/GdomDOMObjectPrivate.h: Removed.
6861 2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>
6863 Reviewed by Xan Lopez.
6865 [Gtk] Enable accessibility in Gtk DRT
6866 https://bugs.webkit.org/show_bug.cgi?id=25989
6868 Add SPI to get the focused accessible element to be used by DRT.
6870 * webkit/webkitprivate.h:
6871 * webkit/webkitwebframe.cpp:
6872 (webkit_web_frame_get_focused_accessible_element):
6874 2009-07-30 Martin Robinson <mrobinson@appcelerator.com>
6876 Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.
6878 [GTK] new-window-policy-decision-requested provides no information about the target frame
6879 https://bugs.webkit.org/show_bug.cgi?id=27792
6881 Add frameName property to the WebKitWebNavigation object.
6883 * WebCoreSupport/FrameLoaderClientGtk.cpp:
6884 (WebKit::getNavigationAction):
6885 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
6886 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
6887 * webkit/webkitwebnavigationaction.cpp:
6888 (webkit_web_navigation_action_get_property):
6889 (webkit_web_navigation_action_set_property):
6890 (webkit_web_navigation_action_class_init):
6891 (webkit_web_navigation_action_get_target_frame):
6892 (webkit_web_navigation_action_set_target_frame):
6893 * webkit/webkitwebnavigationaction.h:
6895 2009-07-29 Kevin McCullough <kmccullough@apple.com>
6897 Reviewed by Darin Adler.
6899 Added foundation work to allow a testing infrastructure for the Web
6902 * WebCoreSupport/InspectorClientGtk.cpp:
6903 (WebKit::InspectorClient::inspectorWindowObjectCleared):
6904 * WebCoreSupport/InspectorClientGtk.h:
6906 2009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org>
6908 Reviewed by Eric Seidel and Xan Lopez.
6910 [Gtk] Enable http/tests/appcache tests
6911 https://bugs.webkit.org/show_bug.cgi?id=27674
6913 Add 'enable-offline-web-application-cache' WebSetting to enable
6914 or disable the appcache. Also, Add appcache SPI for DRT to use.
6916 * webkit/webkitapplicationcache.cpp: Added.
6917 (webkit_application_cache_set_maximum_size):
6918 * webkit/webkitprivate.cpp:
6920 * webkit/webkitprivate.h:
6921 * webkit/webkitwebsettings.cpp:
6922 (webkit_web_settings_class_init):
6923 (webkit_web_settings_set_property):
6924 (webkit_web_settings_get_property):
6925 (webkit_web_settings_copy):
6926 * webkit/webkitwebview.cpp:
6927 (webkit_web_view_update_settings):
6928 (webkit_web_view_settings_notify):
6930 2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
6932 Reviewed by Xan Lopez.
6934 Add information about the regression fix for WEBKIT_DEBUG.
6938 2009-07-28 Priit Laes <plaes@plaes.org>
6940 Reviewed by Xan Lopez.
6942 Fix mnemonics in the soup authentication dialog.
6944 * webkit/webkitsoupauthdialog.c:
6947 2009-07-28 Xan Lopez <xlopez@igalia.com>
6949 Reviewed by Gustavo Noronha.
6951 * NEWS: update for 1.1.12 release.
6953 2009-07-27 Alexey Proskuryakov <ap@webkit.org>
6957 * webkit/webkitwebframe.cpp: (webkit_gc_count_javascript_objects): Added a namespace to
6958 SilenceAssertionsOnly.
6960 2009-07-27 Alexey Proskuryakov <ap@webkit.org>
6962 Reviewed by Darin Adler.
6964 https://bugs.webkit.org/show_bug.cgi?id=27735
6965 Give a helpful name to JSLock constructor argument
6967 * webkit/webkitwebframe.cpp:
6968 (webkit_gc_count_javascript_objects):
6970 2009-07-24 Priit Laes <plaes@plaes.org>
6972 Reviewed by Xan Lopez.
6974 [Gtk] Password is saved into gnome-keyring even if auth. fails
6975 https://bugs.webkit.org/show_bug.cgi?id=27560
6977 Check authentication result and save password only when authentication
6980 * webkit/webkitsoupauthdialog.c:
6982 (response_callback):
6983 (save_password_callback):
6985 2009-07-24 Andrei Popescu <andreip@google.com>
6987 Reviewed by Anders Carlsson.
6989 ApplicationCache should have size limit
6990 https://bugs.webkit.org/show_bug.cgi?id=22700
6992 * WebCoreSupport/ChromeClientGtk.cpp:
6993 (WebKit::ChromeClient::reachedMaxAppCacheSize):
6994 Adds empty implementation of reachedMaxAppCacheSize.
6995 * WebCoreSupport/ChromeClientGtk.h:
6997 2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>
6999 Reviewed by Eric Seidel.
7001 [Gtk] Add implementation of GCController for DRT
7002 https://bugs.webkit.org/show_bug.cgi?id=27636
7004 Add SPI for GCController to use.
7006 * webkit/webkitprivate.h:
7007 * webkit/webkitwebframe.cpp:
7008 (webkit_gc_collect_javascript_objects):
7009 (webkit_gc_collect_javascript_objects_on_alternate_thread):
7010 (webkit_gc_count_javascript_objects):
7012 2009-07-22 Xan Lopez <xlopez@igalia.com>
7014 Reviewed by Mark Rowe.
7016 Fix compiler warning.
7018 * tests/testwebsettings.c:
7019 (test_webkit_web_settings_user_agent):
7021 2009-07-22 Xan Lopez <xlopez@igalia.com>
7023 Reviewed by Gustavo Noronha.
7025 Remove unused variables.
7027 * webkit/webkitwebview.cpp:
7028 (webkit_web_view_grab_focus):
7029 (webkit_web_view_focus_in_event):
7031 2009-07-21 Priit Laes <plaes@plaes.org>
7033 Reviewed by Holger Freyther.
7035 [GTK+] Missing accelerator in authentication dialog
7036 https://bugs.webkit.org/show_bug.cgi?id=25509
7038 Add accelerator to checkbox text.
7040 * WebKit/gtk/webkit/webkitsoupauthdialog.c:
7043 2009-07-21 Priit Laes <plaes@plaes.org>
7045 Reviewed by Holger Freyther.
7047 [GTK] http auth dialog pops up twice after a cancelled atempt
7048 https://bugs.webkit.org/show_bug.cgi?id=24818
7050 Remove workaround required for libsoup versions <=2.26.2 as we depend
7053 * webkit/webkitsoupauthdialog.c:
7054 (session_authenticate):
7056 2009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7058 Reviewed by Holger Freyther.
7060 [GTK] Widget size negotiation
7061 https://bugs.webkit.org/show_bug.cgi?id=17154
7063 Implement proper size request for the WebView widget.
7065 * WebCoreSupport/ChromeClientGtk.cpp:
7066 (WebKit::ChromeClient::contentsSizeChanged):
7067 * webkit/webkitwebview.cpp:
7068 (webkit_web_view_size_request):
7069 (webkit_web_view_class_init):
7071 2009-07-16 Holger Hans Peter Freyther <zecke@selfish.org>
7073 Reviewed by Jan Alonzo.
7075 [GTK+] Update the focus handling code.
7077 Change focus-in to always call setActive(true), call
7078 FocusController::setFocusedFrame when no focused frame exists
7079 other SelectionController::setActive. This is matching Windows
7082 On focus-out call FocusController::setActive(false) and
7083 SelectionController::setFocued(false). This is matching Windows
7086 * webkit/webkitwebview.cpp:
7087 (webkit_web_view_focus_in_event):
7088 (webkit_web_view_focus_out_event):
7090 2009-07-16 Xiaomei Ji <xji@chromium.org>
7092 Reviewed by Dan Bernstein.
7094 This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's."
7095 https://bugs.webkit.org/show_bug.cgi?id=24187
7097 Add one extra parameter to the callee of HitTestResult::title() due to the signature change.
7100 * WebCoreSupport/ChromeClientGtk.cpp:
7101 (WebKit::ChromeClient::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title().
7103 2009-07-16 Xiaomei Ji <xji@chromium.org>
7105 Reviewed by Darin Adler.
7107 Fix tooltip does not get its directionality from its element's directionality.
7108 https://bugs.webkit.org/show_bug.cgi?id=24187
7110 Per mitz's suggestion in comment #6, while getting the plain-text
7111 title, we also get the directionality of the title. How to handle
7112 the directionality is up to clients. Clients could ignore it,
7113 or use attribute or unicode control characters to display the title
7116 * WebCoreSupport/ChromeClientGtk.cpp:
7117 (WebKit::ChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
7118 * WebCoreSupport/ChromeClientGtk.h: Add directionality as 2nd parameter to setToolTip().
7120 2009-07-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7122 Rubber-stamped by Jan Alonzo.
7124 Fix enable-xss-auditor property documentation, and default value
7125 to match the fact that it is now enabled by default.
7127 * webkit/webkitwebsettings.cpp:
7128 (webkit_web_settings_class_init):
7130 2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
7132 Reviewed by Darin Adler.
7134 Change all Noncopyable inheriting visibility to public.
7135 https://bugs.webkit.org/show_bug.cgi?id=27225
7137 Change all Noncopyable inheriting visibility to public because
7138 it is needed to the custom allocation framework (bug #20422).
7140 * webkit/webkitdownload.cpp:
7142 2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7144 Unreviewed. Late NEWS file for 1.1.11.
7148 2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7150 Unreviewed. Changes to the doc control files for 1.1.11.
7152 * docs/webkitgtk-docs.sgml:
7153 * docs/webkitgtk-sections.txt:
7155 2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7157 Rubber-stamped by Holger Freyther.
7159 Fix unit test to use the correct assumption that the SoupMessage
7160 will be NULL when WebKitNetworkRequest is created from an URI.
7162 * tests/testnetworkrequest.c:
7163 (test_network_request_create_destroy):
7165 2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>
7167 <https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk]
7168 REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html
7170 Reviewed by Gustavo Noronha.
7172 focus-in and focus-out events only get triggered when there's user
7173 interaction, hence setFocused(bool) never gets called when
7174 focusEvent is triggered when running the layout tests. The
7175 solution seems to be to implement grab-focus too so we can call
7176 setFocused(bool) when a widget has focus.
7178 * webkit/webkitwebview.cpp:
7179 (webkit_web_view_grab_focus):
7180 (webkit_web_view_focus_in_event):
7181 (webkit_web_view_class_init):
7183 2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>
7185 https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT
7187 Reviewed by Gustavo Noronha and Xan Lopez.
7189 Add API to support opening and closing of JavaScript windows automatically.
7191 * WebCoreSupport/ChromeClientGtk.cpp:
7192 (WebKit::ChromeClient::closeWindowSoon):
7193 * webkit/webkitprivate.h:
7194 * webkit/webkitwebsettings.cpp:
7195 (webkit_web_settings_class_init):
7196 (webkit_web_settings_set_property):
7197 (webkit_web_settings_get_property):
7198 (webkit_web_settings_copy):
7199 * webkit/webkitwebview.cpp:
7200 (webkit_web_view_real_close_web_view):
7201 (webkit_web_view_class_init):
7202 (webkit_web_view_update_settings):
7203 (webkit_web_view_settings_notify):
7204 (webkit_web_view_set_group_name):
7205 * webkit/webkitwebview.h:
7207 2009-07-12 Brent Fulgham <bfulgham@gmail.com>
7209 Speculative build fix after http://trac.webkit.org/changeset/45786.
7211 * WebCoreSupport/ChromeClientGtk.cpp:
7212 (WebKit::ChromeClient::addMessageToConsole):
7213 * WebCoreSupport/ChromeClientGtk.h:
7215 2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>
7217 Reviewed by Dave Hyatt.
7219 Make Widget RefCounted to fix:
7221 <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
7222 at WebCore::Widget::afterMouseDown() after clicking To Do's close
7224 <rdar://problem/6978804> WER #16: Repro Access Violation in
7225 WebCore::PluginView::bindingInstance (1310178023)
7227 <rdar://problem/6991251> WER #13: Crash in WebKit!
7228 WebCore::PluginView::performRequest+203 (1311461169)
7230 * WebCoreSupport/FrameLoaderClientGtk.cpp:
7231 (WebKit::FrameLoaderClient::createPlugin):
7232 (WebKit::FrameLoaderClient::createJavaAppletWidget):
7233 * WebCoreSupport/FrameLoaderClientGtk.h:
7235 2009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7237 Reviewed by Jan Alonzo.
7239 Use soup's content sniffing
7240 https://bugs.webkit.org/show_bug.cgi?id=26982
7242 Add the new Content Sniffing feature provided by libsoup.
7244 * webkit/webkitprivate.cpp:
7247 2009-07-05 Holger Hans Peter Freyther <zecke@selfish.org>
7249 Reviewed by Xan Lopez.
7251 Always initialize WebCore.
7253 It is possible that WebKitWebSettings and other classes get
7254 constructed before the WebKitWebView. In this case WebCore is
7255 not yet properly initialized. Add webkit_init to every class
7256 that can be constructed by API users.
7258 * webkit/webkitdownload.cpp:
7259 (webkit_download_class_init):
7260 * webkit/webkitnetworkrequest.cpp:
7261 (webkit_network_request_class_init):
7262 * webkit/webkitwebbackforwardlist.cpp:
7263 (webkit_web_back_forward_list_class_init):
7264 * webkit/webkitwebhistoryitem.cpp:
7265 (webkit_web_history_item_class_init):
7266 * webkit/webkitwebsettings.cpp:
7267 (webkit_web_settings_class_init):
7268 * webkit/webkitwebwindowfeatures.cpp:
7269 (webkit_web_window_features_class_init):
7271 2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>
7273 Reviewed by Xan Lopez and Gustavo Noronha.
7275 Set user-agent from application
7276 https://bugs.webkit.org/show_bug.cgi?id=17375
7278 Add 'user-agent' setter/getter API to WebSettings.
7280 * WebCoreSupport/FrameLoaderClientGtk.cpp:
7281 (WebKit::FrameLoaderClient::FrameLoaderClient):
7282 (WebKit::FrameLoaderClient::userAgent):
7283 * WebCoreSupport/FrameLoaderClientGtk.h:
7284 * webkit/webkitprivate.h:
7285 * webkit/webkitversion.h.in:
7286 * webkit/webkitwebsettings.cpp:
7287 (webkit_get_user_agent):
7288 (webkit_web_settings_class_init):
7289 (webkit_web_settings_finalize):
7290 (webkit_web_settings_set_property):
7291 (webkit_web_settings_get_property):
7292 (webkit_web_settings_copy):
7293 (webkit_web_settings_get_user_agent):
7294 * webkit/webkitwebsettings.h:
7295 * webkit/webkitwebview.cpp:
7296 (webkit_web_view_dispose):
7298 2009-07-02 Xan Lopez <xlopez@igalia.com>
7300 Reviewed by Holger Freyther.
7302 Update the new boolean property in FocusController that keeps
7303 track of whether or not the Page is focused.
7305 * webkit/webkitwebview.cpp:
7306 (webkit_web_view_focus_in_event):
7307 (webkit_web_view_focus_out_event):
7309 2009-06-29 Xan Lopez <xlopez@igalia.com>
7311 Reviewed by Jan Alonzo.
7313 Fix a couple of compiler warnings.
7315 * webkit/webkitwebnavigationaction.cpp:
7316 * webkit/webkitwebview.cpp:
7317 (webkit_web_view_real_move_cursor):
7319 2009-06-28 Xan Lopez <xlopez@igalia.com>
7323 * WebCoreSupport/ContextMenuClientGtk.cpp:
7324 (WebKit::ContextMenuClient::isSpeaking):
7325 * WebCoreSupport/ContextMenuClientGtk.h:
7327 2009-06-24 Jiahua Huang <jhuangjiahua@gmail.com>
7329 Reviewed by Holger Freyther.
7331 [Gtk] Add Undo/Redo support to WebKitGtk
7332 https://bugs.webkit.org/show_bug.cgi?id=26573
7334 Implement EditorClient::undo and other interested funcs.
7336 * WebCoreSupport/EditorClientGtk.cpp:
7337 (WebKit::EditorClient::registerCommandForUndo):
7338 (WebKit::EditorClient::registerCommandForRedo):
7339 (WebKit::EditorClient::clearUndoRedoOperations):
7340 (WebKit::EditorClient::canUndo):
7341 (WebKit::EditorClient::canRedo):
7342 (WebKit::EditorClient::undo):
7343 (WebKit::EditorClient::redo):
7344 (WebKit::EditorClient::EditorClient):
7345 * WebCoreSupport/EditorClientGtk.h:
7347 2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
7349 Reviewed by Gustavo Noronha and Xan Lopez.
7351 [Gtk] Implement DRT XSS auditor support
7352 https://bugs.webkit.org/show_bug.cgi?id=26571
7354 Add a setting "enable-xss-auditor" to enable this feature.
7356 * webkit/webkitwebsettings.cpp:
7357 (webkit_web_settings_class_init):
7358 (webkit_web_settings_set_property):
7359 (webkit_web_settings_get_property):
7360 (webkit_web_settings_copy):
7361 * webkit/webkitwebview.cpp:
7362 (webkit_web_view_update_settings):
7363 (webkit_web_view_settings_notify):
7365 2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
7367 Reviewed by Gustavo Noronha and Xan Lopez.
7369 webkit_web_back_forward_list_add_item() should add a ref for the history item
7370 https://bugs.webkit.org/show_bug.cgi?id=26517
7372 Add a ref to the WebHistoryItem when it's added to the back
7373 forward list through webkit_web_back_forward_list_add_item.
7374 This keeps the history item alive and prevents pywebkitgtk from
7377 * tests/testwebbackforwardlist.c:
7378 (test_webkit_web_history_item_lifetime):
7379 (test_webkit_web_back_forward_list_order):
7380 (test_webkit_web_back_forward_list_add_item):
7381 * webkit/webkitwebbackforwardlist.cpp:
7382 (webkit_web_back_forward_list_add_item):
7384 2009-06-20 Gustavo Noronha Silva <gns@gnome.org>
7386 Reviewed by Jan Alonzo.
7388 Initial test case for loading statuses.
7390 * tests/testloading.c: Added.
7392 (status_changed_cb):
7393 (test_loading_status):
7396 2009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7398 Rubber-stamped by Jan Alonzo.
7400 Fix the ordering in which the new load status goes into the enum
7401 to avoid ABI breakage.
7403 * webkit/webkitwebframe.h:
7405 2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7407 Reviewed by Xan Lopez and Christian Dywan.
7409 Add a new load status to report that the first visually non-empty
7410 layout has been done.
7412 * WebCoreSupport/FrameLoaderClientGtk.cpp:
7413 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
7414 * webkit/webkitwebframe.h:
7416 2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7418 Reviewed by Xan Lopez.
7420 Fix parameters of navigation-policy-decision-requested callback,
7421 to be correct in number and type
7423 * tests/testhttpbackend.c:
7424 (navigation_policy_decision_requested_cb):
7426 2009-06-18 Christian Dywan <christian@twotoasts.de>
7428 Reviewed by Gustavo Noronha.
7430 * WebCoreSupport/FrameLoaderClientGtk.cpp:
7432 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
7433 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
7434 (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static
7435 function loadDone to emit "load-done" and update the status and update
7436 the relevent places. We missed some status notifications before.
7438 2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7440 Rubber-stamped by Xan Lopez.
7442 Be consistent in always using the term URI instead of URL in the
7443 documentation of WebKitWebView signals.
7445 * webkit/webkitwebview.cpp:
7446 (webkit_web_view_class_init):
7448 2009-06-16 Xan Lopez <xlopez@igalia.com>
7450 Reviewed by Gustavo Noronha.
7452 Do not use g_assert_cmpint to test for NULL pointer, just
7455 * tests/testnetworkrequest.c:
7456 (test_network_request_create_destroy):
7458 2009-06-15 Xan Lopez <xlopez@igalia.com>
7460 Reviewed by Gustavo Noronha.
7462 https://bugs.webkit.org/show_bug.cgi?id=26377
7463 [GTK] Confusion about range of 'progress' property
7465 Range for the progress property is 0.0 .. 1.0, don't multiply it
7466 by 100 to make it a percentage.
7468 * webkit/webkitwebview.cpp:
7469 (webkit_web_view_get_progress):
7471 2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7473 Unreviewed. Add new symbols list for 1.1.10 release.
7475 * docs/webkitgtk-docs.sgml:
7477 2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7479 Rubber-stamped by Xan Lopez.
7481 Fix Since tags for the new uri and message properties.
7483 * webkit/webkitnetworkrequest.cpp:
7484 (webkit_network_request_class_init):
7486 2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7488 Unreviewed. Adding new documented API to the generated
7491 * docs/webkitgtk-sections.txt:
7493 2009-06-15 Xan Lopez <xlopez@igalia.com>
7495 Reviewed by Gustavo Noronha.
7497 Update NEWS for 1.1.10 release.
7501 2009-06-11 Gustavo Noronha Silva <gns@gnome.org>
7503 Reviewed by Xan Lopez.
7505 Add a test to perform an actual download.
7507 * tests/testdownload.c:
7508 (navigation_policy_decision_requested_cb):
7510 (download_requested_cb):
7511 (test_webkit_download_perform):
7514 2009-06-11 Gustavo Noronha Silva <gns@gnome.org>
7516 Reviewed by Xan Lopez.
7518 Fix crash when downloading, caused by assuming SoupMessage would
7519 be there. This change factors the logic required to create a
7520 ResourceRequest from a WebKitNetworkRequest into a core()
7521 function, like we have for some other classes.
7523 * webkit/webkitdownload.cpp:
7524 (webkit_download_start):
7525 * webkit/webkitprivate.cpp:
7527 * webkit/webkitprivate.h:
7528 * webkit/webkitwebframe.cpp:
7529 (webkit_web_frame_load_request):
7531 2009-06-10 Gustavo Noronha Silva <gns@gnome.org>
7533 Reviewed by Xan Lopez.
7535 Make WebKitNetworkRequest a proper GObject, making URI and
7536 SoupMessage properties. Also adding unit tests for creation and
7539 * tests/testnetworkrequest.c: Added.
7540 (test_network_request_create_destroy):
7541 (test_network_request_properties):
7543 * webkit/webkitnetworkrequest.cpp:
7544 (webkit_network_request_get_property):
7545 (webkit_network_request_set_property):
7546 (webkit_network_request_class_init):
7547 (webkit_network_request_init):
7548 (webkit_network_request_constructor):
7549 (webkit_network_request_new_with_core_request):
7550 (webkit_network_request_new):
7551 (webkit_network_request_set_uri):
7552 (webkit_network_request_get_uri):
7553 * webkit/webkitnetworkrequest.h:
7555 2009-06-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7557 Reviewed by Xan Lopez.
7563 2009-06-09 Jan Michael Alonzo <jmalonzo@webkit.org>
7565 Reviewed by Gustavo Noronha.
7567 Clear the frame name before we run each tests so we don't get
7568 "someFloaString" or "3" in the target frame name.
7570 * webkit/webkitprivate.h:
7571 * webkit/webkitwebframe.cpp:
7572 (webkit_web_frame_clear_main_frame_name):
7575 2009-06-10 Xan Lopez <xlopez@igalia.com>
7577 Reviewed by Jan Alonzo.
7579 https://bugs.webkit.org/show_bug.cgi?id=25415
7580 [GTK][ATK] Please implement support for get_text_at_offset
7582 Update test for new implementation (it fixes two bugs and adds
7583 actual implementations for LINE boundaries).
7586 (test_webkit_atk_get_text_at_offset):
7588 2009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7590 Reviewed by Xan Lopez.
7592 https://bugs.webkit.org/show_bug.cgi?id=26104
7593 [GTK] Make NetworkRequest a proper GObject and expose SoupMessage
7595 Refactor how SoupMessage is handled, so that our ResourceRequest
7596 object doesn't have to store it as a member, which complicates
7597 managing ResourceRequest's lifetvime.
7599 * tests/testhttpbackend.c:
7600 (navigation_policy_decision_requested_cb):
7601 (test_soup_message_lifetime):
7602 * webkit/webkitnetworkrequest.cpp:
7604 (webkit_network_request_new_with_core_request):
7606 2009-06-08 Gustavo Noronha Silva <gns@gnome.org>
7608 Reviewed by Jan Alonzo.
7610 https://bugs.webkit.org/show_bug.cgi?id=26240
7611 [GTK] Try again button loses query strings
7613 Only trigger reload, when try again is clicked, this way we do not
7614 lose the query strings, like we did when also triggering a form
7617 * resources/error.html:
7619 2009-06-06 Gustavo Noronha Silva <gns@gnome.org>
7621 Reviewed by Xan Lopez.
7623 https://bugs.webkit.org/show_bug.cgi?id=26175
7624 [GTK] Download progress notification should be throttled, for the benefit of download managers
7626 Throttle notifications for the 'progress' property of the Download
7627 object, and update documentation to note the fact that this is
7628 being done, and how to get all notifications if you really care
7631 * webkit/webkitdownload.cpp:
7632 (webkit_download_class_init):
7633 (webkit_download_received_data):
7635 2009-05-29 Jan Michael Alonzo <jmalonzo@webkit.org>
7637 Reviewed by Gustavo Noronha.
7639 Fixed compile warning when comparing the different navigation types
7641 * webkit/webkitwebnavigationaction.cpp:
7642 (webkit_web_navigation_action_class_init):
7644 2009-05-29 Xan Lopez <xlopez@igalia.com>
7646 Reviewed by Gustavo Noronha.
7648 https://bugs.webkit.org/show_bug.cgi?id=26075
7649 [GTK] Refactor key scrolling code
7651 After the scrolling changes in r44177 we can now use the
7652 FrameView::scroll method like the other ports, keeping the magic
7653 constants for the scrolling amounts inside WebCore proper.
7655 * webkit/webkitwebview.cpp:
7656 (webkit_web_view_real_move_cursor):
7658 2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
7660 Reviewed by Jan Alonzo.
7662 Make NetworkRequest carry a reference of the SoupMessage used by
7663 ResourceRequest, and use that to create new ResourceRequests where
7664 needed, so that no information is lost while passing around
7665 NetworkRequest objects.
7667 * WebCoreSupport/FrameLoaderClientGtk.cpp:
7668 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
7669 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
7670 (WebKit::FrameLoaderClient::startDownload):
7671 * webkit/webkitdownload.cpp:
7672 (webkit_download_start):
7673 * webkit/webkitnetworkrequest.cpp:
7674 (webkit_network_request_finalize):
7675 (webkit_network_request_new_with_core_request):
7676 (webkit_network_request_new):
7677 (webkit_network_request_get_message):
7678 * webkit/webkitprivate.h:
7679 * webkit/webkitwebframe.cpp:
7680 (webkit_web_frame_load_request):
7682 2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7684 Reviewed by Xan Lopez.
7686 https://bugs.webkit.org/show_bug.cgi?id=26048
7687 navigation-policy-decision-requested documentation incomplete
7689 Fix documentation for all policy decision request signals, to
7690 mention that an actual decision is expected when you return TRUE,
7691 meaning that you handled the signal.
7693 * webkit/webkitwebview.cpp:
7694 (webkit_web_view_class_init):
7696 2009-05-28 Xan Lopez <xlopez@igalia.com>
7698 Reviewed by Gustavo Noronha.
7700 Mention the implementation of the new AtkText methods.
7704 2009-05-19 Xan Lopez <xlopez@igalia.com>
7706 Reviewed by Jan Alonzo and Gustavo Noronha.
7708 https://bugs.webkit.org/show_bug.cgi?id=25415
7709 [GTK][ATK] Please implement support for get_text_at_offset
7711 New test file for ATK functionality.
7713 * tests/testatk.c: Added.
7715 (test_get_text_function):
7716 (test_webkit_atk_get_text_at_offset):
7719 2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7721 Reviewed by Xan Lopez.
7723 Document changes worth noting for 1.1.8.
7727 2009-05-27 Xan Lopez <xlopez@igalia.com>
7729 Reviewed by Gustavo Noronha.
7731 https://bugs.webkit.org/show_bug.cgi?id=26039
7732 [GTK] WebKitWebHistoryItem lifetime fixes
7734 Modify the management of history items by the BackForward list.
7736 Having the objects add themselves to a hash table with an extra
7737 reference made impossible for the cleanup code in the dispose
7738 method to be ever called in normal conditions, since dispose is
7739 called before getting rid of the last reference, which the objects
7740 were making to themselves. Get rid of this extra reference and
7741 move the responsibility of the cleanup to the BackForward list
7742 itself, which effectively owns the WebKitWebHistoryItems now.
7744 Also, update the tests to reflect this change.
7746 * tests/testwebbackforwardlist.c:
7747 (test_webkit_web_history_item_lifetime):
7748 (test_webkit_web_back_forward_list_order):
7749 (test_webkit_web_back_forward_list_add_item):
7750 * tests/testwebhistoryitem.c:
7751 (web_history_item_fixture_setup):
7752 (web_history_item_fixture_teardown):
7753 * webkit/webkitprivate.h:
7754 * webkit/webkitwebbackforwardlist.cpp:
7755 (webkit_web_back_forward_list_dispose):
7756 (webkit_web_back_forward_list_class_init):
7757 * webkit/webkitwebhistoryitem.cpp:
7758 (webkit_history_items):
7759 (webkit_history_item_add):
7760 (webkit_web_history_item_dispose):
7763 2009-05-26 Xan Lopez <xlopez@igalia.com>
7765 Reviewed by Jan Alonzo.
7767 https://bugs.webkit.org/show_bug.cgi?id=26039
7768 [GTK] WebKitWebHistoryItem lifetime fixes
7770 Delete the BackForwardList before the Page, otherwise the references
7771 to the WebKitWebHistoryItems will be gone.
7773 * webkit/webkitwebview.cpp:
7774 (webkit_web_view_dispose):
7776 2009-05-27 Gustavo Noronha Silva <gns@gnome.org>
7778 Reviewed by Xan Lopez.
7780 Add comment to clarify why scrolling is done as it is and not with
7783 * WebCoreSupport/ChromeClientGtk.cpp:
7784 (WebKit::ChromeClient::scroll):
7786 2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7788 Unreviewed. Adding new symbols index for 1.1.8.
7790 * docs/webkitgtk-docs.sgml:
7792 2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
7794 Reviewed by Xan Lopez.
7796 Add a new signal called "create-plugin-widget" and emit it from
7797 within the FrameLoaderClientGtk::createPlugin method. If a
7798 GtkWidget gets returned it will be embedded as a WebCore::Widget
7799 using the new GtkPluginWidget.
7801 * WebCoreSupport/FrameLoaderClientGtk.cpp:
7802 (WebKit::FrameLoaderClient::createPlugin):
7803 * webkit/webkitwebview.cpp:
7804 (webkit_signal_accumulator_object_handled):
7805 (webkit_web_view_class_init):
7806 * webkitmarshal.list:
7808 2009-05-24 Xan Lopez <xlopez@igalia.com>
7810 Reviewed by Mark Rowe.
7812 https://bugs.webkit.org/show_bug.cgi?id=25987
7813 [GTK] Clarify WebKitWebView::download-requested documentation
7815 Explain a bit why this signal is not emitted by default and offer
7816 a common solution/setup for that issue.
7818 * webkit/webkitwebview.cpp:
7819 (webkit_web_view_class_init):
7821 2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
7823 Rubber-stamped by Gustavo Noronha.
7825 Break the switch once private browsing is selected.
7827 * webkit/webkitwebsettings.cpp:
7828 (webkit_web_settings_set_property):
7829 (webkit_web_settings_get_property):
7831 2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
7833 Reviewed by Gustavo Noronha and Xan Lopez.
7835 [Gtk] Enable database and localStorage support
7836 https://bugs.webkit.org/show_bug.cgi?id=25629
7838 Add settings to enable or disable database and localStorage
7839 support and enable them by default. This allows databases to be
7840 shown in the WebInspector as well as allow us to run the storage
7843 * webkit/webkitwebsettings.cpp:
7844 (webkit_web_settings_class_init):
7845 (webkit_web_settings_set_property):
7846 (webkit_web_settings_get_property):
7847 (webkit_web_settings_copy):
7848 * webkit/webkitwebview.cpp:
7849 (webkit_web_view_update_settings):
7850 (webkit_web_view_settings_notify):
7852 2009-05-23 David Kilzer <ddkilzer@apple.com>
7854 Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
7856 <https://bugs.webkit.org/show_bug.cgi?id=25495>
7858 Reviewed by Oliver Hunt.
7860 * WebCoreSupport/ChromeClientGtk.h:
7861 (WebKit::ChromeClient::createHTMLParserQuirks): Return a
7862 PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
7864 2009-05-22 Gustavo Noronha Silva <gns@gnome.org>
7866 Reviewed by Jan Alonzo.
7868 Improve NetworkRequest documentation.
7870 * webkit/webkitnetworkrequest.cpp:
7871 (webkit_network_request_class_init):
7872 (webkit_network_request_init):
7874 2009-05-21 Xan Lopez <xlopez@igalia.com>
7876 Reviewed by Maciej Stachowiak.
7878 https://bugs.webkit.org/show_bug.cgi?id=24818
7879 [GTK] http auth dialog pops up twice after a cancelled atempt
7881 Workaround libsoup bug
7882 http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made
7883 libsoup emit the 'authenticate' signal more often than it was
7886 We'll be able to remove this when we depend on libsoup > 2.26.2.
7888 * webkit/webkitsoupauthdialog.c:
7889 (session_authenticate):
7891 2009-05-21 Darin Fisher <darin@chromium.org>
7895 * WebCoreSupport/EditorClientGtk.cpp:
7896 (WebKit::EditorClient::getAutoCorrectSuggestionForMisspelledWord): Add stub for method.
7897 * WebCoreSupport/EditorClientGtk.h:
7899 2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
7901 Reviewed by Darin Adler.
7903 https://bugs.webkit.org/show_bug.cgi?id=25834
7905 Make ChromeClient a interface again
7907 With recent additions to ChromeClient.h empty defaults were
7908 added. This is bad for porters as these changes go unnoticed
7909 and at runtime no notImplemented warning is logged and grepping
7910 for notImplemented will not show anything. Change this Client
7911 to be like the other Clients again and always have pure virtuals
7912 (but for stuff inside #ifdef PLATFORM(MAC)).
7914 Update the various WebKit/* implementations to compile again.
7916 * WebCoreSupport/ChromeClientGtk.cpp:
7917 (WebKit::ChromeClient::setCursor):
7918 (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
7919 * WebCoreSupport/ChromeClientGtk.h:
7920 (WebKit::ChromeClient::scrollRectIntoView):
7922 2009-05-19 Xan Lopez <xlopez@igalia.com>
7924 Reviewed by Jan Alonzo.
7926 Do not try to free enchant broker and dictionary if they do not
7927 exist, those functions aren't NULL-safe.
7929 * webkit/webkitwebsettings.cpp:
7930 (free_spell_checking_language):
7932 2009-05-15 Gustavo Noronha Silva <gns@gnome.org>
7934 Reviewed by Jan Alonzo.
7938 * webkit/webkitwebsettings.cpp:
7939 (free_spell_checking_language):
7940 (webkit_web_settings_finalize):
7941 (webkit_web_settings_set_property):
7943 2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
7945 Reviewed by Jan Alonzo.
7947 Converting filename to uri by concatenating strings is broken
7948 on Windows. Use proper glib conversion functions.
7950 * webkit/webkitwebview.cpp:
7951 (webkit_web_view_open):
7952 * tests/testdownload.c:
7953 (test_webkit_download_create):
7955 2009-05-13 Xan Lopez <xlopez@igalia.com>
7957 Reviewed by Gustavo Noronha.
7959 Do not handle KeyEvents with Ctrl or Alt modifiers that we
7960 otherwise know nothing about. Otherwise shortcuts defined in the
7961 WebView will never be executed.
7963 * WebCoreSupport/EditorClientGtk.cpp:
7964 (WebKit::handleEditingKeyboardEvent):
7966 2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7968 Add information about the SVG index bounds check committed in
7973 2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7975 Reviewed by Xan Lopez.
7977 Note changes since 1.1.6.
7981 2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
7983 Unreviewed. Updated control file, and main file for the 1.1.7
7986 * docs/webkitgtk-docs.sgml:
7987 * docs/webkitgtk-sections.txt:
7989 2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
7991 Reviewed by Xan Lopez.
7993 https://bugs.webkit.org/show_bug.cgi?id=25685
7994 [GTK] Middle click paste form the pasteboard
7996 For paste from middle button (button==2) we want to use
7997 the GDK_PRIMARY_SELECTION. Implement the new getCurrentTarget
7998 method in PasteboardHelperGtk by asking the WebView which
8001 * WebCoreSupport/PasteboardHelperGtk.cpp:
8002 (WebKit::PasteboardHelperGtk::getCurrentTarget):
8003 * WebCoreSupport/PasteboardHelperGtk.h:
8004 * webkit/webkitprivate.h:
8005 * webkit/webkitwebview.cpp:
8006 (webkit_web_view_button_press_event):
8007 (webkit_web_view_use_primary_for_paste):
8009 2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>
8011 Reviewed by Holger Freyther.
8013 [Gtk] Various autotools build refactoring and fixes
8014 https://bugs.webkit.org/show_bug.cgi?id=25286
8016 Add glib-2.0 to the list of required package.
8020 2009-05-11 Christian Dywan <christian@twotoasts.de>
8022 Reviewed by Gustavo Noronha.
8024 https://bugs.webkit.org/show_bug.cgi?id=25697
8025 [GTK] Warnings building WebKit/gtk/tests/testwebframe.c
8027 * tests/testwebframe.c:
8028 (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget*
8029 to fix pointer type incompatibility warnings.
8031 2009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8033 Reviewed by Xan Lopez.
8035 Make the scan program call g_thread_init(NULL) in addition to
8036 g_type_init(), so that it actually works.
8038 * docs/GNUmakefile.am:
8040 2009-05-08 Xan Lopez <xlopez@igalia.com>
8042 Reviewed by Gustavo Noronha.
8044 Unify scrolling code via adjustments and keys. Use the WebCore
8045 defined constants, since that's what people are most used to at
8049 * webkit/webkitwebview.cpp:
8050 (webkit_web_view_real_move_cursor):
8052 2009-05-07 Christian Dywan <christian@twotoasts.de>
8054 Reviewed by Gustavo Noronha.
8056 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8057 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
8058 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): Add missing
8059 call to notifyStatus in the committed case and a missing property notify.
8061 2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8063 Reviewed by Xan Lopez.
8065 https://bugs.webkit.org/show_bug.cgi?id=24786
8066 WebKitDownload sometimes suggests peculiar filenames
8068 When a download is requested by an ongoing request, use the already
8069 provided response to set the suggested filename for the WebKitDownload
8070 object, if available.
8072 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8073 (WebKit::FrameLoaderClient::download):
8074 * webkit/webkitdownload.cpp:
8075 (_WebKitDownloadPrivate::webkit_download_set_property):
8076 (_WebKitDownloadPrivate::webkit_download_get_suggested_filename):
8077 (_WebKitDownloadPrivate::webkit_download_set_suggested_filename):
8078 * webkit/webkitprivate.h:
8079 * webkit/webkitwebview.cpp:
8081 2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
8083 Reviewed by Holger Freyther.
8085 GTK+ API implementation files have bogus extern "C" entries
8086 https://bugs.webkit.org/show_bug.cgi?id=24322
8088 Remove bogus extern "C" from the source files.
8090 * webkit/webkitdownload.cpp:
8091 (DownloadClient::cannotShowURL):
8092 * webkit/webkiterror.cpp:
8093 (webkit_plugin_error_quark):
8094 * webkit/webkitnetworkrequest.cpp:
8095 (webkit_network_request_get_uri):
8096 * webkit/webkitprivate.cpp:
8098 * webkit/webkitversion.cpp:
8099 (webkit_micro_version):
8100 * webkit/webkitwebbackforwardlist.cpp:
8101 * webkit/webkitwebframe.cpp:
8102 (webkit_web_frame_get_load_status):
8103 * webkit/webkitwebhistoryitem.cpp:
8104 * webkit/webkitwebinspector.cpp:
8105 (webkit_web_inspector_set_inspector_client):
8106 * webkit/webkitwebnavigationaction.cpp:
8107 (webkit_web_navigation_action_get_modifier_state):
8108 * webkit/webkitwebpolicydecision.cpp:
8109 (webkit_web_policy_decision_cancel):
8110 * webkit/webkitwebsettings.cpp:
8111 (webkit_web_settings_get_spell_languages):
8112 * webkit/webkitwebview.cpp:
8113 * webkit/webkitwebwindowfeatures.cpp:
8114 (webkit_web_window_features_equal):
8116 2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
8118 Reviewed by Holger Freyther.
8120 Misc fixes to InspectorClientGtk.
8122 * WebCoreSupport/InspectorClientGtk.cpp:
8123 (WebKit::InspectorClient::createPage): use g_filename_to_uri to
8124 get the URI and use web_view_load_uri instead of the deprecated
8125 web_view_open method for loading the URI.
8126 (WebKit::InspectorClient::localizedStringsURL): implement.
8128 2009-05-05 Ben Murdoch <benm@google.com>
8130 Reviewed by Eric Seidel.
8132 Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
8133 https://bugs.webkit.org/show_bug.cgi?id=24776
8135 * WebCoreSupport/ChromeClientGtk.cpp:
8136 (WebKit::ChromeClient::exceededDatabaseQuota):
8137 * WebCoreSupport/ChromeClientGtk.h:
8139 2009-05-06 Christian Dywan <christian@twotoasts.de>
8141 Reviewed by Gustavo Noronha.
8143 http://bugs.webkit.org/show_bug.cgi?id=17066
8144 [GTK] Improve frameloader signals
8146 Implement load-status and progress properties on the view, as well as
8147 load-status on the frame. This supersedes the different load signals
8148 load-progress-changed, load-committed, load-done, load-started and
8149 load-finished which are not only misnamed but broken by design.
8151 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8152 (WebKit::notifyStatus):
8153 (WebKit::FrameLoaderClient::postProgressStartedNotification):
8154 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
8155 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
8156 (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
8157 * webkit/webkitprivate.h:
8158 * webkit/webkitwebframe.cpp:
8159 * webkit/webkitwebframe.h:
8160 * webkit/webkitwebview.cpp:
8161 * webkit/webkitwebview.h:
8163 2009-05-05 Xan Lopez <xlopez@igalia.com>
8165 Reviewed by Holger Freyther.
8169 * WebCoreSupport/EditorClientGtk.cpp:
8170 (WebKit::EditorClient::checkSpellingOfString):
8172 2009-05-02 Gustavo Noronha Silva <gns@gnome.org>
8174 Reviewed by Holger Freyther.
8176 https://bugs.webkit.org/show_bug.cgi?id=25466
8177 WebKitGtk+ 1.1.6 prints weird error messages in Liferea
8179 Use strlen instead of g_utf8_strlen when calculating the size of
8180 the data that is being given to webkit_web_frame_load_string to be
8181 loaded, so that we don't miss any of the content.
8183 * webkit/webkitwebframe.cpp:
8185 2009-05-01 Dimitri Glazkov <dglazkov@chromium.org>
8187 Unreviewed, bulid fix.
8189 Fix mis-applied patch.
8191 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8192 (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
8194 2009-05-01 Pavel Feldman <pfeldman@chromium.org>
8196 Reviewed by Timothy Hatcher.
8198 Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
8200 https://bugs.webkit.org/show_bug.cgi?id=25347
8202 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8203 (WebKit::FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
8204 * WebCoreSupport/FrameLoaderClientGtk.h:
8206 2009-04-30 David Kilzer <ddkilzer@apple.com>
8208 Provide a mechanism to create a quirks delegate for HTMLParser
8210 Reviewed by David Hyatt.
8212 * WebCoreSupport/ChromeClientGtk.h:
8213 (WebKit::ChromeClient::createHTMLParserQuirks): Added. The
8214 default implementation of this factory method returns 0.
8216 2009-04-30 Pavel Feldman <pfeldman@chromium.org>
8218 Reviewed by Dimitri Glazkov.
8220 https://bugs.webkit.org/show_bug.cgi?id=25342
8221 Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
8223 * WebCoreSupport/ChromeClientGtk.cpp:
8224 (WebKit::ChromeClient::addMessageToConsole):
8225 * WebCoreSupport/ChromeClientGtk.h:
8227 2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8229 Unreviewed. Update gtk-doc control and base sgml files for 1.1.6.
8231 * docs/webkitgtk-docs.sgml:
8232 * docs/webkitgtk-sections.txt:
8234 2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8236 Reviewed by Xan Lopez.
8238 Updated with news for the 1.1.6 release.
8242 2009-04-28 Xan Lopez <xlopez@igalia.com>
8244 Reviewed by Gustavo Noronha.
8246 Leave a bit of space from the previous page when advacing a whole
8247 page. This matches the behavior of our scrollbar scrolling code
8248 and is just nicer in general.
8250 * webkit/webkitwebview.cpp:
8252 2009-04-28 Xan Lopez <xlopez@igalia.com>
8254 Unreviewed: committed a few bits by mistake, remove them.
8256 * WebCoreSupport/EditorClientGtk.cpp:
8257 (WebKit::handleEditingKeyboardEvent):
8259 2009-04-28 Xan Lopez <xlopez@igalia.com>
8261 Reviewed by Gustavo Noronha.
8263 https://bugs.webkit.org/show_bug.cgi?id=16135
8264 [GTK] Support caret browsing
8266 Refactor keyboard event handling to work properly under caret
8267 browsing mode. Most of the code comes from the Windows port.
8269 * WebCoreSupport/EditorClientGtk.cpp:
8271 (WebKit::interpretKeyEvent):
8272 (WebKit::handleEditingKeyboardEvent):
8273 (WebKit::EditorClient::handleKeyboardEvent):
8275 2009-04-28 Xan Lopez <xlopez@igalia.com>
8277 Reviewed by Gustavo Noronha.
8279 https://bugs.webkit.org/show_bug.cgi?id=16135
8280 [GTK] Support caret browsing
8282 Based on a patch by Alp Toker.
8284 Add enable-caret-browsing setting to WebKitWebView.
8286 * webkit/webkitwebsettings.cpp:
8287 (_WebKitWebSettingsPrivate::):
8288 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
8289 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
8290 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
8291 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
8292 * webkit/webkitwebview.cpp:
8294 2009-04-27 Gustavo Noronha Silva <gns@gnome.org>
8296 Reviewed by Xan Lopez.
8298 https://bugs.webkit.org/show_bug.cgi?id=25409
8299 [GTK] incorrectly fallsback on cancellation
8301 Check whether we should fallback also on didFailLoad, so that we
8302 don't get error pages showing up in parts of the content of some
8303 sites because of, for instance, location changes.
8305 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8306 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
8308 2009-04-27 Gustavo Noronha Silva <gns@gnome.org>
8310 Reviewed by Xan Lopez.
8312 https://bugs.webkit.org/show_bug.cgi?id=25409
8313 [GTK] incorrectly fallsback on cancellation
8315 Correctly handle cancellation and frame loading interruption
8316 caused by policy change. This also fixes
8317 fast/frames/location-change.html.
8319 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8320 (WebKit::FrameLoaderClient::shouldFallBack):
8322 2009-04-26 Xan Lopez <xlopez@igalia.com>
8324 Reviewed by Mark Rowe.
8328 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8329 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
8331 2009-04-26 Xan Lopez <xlopez@igalia.com>
8333 Reviewed by Gustavo Noronha.
8335 https://bugs.webkit.org/show_bug.cgi?id=25391
8336 G_SIGNAL_ACTION flag in WebKitWebView signals
8338 Most of the signals in WebKitGTK+ have the G_SIGNAL_ACTION flag,
8339 but I don't think this makes sense. The flag is meant for those
8340 signals that can be emitted by the user to trigger some action in
8341 the view, as if it were a normal API, which is not the case for
8344 * webkit/webkitdownload.cpp:
8345 (_WebKitDownloadPrivate::webkit_download_class_init):
8346 * webkit/webkitwebframe.cpp:
8347 * webkit/webkitwebinspector.cpp:
8348 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
8349 * webkit/webkitwebview.cpp:
8351 2009-04-26 Xan Lopez <xlopez@igalia.com>
8353 Unreviewed, actually apply the right patch.
8355 * webkit/webkitwebview.cpp:
8356 (webkit_web_view_move_cursor):
8358 2009-04-26 Xan Lopez <xlopez@igalia.com>
8360 Reviewed by Gustavo Noronha.
8362 Pass a variable to hold the return value of the 'move-cursor'
8363 signal, otherwise a crash can happen.
8365 * webkit/webkitwebview.cpp:
8366 (webkit_web_view_move_cursor):
8368 2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8370 Reviewed by Xan Lopez.
8372 https://bugs.webkit.org/show_bug.cgi?id=24786
8373 WebKitDownload sometimes suggests peculiar filenames
8375 Refactor the emission of the download-requested signal so that we
8376 have less code duplication.
8378 * WebCoreSupport/ContextMenuClientGtk.cpp:
8379 (WebKit::ContextMenuClient::downloadURL):
8380 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8381 (WebKit::FrameLoaderClient::startDownload):
8382 * webkit/webkitprivate.h:
8383 * webkit/webkitwebview.cpp:
8385 2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
8387 Reviewed by Xan Lopez.
8389 [GTK] Error reporting
8390 https://bugs.webkit.org/show_bug.cgi?id=18344
8392 Update FrameLoad errors to use WebKitErrors.
8394 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8395 (WebKit::FrameLoaderClient::cancelledError):
8396 (WebKit::FrameLoaderClient::blockedError):
8397 (WebKit::FrameLoaderClient::cannotShowURLError):
8398 (WebKit::FrameLoaderClient::interruptForPolicyChangeError):
8399 (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
8400 (WebKit::FrameLoaderClient::fileDoesNotExistError):
8401 (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
8402 (WebKit::FrameLoaderClient::shouldFallBack):
8403 * webkit/webkiterror.h: Added.
8404 * webkit/webkiterror.cpp: Added.
8406 2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
8408 Reviewed by Xan Lopez.
8410 [GTK] Error reporting
8411 https://bugs.webkit.org/show_bug.cgi?id=18344
8413 Display a default error page for load errors.
8415 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8416 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
8417 * resources/error.html: Added.
8419 2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
8421 Reviewed by Xan Lopez.
8423 [GTK] Error reporting
8424 https://bugs.webkit.org/show_bug.cgi?id=18344
8426 Add a WebKitWebFrame API to load alternate content for unreachable URLs.
8427 Also add a new signal "load-error" for handling load errors.
8429 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8430 (WebKit::FrameLoaderClient::postProgressFinishedNotification):
8431 (WebKit::FrameLoaderClient::dispatchDidFailLoading):
8432 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
8433 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
8434 * webkit/webkitwebframe.cpp:
8435 * webkit/webkitwebframe.h:
8436 * webkit/webkitwebview.cpp:
8438 2009-04-24 Jan Michael Alonzo <jmalonzo@webkit.org>
8440 Rubber-stamped by Gustavo Noronha.
8442 Fix braces to comply with style guidelines.
8444 * WebCoreSupport/PasteboardHelperGtk.cpp:
8445 (WebKit::PasteboardHelperGtk::getClipboard):
8446 (WebKit::PasteboardHelperGtk::getCopyTargetList):
8447 (WebKit::PasteboardHelperGtk::getPasteTargetList):
8449 2009-04-24 Sergio GarcÃa-Cuevas <sergio_gcg@telefonica.net>
8451 Reviewed by Gustavo Noronha.
8453 https://bugs.webkit.org/show_bug.cgi?id=17267
8454 [GTK] Primary selection/clipboard support
8456 Add a method for getting the primary selection.
8458 * WebCoreSupport/PasteboardHelperGtk.cpp:
8459 (WebKit::PasteboardHelperGtk::getPrimary):
8460 * WebCoreSupport/PasteboardHelperGtk.h:
8462 2009-04-24 Johan Bilien <jobi@via.ecp.fr>
8464 Reviewed by Xan Lopez.
8466 https://bugs.webkit.org/show_bug.cgi?id=25373
8467 Popup menu has the wrong size when popped up near the edge
8470 * webkit/webkitwebview.cpp:
8471 (webkit_web_view_forward_context_menu_event): Let GTK place
8472 the popup menu instead of trying to do better and failing
8474 2009-04-24 Christian Dywan <christian@twotoasts.de>
8476 Rubber-stamped by Gustavo Noronha.
8478 * webkit/webkitwebsettings.cpp:
8479 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the
8480 description of the enable-spell-checking property and correct the
8481 mentioning of the default language used.
8483 2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
8485 Reviewed by Gustavo Noronha.
8487 https://bugs.webkit.org/show_bug.cgi?id=15616
8488 [GTK] Add spell checking
8490 Implement EditorClient::ignoreWordInSpellDocument,
8491 EditorClient::learnWord and EditorClient::getGuessesForWord. This
8492 enables the corresponding user actions.
8494 * WebCoreSupport/EditorClientGtk.cpp:
8495 (WebKit::EditorClient::ignoreWordInSpellDocument):
8496 (WebKit::EditorClient::learnWord):
8497 (WebKit::EditorClient::getGuessesForWord):
8499 2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
8501 Reviewed by Gustavo Noronha.
8503 https://bugs.webkit.org/show_bug.cgi?id=15616
8504 [GTK] Add spell checking
8506 Implement EditorClient::checkSpellingOfString; enabling spell checking
8507 to actually happen, this is the basis for other spelling functions.
8509 * WebCoreSupport/EditorClientGtk.cpp:
8510 (WebKit::EditorClient::checkSpellingOfString):
8512 2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
8514 Reviewed by Gustavo Noronha.
8516 https://bugs.webkit.org/show_bug.cgi?id=15616
8517 [GTK] Add spell checking
8519 Add spell-checking-languages property to WebKitWebSettings.
8521 * webkit/webkitprivate.h:
8522 * webkit/webkitwebsettings.cpp:
8523 (_WebKitWebSettingsPrivate::):
8524 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
8525 (_WebKitWebSettingsPrivate::webkit_web_settings_init):
8526 (_WebKitWebSettingsPrivate::webkit_web_settings_finalize):
8527 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
8528 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
8529 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
8530 (_WebKitWebSettingsPrivate::webkit_web_settings_get_spell_languages):
8532 2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
8534 Reviewed by Gustavo Noronha.
8536 https://bugs.webkit.org/show_bug.cgi?id=15616
8537 [GTK] Add spell checking
8539 Add enable-spell-checking property to WebKitWebSettings and implement
8540 EditorClient::isContinuousSpellCheckingEnabled and
8541 EditorClient::toggleContinuousSpellChecking to allow the UI to
8542 enable check as you type spell checking.
8544 * WebCoreSupport/EditorClientGtk.cpp:
8545 (WebKit::EditorClient::isContinuousSpellCheckingEnabled):
8546 (WebKit::EditorClient::toggleContinuousSpellChecking):
8547 * webkit/webkitwebsettings.cpp:
8548 (_WebKitWebSettingsPrivate::):
8549 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
8550 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
8551 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
8552 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
8554 2009-04-21 Xan Lopez <xlopez@igalia.com>
8556 Reviewed by Gustavo Noronha.
8558 https://bugs.webkit.org/show_bug.cgi?id=21546
8559 [GTK] ATK accessibility enhancements
8561 Implement window<->screen coordinate transformation functions.
8563 * WebCoreSupport/ChromeClientGtk.cpp:
8564 (WebKit::widgetScreenPosition):
8565 (WebKit::ChromeClient::windowToScreen):
8566 (WebKit::ChromeClient::screenToWindow):
8568 2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8570 Reviewed by Xan Lopez.
8572 https://bugs.webkit.org/show_bug.cgi?id=24786
8573 WebKitDownload sometimes suggests peculiar filenames
8575 Remove query and ref from the URI that is to be downloaded when
8576 using it to provide a file name suggestion.
8578 * webkit/webkitdownload.cpp:
8579 (_WebKitDownloadPrivate::webkit_download_set_property):
8581 2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8583 Reviewed by Xan Lopez.
8585 Handle the case when the plugin view is destroyed during
8586 didReceiveResponse, to avoid crashing.
8588 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8589 (WebKit::FrameLoaderClient::committedLoad):
8591 2009-04-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8593 Reviewed by Alexey Proskuryakov.
8595 https://bugs.webkit.org/show_bug.cgi?id=25251
8596 Crash when frame creation removes it from the parent
8598 This brings us up-to-date with the expectations of sub-frame
8599 creation, following what Mac has done. It fixes crashes when
8600 calling init on the child frame removes it from the page.
8602 This makes the following test pass instead of crash:
8604 fast/loader/frame-creation-removal.html
8606 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8607 (WebKit::FrameLoaderClient::createFrame):
8609 2009-04-16 Christian Dywan <christian@twotoasts.de>
8611 Reviewed by Holger Freyther.
8613 http://bugs.webkit.org/show_bug.cgi?id=25042
8614 destroying webview widget directly causes crash.
8616 * tests/testwebframe.c:
8617 (test_webkit_web_frame_create_destroy): Add a test case for destroying
8618 a web view shortly after packing it in a window.
8620 2009-04-16 Xan Lopez <xlopez@igalia.com>
8622 Reviewed by Sam Weinig.
8624 https://bugs.webkit.org/show_bug.cgi?id=25241
8625 Remove superfluous NotImplemented.h includes.
8627 * webkit/webkitprivate.cpp:
8629 2009-04-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8631 Unreviewed. Update gtk-doc control and base sgml files for 1.1.5.
8633 * docs/webkitgtk-docs.sgml:
8634 * docs/webkitgtk-sections.txt:
8636 2009-04-14 Xan Lopez <xlopez@igalia.com>
8638 * NEWS: updated for 1.1.5 release.
8640 2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8642 Reviewed by Holger Freyther.
8644 https://bugs.webkit.org/show_bug.cgi?id=22898
8645 [GTK] need proper API for printing
8647 Added simple printing unit tests.
8649 * tests/testwebframe.c:
8650 (print_requested_cb):
8652 (test_webkit_web_frame_printing):
8655 2009-04-13 Gustavo Noronha Silva <gns@gnome.org>
8657 Reviewed by Holger Freyther.
8659 https://bugs.webkit.org/show_bug.cgi?id=22898
8660 [GTK] need proper API for printing
8662 Implement proper printing API, using the GTK+ printing API.
8664 * WebCoreSupport/ChromeClientGtk.cpp:
8665 (WebKit::ChromeClient::print):
8666 * webkit/webkitprivate.h:
8667 * webkit/webkitwebframe.cpp:
8668 * webkit/webkitwebframe.h:
8669 * webkit/webkitwebview.cpp:
8671 2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8673 Reviewed by Holger Freyther.
8675 https://bugs.webkit.org/show_bug.cgi?id=25124
8676 [GTK] many strings still missing translation calls
8678 Mark the missing strings for translation.
8680 * webkit/webkitdownload.cpp:
8681 (_WebKitDownloadPrivate::webkit_download_cancel):
8682 * webkit/webkitsoupauthdialog.c:
8684 * webkit/webkitwebhistoryitem.cpp:
8685 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
8686 * webkit/webkitwebinspector.cpp:
8687 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
8688 * webkit/webkitwebnavigationaction.cpp:
8689 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
8690 * webkit/webkitwebsettings.cpp:
8691 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
8692 * webkit/webkitwebview.cpp:
8694 2009-04-08 Alejandro Piñeiro <apinheiro@igalia.com>
8696 Reviewed by Holger Freyther.
8698 https://bugs.webkit.org/show_bug.cgi?id=21546
8699 [GTK] ATK accessibility enhancements
8701 Use getOrCreate instead of just get, as we need to actually create
8702 the wrapper object the first time this function is called.
8704 * webkit/webkitwebview.cpp:
8706 2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8708 Rubber-stamped by Sam Weinig.
8710 https://bugs.webkit.org/show_bug.cgi?id=20575
8711 No localization in WebKitGtk
8713 Implemented localization support for WebKitGTK+.
8715 * WebCoreSupport/ChromeClientGtk.cpp:
8716 * WebCoreSupport/ContextMenuClientGtk.cpp:
8717 * po/POTFILES: Added.
8719 * po/webkit.pot: Added.
8720 * webkit/webkitdownload.cpp:
8721 (_WebKitDownloadPrivate::webkit_download_class_init):
8722 * webkit/webkitprivate.cpp:
8724 * webkit/webkitwebframe.cpp:
8726 2009-04-05 Xan Lopez <xlopez@igalia.com>
8728 Reviewed by Holger Freyther.
8730 https://bugs.webkit.org/show_bug.cgi?id=25042
8731 destroying webview widget directly causes crash.
8733 Do not connect the WebView to its own screen-changed signal, set a
8734 default handler instead.
8736 * webkit/webkitwebview.cpp:
8738 2009-04-05 Xan Lopez <xlopez@igalia.com>
8740 Reviewed by Holger Freyther.
8742 https://bugs.webkit.org/show_bug.cgi?id=25042
8743 destroying webview widget directly causes crash.
8745 GtkWidget::screen-changed can be emitted when a widget is being
8746 destroyed, protect against it.
8748 * webkit/webkitwebview.cpp:
8750 2009-04-05 Jan Michael Alonzo <jmalonzo@webkit.org>
8752 Reviewed by Holger Freyther.
8754 [Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
8755 https://bugs.webkit.org/show_bug.cgi?id=24487
8757 Updated documentation and put more information about the
8758 private-browsing setting for WebKitGtk.
8760 * webkit/webkitwebsettings.cpp:
8761 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
8763 2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8765 Reviewed by Holger Freyther.
8767 Remove pre-processor checks for GTK+ >= 2.10, since we now require
8768 at least that version.
8770 * WebCoreSupport/EditorClientGtk.cpp:
8771 (WebKit::clipboard_clear_contents_cb):
8772 (WebKit::EditorClient::respondToChangedSelection):
8773 * webkit/webkitwebframe.cpp:
8774 * webkit/webkitwebview.cpp:
8776 2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8778 Reviewed by Alexey Proskuryakov.
8780 https://bugs.webkit.org/show_bug.cgi?id=24844
8781 Unit test WebKitDownload
8783 Extra checks to avoid crashing and a critical message when
8784 property accessor functions are called before the download is
8787 * webkit/webkitdownload.cpp:
8788 (_WebKitDownloadPrivate::webkit_download_get_progress):
8789 (_WebKitDownloadPrivate::webkit_download_get_elapsed_time):
8791 2009-04-01 Christian Dywan <christian@twotoasts.de>
8793 Reviewed by Holger Freyther.
8795 * tests/testdownload.c: Added.
8796 (test_webkit_download_create):
8797 (main): Add an initial unit test for downloading.
8799 2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8801 Unreviewed typo fixes, and naming normalization in the
8804 * docs/webkitenvironment.xml:
8805 * webkit/webkitwebview.cpp:
8807 2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8809 Reviewed by Holger Freyther.
8811 Updated gtk-doc configuration files for the 1.1.1, 1.1.2, 1.1.3,
8812 and 1.1.4 versions of WebKitGTK+.
8814 * docs/webkitgtk-docs.sgml:
8815 * docs/webkitgtk-sections.txt:
8817 2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8819 Reviewed by Holger Freyther.
8821 https://bugs.webkit.org/show_bug.cgi?id=17045
8824 Added header documentation for WebKitWebNavigationAction and
8825 WebKitWebPolicyDecision.
8827 Added missing documentation pieces for WebKitSoupAuthDialog,
8828 WebKitDownload and WebKitWebPolicyDecision.
8830 Wrote a section about using the WEBKIT_DEBUG environment variable.
8832 * docs/GNUmakefile.am:
8833 * docs/webkitenvironment.xml: Added.
8834 * docs/webkitgtk-docs.sgml:
8835 * webkit/webkitdownload.cpp:
8836 * webkit/webkitsoupauthdialog.c:
8837 * webkit/webkitwebnavigationaction.cpp:
8838 * webkit/webkitwebpolicydecision.cpp:
8840 2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8842 Reviewed by Holger Freyther.
8844 Integrate gtk-doc into the Gtk+ buildsystem.
8846 Based on original work by Holger Freyther.
8848 Integrate gtk-doc into our buildsystem. We are forced to
8849 use recursive make for gtk-doc itself as the to be installed
8850 gtk-doc.make (done by gtkdocize) is not working in a non
8851 recursive environment.
8853 The documentation can only be generated when srcdir == builddir.
8854 In all other cases the generated files will not be found. This
8855 limitation can be found in pango and gtk+ as well. There is no
8856 easy way around. The resulting html documentation will be saved
8857 in the srcdir as well.
8859 * docs/GNUmakefile.am: Added.
8860 * docs/version.xml.in: Added.
8861 * docs/webkitgtk-docs.sgml:
8863 2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8865 Unreviewed. Documenting what changed since the 1.1.3 release, in
8870 2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
8872 Unreviewed. Add information on the bug-fix-only 1.1.3 release.
8876 2009-03-30 Xan Lopez <xlopez@igalia.com>
8878 Reviewed by Holger Freyther.
8880 https://bugs.webkit.org/show_bug.cgi?id=24878
8881 [GTK] Use GtkBinding system to handle key events in WebView
8883 Use GtkBinding system for key events in WebKitWebView. Allows the
8884 user to reconfigure the bindings and fixes a bunch of bugs along
8885 the way (we were not checking modifier keys in most actions).
8887 * webkit/webkitwebview.cpp:
8888 (webkit_web_view_move_cursor):
8889 * webkit/webkitwebview.h:
8890 * webkitmarshal.list:
8892 2009-03-28 Xan Lopez <xlopez@igalia.com>
8894 Reviewed by Mark Rowe.
8896 https://bugs.webkit.org/show_bug.cgi?id=24790
8897 [GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function
8899 Set the right visibility to the WebKitSoupAuthDialog get_type
8902 * webkit/webkitsoupauthdialog.h:
8904 2009-03-28 Jan Michael Alonzo <jmalonzo@webkit.org>
8906 Gtk build fix. Not reviewed.
8908 FrameLoader::loadURL and FrameLoader::detachChildren went private
8909 per changes in http://trac.webkit.org/changeset/42055. Follow
8910 Mac's behaviour and use FrameLoader::loadURLIntoChildFrame for
8911 loadURL and FrameLoader::detachParent for detachChildrem.
8913 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8914 (WebKit::FrameLoaderClient::createFrame):
8915 * webkit/webkitwebview.cpp:
8917 2009-03-25 Gustavo Noronha Silva <gns@gnome.org>
8919 Reviewed by Holger Freyther.
8921 https://bugs.webkit.org/show_bug.cgi?id=15793
8922 [GTK] tooltip position doesn't update when hovering consecutive links
8924 Work-around tooltips not updating their location when the elements
8925 are consecutive, by clearing the tooltip when handling
8926 mouseDidMoveOverElement.
8928 * WebCoreSupport/ChromeClientGtk.cpp:
8929 (WebKit::ChromeClient::mouseDidMoveOverElement):
8931 2009-03-23 Alejandro Garcia Castro <alex@igalia.com>
8933 Reviewed by Holger Freyther.
8935 [Gtk] Current API does not allow us to open target="_blank" links
8936 in new tabs instead of windows
8937 https://bugs.webkit.org/show_bug.cgi?id=23932
8939 Added a signal to the API (new-window-policy-decision-requested)
8940 that allows the browser to decide the policy for the new window
8941 request, if the signal is not handled we open the new window as
8944 * WebCoreSupport/FrameLoaderClientGtk.cpp:
8945 (WebKit::getNavigationAction):
8946 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
8947 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
8948 * webkit/webkitwebview.cpp:
8950 2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>
8952 Not reviewed. Fix style issues with my previous commit (r41866) as
8953 suggested by Holger in https://bugs.webkit.org/show_bug.cgi?id=24493
8955 * tests/testwebhistoryitem.c:
8956 (test_webkit_web_history_item_get_data):
8957 (test_webkit_web_history_item_alternate_title):
8959 2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>
8961 Reviewed by Holger Freyther.
8963 [GTK] Misc patches for WebKitWebHistoryItem
8964 https://bugs.webkit.org/show_bug.cgi?id=24493
8966 Add unit test for WebKitWebHistoryItem
8968 * tests/testwebhistoryitem.c: Added.
8969 (web_history_item_fixture_setup):
8970 (web_history_item_fixture_teardown):
8971 (test_webkit_web_history_item_get_data):
8972 (test_webkit_web_history_item_alternate_title):
8975 2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>
8977 Reviewed by Holger Freyther.
8979 Separate gtk unit tests
8980 https://bugs.webkit.org/show_bug.cgi?id=24039
8982 Split the current single-file unit test to make it more
8983 modularized and manageable in the future as more unit tests are
8986 * tests/main.c: Removed.
8987 * tests/testwebbackforwardlist.c: Copied from WebKit/gtk/tests/main.c.
8989 * tests/testwebframe.c: Copied from WebKit/gtk/tests/main.c.
8992 2009-03-16 Christian Dywan <christian@twotoasts.de>
8994 Reviewed by Adam Roben.
8996 [gtk] API implementation: url and title
8997 http://bugs.webkit.org/show_bug.cgi?id=14807
8999 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9000 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
9001 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
9002 (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
9003 * webkit/webkitwebview.cpp:
9004 * webkit/webkitwebview.h: Implement "title" and "uri" properties as well
9005 as according functions. "uri" always reflects the current location
9006 including navigation inside the same page. title-changed is deprecated.
9008 2009-03-15 Gustavo Noronha Silva <gns@gnome.org>
9010 Reviewed by Anders Carlsson.
9012 Fix default policy decision to be ignore, on MIME checks, if
9013 WebKit doesn't know how to handle the MIME type. The documentation
9014 is already correct, and this was an oversight when the policy
9015 decision code was first committed. Since 1.1.2 will be the first
9016 release to support download, there is no practical change in
9019 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9020 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
9022 2009-03-15 Xan Lopez <xlopez@igalia.com>
9024 * NEWS: update for 1.1.2.
9026 2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>
9028 Reviewed by Holger Freyther.
9030 [GTK] use of confirm dialog (yes/no) causes segfault
9031 https://bugs.webkit.org/show_bug.cgi?id=20940
9033 Change the script-confirm marshaller from OBJECT,STRING,BOOLEAN to
9034 OBJECT,STRING,POINTER
9036 * webkit/webkitwebview.cpp:
9037 * webkitmarshal.list:
9039 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
9041 Reviewed by Alexey Proskuryakov.
9043 https://bugs.webkit.org/show_bug.cgi?id=24553
9044 [GTK] Improvements to WebKitDownload
9046 Rename 'state' to 'status' to match the naming in the frame
9047 loader rework that we plan to land soonish, and make it a
9048 property, for the same reason.
9050 * webkit/webkitdownload.cpp:
9051 (_WebKitDownloadPrivate::):
9052 (_WebKitDownloadPrivate::webkit_download_finalize):
9053 (_WebKitDownloadPrivate::webkit_download_get_property):
9054 (_WebKitDownloadPrivate::webkit_download_set_property):
9055 (_WebKitDownloadPrivate::webkit_download_class_init):
9056 (_WebKitDownloadPrivate::webkit_download_init):
9057 (_WebKitDownloadPrivate::webkit_download_start):
9058 (_WebKitDownloadPrivate::webkit_download_cancel):
9059 (_WebKitDownloadPrivate::webkit_download_set_destination_uri):
9060 (_WebKitDownloadPrivate::webkit_download_get_status):
9061 (_WebKitDownloadPrivate::webkit_download_set_status):
9062 (_WebKitDownloadPrivate::webkit_download_received_data):
9063 (_WebKitDownloadPrivate::webkit_download_finished_loading):
9064 (_WebKitDownloadPrivate::webkit_download_error):
9065 * webkit/webkitdownload.h:
9067 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
9069 Reviewed by Alexey Proskuryakov.
9071 https://bugs.webkit.org/show_bug.cgi?id=24553
9072 [GTK] Improvements to WebKitDownload
9074 Improved documentation for the download-requested signal, to make
9077 * webkit/webkitwebview.cpp:
9079 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
9081 Reviewed by Alp Toker.
9083 https://bugs.webkit.org/show_bug.cgi?id=24541
9084 Scrolling with home and end keys not always works
9086 Also make page up and page down keys be handled by the webview key
9087 event code, so that they also work in cases where the GTK+
9088 scrollbars don't handle them directly, like in the bugzill's patch
9091 * webkit/webkitwebview.cpp:
9093 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
9095 Reviewed by Alp Toker.
9097 https://bugs.webkit.org/show_bug.cgi?id=24541
9098 Scrolling with home and end keys not always works
9100 Make home and end keys behave more consistently for scrolling the
9103 * webkit/webkitwebview.cpp:
9105 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
9107 Reviewed by Alp Toker.
9109 https://bugs.webkit.org/show_bug.cgi?id=24254
9110 [GTK] spacebar doesn't scroll down
9112 Make spacebar and shift+spacebar scroll like page up and down
9115 * webkit/webkitwebview.cpp:
9117 2009-03-10 Xan Lopez <xlopez@igalia.com>
9119 Reviewed by Holger Freyther.
9121 https://bugs.webkit.org/show_bug.cgi?id=24493
9122 [GTK] Misc patches for WebKitWebHistoryItem
9124 Only run code in dispose once per instance.
9126 * webkit/webkitwebhistoryitem.cpp:
9127 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
9129 2009-03-10 Xan Lopez <xlopez@igalia.com>
9131 Reviewed by Holger Freyther.
9133 https://bugs.webkit.org/show_bug.cgi?id=24493
9134 [GTK] Misc patches for WebKitWebHistoryItem
9136 Call deref() on our internal HistoryItem on dispose, as we always
9137 acquire it with a releaseRef() call to a PassRefPtr, which passes
9140 * webkit/webkitwebhistoryitem.cpp:
9141 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
9143 2009-03-10 Xan Lopez <xlopez@igalia.com>
9145 Reviewed by Holger Freyther.
9147 https://bugs.webkit.org/show_bug.cgi?id=24493
9148 [GTK] Misc patches for WebKitWebHistoryItem
9150 return foo? foo : NULL == return foo
9152 * webkit/webkitwebhistoryitem.cpp:
9155 2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
9157 Reviewed by Holger Freyther.
9159 Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
9160 https://bugs.webkit.org/show_bug.cgi?id=24487
9162 Add private browsing option "enable-private-browsing" to WebKitWebSettings.
9164 * webkit/webkitwebsettings.cpp:
9165 (_WebKitWebSettingsPrivate::):
9166 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
9167 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
9168 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
9169 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
9170 * webkit/webkitwebview.cpp:
9172 2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
9174 Reviewed by Holger Freyther.
9176 [GTK] BackForward history leak?
9177 https://bugs.webkit.org/show_bug.cgi?id=19528
9179 Don't ref the history items when returning the back/forward list
9180 Added test_webkit_web_history_item_lifetime test case for this.
9183 (test_webkit_web_history_item_lifetime):
9184 (test_webkit_web_back_forward_list_order): Style fix.
9185 (test_webkit_web_back_forward_list_add_item): Style fix.
9187 * webkit/webkitwebbackforwardlist.cpp:
9188 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
9189 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
9191 2009-03-10 Xan Lopez <xlopez@igalia.com>
9193 Reviewed by Alexey Proskuryakov.
9195 https://bugs.webkit.org/show_bug.cgi?id=24493
9196 [GTK] Misc patches for WebKitWebHistoryItem
9198 Use g_hash_table_new_full so we can save the manual unref on the
9199 values when removing them from the table.
9201 * webkit/webkitwebhistoryitem.cpp:
9202 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
9204 2009-03-10 Xan Lopez <xan@gnome.org>
9206 Reviewed by Alexey Proskuryakov.
9208 https://bugs.webkit.org/show_bug.cgi?id=24493
9209 [GTK] Misc patches for WebKitWebHistoryItem
9211 Use 'if (foo)' instead of 'if (foo != NULL)', per coding style
9214 * webkit/webkitwebhistoryitem.cpp:
9215 (_WebKitWebHistoryItemPrivate::webkit_history_item_remove):
9216 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title):
9217 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title):
9218 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri):
9219 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri):
9220 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time):
9221 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target):
9222 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
9223 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):
9225 2009-03-10 Xan Lopez <xlopez@igalia.com>
9227 Reviewed by Alexey Proskuryakov.
9229 Correct return value to false instead of NULL.
9231 * webkit/webkitwebhistoryitem.cpp:
9232 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
9234 2009-03-08 Holger Hans Peter Freyther <zecke@selfish.org>
9236 Reviewed by Mark Rowe.
9238 Add javascript-profiling-enabled property and implement it. This
9239 will enable/disable the profiler on the InstpectorController.
9241 * webkit/webkitprivate.h:
9242 * webkit/webkitwebinspector.cpp:
9243 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
9244 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property):
9245 (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property):
9246 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_inspector_client):
9247 * webkit/webkitwebview.cpp:
9249 2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
9253 https://bugs.webkit.org/show_bug.cgi?id=24295
9254 webkit_web_back_forward_list_add_item needs a Since tag
9256 Add missing Since tag to webkit_web_back_forward_list_add_item
9259 * webkit/webkitwebbackforwardlist.cpp:
9261 2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
9263 Reviewed by Mark Rowe.
9265 https://bugs.webkit.org/show_bug.cgi?id=24417
9266 [GTK] WebKitDownload's _cancel and _dispose methods may emit warnings
9268 NULL-check for timer on _cancel and _dispose, to avoid bad
9271 * webkit/webkitdownload.cpp:
9272 (_WebKitDownloadPrivate::webkit_download_finalize):
9273 (_WebKitDownloadPrivate::webkit_download_cancel):
9275 2009-03-02 Xan Lopez <xan@gnome.org>
9277 Reviewed by Mark Rowe.
9279 https://bugs.webkit.org/show_bug.cgi?id=24287
9280 [GTK] Move auth dialog feature to WebKit/
9282 Add WebKitSoupAuthDialog and add it to the session in webkit_init.
9284 * webkit/webkitprivate.cpp:
9285 (currentToplevelCallback):
9287 * webkit/webkitsoupauthdialog.c: Added.
9288 (webkit_soup_auth_dialog_class_init):
9289 (webkit_soup_auth_dialog_init):
9290 (webkit_soup_auth_dialog_session_feature_init):
9292 (set_password_callback):
9293 (response_callback):
9296 (find_password_callback):
9297 (session_authenticate):
9299 * webkit/webkitsoupauthdialog.h: Added.
9301 2009-03-03 Gustavo Noronha Silva <gns@gnome.org>
9303 Reviewed by Alexey Proskuryakov.
9305 https://bugs.webkit.org/show_bug.cgi?id=16826
9306 [Gtk] Implement WebKitDownload
9308 Implement download, and provide a nice object wrapping the
9309 download process. Initial work done by Marco Barisione and
9310 Pierre-Luc Beaudoin for Collabora.
9312 * WebCoreSupport/ContextMenuClientGtk.cpp:
9313 (WebKit::ContextMenuClient::downloadURL):
9314 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9315 (WebKit::FrameLoaderClient::download):
9316 (WebKit::FrameLoaderClient::startDownload):
9318 * webkit/webkitdefines.h:
9319 * webkit/webkitdownload.cpp: Added.
9320 (_WebKitDownloadPrivate::):
9321 (_WebKitDownloadPrivate::webkit_download_dispose):
9322 (_WebKitDownloadPrivate::webkit_download_finalize):
9323 (_WebKitDownloadPrivate::webkit_download_get_property):
9324 (_WebKitDownloadPrivate::webkit_download_set_property):
9325 (_WebKitDownloadPrivate::webkit_download_class_init):
9326 (_WebKitDownloadPrivate::webkit_download_init):
9327 (_WebKitDownloadPrivate::webkit_download_new):
9328 (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri):
9329 (_WebKitDownloadPrivate::webkit_download_close_stream):
9330 (_WebKitDownloadPrivate::webkit_download_start):
9331 (_WebKitDownloadPrivate::webkit_download_cancel):
9332 (_WebKitDownloadPrivate::webkit_download_get_uri):
9333 (_WebKitDownloadPrivate::webkit_download_get_network_request):
9334 (_WebKitDownloadPrivate::webkit_download_set_response):
9335 (_WebKitDownloadPrivate::webkit_download_get_suggested_filename):
9336 (_WebKitDownloadPrivate::webkit_download_get_destination_uri):
9337 (_WebKitDownloadPrivate::webkit_download_set_destination_uri):
9338 (_WebKitDownloadPrivate::webkit_download_get_state):
9339 (_WebKitDownloadPrivate::webkit_download_get_total_size):
9340 (_WebKitDownloadPrivate::webkit_download_get_current_size):
9341 (_WebKitDownloadPrivate::webkit_download_get_progress):
9342 (_WebKitDownloadPrivate::webkit_download_get_elapsed_time):
9343 (_WebKitDownloadPrivate::webkit_download_received_data):
9344 (_WebKitDownloadPrivate::webkit_download_finished_loading):
9345 (_WebKitDownloadPrivate::webkit_download_error):
9346 (_WebKitDownloadPrivate::DownloadClient::DownloadClient):
9347 (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse):
9348 (_WebKitDownloadPrivate::DownloadClient::didReceiveData):
9349 (_WebKitDownloadPrivate::DownloadClient::didFinishLoading):
9350 (_WebKitDownloadPrivate::DownloadClient::didFail):
9351 (_WebKitDownloadPrivate::DownloadClient::wasBlocked):
9352 (_WebKitDownloadPrivate::DownloadClient::cannotShowURL):
9353 * webkit/webkitdownload.h: Added.
9354 * webkit/webkitprivate.h:
9355 * webkit/webkitwebview.cpp:
9356 * webkitmarshal.list:
9358 2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
9360 Reviewed by Holger Freyther.
9362 [Gtk] get the HTTP layout tests going
9363 https://bugs.webkit.org/show_bug.cgi?id=24259
9365 Added API to get the response mime type from a frame. We need this
9366 so we can decide if we need to dump the frame as text or its
9369 * webkit/webkitprivate.h:
9370 * webkit/webkitwebframe.cpp:
9372 2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
9374 Reviewed by Holger Freyther.
9376 [Gtk] get the HTTP layout tests going
9377 https://bugs.webkit.org/show_bug.cgi?id=24259
9379 Create a WebKitWebHistoryItem for each WebCore::HistoryItem when
9381 Add necessary API additions for us to be able to dump a WebKitWebHistoryItem
9383 * webkit/webkitprivate.h:
9384 * webkit/webkitwebbackforwardlist.cpp:
9385 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
9386 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
9387 * webkit/webkitwebhistoryitem.cpp:
9388 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
9389 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new):
9390 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
9391 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target):
9392 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
9393 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):
9397 2009-03-01 Christian Dywan <christian@twotoasts.de>
9399 Reviewed by Holger Freyther.
9401 * webkit/webkitprivate.h:
9402 * webkit/webkitwebview.cpp:
9403 (webkit_web_view_get_encoding):
9404 * webkit/webkitwebview.h: Implement 'encoding' and 'custom-encoding'
9405 properties as well as webkit_web_view_get_encoding.
9407 2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
9409 Unreviewed simple wording fix for the NEWS file.
9413 2009-03-01 Xan Lopez <xan@gnome.org>
9415 Add NEWS file to track progress between releases.
9419 2009-02-28 Christian Dywan <christian@twotoasts.de>
9421 Reviewed by Holger Freyther.
9423 * webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a
9424 locale path is passed for compatibility, since we used to support that.
9426 2009-02-27 Gustavo Noronha Silva <gns@gnome.org>
9428 Reviewed by David Hyatt.
9430 Automatically ignore empty requests to avoid crashing. This fixes
9431 the crash in fast/loader/empty-embed-src-attribute.html.
9433 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9434 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
9435 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
9436 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
9438 2009-02-27 Xan Lopez <xan@gnome.org>
9440 Reviewed by Alexey Proskuryakov.
9442 https://bugs.webkit.org/show_bug.cgi?id=24221
9443 [GTK] Do not emit load-finished when being disposed
9445 webkit_web_view_stop_load() is called from dispose() on
9446 WebKitWebView. This eventually calls postProgressFinishedNotification
9447 in FrameLoaderClientGtk, which emits load-finished. Add
9448 a 'disposing' flag to WebView that we can check here, so
9449 we avoid emitting signals on objects on their way to be
9450 destroyed. This fixes a bunch of critical warnings when
9451 closing a loading WebView.
9453 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9454 (WebKit::FrameLoaderClient::postProgressFinishedNotification):
9455 * webkit/webkitprivate.h:
9456 * webkit/webkitwebview.cpp:
9458 2009-02-27 Xan Lopez <xan@gnome.org>
9460 Rubber-stamped by Alexey Proskuryakov.
9462 https://bugs.webkit.org/show_bug.cgi?id=24222
9463 [GTK] Remove checks for old glib versions
9465 libsoup, which is a hard dependency, needs at least glib 2.15.3,
9466 so remove all glib checks for versions older than that.
9468 * webkit/webkitwebview.cpp:
9470 2009-02-26 Xan Lopez <xan@gnome.org>
9472 Reviewed by Holger Freyther.
9474 https://bugs.webkit.org/show_bug.cgi?id=16947
9475 [GTK] Missing HTTP Auth challenge
9477 Add new marshalers list.
9479 * webkitmarshal.list: Added.
9481 2009-02-26 Xan Lopez <xan@gnome.org>
9483 Reviewed by Alexey Proskuryakov.
9485 https://bugs.webkit.org/show_bug.cgi?id=24193
9486 [GTK] Checkbuttons not activated with space
9488 Do not swallow key events with GtkIMContext for non-editable
9491 * WebCoreSupport/EditorClientGtk.cpp:
9492 (WebKit::EditorClient::handleInputMethodKeydown):
9494 2009-02-26 Xan Lopez <xan@gnome.org>
9496 Reviewed by Alexey Proskuryakov.
9498 https://bugs.webkit.org/show_bug.cgi?id=24103
9499 [GTK] Use correct return value for WebView button-release handler
9501 We are returning whatever the core code tells us it did, but this
9502 does not play well with the GTK+ model. GTK+ in general expects it
9503 will see a button-release if it saw a button-press and no
9504 motion/leave/etc events in between. EventHandler.cpp will, in some
9505 cases, not handle press but handle release, confusing the parent
9506 container of the WebView.
9508 As a workaround return always FALSE for button-release (this is
9509 the same than the Windows port does).
9511 * webkit/webkitwebview.cpp:
9513 2009-02-26 Xan Lopez <xan@gnome.org>
9515 Reviewed by Holger Freyther.
9517 https://bugs.webkit.org/show_bug.cgi?id=17585
9518 [gtk] get|set encoding api
9520 Add functions to get and set a custom encoding an a view.
9522 * webkit/webkitprivate.h:
9523 * webkit/webkitwebview.cpp:
9524 (webkit_web_view_set_custom_encoding):
9525 (webkit_web_view_get_custom_encoding):
9526 * webkit/webkitwebview.h:
9528 2009-02-23 Xan Lopez <xan@gnome.org>
9530 Reviewed by Alexey Proskuryakov.
9532 https://bugs.webkit.org/show_bug.cgi?id=22624
9533 [SOUP][GTK] Need API to get SoupSession from WebKit.
9535 Add API to get the default soup session.
9537 * webkit/webkitwebview.cpp:
9538 * webkit/webkitwebview.h:
9540 2009-02-23 Xan Lopez <xan@gnome.org>
9542 Reviewed by Alexey Proskuryakov.
9544 https://bugs.webkit.org/show_bug.cgi?id=22624
9545 [SOUP][GTK] Need API to get SoupSession from WebKit.
9547 Add soup dependency to pc file.
9551 2009-02-23 Jan Michael Alonzo <jmalonzo@webkit.org>
9553 Reviewed by Mark Rowe.
9555 [GTK] Back / Forward history menus are flipped
9556 https://bugs.webkit.org/show_bug.cgi?id=22694
9558 Don't call g_list_reverse when returning the back or forward list.
9561 (test_webkit_web_back_forward_list_order):
9563 * webkit/webkitwebbackforwardlist.cpp:
9564 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
9565 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
9567 2009-02-17 Xan Lopez <xan@gnome.org>
9569 Rubber-stamped by Alexey Proskuryakov.
9571 Restoring change landed in r40715, which was accidentally undone
9574 * webkit/webkitwebframe.cpp:
9576 2009-02-12 Christian Dywan <christian@twotoasts.de>
9578 Reviewed by Holger Freyther.
9580 http://bugs.webkit.org/show_bug.cgi?id=17176
9581 [GTK] API: hovering-over-link and webkit_web_view_open /_load_foo
9583 * webkit/webkitwebframe.cpp:
9584 * webkit/webkitwebframe.h:
9585 * webkit/webkitwebview.cpp:
9586 * webkit/webkitwebview.h: Introduce webkit_web_frame_load_uri,
9587 webkit_web_frame_load_string, webkit_web_view_load_uri and
9588 webkit_web_view_load_request and unify implementations.
9590 2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
9592 Stub out InspectorClient::hiddenPanels.
9594 Reviewed by Timothy Hatcher.
9596 * WebCoreSupport/InspectorClientGtk.cpp:
9597 (WebKit::InspectorClient::hiddenPanels):
9598 * WebCoreSupport/InspectorClientGtk.h:
9600 2009-02-07 Holger Hans Peter Freyther <zecke@selfish.org>
9602 Unreviewed build fix Use toNormalizedRange().
9604 * WebCoreSupport/EditorClientGtk.cpp:
9605 (WebKit::clipboard_get_contents_cb):
9607 2009-02-06 Geoffrey Garen <ggaren@apple.com>
9611 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9612 (WebKit::FrameLoaderClient::updateGlobalHistoryRedirectLinks):
9613 * WebCoreSupport/FrameLoaderClientGtk.h:
9615 2009-02-06 Xan Lopez <xan@gnome.org>
9617 Reviewed by Holger Freyther.
9619 Reported by Daniel Macks.
9621 https://bugs.webkit.org/show_bug.cgi?id=20412
9623 Use positive numbers for the target info IDs, gtk_target_list_add
9624 casts them to 'guint'. Also just start them from 0, since the
9625 values are not relevant or magic in any way, they are just used as
9626 tokens for the user of the API.
9628 * webkit/webkitwebview.h:
9630 2009-02-06 Xan Lopez <xan@gnome.org>
9632 Reviewed by Alexey Proskuryakov.
9634 https://bugs.webkit.org/show_bug.cgi?id=23769
9636 Do not use empty ResourceError errors.
9638 Rather create bogus but non-null errors, since some codepaths
9639 expect these. For example, see DocumentLoader::mainReceivedError.
9641 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9642 (WebKit::FrameLoaderClient::cancelledError):
9643 (WebKit::FrameLoaderClient::blockedError):
9644 (WebKit::FrameLoaderClient::cannotShowURLError):
9645 (WebKit::FrameLoaderClient::interruptForPolicyChangeError):
9646 (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
9647 (WebKit::FrameLoaderClient::fileDoesNotExistError):
9648 (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
9650 2009-02-06 Xan Lopez <xan@gnome.org>
9652 Reviewed by Alexey Proskuryakov.
9654 https://bugs.webkit.org/show_bug.cgi?id=23761
9656 Use two-arg KURL ctor.
9658 We are using the one-arg ctor currently, but:
9660 - It assumes the strings are already encoded, which is not
9661 necesarily the case for us.
9663 - The single-argument KURL ctors expect their input to already be
9664 the output of a previous KURL::parse call, so for the general
9665 case (ie, random user input) we need to use the two-arg ctor
9668 * webkit/webkitwebframe.cpp:
9669 * webkit/webkitwebview.cpp:
9671 2009-02-05 Aaron Boodman <aa@chromium.org>
9673 Reviewed by Dave Hyatt.
9675 https://bugs.webkit.org/show_bug.cgi?id=23708
9676 Adds documentElementAvailable() callback to FrameLoaderClient.
9678 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9679 (WebKit::FrameLoaderClient::documentElementAvailable):
9680 Stub out documentElementAvailable()
9681 * WebCoreSupport/FrameLoaderClientGtk.h:
9684 2009-02-03 Hiroyuki Ikezoe <poincare@ikezoe.net>
9686 Reviewed by Holger Freyther.
9688 https://bugs.webkit.org/show_bug.cgi?id=22988
9689 [GTK] Need a public method to add a WebKitWebHistoryItem to
9690 WebKitWebBackForwardList.
9692 Wrap WebCore::BackForwardList::addItem.
9695 (test_webkit_web_back_forward_list_add_item):
9697 * webkit/webkitwebbackforwardlist.cpp:
9698 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_add_item):
9699 * webkit/webkitwebbackforwardlist.h:
9701 2009-02-02 Geoffrey Garen <ggaren@apple.com>
9705 * webkit/webkitwebview.cpp:
9707 2009-02-02 Geoffrey Garen <ggaren@apple.com>
9711 * webkit/webkitwebframe.cpp:
9713 2009-02-02 Geoffrey Garen <ggaren@apple.com>
9717 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9718 (WebKit::FrameLoaderClient::createFrame):
9720 2009-02-02 Geoffrey Garen <ggaren@apple.com>
9722 Reviewed by Sam Weinig.
9724 Track redirects in global history.
9728 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9729 (WebKit::FrameLoaderClient::createFrame):
9730 (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
9731 * WebCoreSupport/FrameLoaderClientGtk.h:
9733 2009-02-02 Anders Carlsson <andersca@apple.com>
9737 * WebCoreSupport/FrameLoaderClientGtk.h:
9739 2009-02-02 Anders Carlsson <andersca@apple.com>
9741 Reviewed by Dan Bernstein.
9743 Update for changes to WebCore.
9745 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9746 (WebKit::FrameLoaderClient::createPlugin):
9747 (WebKit::FrameLoaderClient::createJavaAppletWidget):
9748 * WebCoreSupport/FrameLoaderClientGtk.h:
9750 2009-02-02 Holger Hans Peter Freyther <zecke@selfish.org>
9752 Reviewed by Darin Adler.
9754 Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
9756 https://bugs.webkit.org/show_bug.cgi?id=23428
9758 FrameView::forceLayout could be killed but the comment might
9759 contain a value over the the plain FrameView::layout...
9761 Adjust the WebCore/WebKit consumers of these methods.
9763 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9764 (WebKit::FrameLoaderClient::forceLayout):
9765 * webkit/webkitwebview.cpp:
9767 2009-01-30 Geoffrey Garen <ggaren@apple.com>
9771 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9772 (WebKit::FrameLoaderClient::createFrame):
9774 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
9776 Reviewed by Simon Hausmann.
9778 https://bugs.webkit.org/show_bug.cgi?id=22056
9780 Kill FrameLoaderClient.cpp, move the code over to Frame::createView
9782 FrameLoaderClient is supposed to be an interface, move the
9783 to be shared code to Frame which is a controller and is
9784 allowed to create a FrameView.
9786 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9787 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
9789 2009-01-27 Brady Eidson <beidson@apple.com>
9791 Reviewed by Dan Bernstein
9793 Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
9795 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9796 (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):
9797 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
9798 * WebCoreSupport/FrameLoaderClientGtk.h:
9800 2009-01-25 Darin Adler <darin@apple.com>
9802 Try to fix GTK build.
9804 * webkit/webkitwebview.cpp: Added include of FloatQuad.h.
9806 2009-01-13 Alexander V. Butenko <alex@digiqube.com>
9808 Reviewed by Holger Freyther.
9810 https://bugs.webkit.org/show_bug.cgi?id=23279
9812 Fix crash on WebView dispose stage.
9814 Add null checks to webkit_web_view_set_scroll_adjustments and
9815 webkit_web_view_get_accessible as they get called from within
9818 * webkit/webkitwebview.cpp:
9820 2009-01-11 Xan Lopez <xan@gnome.org>
9822 Reviewed by Holger Freyther.
9824 Use NULL instead of 0 when dealing with pointers, as agreed for
9825 the coding style of the WebKit GTK port for its GTK+ specific
9828 * webkit/webkitwebview.cpp:
9830 2009-01-11 Xan Lopez <xan@gnome.org>
9832 Reviewed by Holger Freyther.
9834 Add padding to the class structs to avoid breaking ABI each time
9837 * webkit/webkitnetworkrequest.h:
9838 * webkit/webkitwebbackforwardlist.h:
9839 * webkit/webkitwebhistoryitem.h:
9840 * webkit/webkitwebnavigationaction.h:
9841 * webkit/webkitwebpolicydecision.h:
9842 * webkit/webkitwebview.h:
9844 2009-01-09 Benjamin Otte <otte@gnome.org>
9846 Reviewed by Holger Freyther.
9848 https://bugs.webkit.org/show_bug.cgi?id=23194
9850 make the finalize function the dispose function. Not releasing held
9851 objects in dispose can cause crashers later.
9853 * webkit/webkitwebview.cpp:
9855 2009-01-09 Benjamin Otte <otte@gnome.org>
9857 Reviewed by Holger Freyther.
9859 https://bugs.webkit.org/show_bug.cgi?id=23194
9861 Remove broken code that uses a fallback. The previous code did 2
9862 policy decisions which caused crashes.
9863 Download is still notImplemented();
9865 * webkit/webkitwebpolicydecision.cpp:
9866 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download):
9868 2009-01-03 Xan Lopez <xan@gnome.org>
9870 Reviewed by Holger Freyther.
9872 [GTK] Need a public method to reload view bypassing cache
9873 https://bugs.webkit.org/show_bug.cgi?id=19815
9875 * webkit/webkitwebview.cpp:
9876 * webkit/webkitwebview.h:
9878 Add webkit_web_view_reload_bypass_cache.
9880 2009-01-07 Holger Hans Peter Freyther <zecke@selfish.org>
9882 Reviewed by Maciej Stachowiak.
9884 Add private API to get the number of active animations of
9885 a frame. This is required by the DumpRenderTree utility.
9887 * webkit/webkitprivate.h:
9888 * webkit/webkitwebframe.cpp:
9890 2009-01-05 Adam Treat <adam.treat@torchmobile.com>
9894 * WebCoreSupport/ChromeClientGtk.h:
9896 2009-01-05 Adam Treat <adam.treat@torchmobile.com>
9898 Reviewed by George Staikos.
9900 Build fix for contentsSizeChanged
9902 * WebCoreSupport/ChromeClientGtk.cpp:
9903 (WebKit::ChromeClient::contentsSizeChanged):
9904 * WebCoreSupport/ChromeClientGtk.h:
9906 2009-01-04 Adam Treat <adam.treat@torchmobile.com>
9908 Reviewed by George Staikos.
9910 Make the gtk port build with the new fixedLayoutSize feature
9912 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9913 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
9915 2009-01-03 Holger Hans Peter Freyther <zecke@selfish.org>
9917 Reviewed by Darin Adler.
9919 [GTK] Fix the reference counting of WebKitWebFrames
9921 The ownership is the following: WebKitWebView owns a WebCore::Page.
9922 WebKitWebView is creating one WebKitWebFrame which will be the
9923 mainFrame of the WebCore::Page (having the reference on the Frame).
9925 The FrameLoaderClient has the reference of the WebKitWebFrame for
9926 the main frame and also any other frame. This means when the
9927 WebCore::Frame goes away the FrameLoaderClient will go away which
9928 will normally remove the last reference of the WebKitWebFrame. Because
9929 an API user might have g_object_ref'ed the WebKitWebFrame null
9930 checks had to be added to WebKitWebFrame.
9932 For WebCore::Frames created by the FrameLoaderClient the ownership
9933 will be passed down to the FrameTree, the WebKitWebFrame is not holding
9934 a reference to the WebCore::Frame.
9936 Do not g_object_unref the mainFrame in the destructor of the
9937 WebKitWebFrame as this will happen from within the WebCore::Page
9938 destruction. Do not hold a reference to the WebCore::Frame (circle) in
9939 WebKitWebFrame, add null checks as the WebCore::Frame might have gone
9940 away. Do not keep track of the FrameLoaderClient in the private
9941 structures as it was mostly unusued.
9943 https://bugs.webkit.org/show_bug.cgi?id=21837
9945 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9946 (WebKit::FrameLoaderClient::frameLoaderDestroyed):
9947 (WebKit::FrameLoaderClient::createFrame):
9948 * tests/main.c: Add test case.
9949 (test_webkit_web_frame_create_destroy):
9950 (test_webkit_web_frame_lifetime):
9952 * webkit/webkitprivate.cpp:
9954 * webkit/webkitprivate.h:
9955 * webkit/webkitwebframe.cpp:
9956 * webkit/webkitwebview.cpp:
9958 2009-01-02 Holger Hans Peter Freyther <zecke@selfish.org>
9960 Unreviewed build fix.
9962 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9964 2008-12-31 Holger Hans Peter Freyther <zecke@selfish.org>
9966 Reviewed by Nikolas Zimmermann.
9968 https://bugs.webkit.org/show_bug.cgi?id=17045
9970 Add section information for View, Frame, Settings, HistoryItem, BackForwardList, WindowFeatures and Inspector
9972 Add section information and informal examples for WebKitWebView,
9973 WebKitWebFrame, WebKitWebSettings, WebKitWebNetworkRequest,
9974 WebKitWebWindowFeatures, WebKitWebHistoryItem,
9975 WebKitWebBackForwardList and WebKitWebInspector.
9977 * docs/webkitgtk-sections.txt: Decide to not document some bits
9978 * webkit/webkitnetworkrequest.cpp:
9979 * webkit/webkitwebbackforwardlist.cpp:
9980 * webkit/webkitwebframe.cpp:
9981 * webkit/webkitwebhistoryitem.cpp:
9982 * webkit/webkitwebhistoryitem.h:
9983 * webkit/webkitwebinspector.cpp:
9984 * webkit/webkitwebsettings.cpp:
9985 * webkit/webkitwebsettings.h:
9986 * webkit/webkitwebview.cpp:
9987 * webkit/webkitwebwindowfeatures.cpp:
9989 2008-12-21 Xan Lopez <xan@gnome.org>
9991 Reviewed by Holger Freyther.
9993 https://bugs.webkit.org/show_bug.cgi?id=16092
9994 [GTK] Middle-mouse click should allow opening a URL in a new tab
9996 Add mouse button and keyboard state modifiers info to navigation action.
9998 * WebCoreSupport/FrameLoaderClientGtk.cpp:
9999 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
10000 * webkit/webkitwebnavigationaction.cpp:
10001 (_WebKitWebNavigationActionPrivate::):
10002 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property):
10003 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property):
10004 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
10005 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_button):
10006 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_modifier_state):
10007 * webkit/webkitwebnavigationaction.h:
10009 2008-12-19 Marco Barisione <marco.barisione@collabora.co.uk>
10011 Reviewed by Holger Freyther.
10013 http://bugs.webkit.org/show_bug.cgi?id=16562
10014 [gtk] Implement WebPolicyDelegate methods
10016 Original work by Pierre-Luc Beaudoin. Final touches by Gustavo
10019 This implements the delegates methods of WebPolicyDelegate.
10020 Since Gtk+/C doesn't have delegate methods, they are replaced with
10023 A new object WebKitWebPolicyDecision allows the browser to delay its
10024 response in certain cases. WebKitWebNavigationAction contains the
10025 information about what caused a navigation request.
10027 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10028 (WebKit::FrameLoaderClient::FrameLoaderClient):
10029 (WebKit::FrameLoaderClient::~FrameLoaderClient):
10030 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
10031 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
10032 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
10033 (WebKit::FrameLoaderClient::cancelPolicyCheck):
10034 (WebKit::FrameLoaderClient::canShowMIMEType):
10035 * WebCoreSupport/FrameLoaderClientGtk.h:
10037 * webkit/webkitdefines.h:
10038 * webkit/webkitprivate.cpp:
10041 * webkit/webkitprivate.h:
10042 * webkit/webkitwebnavigationaction.cpp: Added.
10043 (_WebKitWebNavigationActionPrivate::):
10044 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property):
10045 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property):
10046 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_init):
10047 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_finalize):
10048 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
10049 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_reason):
10050 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_reason):
10051 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_original_uri):
10052 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_original_uri):
10053 * webkit/webkitwebnavigationaction.h: Added.
10054 * webkit/webkitwebpolicydecision.cpp: Added.
10055 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_class_init):
10056 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_init):
10057 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_new):
10058 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_use):
10059 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_ignore):
10060 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download):
10061 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_cancel):
10062 * webkit/webkitwebpolicydecision.h: Added.
10063 * webkit/webkitwebview.cpp:
10064 * webkit/webkitwebview.h:
10066 2008-12-18 Dan Bernstein <mitz@apple.com>
10068 Reviewed by Sam Weinig.
10070 - stub out FrameLoaderClient::shouldUseCredentialStorage().
10072 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10073 (WebKit::FrameLoaderClient::shouldUseCredentialStorage):
10074 * WebCoreSupport/FrameLoaderClientGtk.h:
10076 2008-12-18 Sam Weinig <sam@webkit.org>
10078 Reviewed by John Sullivan.
10080 Stub out FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout()
10082 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10083 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
10084 * WebCoreSupport/FrameLoaderClientGtk.h:
10086 2008-12-13 Holger Hans Peter Freyther <zecke@selfish.org>
10088 Reviewed by Cameron Zwarich.
10090 [GTK] Fix crash with LayoutTests/fast/loader/frame-creation-removal.html
10092 Call WebCore::Frame::init after the frame has been given
10093 a name and been added to the FrameTree of the parent.
10095 Removing the call to init is fine as FrameLoaderClientGtk::createFrame
10096 is the only user of webkit_web_frame_init_with_web_view and is already
10097 calling WebCore::Frame::init.
10099 * webkit/webkitwebframe.cpp:
10101 2008-12-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
10103 Reviewed by Holger Freyther.
10105 https://bugs.webkit.org/show_bug.cgi?id=22779
10107 Check for GTK version >= 2.14.0 before using gtk_test_init.
10112 2008-12-13 Zan Dobersek <zandobersek@gmail.com>
10114 Reviewed by Darin Adler.
10116 https://bugs.webkit.org/show_bug.cgi?id=22039
10118 Implement animation and transition pausing as needed by DumpRenderTree.
10120 * webkit/webkitprivate.h:
10121 * webkit/webkitwebframe.cpp:
10123 2008-11-29 Holger Hans Peter Freyther <zecke@selfish.org>
10125 Rubber-stamped by Simon Hausmann.
10127 https://bugs.webkit.org/show_bug.cgi?id=22574
10129 Make webkit_web_view_set_window_features internal
10131 Calling this method will not result in a notify::window-features
10132 signal being emitted. This would allow replacing a
10133 WebKitWebWindowFeature on a WebKitWebView without anyone noticing
10134 and the client code would monitor the wrong object.
10136 * WebCoreSupport/ChromeClientGtk.cpp:
10137 (WebKit::ChromeClient::createWindow):
10138 * webkit/webkitwebview.cpp:
10139 * webkit/webkitwebview.h:
10141 2008-12-09 Brett Wilson <brettw@chromium.org>
10143 Reviewed by Dave Hyatt.
10145 https://bugs.webkit.org/show_bug.cgi?id=22177
10147 Add a callback on ChromeClient that the state of form elements on
10148 the page has changed. This is to allow clients implementing session
10149 saving to know when the current state is dirty.
10151 * WebCoreSupport/ChromeClientGtk.h:
10152 (WebKit::ChromeClient::formStateDidChange):
10154 2008-12-07 Holger Hans Peter Freyther <zecke@selfish.org>
10156 Reviewed by Eric Seidel.
10158 [Gtk+] Use glib's unit test facilities to test the WebKit/Gtk+ API
10160 https://bugs.webkit.org/show_bug.cgi?id=22491
10162 Add the skeleton to WebKit/gtk/tests and integrate that into the
10163 buildsystem. Testing support was added in glib 2.16. For versions
10164 using glib < 2.16 we compile an empty application.
10166 * tests/main.c: Added. https://bugs.webkit.org/show_bug.cgi?id=21837
10167 will be the first consumer.
10170 2008-12-06 Simon Fraser <simon.fraser@apple.com>
10172 Reviewed by Dave Hyatt
10174 https://bugs.webkit.org/show_bug.cgi?id=15671
10176 Renderer::caretRect() is now localCaretRect(), which needs
10177 converting to absolute coordinates (taking transforms into account).
10179 * webkit/webkitwebview.cpp:
10181 2008-12-01 Xan Lopez <xan@gnome.org>
10183 Reviewed by Holger Freyther.
10185 http://bugs.webkit.org/show_bug.cgi?id=22553
10186 Remove unneeded GObject casts.
10188 Remove unneeded casts to GObject in functions that take a gpointer
10191 * WebCoreSupport/ChromeClientGtk.cpp:
10192 (WebKit::ChromeClient::setWindowRect):
10193 (WebKit::ChromeClient::createWindow):
10194 (WebKit::ChromeClient::setToolbarsVisible):
10195 (WebKit::ChromeClient::toolbarsVisible):
10196 (WebKit::ChromeClient::setStatusbarVisible):
10197 (WebKit::ChromeClient::statusbarVisible):
10198 (WebKit::ChromeClient::setScrollbarsVisible):
10199 (WebKit::ChromeClient::scrollbarsVisible):
10200 (WebKit::ChromeClient::setMenubarVisible):
10201 (WebKit::ChromeClient::menubarVisible):
10202 (WebKit::ChromeClient::setToolTip):
10203 * WebCoreSupport/InspectorClientGtk.cpp:
10204 (WebKit::InspectorClient::createPage):
10205 * webkit/webkitwebframe.cpp:
10206 * webkit/webkitwebview.cpp:
10207 * webkit/webkitwebwindowfeatures.cpp:
10208 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features):
10210 2008-11-29 Christian Dywan <christian@twotoasts.de>
10212 Reviewed by Holger Freyther.
10214 http://bugs.webkit.org/show_bug.cgi?id=17122
10215 [GTK] Bad font default settings
10217 Implement a property "enforce-96-dpi" in WebKitWebSettings
10218 that can be enabled to force the view to assume 96 DPI.
10220 * webkit/webkitwebsettings.cpp:
10221 (_WebKitWebSettingsPrivate::):
10222 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
10223 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
10224 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
10225 * webkit/webkitwebview.cpp:
10227 2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>
10229 Reviewed by Nikolas Zimmermann.
10231 Simplify the code. There is no reason to have code like
10232 if (true) return false; which is using temporary variables.
10234 * webkit/webkitwebview.cpp:
10236 2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>
10238 Reviewed by Nikolas Zimmermann.
10240 Remove bogus null checks. The WebKitWebView own's a WebCore::Page
10241 which is owning a WebCore::ChromeClient. There is no way that a
10242 WebCore::ChromeClient is still around when the WebKitWebView is gone.
10244 m_webView can only be null when a ChromeClient gets constructed with
10245 a null WebKitWebView which is not allowed.
10247 * WebCoreSupport/ChromeClientGtk.cpp:
10248 (WebKit::ChromeClient::ChromeClient):
10249 (WebKit::ChromeClient::windowRect):
10250 (WebKit::ChromeClient::setWindowRect):
10251 (WebKit::ChromeClient::pageRect):
10252 (WebKit::ChromeClient::focus):
10253 (WebKit::ChromeClient::unfocus):
10254 (WebKit::ChromeClient::show):
10255 (WebKit::ChromeClient::setToolbarsVisible):
10256 (WebKit::ChromeClient::toolbarsVisible):
10257 (WebKit::ChromeClient::setStatusbarVisible):
10258 (WebKit::ChromeClient::statusbarVisible):
10259 (WebKit::ChromeClient::setScrollbarsVisible):
10260 (WebKit::ChromeClient::setMenubarVisible):
10261 (WebKit::ChromeClient::menubarVisible):
10262 (WebKit::ChromeClient::canTakeFocus):
10263 (WebKit::ChromeClient::repaint):
10264 (WebKit::ChromeClient::scroll):
10265 (WebKit::ChromeClient::platformWindow):
10267 2008-11-28 Gustavo Noronha Silva <gns@gnome.org>
10269 Reviewed and slightly modified by Holger Freyther.
10271 https://bugs.webkit.org/show_bug.cgi?id=19130
10273 ChromeClient::createWindow and friends need to be implemented
10275 Code from Gustavo Noronha and Marco Barisione
10276 <marco.barisione@collabora.co.uk> in this change set.
10278 Implemented all the ChromeClient interfaces needed to have new
10279 window creation functioning and exposed to client code. We
10280 implemented a mirror GObject to the WindowFeatures object provided
10283 * WebCoreSupport/ChromeClientGtk.cpp:
10284 (WebKit::ChromeClient::windowRect):
10285 (WebKit::ChromeClient::setWindowRect):
10286 (WebKit::ChromeClient::unfocus):
10287 (WebKit::ChromeClient::createWindow):
10288 (WebKit::ChromeClient::show):
10289 (WebKit::ChromeClient::setToolbarsVisible):
10290 (WebKit::ChromeClient::toolbarsVisible):
10291 (WebKit::ChromeClient::setStatusbarVisible):
10292 (WebKit::ChromeClient::statusbarVisible):
10293 (WebKit::ChromeClient::setScrollbarsVisible):
10294 (WebKit::ChromeClient::scrollbarsVisible):
10295 (WebKit::ChromeClient::setMenubarVisible):
10296 (WebKit::ChromeClient::menubarVisible):
10297 (WebKit::ChromeClient::setResizable):
10298 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10299 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
10300 (WebKit::FrameLoaderClient::dispatchShow):
10301 (WebKit::FrameLoaderClient::dispatchCreatePage):
10303 * webkit/webkitdefines.h:
10304 * webkit/webkitprivate.h:
10305 * webkit/webkitwebview.cpp:
10306 * webkit/webkitwebview.h:
10307 * webkit/webkitwebwindowfeatures.cpp: Added.
10308 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_class_init):
10309 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_init):
10310 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_finalize):
10311 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_set_property):
10312 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_get_property):
10313 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new):
10314 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features):
10315 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_equal):
10316 * webkit/webkitwebwindowfeatures.h: Added.
10318 2008-11-24 Darin Fisher <darin@chromium.org>
10322 http://bugs.webkit.org/show_bug.cgi?id=15643
10324 * WebCoreSupport/EditorClientGtk.cpp:
10325 (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled):
10326 * WebCoreSupport/EditorClientGtk.h:
10328 2008-11-24 Darin Adler <darin@apple.com>
10330 Reviewed by Dan Bernstein.
10332 - https://bugs.webkit.org/show_bug.cgi?id=22470
10333 remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
10335 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10336 (WebKit::FrameLoaderClient::updateGlobalHistory): Remove argument.
10337 * WebCoreSupport/FrameLoaderClientGtk.h: Ditto.
10339 2008-11-24 Christian Dywan <christian@twotoasts.de>
10341 Reviewed by Holger Freyther.
10343 http://bugs.webkit.org/show_bug.cgi?id=17122
10344 [GTK] Bad font default settings
10346 * webkit/webkitwebsettings.cpp:
10347 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
10348 Use default font size 12 instead of 10
10350 2008-11-24 Zan Dobersek <zandobersek@gmail.com>
10352 Reviewed by Holger Freyther.
10354 https://bugs.webkit.org/show_bug.cgi?id=22039
10356 Implement a semi-private function for adding a directory to
10357 PluginDatabase's paths.
10359 * webkit/webkitprivate.h:
10360 * webkit/webkitwebsettings.cpp:
10361 (_WebKitWebSettingsPrivate::webkit_web_settings_add_extra_plugin_directory):
10363 2008-11-23 Holger Hans Peter Freyther <zecke@selfish.org>
10365 Rubber-stamped by Sam Weinig.
10367 Add gtk-doc configuration/source for the WebKit/Gtk+ Reference Manual
10369 These files will be used by gtk-doc to generate the documentation. They
10370 contain information how to group the symbols of our API, which objects
10371 to inspect during the generation of the manual and how to display the
10374 * docs/webkitgtk-docs.sgml: Added.
10375 * docs/webkitgtk-overrides.txt: Added.
10376 * docs/webkitgtk-sections.txt: Added.
10377 * docs/webkitgtk.types: Added.
10379 2008-11-23 Holger Hans Peter Freyther <zecke@selfish.org>
10381 Reviewed by Sam Weinig.
10383 Make gtk-doc happy with the existing API documentation
10385 - Mark the *Private pointers in the struct private
10386 - Use Returns: where gtk-doc wants us to
10387 - Fix the parameters to make gtk-doc happy
10388 - Fix signal references
10390 * webkit/webkitnetworkrequest.h:
10391 * webkit/webkitwebbackforwardlist.cpp:
10392 * webkit/webkitwebbackforwardlist.h:
10393 * webkit/webkitwebframe.h:
10394 * webkit/webkitwebhistoryitem.cpp:
10395 * webkit/webkitwebinspector.cpp:
10396 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
10397 * webkit/webkitwebview.cpp:
10398 * webkit/webkitwebview.h:
10400 2008-11-19 Darin Fisher <darin@chromium.org>
10404 https://bugs.webkit.org/show_bug.cgi?id=22373
10405 Ports busted by addition of ScriptValue.{h,cpp}
10407 * webkit/webkitwebview.cpp:
10409 2008-11-18 Holger Hans Peter Freyther <zecke@selfish.org>
10411 Reviewed by Simon Hausmann.
10413 Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports
10415 After Hyatt's work on Widget and ScrollView there is little difference
10416 between the implementation of Qt, Gtk+ and Win. In fact any kind of
10417 difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
10418 port and the Qt port has at least one of them left.
10420 The only difference between the implementations is in getting the the
10421 IntSize for the new FrameView, the background color to be applied and
10422 eventually some post processing.
10424 Unify the implementations by providing a static helper function that
10425 takes a Frame, IntSize, color and transparency bit and calling it from
10426 the Gtk+, the Qt and the Windows port.
10428 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10429 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
10431 2008-11-16 Christian Dywan <christian@twoasts.de>
10433 Reviewed by Holger Freyther.
10435 https://bugs.webkit.org/show_bug.cgi?id=22207
10436 [Gtk] Font sizes are not handled properly when updated at runtime
10438 * webkit/webkitwebview.cpp: Move the DPI/ conversion into a
10439 helper function and apply the logic in the notification callback.
10441 2008-11-06 Alp Toker <alp@nuanti.com>
10443 Reviewed by Darin Adler.
10445 https://bugs.webkit.org/show_bug.cgi?id=22047
10446 GTK: Add support for multiple file selection in the file upload control
10448 Implemented with GtkFileChooser.
10450 * WebCoreSupport/ChromeClientGtk.cpp:
10451 (WebKit::ChromeClient::runOpenPanel):
10453 2008-11-03 Cameron Zwarich <zwarich@apple.com>
10455 Rubber-stamped by Maciej Stachowiak.
10457 Move more files into the runtime subdirectory of JavaScriptCore.
10459 * webkit/webkitprivate.cpp:
10461 2008-11-03 Alp Toker <alp@nuanti.com>
10463 Reviewed by Holger Freyther.
10465 Deprecate flawed webkit_web_frame_new() function. This would never
10466 have worked properly when used outside WebCore since Frame::create()
10467 can only be called without an owner element once in the lifetime of a
10468 Page and would result in assertions, leaks and an unusable WebView
10471 Frame creation may be exposed in API some time later via the DOM
10472 binding but probably not in the WebKit GTK+ core API.
10474 * webkit/webkitwebframe.cpp:
10475 * webkit/webkitwebframe.h:
10477 2008-11-03 Alp Toker <alp@nuanti.com>
10479 Reviewed by Holger Freyther.
10481 Redundant scrollbars appear in frames where they shouldn't be visible
10482 eg. embedded Google adverts.
10484 Call setCanHaveScrollbars() when necessary. The Mac and Win ports
10485 already have this but it was missing in FrameLoaderClientGtk.
10487 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10488 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
10490 2008-11-03 Alp Toker <alp@nuanti.com>
10492 Rubber-stamped by Holger Freyther.
10494 Sync WebKit GTK+ default UA version string to 528.5+. (We're still
10495 doing this manually!)
10497 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10498 (WebKit::composeUserAgent):
10500 2008-10-31 Christian Dywan <christian@twotoasts.de>
10502 Reviewed by Mark Rowe.
10504 http://bugs.webkit.org/show_bug.cgi?id=22018
10505 enable-developer-extras doesn't toggle WebInspector
10507 * webkit/webkitwebview.cpp:
10508 Add missing 'if' in notification for 'enable-developer-extras'.
10510 2008-10-30 Alp Toker <alp@nuanti.com>
10512 Reviewed by Dave Hyatt.
10514 Fix GIF animations. WebCore will not update animated GIFs if
10515 the WebView is marked offscreen so we need to call
10516 frameView->setParentVisible() when necessary like the Mac and Win
10517 ports do. Regression was introduced around r37155 during the
10518 HostWindow refactor.
10520 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10521 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
10523 2008-10-30 Alp Toker <alp@nuanti.com>
10525 Rubber-stamped by Holger Freyther.
10527 Fix typo in recently added web inspector signal. dettach -> detach.
10529 * WebCoreSupport/InspectorClientGtk.cpp:
10530 (WebKit::InspectorClient::detachWindow):
10531 * webkit/webkitwebinspector.cpp:
10532 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
10534 2008-10-30 Alp Toker <alp@nuanti.com>
10536 Fix version comments for the web inspector added in r37982. Available
10537 since 1.0.3, not 1.0.2.
10539 * webkit/webkitwebinspector.cpp:
10540 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
10541 * webkit/webkitwebsettings.cpp:
10542 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
10543 * webkit/webkitwebview.cpp:
10545 2008-10-29 Gustavo Noronha Silva <gns@gnome.org>
10547 Reviewed and slightly changed by Holger Freyther.
10549 Implemented a new WebKitWebInspector class to provide a GObject
10550 API for the Web Inspector. Also implemented InspectorClient.
10552 * WebCoreSupport/InspectorClientGtk.cpp:
10553 (WebKit::notifyWebViewDestroyed):
10554 (WebKit::InspectorClient::InspectorClient):
10555 (WebKit::InspectorClient::inspectorDestroyed):
10556 (WebKit::InspectorClient::webViewDestroyed):
10557 (WebKit::InspectorClient::createPage):
10558 (WebKit::InspectorClient::showWindow):
10559 (WebKit::InspectorClient::closeWindow):
10560 (WebKit::InspectorClient::attachWindow):
10561 (WebKit::InspectorClient::detachWindow):
10562 (WebKit::InspectorClient::inspectedURLChanged):
10563 * WebCoreSupport/InspectorClientGtk.h:
10565 * webkit/webkit-marshal.list:
10566 * webkit/webkitdefines.h:
10567 * webkit/webkitprivate.h:
10568 * webkit/webkitwebinspector.cpp: Added.
10569 (_WebKitWebInspectorPrivate::webkit_inspect_web_view_request_handled):
10570 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
10571 (_WebKitWebInspectorPrivate::webkit_web_inspector_init):
10572 (_WebKitWebInspectorPrivate::webkit_web_inspector_finalize):
10573 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property):
10574 (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property):
10575 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_web_view):
10576 * webkit/webkitwebinspector.h: Added.
10577 * webkit/webkitwebsettings.cpp:
10578 (_WebKitWebSettingsPrivate::):
10579 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
10580 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
10581 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
10582 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
10583 * webkit/webkitwebview.cpp:
10584 * webkit/webkitwebview.h:
10586 2008-10-27 Michael Tross <michael@tross.org>
10588 Reviewed by Alp Toker. Landed by Jan Alonzo.
10590 https://bugs.webkit.org/show_bug.cgi?id=21827
10591 [GTK] Fix memory leak in webkit_web_view_load_string
10593 * webkit/webkitwebview.cpp:
10595 2008-10-24 Sam Weinig <sam@webkit.org>
10599 * WebCoreSupport/ChromeClientGtk.cpp:
10601 2008-10-24 Sam Weinig <sam@webkit.org>
10603 Reviewed by Dan Bernstein.
10605 Fix https://bugs.webkit.org/show_bug.cgi?id=21759
10606 Layering violation: FileChooser should not depend on Document/Frame/Page
10608 * WebCoreSupport/ChromeClientGtk.cpp:
10609 (WebKit::ChromeClient::runOpenPanel):
10610 * WebCoreSupport/ChromeClientGtk.h:
10612 2008-10-24 Timothy Hatcher <timothy@apple.com>
10614 Stub out new InspectorClient methods.
10616 https://bugs.webkit.org/show_bug.cgi?id=21856
10618 Reviewed by Darin Adler.
10620 * WebCoreSupport/InspectorClientGtk.cpp:
10621 (WebKit::InspectorClient::populateSetting): Not implemented.
10622 (WebKit::InspectorClient::storeSetting): Ditto.
10623 (WebKit::InspectorClient::removeSetting): Ditto.
10624 * WebCoreSupport/InspectorClientGtk.h:
10626 2008-10-22 Alp Toker <alp@nuanti.com>
10628 Build fix for older GTK+ versions where GTK_TYPE_TARGET_LIST isn't
10631 * webkit/webkitwebview.cpp:
10633 2008-10-22 Alp Toker <alp@nuanti.com>
10635 Reviewed by Adam Roben.
10637 Avoid critical warnings on older GTK+ versions (2.8) by not checking
10638 for GTK+ setting properties when we know they don't exist.
10640 * WebCoreSupport/ContextMenuClientGtk.cpp:
10641 (WebKit::inputMethodsMenuItem):
10642 (WebKit::unicodeMenuItem):
10644 2008-10-20 Sam Weinig <sam@webkit.org>
10646 Reviewed by Anders Carlsson.
10648 Remove FrameLoaderClient::detachedFromParent4. It is no longer used by any port.
10650 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10651 * WebCoreSupport/FrameLoaderClientGtk.h:
10653 2008-10-20 Alp Toker <alp@nuanti.com>
10655 Reviewed by Dave Hyatt.
10657 https://bugs.webkit.org/show_bug.cgi?id=21303
10658 [GTK] Scrolling glitches
10660 Implement a buffering scheme to avoid full repaints when scrolling
10661 views or subframes significantly improving scrolling performance.
10663 Improve rendering performance by coalescing large numbers of small
10666 Also fixes long-running issues with scrollbar positioning and frame
10669 Rendering in the GTK+ port should be more similar to other ports after
10672 * WebCoreSupport/ChromeClientGtk.cpp:
10673 (WebKit::ChromeClient::repaint):
10674 (WebKit::ChromeClient::scroll):
10675 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10676 (WebKit::FrameLoaderClient::forceLayout):
10677 * webkit/webkitwebview.cpp:
10679 2008-10-17 Luke Kenneth Casson Leighton <lkcl@lkcl.net>
10681 Reviewed by Mark Rowe. Landed by Jan Alonzo.
10683 https://bugs.webkit.org/show_bug.cgi?id=20403
10684 [Gtk] Segfault after a table with an iframe is attempted to be added twice to DOM model with javascript
10686 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10687 (WebKit::FrameLoaderClient::frameLoaderDestroyed):
10688 (WebKit::FrameLoaderClient::detachedFromParent4):
10690 2008-10-06 David Hyatt <hyatt@apple.com>
10692 Enable viewless Mac WebKit to paint some basic pages.
10694 Reviewed by Sam Weinig
10696 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10697 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
10698 * WebCoreSupport/FrameLoaderClientGtk.h:
10700 2008-10-03 David Hyatt <hyatt@apple.com>
10702 Fix Gtk bustage from use of containingWindow() over on the WebKit side. Replace with HostWindow use.
10704 * webkit/webkitwebview.cpp:
10706 2008-10-03 David Hyatt <hyatt@apple.com>
10708 https://bugs.webkit.org/show_bug.cgi?id=21340
10710 Remove "containingWindow()/setContainingWindow()" from Widget. HostWindow covers this now.
10712 Reviewed by Dan Bernstein & Darin Adler
10714 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10715 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
10717 2008-10-03 Alp Toker <alp@nuanti.com>
10719 Remove some left-over GTK+ includes. No change in functionality.
10721 * webkit/webkitwebhistoryitem.h:
10723 2008-10-03 Alp Toker <alp@nuanti.com>
10725 Build fix following r37234. Remove addToDirtyRegion from the header
10728 * WebCoreSupport/ChromeClientGtk.h:
10730 2008-10-03 David Hyatt <hyatt@apple.com>
10732 Remove addToDirtyRegion.
10734 Reviewed by Oliver Hunt
10736 * WebCoreSupport/ChromeClientGtk.cpp:
10738 2008-10-02 David Hyatt <hyatt@apple.com>
10740 https://bugs.webkit.org/show_bug.cgi?id=21314
10742 Make scrollBackingStore cross-platform.
10744 Reviewed by Sam Weinig
10746 * WebCoreSupport/ChromeClientGtk.cpp:
10747 (WebKit::ChromeClient::repaint):
10748 (WebKit::ChromeClient::scroll):
10749 * WebCoreSupport/ChromeClientGtk.h:
10751 2008-10-01 David Hyatt <hyatt@apple.com>
10753 https://bugs.webkit.org/show_bug.cgi?id=21282
10755 Make contentsToScreen/screenToContents cross-platform. Only implemented by Mac/Win right now.
10757 Reviewed by Adam Roben
10759 * WebCoreSupport/ChromeClientGtk.cpp:
10760 (WebKit::ChromeClient::windowToScreen):
10761 (WebKit::ChromeClient::screenToWindow):
10762 * WebCoreSupport/ChromeClientGtk.h:
10764 2008-09-30 Dave Hyatt <hyatt@apple.com>
10766 http://bugs.webkit.org/show_bug.cgi?id=21250
10768 Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
10769 repaints up through the ChromeClient.
10771 Reviewed by Darin Adler
10773 * WebCoreSupport/ChromeClientGtk.cpp:
10774 (WebKit::ChromeClient::repaint):
10775 * WebCoreSupport/ChromeClientGtk.h:
10777 2008-09-16 Alp Toker <alp@nuanti.com>
10779 Suggested by Dave Hyatt.
10781 Build fix and cleanup. Rename ScrollBar to Scrollbar.
10783 * webkit/webkitwebview.cpp:
10785 2008-09-13 Adrien Nader <camaradetux@gmail.com>
10787 Gtk build fix, not reviewed.
10789 * webkit/webkitwebview.cpp:
10791 2008-09-10 Alp Toker <alp@nuanti.com>
10793 Reviewed by Mark Rowe.
10795 https://bugs.webkit.org/show_bug.cgi?id=17267
10796 [GTK] Primary selection/clipboard support
10798 Implement primary selection support (copying only, no paste yet).
10800 * WebCoreSupport/EditorClientGtk.cpp:
10801 (WebKit::clipboard_get_contents_cb):
10802 (WebKit::clipboard_clear_contents_cb):
10803 (WebKit::EditorClient::respondToChangedSelection):
10805 2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
10807 Reviewed by Maciej Stachowiak.
10809 Bug 20704: Replace the KJS namespace
10810 <https://bugs.webkit.org/show_bug.cgi?id=20704>
10812 Rename the KJS namespace to JSC.
10814 * webkit/webkitprivate.cpp:
10817 2008-09-05 Gustavo Noronha Silva <gns@gnome.org>
10819 Reviewed by Alp Toker.
10821 https://bugs.webkit.org/show_bug.cgi?id=18346
10822 [GTK] Remove build warnings
10824 Removed/commented code that is not (yet) used, and reordered
10825 member variables initialization for FrameLoaderClient, so that the
10826 compiler is happy and prints less warnings when building.
10828 * WebCoreSupport/ContextMenuClientGtk.cpp:
10829 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10830 (WebKit::FrameLoaderClient::FrameLoaderClient):
10832 2008-09-03 Alp Toker <alp@nuanti.com>
10834 Build fix following r36073. Include config.h where necessary.
10836 * WebCoreSupport/PasteboardHelperGtk.cpp:
10837 * webkit/webkitversion.cpp:
10839 2008-09-01 Alp Toker <alp@nuanti.com>
10841 Reviewed by Eric Seidel.
10843 https://bugs.webkit.org/show_bug.cgi?id=19939
10844 [GTK] webkit_web_history_item_get_title() fails with assertion
10846 Make sure newly constructed WebHistoryItem objects wrap a WebCore
10847 history item when necessary. Avoid G_PARAM_CONSTRUCT since it destroys
10848 history data -- use WEBKIT_PARAM flags instead as they do the right
10849 thing. This restores history functionality.
10851 Also use CString to simplify UTF-8 string management.
10853 * webkit/webkitwebbackforwardlist.cpp:
10854 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
10855 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
10856 No need to initialize the vector with a size since it's cleared by the
10858 * webkit/webkitwebhistoryitem.cpp:
10859 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_finalize):
10860 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
10861 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
10862 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new):
10863 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
10864 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title):
10865 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title):
10866 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title):
10867 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri):
10868 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri):
10870 2008-08-27 Adrien Nader <camaradetux@gmail.com>
10872 Reviewed by Eric Seidel.
10874 https://bugs.webkit.org/show_bug.cgi?id=20099
10875 [GTK] SHIFT+PAGE_UP/DOWN doesn't extend selection
10877 * WebCoreSupport/EditorClientGtk.cpp:
10878 (WebKit::EditorClient::handleKeyboardEvent):
10880 2008-08-27 Brady Eidson <beidson@apple.com>
10884 <rdar://problem/6134133> - Crash when loading large movie as a standalone document
10886 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10887 (WebKit::FrameLoaderClient::pluginWillHandleLoadError): Stubbed for now
10888 * WebCoreSupport/FrameLoaderClientGtk.h:
10890 2008-08-18 Alp Toker <alp@nuanti.com>
10892 Reviewed by Holger Freyther.
10894 https://bugs.webkit.org/show_bug.cgi?id=20350
10895 [GTK] Get DumpRenderTree working
10897 Add a private function to WebFrame to dump the render tree as required
10898 for the DumpRenderTree testing tool.
10900 * webkit/webkitprivate.h:
10901 * webkit/webkitwebframe.cpp:
10903 2008-08-12 Timothy Hatcher <timothy@apple.com>
10905 Add a stub for InspectorClient::setAttachedWindowHeight.
10907 * WebCoreSupport/InspectorClientGtk.cpp:
10908 (WebKit::InspectorClient::setAttachedWindowHeight):
10909 Call notImplemented().
10910 * WebCoreSupport/InspectorClientGtk.h:
10912 2008-08-10 Alp Toker <alp@nuanti.com>
10914 Remove leftover qmake/GTK+ build files.
10916 * webkit/headers.pri: Removed.
10918 2008-08-02 Christian Dywan <christian@twotoasts.de>
10920 Reviewed by Eric Seidel.
10922 Remove webkit-marshal.list, which was made obsolete in #19742
10924 * webkit/webkit-marshal.list: Removed.
10926 2008-08-01 Wouter Bolsterlee <uws@xs4all.nl>
10928 Reviewed by Eric Seidel.
10930 https://bugs.webkit.org/show_bug.cgi?id=20035
10931 [GTK] Fix return value for webkit_web_view_go_to_back_forward_item()
10933 * webkit/webkitwebview.cpp:
10935 2008-07-30 Marco Barisione <marco.barisione@collabora.co.uk>
10937 Reviewed by Holger.
10939 http://bugs.webkit.org/show_bug.cgi?id=19742
10940 [GTK] Auto generate webkitmarshal.list
10942 Auto generate webkitmarshal.list from source files to reduce the
10943 number of conflicts when merging git branches or when applying
10945 Also rename webkit-marshal.* to webkitmarshal.* for consistency.
10947 * webkit/webkitwebframe.cpp: Include webkitmarshal.h instead of
10949 * webkit/webkitwebview.cpp: Ditto.
10951 2008-07-30 Gustavo Noronha Silva <gns@gnome.org>
10955 https://bugs.webkit.org/show_bug.cgi?id=20205
10956 Typo in comment for bracer ending block
10958 * webkit/webkitprivate.cpp: Typo fix in comment for the brace
10959 that ends the WebKit namespace; WebCore -> WebKit
10961 2008-07-26 Mark Rowe <mrowe@apple.com>
10963 Build fix. Changes to accommodate newly named/signatured loading methods in WebCore.
10965 * WebCoreSupport/FrameLoaderClientGtk.cpp:
10966 (WebKit::FrameLoaderClient::createFrame):
10968 2008-07-17 Christian Dywan <christian@twotoasts.de>
10970 Reviewed by Holger Freyther.
10972 https://bugs.webkit.org/show_bug.cgi?id=19813
10973 [GTK] WebKit crashes on invalid settings notify callback
10975 * webkit/webkitwebview.cpp: Disconnect in webkit_web_view_finalize
10977 2008-07-08 Jan Michael Alonzo <jmalonzo@webkit.org>
10979 Reviewed by Christian Dywan.
10981 Replace 'const' with G_CONST_RETURN macro to make it flexible to
10984 * webkit/webkitnetworkrequest.cpp:
10985 * webkit/webkitnetworkrequest.h:
10986 * webkit/webkitwebframe.cpp:
10987 * webkit/webkitwebframe.h:
10988 * webkit/webkitwebhistoryitem.cpp:
10989 * webkit/webkitwebhistoryitem.h:
10991 2008-06-18 Marco Barisione <marco.barisione@collabora.co.uk>
10993 Reviewed by Alp Toker.
10995 https://bugs.webkit.org/show_bug.cgi?id=19171
10996 [GTK] GTypes for enumerations
10998 Generate GTypes for public enumerations so they can be used as
11001 * GNUmakefile.am: Generate webkit-enum-types.cpp and
11002 webkit-enum-types.h.
11004 2008-06-17 Christian Dywan <christian@twotoasts.de>
11008 [GTK] WebKitWebHistoryItem needs properties
11009 https://bugs.webkit.org/show_bug.cgi?id=19558
11011 Implement properties matching the existing accessors.
11013 * webkit/webkitwebhistoryitem.cpp:
11014 (_WebKitWebHistoryItemPrivate::):
11015 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
11016 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_property):
11017 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_property):
11018 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title):
11020 2008-06-15 Darin Adler <darin@apple.com>
11022 - give Frame object functions shorter names: scriptProxy() -> script(),
11023 selectionController() -> selection(), animationController() -> animation()
11025 * WebCoreSupport/EditorClientGtk.cpp:
11026 (WebKit::EditorClient::handleKeyboardEvent):
11027 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11028 (WebKit::FrameLoaderClient::windowObjectCleared):
11029 * webkit/webkitwebframe.cpp:
11030 * webkit/webkitwebview.cpp:
11032 2008-06-15 Darin Adler <darin@apple.com>
11034 - undo bogus renaming done by the script
11036 * WebCoreSupport/ContextMenuClientGtk.cpp:
11037 * webkit/webkitnetworkrequest.h:
11038 * webkit/webkitwebbackforwardlist.h:
11039 * webkit/webkitwebframe.h:
11040 * webkit/webkitwebhistoryitem.h:
11041 * webkit/webkitwebsettings.h:
11043 2008-06-15 Darin Adler <darin@apple.com>
11045 - new names for a few key JavaScriptCore files
11047 * WebCoreSupport/ContextMenuClientGtk.cpp:
11048 * webkit/webkitnetworkrequest.h:
11049 * webkit/webkitwebbackforwardlist.h:
11050 * webkit/webkitwebframe.h:
11051 * webkit/webkitwebhistoryitem.h:
11052 * webkit/webkitwebsettings.h:
11054 2008-06-15 Christian Dywan <christian@twotoasts.de>
11056 Reviewed by Alp Toker.
11058 [GTK] Property setters do not call g_object_notify()
11059 https://bugs.webkit.org/show_bug.cgi?id=18405
11061 * webkit/webkitwebview.cpp:
11063 2008-06-15 Christian Dywan <christian@twotoasts.de>
11065 Reviewed by Alp Toker.
11067 Tiny documentation fix, s/capacity/limit
11069 * webkit/webkitwebbackforwardlist.cpp:
11071 2008-06-14 Darin Adler <darin@apple.com>
11073 Rubber stamped by Sam.
11075 - new names for kjs_binding.h and kjs_proxy.h
11077 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11078 * webkit/webkitwebframe.cpp:
11080 2008-06-14 Darin Adler <darin@apple.com>
11084 * webkit/webkitwebframe.cpp: Remove a bogus release() call.
11086 2008-06-14 Darin Adler <darin@apple.com>
11090 - more https://bugs.webkit.org/show_bug.cgi?id=17257
11091 start ref counts at 1 instead of 0 for speed
11093 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11094 (WebKit::FrameLoaderClient::createDocumentLoader): Use create instead of new.
11095 * webkit/webkitwebframe.cpp:
11096 (webkit_web_frame_new): Ditto.
11097 (webkit_web_frame_init_with_web_view): Ditto.
11099 2008-06-13 Darin Adler <darin@apple.com>
11103 * WebCoreSupport/FrameLoaderClientGtk.h: Add missing argument.
11105 2008-06-13 Darin Adler <darin@apple.com>
11107 Reviewed by John Sullivan.
11109 - updated for addition of FormState argument to action policy functions
11111 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11112 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
11113 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
11115 2008-06-10 Christian Dywan <christian@twotoasts.de>
11117 Reviewed by Alp Toker and Darin Adler.
11119 https://bugs.webkit.org/show_bug.cgi?id=16676
11120 Apply GTK coding style to WebKit Gtk public headers
11122 * webkit/webkitnetworkrequest.h:
11123 * webkit/webkitwebbackforwardlist.h:
11124 * webkit/webkitwebframe.h:
11125 * webkit/webkitwebhistoryitem.h:
11126 * webkit/webkitwebsettings.h:
11127 * webkit/webkitwebview.h:
11129 2008-06-07 Jan Michael Alonzo <jmalonzo@webkit.org>
11131 Confirmed by Christian Dywan.
11133 Gtk build fix for r34432
11135 * webkit/webkitwebhistoryitem.cpp:
11136 (_WebKitWebHistoryItemPrivate::webkit_history_item_add):
11137 (_WebKitWebHistoryItemPrivate::webkit_history_item_remove):
11138 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
11139 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
11140 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new):
11141 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
11144 2008-06-07 Darin Adler <darin@apple.com>
11146 - try to fix build after HistoryItem changes
11148 * webkit/webkitwebhistoryitem.cpp:
11149 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new): Use HistoryItem::create.
11150 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data): Ditto. I also
11151 believe this fixes a memory leak in the old version.
11153 2008-06-07 Christian Dywan <christian@twotoasts.de>
11155 Reviewed by Alp Toker.
11157 https://bugs.webkit.org/show_bug.cgi?id=17324
11158 Remove PLATFORM ifdefs from ContextMenu.cpp
11160 * WebCoreSupport/ContextMenuClientGtk.cpp:
11161 (WebKit::ContextMenuClient::ContextMenuClient):
11162 (WebKit::ContextMenuClient::contextMenuDestroyed):
11163 (WebKit::inputMethodsMenuItem):
11165 (WebKit::insertControlCharacter):
11166 (WebKit::unicodeMenuItem):
11167 (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):
11168 * WebCoreSupport/ContextMenuClientGtk.h:
11169 * webkit/webkitwebview.cpp:
11171 2008-06-05 Alp Toker <alp@nuanti.com>
11173 Add 'Since' documentation for API versioning functions.
11175 * webkit/webkitversion.cpp:
11177 2008-06-05 Christian Dywan <christian@twotoasts.de>
11179 Reviewed by Alp Toker.
11181 https://bugs.webkit.org/show_bug.cgi?id=14141
11182 Please add a version to the Gtk port
11185 * webkit/webkitversion.cpp: Added.
11186 * webkit/webkitversion.h.in: Added.
11187 * webkit/webkitwebsettings.cpp:
11188 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
11189 * webkit/webkitwebview.cpp:
11191 2008-06-01 Alp Toker <alp@nuanti.com>
11193 Suggested by Christian Dywan.
11195 Use float literals for zoom values and improve documentation wording.
11197 * webkit/webkitwebsettings.cpp:
11198 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
11199 * webkit/webkitwebview.cpp:
11201 2008-06-01 Alp Toker <alp@nuanti.com>
11203 Reviewed by Oliver.
11205 Remove webkit_web_view_go_backward(),
11206 webkit_web_view_can_go_backward(). These have been obsoleted by
11207 the back() versions for quite a while.
11209 * webkit/webkitwebview.cpp:
11210 * webkit/webkitwebview.h:
11212 2008-05-31 Alp Toker <alp@nuanti.com>
11214 Fix inconsistent zoom docs and enum name landed in r34249. Issue
11215 noticed by Marco Barisione.
11217 * webkit/webkitwebview.cpp:
11219 2008-05-30 Carlos MartÃn Nieto <carlos@cmartin.tk>
11221 Reviewed by Alp Toker.
11223 http://bugs.webkit.org/show_bug.cgi?id=18383
11224 [GTK] The "hovering-over-link" signal arguments aren't documented.
11226 * webkit/webkitwebview.cpp:
11228 2008-05-29 Marco Barisione <marco@collabora.co.uk>
11230 Reviewed (and tweaked) by Alp Toker.
11232 http://bugs.webkit.org/show_bug.cgi?id=18281
11233 [GTK] add functions to set/get the zoom level
11235 * webkit/webkitwebsettings.cpp:
11236 (_WebKitWebSettingsPrivate::):
11237 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
11238 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
11239 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
11240 * webkit/webkitwebview.cpp: Add functions to get and set the zoom
11242 * webkit/webkitwebview.h: Ditto.
11243 * webkit/webkitprivate.h:
11245 2008-05-28 Alp Toker <alp@nuanti.com>
11247 Reviewed by Alexey Proskuryakov.
11249 http://bugs.webkit.org/show_bug.cgi?id=18704
11250 [gtk] cannot type letters with dead keys in textarea
11252 http://bugs.webkit.org/show_bug.cgi?id=14120
11253 [GDK] Support input methods
11255 Add support for input method composition.
11257 Remove some old hacks so we handle input method events more
11260 * WebCoreSupport/EditorClientGtk.cpp:
11261 (WebKit::imContextCommitted):
11262 (WebKit::imContextPreeditChanged):
11263 (WebKit::EditorClient::setInputMethodState):
11264 (WebKit::EditorClient::respondToChangedSelection):
11265 (WebKit::EditorClient::handleInputMethodKeydown):
11266 (WebKit::EditorClient::EditorClient):
11267 (WebKit::EditorClient::~EditorClient):
11268 (WebKit::EditorClient::textFieldDidBeginEditing):
11269 (WebKit::EditorClient::textFieldDidEndEditing):
11270 (WebKit::EditorClient::textDidChangeInTextField):
11271 (WebKit::EditorClient::doTextFieldCommandFromEvent):
11272 * webkit/webkitwebview.cpp:
11274 2008-05-25 Alp Toker <alp@nuanti.com>
11278 Drop WebView focus when the widget is focused out.
11280 * webkit/webkitwebview.cpp:
11282 2008-05-25 Sriram Neelakandan <sriram.neelakandan@gmail.com>
11284 Reviewed by Alp Toker.
11286 http://bugs.webkit.org/show_bug.cgi?id=18935
11287 [Gtk] Plugin Load crashes with NP_FULL mode
11289 Fix crash due to uninitialized variable.
11291 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11292 (WebKit::FrameLoaderClient::FrameLoaderClient):
11294 2008-05-24 Alp Toker <alp@nuanti.com>
11296 https://bugs.webkit.org/show_bug.cgi?id=18825
11297 webkitgtk fails to build from source: "Database Tracker" has not been declared
11299 GTK+ fix for building without database support.
11300 exceededDatabaseQuota() still needs to be present, just a no-op.
11302 * WebCoreSupport/ChromeClientGtk.cpp:
11303 (WebKit::ChromeClient::exceededDatabaseQuota):
11305 2008-05-23 Alp Toker <alp@nuanti.com>
11307 GTK+ fixes for building without database support.
11309 * WebCoreSupport/ChromeClientGtk.cpp:
11311 2008-05-19 Alp Toker <alp@nuanti.com>
11313 Reviewed by Anders and Beth.
11315 http://bugs.webkit.org/show_bug.cgi?id=16495
11316 [GTK] Accessibility support with ATK/AT-SPI
11318 Initial ATK/AT-SPI accessibility support for the GTK+ port.
11320 * webkit/webkitwebview.cpp:
11322 2008-05-06 Christian Dywan <christian@twotoasts.de>
11324 Rubber stamped by Alp.
11326 Back out 17626. It wasn't ready for commit.
11328 * webkit/webkitprivate.h:
11329 * webkit/webkitwebview.cpp:
11330 * webkit/webkitwebview.h:
11332 2008-05-01 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
11334 Reviewed by Alp Toker.
11336 https://bugs.webkit.org/show_bug.cgi?id=14750
11337 Added support for NPAPI plugins on Gtk and Qt-x11 ports.
11339 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11340 (WebKit::FrameLoaderClient::FrameLoaderClient):
11341 (WebKit::FrameLoaderClient::committedLoad):
11342 (WebKit::FrameLoaderClient::createPlugin):
11343 (WebKit::FrameLoaderClient::redirectDataToPlugin):
11344 (WebKit::FrameLoaderClient::finishedLoading):
11345 (WebKit::FrameLoaderClient::setMainDocumentError):
11346 * WebCoreSupport/FrameLoaderClientGtk.h:
11348 2008-04-30 Sean Egan <seanegan@gmail.com>
11350 Reviewed and modified by Holger.
11352 https://bugs.webkit.org/show_bug.cgi?id=17626
11353 Support setting background color and a 16-bit alpha channel.
11355 * webkit/webkitprivate.h:
11356 * webkit/webkitwebview.cpp:
11357 * webkit/webkitwebview.h:
11359 2008-04-24 Dan Bernstein <mitz@apple.com>
11363 * webkit/webkitwebview.cpp:
11365 2008-04-24 Anders Carlsson <andersca@apple.com>
11369 Change some String arguments to be const references instead.
11371 * WebCoreSupport/EditorClientGtk.cpp:
11372 (WebKit::EditorClient::shouldInsertText):
11373 * WebCoreSupport/EditorClientGtk.h:
11375 2008-04-23 Christian Dywan <christian@twotoasts.de>
11377 Reviewed by Alp Toker.
11379 Emit a warning about an unknown setting only if it is
11380 not a valid property. Otherwise applications can't
11381 subclass WebKitWebSettings to add new properties.
11383 * webkit/webkitwebview.cpp:
11385 2008-04-20 Simon Hausmann <hausmann@webkit.org>
11387 Reviewed by Alp Toker.
11389 http://bugs.webkit.org/show_bug.cgi?id=18578
11390 Share the printing code between the Gtk and the Qt port
11392 Share the printing code between the Gtk and the Qt port
11393 and added printing to the Qt WebKit API.
11395 * webkit/webkitwebframe.cpp: Removed PrintContext in favour of
11396 page/Printcontext.cpp/h
11398 2008-04-19 Alp Toker <alp@nuanti.com>
11400 Reviewed by Maciej.
11402 Enable visited link tracking by default at startup.
11404 With this patch, the GTK+ port rendering of Acid3 now matches the
11407 * webkit/webkitprivate.cpp:
11411 2008-04-11 Mark Rowe <mrowe@apple.com>
11413 Gtk build fix after r32231.
11415 * webkit/webkitwebview.cpp: Update to use contentRenderer.
11417 2008-04-18 Alp Toker <alp@atoker.com>
11419 Rubber-stamped by Holger Freyther.
11421 http://bugs.webkit.org/show_bug.cgi?id=18218
11422 [Gtk] segfault when clicking on a disabled button
11424 Always use the main frame for mouse events (not the focused frame)
11425 since it knows best how to get the event through to the right target.
11427 This also fixes a null crasher.
11429 * webkit/webkitwebview.cpp:
11431 2008-04-17 Alp Toker <alp@atoker.com>
11433 Rubber-stamped by Holger Freyther.
11435 Reduce hard-coded page-cache count to 3 based on research done for the
11436 Mac port on value / page.
11438 We will need to make this more dynamic or configurable at some point
11439 but for now it's best to keep closer to the behaviour before page
11440 caching was enabled.
11442 Issue spotted by Mark Rowe.
11444 * webkit/webkitprivate.cpp:
11447 2008-04-17 Daniele Metilli <daniele.metilli@gmail.com>
11451 Fixed a typo in the copyright header.
11453 * webkit/webkitprivate.h:
11455 2008-04-14 Holger Freyther <zecke@selfish.org>
11457 Reviewed by Alp Toker.
11459 https://bugs.webkit.org/show_bug.cgi?id=18411
11460 Enable Page caching and create FrameViews on the fly
11462 Create the FrameView on the fly and cache pages
11464 - Keep a copy of the GtkAdjustment to be able to reuse it for the
11466 - Do not initially create a FrameView and update the WebKit code to
11467 cope with not having a view.
11468 - Cache seven pages by default.
11470 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11471 (WebKit::FrameLoaderClient::createFrame):
11472 (WebKit::FrameLoaderClient::canCachePage):
11473 (WebKit::FrameLoaderClient::savePlatformDataToCachedPage):
11474 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage):
11475 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
11476 * webkit/webkitprivate.cpp:
11478 * webkit/webkitprivate.h:
11479 * webkit/webkitwebframe.cpp:
11480 * webkit/webkitwebview.cpp:
11482 2008-04-10 Mario Bensi <mbensi@pleyo.com>
11484 Reviewed by Alp Toker.
11486 https://bugs.webkit.org/show_bug.cgi?id=18400
11487 Database example doesn't work on Gtk port
11489 Fix quota in ChromeClient
11491 * WebCoreSupport/ChromeClientGtk.cpp:
11492 (WebKit::ChromeClient::exceededDatabaseQuota):
11494 2008-04-08 Adam Roben <aroben@apple.com>
11496 Move callOnMainThread to WTF
11498 Reviewed by Alexey Proskuryakov.
11500 * webkit/webkitprivate.cpp: Updated #include.
11501 (webkit_init): Changed to call KJS::initializeThreading.
11503 2008-04-06 Luca Bruno <lethalman88@gmail.com>
11505 Reviewed by Alp Toker.
11507 Fix webkit_web_view_get_transparent() return value.
11509 * webkit/webkitwebview.cpp:
11511 2008-03-31 Jasper Bryant-Greene <jasper@unix.geek.nz>
11513 Reviewed by Darin Adler.
11515 Resolves http://bugs.webkit.org/show_bug.cgi?id=18010
11516 "WebKitNetworkRequestPrivate is defined in two places unnecessarily"
11518 Removed unnecessary definition of WebKitNetworkRequestPrivate in
11521 * webkit/webkitprivate.h:
11523 2008-03-25 Brady Eidson <beidson@apple.com>
11527 Remove newly obsolete FrameLoaderClient methods
11529 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11530 * WebCoreSupport/FrameLoaderClientGtk.h:
11532 2008-03-20 Alp Toker <alp@atoker.com>
11534 GTK+ build fix. Back out r31183. This patch also introduced API style
11537 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11538 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
11539 * webkit/headers.pri:
11540 * webkit/webkit-marshal.list:
11541 * webkit/webkitdefines.h:
11542 * webkit/webkitnavigationaction.cpp: Removed.
11543 * webkit/webkitnavigationaction.h: Removed.
11544 * webkit/webkitprivate.cpp:
11545 * webkit/webkitprivate.h:
11546 * webkit/webkitwebview.cpp:
11547 * webkit/webkitwebview.h:
11549 2008-03-20 Jasper Bryant-Greene <jasper@unix.geek.nz>
11551 Reviewed and tweaked by Anders.
11553 Resolves http://bugs.webkit.org/show_bug.cgi?id=16092
11554 "[GTK] Middle-mouse click should allow opening a URL in a new tab"
11556 Created WebKitNavigationAction object exported through the API. The
11557 navigation-requested signal provides this object as context for the
11558 requested navigation, allowing the application to decide what to do
11559 with the navigation based on which mouse button was used, which
11560 modifier keys were held down, etc. This allows, for example, the
11561 application to open links in a new tab when either middle-click or
11562 control-click are used to initiate the navigation.
11564 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11565 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
11566 * webkit/headers.pri:
11567 * webkit/webkit-marshal.list:
11568 * webkit/webkitdefines.h:
11569 * webkit/webkitnavigationaction.cpp: Added.
11570 (webkit_navigation_action_finalize):
11571 (webkit_navigation_action_class_init):
11572 (webkit_navigation_action_init):
11573 (webkit_navigation_action_get_button):
11574 (webkit_navigation_action_get_modifier_flags):
11575 (webkit_navigation_action_get_navigation_type):
11576 (webkit_navigation_action_get_original_url):
11577 * webkit/webkitnavigationaction.h: Added.
11578 * webkit/webkitprivate.cpp:
11580 * webkit/webkitprivate.h:
11581 * webkit/webkitwebview.cpp:
11582 * webkit/webkitwebview.h:
11584 2008-03-18 Rodney Dawes <dobey@wayofthemonkey.com>
11586 Reviewed and landed by jhoneycutt.
11588 Update to check if the MIME type is supported by a plugin.
11590 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11591 (FrameLoaderClient::objectContentType):
11593 2008-03-18 Rodney Dawes <dobey@wayofthemonkey.com>
11595 Reviewed by Jon Honeycutt.
11597 Update setContainingWindow() calls to pass a GtkWidget.
11599 * webkit/webkitwebframe.cpp:
11600 (webkit_web_frame_new):
11601 (webkit_web_frame_init_with_web_view):
11603 2008-03-13 Rodney Dawes <dobey@wayofthemonkey.com>
11605 Fix GTK+ build for SharedBuffer changes.
11607 * webkit/webkitwebview.cpp:
11608 (webkit_web_view_load_string):
11610 2008-03-12 Tommi Komulainen <tommi.komulainen@iki.fi>
11612 Reviewed by Alp Toker.
11614 http://bugs.webkit.org/show_bug.cgi?id=17799
11615 WebView signals should use more specific types
11617 * webkit/webkitwebview.cpp: Use WEBKIT_TYPE_WEB_FRAME argument
11618 type in "script-alert", "script-confirm", "script-script-prompt"
11619 signals so that it gets more clearly documented rather than just
11622 2008-03-10 Xan Lopez <xan@gnome.org>
11624 Reviewed by Alp Toker.
11626 Fix "missing braces" compiler warning.
11628 * webkit/webkitwebview.cpp:
11630 2008-03-04 Sam Weinig <sam@webkit.org>
11632 Reviewed by Mark Rowe.
11634 - Remove all unnecessary includes of JSDOMWindowBase.h, we prefer including
11637 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11638 * webkit/webkitwebframe.cpp:
11640 2008-03-03 Sam Weinig <sam@webkit.org>
11644 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11645 (WebKit::FrameLoaderClient::windowObjectCleared):
11647 2008-03-03 Alp Toker <alp@atoker.com>
11649 Fix the GTK+ build following breakage introduced in r30712.
11651 * WebCoreSupport/EditorClientGtk.cpp:
11652 (WebKit::imContextCommitted):
11654 2008-03-02 Alp Toker <alp@atoker.com>
11656 Reviewed by Mark Rowe.
11658 Split the WebKit GTK+ build out of the WebCore build and change the
11659 shared object name to match the package name.
11663 2008-02-27 Adam Roben <aroben@apple.com>
11665 Attempt to fix the GTK+ build
11667 * webkit/webkitwebframe.cpp:
11669 2008-02-24 Darin Adler <darin@apple.com>
11673 - remove separate client calls for "standard" and "reload' history
11675 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11676 (WebKit::FrameLoaderClient::updateGlobalHistory):
11677 * WebCoreSupport/FrameLoaderClientGtk.h:
11679 2008-02-23 Alexey Proskuryakov <ap@webkit.org>
11683 * webkit/webkitprivate.cpp:
11684 (webkit_init): Renamed initializeThreading to initializeThreadingAndMainThread.
11686 2008-02-18 Alp Toker <alp@atoker.com>
11688 Reviewed by Mark Rowe.
11690 http://bugs.webkit.org/show_bug.cgi?id=17312
11691 [GTK] Webview Transparent Background
11693 Add support for WebView background transparency.
11695 * webkit/webkitprivate.h:
11696 * webkit/webkitwebview.cpp:
11697 * webkit/webkitwebview.h:
11699 2008-02-18 Alp Toker <alp@atoker.com>
11701 Reviewed by Mark Rowe.
11703 Implement webkit_web_view_get_focused_frame()
11705 Equivalent to selectedFrame in the Mac API.
11707 * webkit/webkitwebview.cpp:
11708 * webkit/webkitwebview.h:
11710 2008-02-17 Jan Michael Alonzo <jmalonzo@unpluggable.com>
11712 Reviewed by Mark Rowe.
11714 Fix a crash introduced in changeset #29985 by moving the dereference to after
11717 * webkit/webkitwebhistoryitem.cpp:
11718 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
11720 2008-02-15 Alp Toker <alp@atoker.com>
11722 Fix the GTK+ build following breakage introduced in r30243.
11724 * WebCoreSupport/ChromeClientGtk.cpp:
11725 (WebKit::ChromeClient::mouseDidMoveOverElement):
11726 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11727 (WebKit::FrameLoaderClient::objectContentType):
11729 2008-02-15 Darin Adler <darin@apple.com>
11731 - another try at fixing the build
11733 * webkit/webkitwebview.cpp: Added some explicit conversions to KURL.
11735 2008-02-14 Darin Adler <darin@apple.com>
11737 * webkit/webkitwebframe.cpp: Removed DeprecatedString use to try to keep it building.
11738 * webkit/webkitwebview.cpp: Ditto.
11740 2008-02-14 Holger Hans Peter Freyther <zecke@selfish.org>
11744 * Make the handling of the coreFrame consistent. We construct the coreFrame
11745 at the beginning and it will live until the end. Change the g_return_(val_)if
11746 to ASSERTs as having a 0 coreFrame can never happen.
11748 * webkit/webkitwebframe.cpp:
11749 (PrintContext::webkit_web_frame_print):
11751 2008-02-14 Holger Hans Peter Freyther <zecke@selfish.org>
11755 * Make sure that the WebCore::Frame is living as long as the WebKitWebFrame
11756 wrapped around it. All current calls to WebCore::Frame from within the
11757 WebKitWebFrame are safe, even in the case where the WebCore::Frame is already
11758 detached from the WebCore::Page.
11759 * For the mainFrame the WebKitWebView is holding the initial reference and
11760 will unref on destruction.
11761 * For sub-frames the FramerLoaderClientGtk.cpp will do the unrefing when the
11762 frame gets detached from the parent.
11763 * Make sure FrameLoader::detachFromParent gets called by calling FrameLoader::detachChildren
11765 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11766 (WebKit::FrameLoaderClient::detachedFromParent4):
11767 * webkit/webkitprivate.cpp:
11769 * webkit/webkitprivate.h:
11770 * webkit/webkitwebframe.cpp:
11771 * webkit/webkitwebview.cpp:
11773 2008-02-14 Holger Hans Peter Freyther <zecke@selfish.org>
11777 WebCore::Frame is RefCounted, do not manually delete it!
11779 * webkit/webkitwebframe.cpp:
11781 2008-02-14 Holger Hans Peter Freyther <zecke@selfish.org>
11787 * webkit/webkitwebframe.cpp:
11789 2008-02-14 Holger Hans Peter Freyther <zecke@selfish.org>
11793 * Update the Copyright Information
11795 * WebCoreSupport/FrameLoaderClientGtk.cpp:
11796 * webkit/webkitprivate.h:
11797 * webkit/webkitwebframe.cpp:
11799 2008-02-13 Alp Toker <alp@atoker.com>
11801 Reviewed by Adam Roben.
11803 Fix very small, upside down, inside out text on GTK+/DirectFB.
11805 Based on an initial patch by Sriram Neelakandan <sriram.neelakandan@gmail.com>
11807 Test the result of gdk_screen_get_resolution() and use a default
11808 fallback in case of failure.
11810 Also remove an unhelpful runtime warning.
11812 * webkit/webkitwebview.cpp:
11814 2008-02-08 Pierre-Luc Beaudoin <pierre-luc.beaudoin@collabora.co.uk>
11816 Reviewed by Alp Toker.
11818 http://bugs.webkit.org/show_bug.cgi?id=17009
11819 [Gtk] Webkit strips accents from some dead-key combinations
11821 KeyEvents have to go through the gtk input method.
11823 * WebCoreSupport/EditorClientGtk.cpp:
11824 (WebKit::imContextCommitted):
11825 (WebKit::EditorClient::doTextFieldCommandFromEvent):
11827 2008-02-05 Mark Rowe <mrowe@apple.com>
11829 Reviewed by Alp Toker.
11831 Fix warnings seen on the Gtk port by declaring variables and using constants of the correct types.
11833 * webkit/webkitwebbackforwardlist.cpp:
11834 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_contains_item):
11835 * webkit/webkitwebhistoryitem.cpp:
11836 * webkit/webkitwebview.cpp:
11838 2008-02-04 Christian Dywan <christian@imendio.com>
11840 Reviewed by Alp Toker.
11842 http://bugs.webkit.org/show_bug.cgi?id=17065
11843 [GTK] Use a consistent coding style
11845 * WebCoreSupport/EditorClientGtk.cpp:
11846 (WebKit::imContextCommitted):
11847 (WebKit::EditorClient::EditorClient):
11848 (WebKit::EditorClient::~EditorClient):
11849 (WebKit::EditorClient::textFieldDidEndEditing):
11850 * webkit/webkitdefines.h:
11851 * webkit/webkitnetworkrequest.cpp:
11852 (_WebKitNetworkRequestPrivate::webkit_network_request_finalize):
11853 (_WebKitNetworkRequestPrivate::webkit_network_request_class_init):
11854 (_WebKitNetworkRequestPrivate::webkit_network_request_init):
11855 (_WebKitNetworkRequestPrivate::webkit_network_request_new):
11856 (_WebKitNetworkRequestPrivate::webkit_network_request_set_uri):
11857 (_WebKitNetworkRequestPrivate::webkit_network_request_get_uri):
11858 * webkit/webkitnetworkrequest.h:
11859 * webkit/webkitprivate.cpp:
11860 (WebKit::getViewFromFrame):
11862 * webkit/webkitprivate.h:
11863 * webkit/webkitwebbackforwardlist.cpp:
11864 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_new_with_web_view):
11865 * webkit/webkitwebbackforwardlist.h:
11866 * webkit/webkitwebframe.cpp:
11867 * webkit/webkitwebframe.h:
11868 * webkit/webkitwebhistoryitem.cpp:
11869 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
11870 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_finalize):
11871 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
11872 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new):
11873 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
11874 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title):
11875 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title):
11876 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title):
11877 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri):
11878 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri):
11880 * webkit/webkitwebhistoryitem.h:
11881 * webkit/webkitwebsettings.h:
11882 * webkit/webkitwebview.cpp:
11883 * webkit/webkitwebview.h:
11885 2008-02-04 Alp Toker <alp@atoker.com>
11887 Rubber-stamped by Mark Rowe.
11889 Remove all trailing whitespace in the GTK+ port and related
11892 * WebCoreSupport/DragClientGtk.h:
11893 * WebCoreSupport/FrameLoaderClientGtk.h:
11894 * WebCoreSupport/InspectorClientGtk.h:
11895 * WebCoreSupport/PasteboardHelperGtk.h:
11896 * webkit/webkitprivate.h:
11897 * webkit/webkitwebbackforwardlist.cpp:
11898 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_contains_item):
11899 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
11900 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_item):
11901 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_length):
11902 * webkit/webkitwebhistoryitem.cpp:
11903 (_WebKitWebHistoryItemPrivate::webkit_history_items):
11904 (_WebKitWebHistoryItemPrivate::webkit_history_item_add):
11905 (_WebKitWebHistoryItemPrivate::webkit_history_item_remove):
11906 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
11907 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
11908 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title):
11909 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title):
11910 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title):
11911 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri):
11912 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time):
11914 * webkit/webkitwebhistoryitem.h:
11915 * webkit/webkitwebview.cpp:
11916 * webkit/webkitwebview.h:
11918 2008-02-03 Christian Dywan <christian@imendio.com>
11920 Reviewed by Alp Toker.
11922 http://bugs.webkit.org/show_bug.cgi?id=17046
11923 [GTK] Context menu fixes and customisation suport
11925 * webkit/webkitwebview.cpp:
11927 2008-01-31 Alp Toker <alp@atoker.com>
11929 Reviewed by Mark Rowe.
11931 Fix the pkg-config file to follow GTK+ package naming and versioning
11934 Remove unneeded dependency listings.
11936 * WebKitGtk.pc.in: Removed.
11937 * webkit.pc.in: Copied from WebKit/gtk/WebKitGtk.pc.in.
11939 2008-01-31 Alp Toker <alp@atoker.com>
11941 Rubber-stamped by Adam Roben.
11943 http://bugs.webkit.org/show_bug.cgi?id=17006
11944 [GTK] Header path should be webkit/webkit.h
11946 Move the GTK+ API sources as needed and update the build systems.
11948 * WebView: Removed.
11949 * WebView/headers.pri: Removed.
11950 * WebView/webkit-marshal.list: Removed.
11951 * WebView/webkit.h: Removed.
11952 * WebView/webkitdefines.h: Removed.
11953 * WebView/webkitnetworkrequest.cpp: Removed.
11954 * WebView/webkitnetworkrequest.h: Removed.
11955 * WebView/webkitprivate.cpp: Removed.
11956 * WebView/webkitprivate.h: Removed.
11957 * WebView/webkitwebbackforwardlist.cpp: Removed.
11958 * WebView/webkitwebbackforwardlist.h: Removed.
11959 * WebView/webkitwebframe.cpp: Removed.
11960 * WebView/webkitwebframe.h: Removed.
11961 * WebView/webkitwebhistoryitem.cpp: Removed.
11962 * WebView/webkitwebhistoryitem.h: Removed.
11963 * WebView/webkitwebsettings.cpp: Removed.
11964 * WebView/webkitwebsettings.h: Removed.
11965 * WebView/webkitwebview.cpp: Removed.
11966 * WebView/webkitwebview.h: Removed.
11967 * webkit: Copied from WebKit/gtk/WebView.
11969 * webkit/webkitnetworkrequest.h:
11970 * webkit/webkitprivate.h:
11971 * webkit/webkitwebbackforwardlist.h:
11972 * webkit/webkitwebframe.h:
11973 * webkit/webkitwebhistoryitem.h:
11974 * webkit/webkitwebsettings.h:
11975 * webkit/webkitwebview.h:
11977 2008-01-27 Jan Michael Alonzo <jmalonzo@unpluggable.com>
11979 Reviewed by Alp Toker.
11981 http://bugs.webkit.org/show_bug.cgi?id=14811
11982 [gtk] [request] add a webkit_gtk_page_go_to_history_item function
11984 implement back/forward list and history item
11986 * WebView/headers.pri:
11987 * WebView/webkit.h:
11988 * WebView/webkitprivate.cpp:
11989 * WebView/webkitprivate.h:
11990 * WebView/webkitwebbackforwardlist.cpp: Added.
11991 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_dispose):
11992 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_class_init):
11993 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_init):
11994 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_new_with_web_view):
11995 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_go_forward):
11996 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_go_back):
11997 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_contains_item):
11998 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_go_to_item):
11999 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
12000 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
12001 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_item):
12002 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_current_item):
12003 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_item):
12004 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_nth_item):
12005 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_length):
12006 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_length):
12007 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_limit):
12008 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_set_limit):
12009 * WebView/webkitwebbackforwardlist.h: Added.
12010 * WebView/webkitwebhistoryitem.cpp: Added.
12011 (_WebKitWebHistoryItemPrivate::webkit_history_items):
12012 (_WebKitWebHistoryItemPrivate::webkit_history_item_add):
12013 (_WebKitWebHistoryItemPrivate::webkit_history_item_remove):
12014 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
12015 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_finalize):
12016 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
12017 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_init):
12018 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
12019 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new):
12020 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
12021 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title):
12022 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title):
12023 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_set_alternate_title):
12024 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri):
12025 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri):
12026 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time):
12029 * WebView/webkitwebhistoryitem.h: Added.
12030 * WebView/webkitwebview.cpp:
12031 * WebView/webkitwebview.h:
12033 2008-01-25 Ori Bernstein <ori@eigenstate.org>
12035 Reviewed by Alp Toker.
12037 http://bugs.webkit.org/show_bug.cgi?id=16795
12038 WebKitGtk crashes when there is no focused Frame
12040 Add a null check. focusedFrame() isn't used directly anywhere else so
12041 this is the only case that needs to be fixed.
12043 * WebView/webkitwebview.cpp:
12045 2008-01-22 Christian Dywan <christian@imendio.com>
12047 Reviewed by Alp Toker.
12049 [GTK] API: WebKitWebSettings is not usable
12050 http://bugs.webkit.org/show_bug.cgi?id=16219
12052 Implement WebKitWebSettings.
12054 * WebView/headers.pri:
12055 * WebView/webkit.h:
12056 * WebView/webkitprivate.cpp:
12057 * WebView/webkitprivate.h:
12058 * WebView/webkitsettings.cpp: Removed.
12059 * WebView/webkitsettings.h: Removed.
12060 * WebView/webkitwebsettings.cpp: Added.
12061 * WebView/webkitwebsettings.h: Added.
12062 * WebView/webkitwebview.cpp:
12063 * WebView/webkitwebview.h:
12065 2008-01-21 Alp Toker <alp@atoker.com>
12067 GTK+ build fix for breakage introduced in r29698.
12069 * WebCoreSupport/ChromeClientGtk.h:
12071 2008-01-21 Darin Adler <darin@apple.com>
12073 Reviewed by John Sullivan.
12075 - updated for changes to database functions
12077 * WebCoreSupport/ChromeClientGtk.cpp:
12078 (WebKit::ChromeClient::exceededDatabaseQuota):
12079 * WebCoreSupport/ChromeClientGtk.h:
12080 * WebView/webkitprivate.cpp:
12083 2008-01-20 Alp Toker <alp@atoker.com>
12085 Reviewed by Mark Rowe.
12087 Attach the widget's style to its window and set the background to the
12088 base background to avoid black flicker when repainting. This is
12089 similar to what GtkTextView does.
12091 * WebView/webkitwebview.cpp:
12093 2008-01-19 Christian Dywan <christian@imendio.com>
12095 Reviewed by Alp Toker.
12097 http://bugs.webkit.org/show_bug.cgi?id=16882
12098 [GTK] ChromeClientGtk is incompete
12100 Implement these functions.
12102 * WebCoreSupport/ChromeClientGtk.cpp:
12103 (WebKit::ChromeClient::windowRect):
12104 (WebKit::ChromeClient::pageRect):
12105 (WebKit::ChromeClient::scaleFactor):
12106 (WebKit::ChromeClient::focus):
12107 (WebKit::ChromeClient::unfocus):
12108 (WebKit::ChromeClient::canTakeFocus):
12109 (WebKit::ChromeClient::takeFocus):
12110 (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel):
12112 2008-01-18 Luca Bruno <lethalman88@gmail.com>
12114 Reviewed by Alp Toker.
12116 http://bugs.webkit.org/show_bug.cgi?id=16910
12117 [GTK] REGRESSION: keyboard cursor doesn't blink
12119 http://bugs.webkit.org/show_bug.cgi?id=16863
12120 [GTK] REGRESSION: tab focusing doesn't work
12122 * WebView/webkitwebview.cpp:
12123 (webkit_web_view_focus_in_event): Added. Set the active frame.
12124 (webkit_web_view_class_init):
12126 2008-01-16 Alp Toker <alp@atoker.com>
12128 Reviewed by Mark Rowe.
12130 http://bugs.webkit.org/show_bug.cgi?id=16218
12131 [GTK] API: Should this entry point be called go_back rather than go_backward?
12133 Obsolete 'backward' terminology in API in favour of 'back'. Introduce
12134 step-based back/forward functions.
12136 Document more functions.
12138 * WebView/webkitdefines.h:
12139 * WebView/webkitwebview.cpp:
12140 * WebView/webkitwebview.h:
12142 2008-01-10 Maciej Stachowiak <mjs@apple.com>
12146 - remove SecurityOriginData and fold its functionality into SecurityOrigin
12148 * WebCoreSupport/ChromeClientGtk.cpp:
12149 (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase):
12150 (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
12151 * WebCoreSupport/ChromeClientGtk.h:
12153 2008-01-09 Luca Bruno <lethalman88@gmail.com>
12155 Reviewed by Alp Toker.
12157 http://bugs.webkit.org/show_bug.cgi?id=16802
12158 [GTK] Missing gtk properties
12160 Add missing properties to WebKitViewFrame and WebKitWebView.
12162 * WebView/webkitprivate.h: add some useful defines for param specs
12163 * WebView/webkitwebframe.cpp:
12164 (webkit_web_frame_get_property): added
12165 (webkit_web_frame_class_init): add name, title and uri read-only properties
12166 * WebView/webkitwebview.cpp:
12167 (webkit_web_view_get_property): add editable property read
12168 (webkit_web_view_set_property): added for editable property write
12169 (webkit_web_view_class_init): add read-write editable property
12171 2008-01-03 Xan Lopez <xan@gnome.org>
12173 Reviewed by Alp Toker.
12175 http://bugs.webkit.org/show_bug.cgi?id=16654
12176 [GTK] Signal "navigation-requested" does not react correctly on
12177 return TRUE from callbacks
12179 * WebView/webkitwebview.cpp: use our own accumulator for signals
12180 returning WebKitNavigationResponse. The emission will be stopped
12181 when any callback returns anything but
12182 WEBKIT_NAVIGATION_RESPONSE_ACCEPT.
12184 2008-01-02 Holger Hans Peter Freyther <zecke@selfish.org>
12186 Rubber stamped by Darin Adler.
12188 Coding Style fix. Do not use an else because we use a return in the
12191 * WebView/webkitwebview.cpp:
12193 2008-01-02 Luca Bruno <lethalman88@gmail.com>
12195 Reviewed by Alp Toker.
12197 http://bugs.webkit.org/show_bug.cgi?id=16115
12198 [GTK] ContextMenu and ContextMenuItem lacks an implementation
12200 Add context menu support.
12202 Based on a patch by Holger Freyther.
12204 * WebCoreSupport/ContextMenuClientGtk.cpp:
12205 (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):
12206 * WebView/webkitprivate.h:
12207 * WebView/webkitwebview.cpp:
12209 2007-12-29 Jan Michael Alonzo <jmalonzo@unpluggable.com>
12211 Reviewed by Alp Toker.
12213 http://bugs.webkit.org/show_bug.cgi?id=16669
12214 autotools update and fixes
12216 pkgconfig file and icon database inclusion fix
12218 * WebKitGtk.pc.in: Remove ICU_FLAGS from Cflags
12219 * WebView/webkitprivate.cpp: Guard ICONDATABASE inclusions
12221 2007-12-28 Christian Dywan <christian@twotoasts.de>
12223 Reviewed by Alp Toker.
12225 http://bugs.webkit.org/show_bug.cgi?id=16642
12226 [GTK] webkit_web_view_has_selection returns the opposite result
12228 Invert the return value.
12230 * WebView/webkitwebview.cpp:
12232 2007-12-26 Jan Michael Alonzo <jmalonzo@unpluggable.com>
12234 Reviewed by Alp Toker.
12236 http://bugs.webkit.org/show_bug.cgi?id=16390
12237 Use autotools or GNU make as the build system for the GTK port
12239 * WebKitGtk.pc.in: Added.
12241 2007-12-24 Christian Dywan <christian@twotoasts.de>
12243 Reviewed by Alp Toker.
12245 http://bugs.webkit.org/attachment.cgi?id=18099
12246 There are no NULL checks for strings in public api
12248 Add missing NULL checks for string parameters.
12250 Provide sensible defaults when NULL is passed for the optional
12251 parameters in webkit_web_view_load_string(). UTF-8 is the default
12252 encoding used by GLib and text/html is a reasonable default content
12255 * WebView/webkitnetworkrequest.cpp:
12256 * WebView/webkitwebview.cpp:
12258 2007-12-22 Xan Lopez <xan@gnome.org>
12260 Reviewed by Alp Toker.
12262 Use webView, web_view, etc for variable names instead of page, which
12263 was left over from the old API.
12265 * WebCoreSupport/EditorClientGtk.cpp:
12266 (WebKit::imContextCommitted):
12267 (WebKit::EditorClient::EditorClient):
12268 (WebKit::EditorClient::~EditorClient):
12269 (WebKit::EditorClient::textFieldDidBeginEditing):
12270 (WebKit::EditorClient::textFieldDidEndEditing):
12271 * WebCoreSupport/EditorClientGtk.h:
12272 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12273 (WebKit::FrameLoaderClient::postProgressStartedNotification):
12274 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
12275 (WebKit::FrameLoaderClient::postProgressFinishedNotification):
12276 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
12277 (WebKit::FrameLoaderClient::windowObjectCleared):
12278 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
12279 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
12280 (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
12282 2007-12-22 Alp Toker <alp@atoker.com>
12286 GTK_TARGET_OTHER_APP is not available in older GTK+ versions. Pass
12287 empty target flags for now.
12289 Check GTK+, not GLib versions, since they are different.
12291 * WebView/webkitwebview.cpp:
12293 2007-12-22 Luca Bruno <lethalman88@gmail.com>
12295 Reviewed by Alp Toker.
12297 http://bugs.webkit.org/show_bug.cgi?id=16311
12298 [Gtk] Copy rich text to clipboard as text/plain and text/html.
12300 Add copy and paste targets for WebView and implement
12301 WebCore::PasteboardHelper.
12303 * WebCoreSupport/PasteboardHelperGtk.cpp: Added.
12304 (WebKit::PasteboardHelperGtk::getClipboard):
12305 (WebKit::PasteboardHelperGtk::getCopyTargetList):
12306 (WebKit::PasteboardHelperGtk::getPasteTargetList):
12307 * WebCoreSupport/PasteboardHelperGtk.h: Added.
12308 * WebView/webkitprivate.cpp:
12309 (webkit_init): set the PasteboardHelperGtk as WebCore::Pasteboard helper
12310 * WebView/webkitprivate.h:
12311 (_WebKitWebViewPrivate::copy_target_list): added
12312 (_WebKitWebViewPrivate::paste_target_list): added
12313 * WebView/webkitwebview.cpp:
12314 (webkit_web_view_get_property): added
12315 (webkit_web_view_finalize):
12316 (webkit_web_view_class_init): create properties for COPY_TARGET and PASTE_TARGET and create the copy and paste target lists
12317 (webkit_web_view_get_copy_target_list): added
12318 (webkit_web_view_get_paste_target_list): added
12319 * WebView/webkitwebview.h:
12320 (webkit_web_view_get_copy_target_list): added
12321 (webkit_web_view_get_paste_target_list): added
12323 2007-12-22 Xan Lopez <xan@gnome.org>
12325 Reviewed by Alp Toker.
12327 Follow up to http://bugs.webkit.org/show_bug.cgi?id=16144
12329 * WebView/webkitwebview.cpp:
12330 Fix signal id arguments for g_signal_emit in
12331 clipboard functions.
12333 2007-12-21 Alp Toker <alp@atoker.com>
12335 Documentation typo fix: s/wether/whether
12337 * WebView/webkitwebview.cpp:
12339 2007-12-21 Christian Dywan <christian@twotoasts.de>
12341 Reviewed by Alp Toker.
12343 http://bugs.webkit.org/show_bug.cgi?id=16144
12344 [GTK] Clipboard/ selection handling functions
12346 * WebView/webkitprivate.h:
12347 * WebView/webkitwebview.cpp:
12348 * WebView/webkitwebview.h:
12350 2007-12-19 Christian Dywan <christian@twotoasts.de>
12352 Reviewed by Alp Toker.
12354 http://bugs.webkit.org/show_bug.cgi?id=16222
12355 [GTK] Implement inline search and highlighting of matching strings.
12357 * WebView/webkitwebview.cpp:
12358 * WebView/webkitwebview.h:
12360 2007-12-19 Alp Toker <alp@atoker.com>
12362 Reviewed by Holger Freyther.
12364 Delete when Destroy functions are called to avoid leaks
12366 This matches the Mac port.
12368 * WebCoreSupport/ChromeClientGtk.cpp:
12369 * WebCoreSupport/ContextMenuClientGtk.cpp:
12370 * WebCoreSupport/InspectorClientGtk.cpp:
12372 2007-12-14 Juan A. Suarez Romero <jasuarez@igalia.com>
12374 Reviewed by Alp Toker.
12376 http://bugs.webkit.org/show_bug.cgi?id=16042
12377 [GTK] Eliminate webkit_init()
12379 Move webkit initialization to WebView class init.
12381 * WebView/headers.pri:
12382 * WebView/webkit.h:
12383 * WebView/webkitglobal.cpp: Removed.
12384 * WebView/webkitglobal.h: Removed.
12385 * WebView/webkitprivate.cpp:
12386 (WebKit::webkit_init):
12387 * WebView/webkitprivate.h:
12388 * WebView/webkitwebframe.cpp:
12389 * WebView/webkitwebview.cpp:
12391 2007-12-17 Luca Bruno <lethalman88@gmail.com>
12393 Reviewed by Alp Toker.
12395 http://bugs.webkit.org/show_bug.cgi?id=13542
12396 gdklauncher doesnt change URL in adress GTKEntry.
12398 Let DOMDocument observers do their work before emitting title-changed.
12399 The load-committed signal has been added for both the view and the frame.
12401 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12402 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle): emit title-changed
12403 (WebKit::FrameLoaderClient::setTitle): set private title
12404 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): update the frame uri and emit load-committed
12405 * WebView/webkit-marshal.list:
12406 * WebView/webkitprivate.h:
12407 (_WebKitWebFramePrivate): rename location to uri
12408 * WebView/webkitwebframe.cpp:
12409 (webkit_web_frame_get_location): renamed to *_get_uri
12410 (webkit_web_frame_get_uri):
12411 (webkit_web_frame_real_title_changed): removed (see FrameLoaderClient::setTitle)
12412 (webkit_web_frame_class_init): pass the frame and the title in title-changed, not the uri
12413 (webkit_web_frame_finalize):
12414 * WebView/webkitwebframe.h:
12415 (_WebKitWebFrameClass): removed title_changed
12416 * WebView/webkitwebview.cpp:
12417 (webkit_web_view_class_init): pass only the title in title-changed
12419 2007-12-14 Alp Toker <alp@atoker.com>
12421 Fix inconsistent indentation in the license header. Maciej was right!
12423 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12425 2007-12-14 Alp Toker <alp@atoker.com>
12427 Reviewed by Maciej.
12429 http://bugs.webkit.org/show_bug.cgi?id=16432
12430 [GTK] Update license headers
12432 Consent has been given by the authors of these files to change license
12433 to the LGPL as outlined in the bug report.
12435 * WebCoreSupport/ChromeClientGtk.cpp:
12436 * WebCoreSupport/ContextMenuClientGtk.cpp:
12437 * WebCoreSupport/DragClientGtk.cpp:
12438 * WebCoreSupport/EditorClientGtk.cpp:
12439 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12440 (WebKit::FrameLoaderClient::makeRepresentation):
12441 (WebKit::FrameLoaderClient::forceLayout):
12442 (WebKit::FrameLoaderClient::forceLayoutForNonHTML):
12443 (WebKit::FrameLoaderClient::setCopiesOnScroll):
12444 (WebKit::FrameLoaderClient::detachedFromParent1):
12445 (WebKit::FrameLoaderClient::detachedFromParent2):
12446 (WebKit::FrameLoaderClient::detachedFromParent3):
12447 (WebKit::FrameLoaderClient::detachedFromParent4):
12448 (WebKit::FrameLoaderClient::loadedFromCachedPage):
12449 (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents):
12450 (WebKit::FrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
12451 (WebKit::FrameLoaderClient::dispatchDidCancelClientRedirect):
12452 (WebKit::FrameLoaderClient::dispatchWillPerformClientRedirect):
12453 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
12454 (WebKit::FrameLoaderClient::dispatchWillClose):
12455 (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
12456 (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad):
12457 (WebKit::FrameLoaderClient::dispatchDidFirstLayout):
12458 (WebKit::FrameLoaderClient::dispatchShow):
12459 (WebKit::FrameLoaderClient::cancelPolicyCheck):
12460 (WebKit::FrameLoaderClient::dispatchDidLoadMainResource):
12461 (WebKit::FrameLoaderClient::revertToProvisionalState):
12462 (WebKit::FrameLoaderClient::clearUnarchivingState):
12463 (WebKit::FrameLoaderClient::willChangeTitle):
12464 (WebKit::FrameLoaderClient::didChangeTitle):
12465 (WebKit::FrameLoaderClient::finalSetupForReplace):
12466 (WebKit::FrameLoaderClient::setDefersLoading):
12467 (WebKit::FrameLoaderClient::isArchiveLoadPending):
12468 (WebKit::FrameLoaderClient::cancelPendingArchiveLoad):
12469 (WebKit::FrameLoaderClient::clearArchivedResources):
12470 (WebKit::FrameLoaderClient::canHandleRequest):
12471 (WebKit::FrameLoaderClient::canShowMIMEType):
12472 (WebKit::FrameLoaderClient::representationExistsForURLScheme):
12473 (WebKit::FrameLoaderClient::generatedMIMETypeForURLScheme):
12474 (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
12475 (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
12476 (WebKit::FrameLoaderClient::dispatchDidFailLoading):
12477 (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
12478 (WebKit::FrameLoaderClient::download):
12479 (WebKit::FrameLoaderClient::cancelledError):
12480 (WebKit::FrameLoaderClient::blockedError):
12481 (WebKit::FrameLoaderClient::cannotShowURLError):
12482 (WebKit::FrameLoaderClient::interruptForPolicyChangeError):
12483 (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
12484 (WebKit::FrameLoaderClient::fileDoesNotExistError):
12485 (WebKit::FrameLoaderClient::shouldFallBack):
12486 (WebKit::FrameLoaderClient::willUseArchive):
12487 (WebKit::FrameLoaderClient::canCachePage):
12488 (WebKit::FrameLoaderClient::dispatchCreatePage):
12489 (WebKit::FrameLoaderClient::dispatchUnableToImplementPolicy):
12490 (WebKit::FrameLoaderClient::setMainDocumentError):
12491 (WebKit::FrameLoaderClient::startDownload):
12492 (WebKit::FrameLoaderClient::updateGlobalHistoryForStandardLoad):
12493 (WebKit::FrameLoaderClient::updateGlobalHistoryForReload):
12494 (WebKit::FrameLoaderClient::savePlatformDataToCachedPage):
12495 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage):
12496 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
12497 * WebCoreSupport/InspectorClientGtk.cpp:
12498 * WebView/webkitwebview.cpp:
12500 2007-12-14 Darin Adler <darin@apple.com>
12502 Reviewed by Alexey.
12504 * WebCoreSupport/EditorClientGtk.cpp:
12505 (WebKit::EditorClient::handleKeyboardEvent): Changed to use Editor::command
12506 instead of Editor::execCommand.
12507 * WebView/webkitwebview.cpp: Ditto.
12509 2007-12-12 Brady Eidson <beidson@apple.com>
12511 Reviewed by Sam Weinig
12513 As part of doing some CachedPage and client cleanup, keep GTK building
12515 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12516 (WebKit::FrameLoaderClient::savePlatformDataToCachedPage):
12517 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage):
12518 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
12519 * WebCoreSupport/FrameLoaderClientGtk.h:
12521 2007-12-12 Alp Toker <alp@atoker.com>
12523 Reviewed by Holger Freyther.
12525 http://bugs.webkit.org/show_bug.cgi?id=15576
12526 [GTK] Printing support
12528 Add printing support.
12530 The API will be kept internal for the time being, but printing can now
12531 be triggered by Web pages or the JSC API using JavaScript.
12533 The print spooler and pagination code is fairly abstract and could be
12534 shared by other ports including Win and Qt once complete. It doesn't
12535 have header/footer support yet.
12537 * WebCoreSupport/ChromeClientGtk.cpp:
12538 (WebKit::ChromeClient::print):
12539 * WebView/webkitprivate.h:
12540 * WebView/webkitwebframe.cpp:
12541 (PrintContext::begin_print):
12542 (PrintContext::draw_page):
12543 (PrintContext::end_print):
12544 (PrintContext::webkit_web_frame_print):
12546 2007-12-12 Sam Weinig <sam@webkit.org>
12550 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12551 (WebKit::FrameLoaderClient::didChangeTitle):
12553 2007-12-12 Sam Weinig <sam@webkit.org>
12557 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12558 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
12560 2007-12-11 George Wright <george.wright@collabora.co.uk>
12562 Reviewed by Alp Toker.
12564 http://bugs.webkit.org/show_bug.cgi?id=14120
12565 [GDK] Support input methods
12567 This patch adds infrastructure for input method support.
12569 It also adds Hildon features for the Maemo mobile platform sufficient
12570 to support the virtual keyboard.
12572 * WebCoreSupport/EditorClientGtk.cpp:
12573 (WebKit::imContextCommitted):
12574 (WebKit::EditorClient::EditorClient):
12575 (WebKit::EditorClient::~EditorClient):
12576 (WebKit::EditorClient::textFieldDidBeginEditing):
12577 (WebKit::EditorClient::textFieldDidEndEditing):
12578 * WebCoreSupport/EditorClientGtk.h:
12579 * WebView/webkitprivate.h:
12580 * WebView/webkitwebview.cpp:
12582 2007-12-07 Alexey Proskuryakov <ap@webkit.org>
12584 Reviewed by Darin Adler.
12586 <rdar://problem/5535636>
12587 Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
12589 http://bugs.webkit.org/show_bug.cgi?id=13916
12590 JavaScript detects Tab as a character input on a textfield validation
12592 * WebCoreSupport/EditorClientGtk.cpp:
12593 (WebKit::EditorClient::handleKeyboardEvent):
12594 (WebKit::EditorClient::handleInputMethodKeydown):
12595 * WebCoreSupport/EditorClientGtk.h:
12596 Updated for cross-platform changes as much as it was possible without a gtk build environment.
12598 2007-12-08 Luca Bruno <lethalman88@gmail.com>
12600 Reviewed by Alp Toker.
12602 http://bugs.webkit.org/show_bug.cgi?id=16346
12603 [GTK] Some webview parts must use the focused frame.
12605 Also update some old code.
12607 * WebView/webkitprivate.cpp:
12608 (getFrameFromView): removed
12610 * WebView/webkitprivate.h:
12611 (getFrameFromView): removed
12613 * WebView/webkitwebview.cpp:
12614 (webkit_web_view_expose_event):
12615 (webkit_web_view_key_press_event): use focused frame
12616 (webkit_web_view_key_release_event): use focused frame
12617 (webkit_web_view_button_press_event):
12618 (webkit_web_view_button_release_event):
12619 (webkit_web_view_motion_event):
12620 (webkit_web_view_scroll_event):
12621 (webkit_web_view_size_allocate):
12622 (webkit_web_view_set_scroll_adjustments):
12623 (webkit_web_view_execute_script):
12624 (webkit_web_view_stop_loading):
12625 (webkit_web_view_load_string):
12626 (webkit_web_view_reload):
12627 (webkit_web_view_open):
12628 (webkit_web_view_can_go_forward):
12629 (webkit_web_view_can_go_backward):
12630 (webkit_web_view_go_forward):
12631 (webkit_web_view_go_backward):
12633 * WebCoreSupport/EditorClientGtk.cpp:
12634 (WebKit::EditorClient::handleKeypress): fix for page up and page down keys for editable contents
12636 2007-12-07 Luca Bruno <lethalman88@gmail.com>
12638 Reviewed by Alp Toker.
12640 http://bugs.webkit.org/show_bug.cgi?id=16333
12641 [GTK] Key bindings must work with focused frames.
12643 There are still more cases where getFrameFromView() is mis-used that
12644 need to be fixed, but this is a good start.
12646 * WebView/webkitwebview.cpp:
12647 (webkit_web_view_real_select_all):
12648 (webkit_web_view_real_cut_clipboard):
12649 (webkit_web_view_real_copy_clipboard):
12650 (webkit_web_view_real_paste_clipboard):
12652 2007-12-06 Xan Lopez <xan@gnome.org>
12654 Reviewed by Alp Toker.
12656 http://bugs.webkit.org/show_bug.cgi?id=16329
12657 [GTK] Two small cleanups
12659 * WebCoreSupport/ChromeClientGtk.cpp:
12660 (WebKit::ChromeClient::createWindow):
12661 (WebKit::ChromeClient::addMessageToConsole):
12662 (WebKit::ChromeClient::runJavaScriptAlert):
12663 (WebKit::ChromeClient::runJavaScriptConfirm):
12664 (WebKit::ChromeClient::runJavaScriptPrompt):
12665 (WebKit::ChromeClient::setStatusbarText):
12666 (WebKit::ChromeClient::mouseDidMoveOverElement):
12667 (WebKit::ChromeClient::setToolTip):
12668 * WebCoreSupport/ChromeClientGtk.h:
12669 * WebView/webkitprivate.cpp:
12671 s/m_webPage/m_webView/
12672 * WebView/webkitwebview.cpp:
12673 Chain up to the parent class to activate bindings instead
12674 of doing it explicitely.
12676 2007-12-06 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
12678 Reviewed by Alp Toker.
12680 http://bugs.webkit.org/show_bug.cgi?id=16173
12683 Change license from BSD to LGPL.
12685 * WebCoreSupport/ChromeClientGtk.h:
12686 * WebView/webkitdefines.h:
12687 * WebView/webkitglobal.cpp:
12688 * WebView/webkitglobal.h:
12689 * WebView/webkitnetworkrequest.cpp:
12690 * WebView/webkitnetworkrequest.h:
12691 * WebView/webkitprivate.cpp:
12692 * WebView/webkitprivate.h:
12693 * WebView/webkitsettings.cpp:
12694 * WebView/webkitsettings.h:
12695 * WebView/webkitwebframe.cpp:
12696 * WebView/webkitwebframe.h:
12697 * WebView/webkitwebview.h:
12699 2007-12-05 Michael Natterer <mitch@imendio.com>
12701 Reviewed by Alp Toker.
12703 * WebView/webkitwebview.cpp: split key and button event handlers
12704 into separate press and release functions.
12706 2007-12-05 Luca Bruno <lethalman88@gmail.com>
12708 Reviewed by Alp Toker.
12710 Handle events for Home and End keys.
12712 * WebView/webkitwebview.cpp:
12713 (webkit_web_view_key_event):
12714 * WebCoreSupport/EditorClientGtk.cpp:
12715 (EditorClient::handleKeypress):
12717 2007-12-05 Michael Natterer <mitch@imendio.com>
12719 Reviewed by Alp Toker.
12721 * WebView/webkitwebview.cpp
12722 * WebCoreSupport/ChromeClientGtk.cpp
12723 * WebCoreSupport/FrameLoaderClientGtk.cpp: canonicalize signal names.
12725 2007-12-04 Darin Adler <darin@apple.com>
12727 Reviewed by Kevin Decker.
12729 * WebCoreSupport/FrameLoaderClientGtk.cpp: Removed obsolete privateBrowsingEnabled.
12730 * WebCoreSupport/FrameLoaderClientGtk.h: Ditto.
12732 2007-12-04 Michael Natterer <mitch@imendio.com>
12734 Reviewed by Alp Toker.
12736 * WebView/webkitwebframe.cpp: don't redeclare the marshaller
12737 prototype but simply include "webkit-marshal.h" now that its build
12740 2007-12-04 Luca Bruno <lethalman88@gmail.com>
12742 Reviewed by Alp Toker.
12744 Fix a regression in key press propagation in r28386.
12746 Fix indentation (was off by two spaces).
12748 * WebView/webkitwebview.cpp:
12750 2007-12-04 Luca Bruno <lethalman88@gmail.com>
12752 Reviewed by Alp Toker.
12754 http://bugs.webkit.org/show_bug.cgi?id=15911
12755 [GTK] Use GtkBindingSet to make key bindings user-configurable
12757 This patch doesn't cover the full range of bindings, only the ones
12758 that seem obviously correct and have clear public API.
12760 * WebCoreSupport/EditorClientGtk.cpp:
12761 (WebKit::EditorClient::handleKeypress): do not handle clipboard operations and select-all
12762 * WebView/webkitwebview.cpp: add cut, copy, paste and select-all signals and allow binding sets (issue #15911 and #16144)
12763 * WebView/webkitwebview.h:
12765 2007-12-04 Xan Lopez <xan@gnome.org>
12767 Reviewed by Alp Toker.
12769 http://bugs.webkit.org/show_bug.cgi?id=15561
12770 GTK port needs DumpRenderTree implementation
12772 Start work on the GTK+ DRT.
12774 Add a couple of proposed new API entry points. They are currently for
12775 internal use only by DRT and not in the public headers.
12777 * WebView/webkitprivate.h:
12778 * WebView/webkitwebframe.cpp:
12780 2007-12-03 Dan Bernstein <mitz@apple.com>
12782 Reviewed by Dave Hyatt.
12784 - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
12786 * WebView/webkitwebview.cpp: Remove the call to sendResizeEvent() since
12787 FrameView sends it now.
12789 2007-12-03 Alp Toker <alp@atoker.com>
12791 globalObject() GTK+ build fix.
12793 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12794 (WebKit::FrameLoaderClient::windowObjectCleared):
12796 2007-12-03 Geoffrey Garen <ggaren@apple.com>
12798 GTK Build fix: get globalExec from the right place.
12800 * WebView/webkitwebframe.cpp:
12802 2007-12-01 Alp Toker <alp@atoker.com>
12804 Reviewed by Adam Roben.
12806 Wrap type definitions in webkitdefines.h with G_BEGIN_DECLS, which
12807 takes care of extern "C".
12809 Introduce a webkit.h convenience header.
12811 Remove another left-over from the old API.
12813 * WebView/headers.pri:
12814 * WebView/webkit.h: Added.
12815 * WebView/webkitdefines.h:
12817 2007-12-01 Alp Toker <alp@atoker.com>
12819 Reviewed by Adam Roben.
12821 http://bugs.webkit.org/show_bug.cgi?id=15687
12822 [Gtk] Allow API clients to interact with JavaScript in web pages
12824 Include the necessary JavaScriptCore headers directly in the public
12827 This is the last of a series of changes needed to allow GTK+
12828 applications to access the JS API.
12830 Until http://bugs.webkit.org/show_bug.cgi?id=16029 is resolved,
12831 developers will still have to include the individual JS API headers
12832 individually if they want to use it in their applications.
12834 Patch also removes some old legacy use of GDK that was in
12835 WebKitWebFrame. No ABI change.
12837 * WebView/webkitdefines.h:
12838 * WebView/webkitwebframe.h:
12839 * WebView/webkitwebview.h:
12841 2007-11-30 Jan Michael Alonzo <jmalonzo@unpluggable.com>
12843 Fix for GTK+ Debug build breakage introduced in r28273.
12845 * WebView/webkitprivate.cpp:
12848 2007-11-30 Alp Toker <alp@atoker.com>
12850 Reviewed by Adam Roben.
12852 http://bugs.webkit.org/show_bug.cgi?id=15691
12853 [GTK] Public API does not follow GTK+ conventions
12855 Refactor the WebKit/GTK+ public API. Changes:
12856 WebKitPage -> WebKitWebView
12857 WebKitFrame -> WebKitWebFrame
12859 Public API source and header names have been updated to mirror the API
12862 The API is now kept in WebKit/gtk/WebView to match other ports in the
12863 same class such as Mac and Win.
12865 API/ABI-breaking change.
12868 * Api/headers.pri: Removed.
12869 * Api/webkitgtk-marshal.list: Removed.
12870 * Api/webkitgtkdefines.h: Removed.
12871 * Api/webkitgtkframe.cpp: Removed.
12872 * Api/webkitgtkframe.h: Removed.
12873 * Api/webkitgtkglobal.cpp: Removed.
12874 * Api/webkitgtkglobal.h: Removed.
12875 * Api/webkitgtknetworkrequest.cpp: Removed.
12876 * Api/webkitgtknetworkrequest.h: Removed.
12877 * Api/webkitgtkpage.cpp: Removed.
12878 * Api/webkitgtkpage.h: Removed.
12879 * Api/webkitgtkprivate.cpp: Removed.
12880 * Api/webkitgtkprivate.h: Removed.
12881 * Api/webkitgtksettings.cpp: Removed.
12882 * Api/webkitgtksettings.h: Removed.
12883 * WebCoreSupport/ChromeClientGtk.cpp:
12884 (WebKit::ChromeClient::ChromeClient):
12885 (WebKit::ChromeClient::createWindow):
12886 * WebCoreSupport/ChromeClientGtk.h:
12887 (WebKit::ChromeClient::webPage):
12888 * WebCoreSupport/EditorClientGtk.cpp:
12889 (WebKit::EditorClient::isEditable):
12890 (WebKit::EditorClient::EditorClient):
12891 * WebCoreSupport/EditorClientGtk.h:
12892 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12893 (WebKit::FrameLoaderClient::FrameLoaderClient):
12894 (WebKit::FrameLoaderClient::postProgressStartedNotification):
12895 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
12896 (WebKit::FrameLoaderClient::postProgressFinishedNotification):
12897 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
12898 (WebKit::FrameLoaderClient::createFrame):
12899 (WebKit::FrameLoaderClient::windowObjectCleared):
12900 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
12901 (WebKit::FrameLoaderClient::setTitle):
12902 * WebCoreSupport/FrameLoaderClientGtk.h:
12903 (WebKit::FrameLoaderClient::webFrame):
12905 * WebView/headers.pri: Added.
12906 * WebView/webkit-marshal.list: Added.
12907 * WebView/webkitdefines.h: Added.
12908 * WebView/webkitglobal.cpp: Added.
12909 * WebView/webkitglobal.h: Added.
12910 * WebView/webkitnetworkrequest.cpp: Added.
12911 * WebView/webkitnetworkrequest.h: Added.
12912 * WebView/webkitprivate.cpp: Added.
12915 (WebKit::getFrameFromView):
12916 (WebKit::getViewFromFrame):
12919 * WebView/webkitprivate.h: Added.
12920 * WebView/webkitsettings.cpp: Added.
12921 * WebView/webkitsettings.h: Added.
12922 * WebView/webkitwebframe.cpp: Added.
12923 * WebView/webkitwebframe.h: Added.
12924 * WebView/webkitwebview.cpp: Added.
12925 * WebView/webkitwebview.h: Added.
12927 2007-11-28 Alp Toker <alp@atoker.com>
12929 Reviewed by Timothy Hatcher.
12931 http://bugs.webkit.org/show_bug.cgi?id=16174
12932 [GTK] Use "URI" not "URL" in public API
12934 Replace use of the term "URL" with "URI" in public headers,
12935 documentation and some internal code to match GLib/GTK+ convention.
12937 This is now mentioned in the API guidelines:
12938 http://trac.webkit.org/projects/webkit/wiki/HackingGtk
12940 API/ABI-breaking change.
12942 * Api/webkitgtkframe.cpp:
12943 * Api/webkitgtknetworkrequest.cpp:
12944 * Api/webkitgtknetworkrequest.h:
12945 * Api/webkitgtkpage.cpp:
12946 * Api/webkitgtkpage.h:
12947 * Api/webkitgtkprivate.h:
12948 * Api/webkitgtksettings.h:
12950 2007-11-29 Brady Eidson <beidson@apple.com>
12952 Better build fix for Gtk
12954 * WebCoreSupport/ChromeClientGtk.h:
12956 2007-11-29 Brady Eidson <beidson@apple.com>
12958 Keep it building with new client method
12960 * WebCoreSupport/ChromeClientGtk.cpp:
12961 (WebKit::ChromeClient::requestQuotaIncreaseForNewDatabase):
12962 (WebKit::ChromeClient::requestQuotaIncreaseForDatabaseOperation):
12963 * WebCoreSupport/ChromeClientGtk.h:
12965 2007-11-26 Alp Toker <alp@atoker.com>
12967 Reviewed by Adam Roben.
12969 http://bugs.webkit.org/show_bug.cgi?id=16149
12970 Implement the window-object-cleared signal
12972 This implementation provides the JSGlobalContextRef and JSObjectRef
12973 directly rather than using an intermediate JS wrapper object, similar
12974 to the approach taken by the Win port.
12976 * Api/webkitgtk-marshal.list:
12977 * Api/webkitgtkframe.h:
12978 * Api/webkitgtkpage.cpp:
12979 * Api/webkitgtkpage.h:
12980 * WebCoreSupport/FrameLoaderClientGtk.cpp:
12981 (WebKit::FrameLoaderClient::windowObjectCleared):
12983 2007-11-24 Alp Toker <alp@atoker.com>
12985 Reviewed by Mark Rowe.
12987 http://bugs.webkit.org/show_bug.cgi?id=15691
12988 [GTK] Public API does not follow GTK+ conventions
12990 Public API enhancements:
12992 Implement webkit_page_get_editable() and webkit_page_set_editable().
12994 Implement webkit_frame_get_name().
12996 Remove definitions for functions that are unusable or not implemented.
12997 This has caused much confusion for application developers.
12999 Improve documentation.
13001 Correct/constify some return types.
13003 Add parameter checks.
13005 Make the default fixed font "Courier New" to match the other Web
13008 * Api/webkitgtkframe.cpp:
13009 * Api/webkitgtkframe.h:
13010 * Api/webkitgtkpage.cpp:
13011 * Api/webkitgtkpage.h:
13012 * Api/webkitgtkprivate.h:
13013 * WebCoreSupport/EditorClientGtk.cpp:
13014 (WebKit::EditorClient::isEditable):
13016 2007-11-24 Alp Toker <alp@atoker.com>
13018 Reviewed by Mark Rowe.
13020 http://bugs.webkit.org/show_bug.cgi?id=16125
13021 [GTK] Up key doesn't work properly when content is editable
13023 Add a missing 'break' to avoid falling through to the next case when
13024 handling VK_UP keystrokes. This was noticed when working on editing
13025 support in the GTK+ port.
13027 I've checked the other cases for similar typos and they seem fine.
13029 * WebCoreSupport/EditorClientGtk.cpp:
13030 (WebKit::EditorClient::handleKeypress):
13032 2007-11-24 Xan Lopez <xan@gnome.org>
13034 Reviewed by Alp Toker.
13036 http://bugs.webkit.org/show_bug.cgi?id=15745
13037 [GTK] Arrow keys do not Scroll
13039 * Api/webkitgtkpage.cpp:
13041 Support Up/Down/Right/Left keys to scroll. Slight hack, see FIXME for
13044 2007-11-24 Christian Dywan <christian@twotoasts.de>
13046 Reviewed by Alp Toker.
13048 http://bugs.webkit.org/show_bug.cgi?id=15891
13049 [GTK] Javascript console and dialogs are not implemented
13051 Fix call to gtk_message_dialog_new() which expects a format string.
13053 * Api/webkitgtkpage.cpp:
13055 2007-11-24 Christian Dywan <christian@twotoasts.de>
13057 Reviewed by Alp Toker.
13059 http://bugs.webkit.org/show_bug.cgi?id=15793
13060 [GTK] Webkit doesn't show title attribute tooltip when hovering over an image
13062 Implement tooltip support using the new Tooltip API.
13064 Support for older versions of GTK+ is still lacking.
13066 * WebCoreSupport/ChromeClientGtk.cpp:
13067 (WebKit::ChromeClient::setToolTip):
13069 2007-11-22 Alp Toker <alp@atoker.com>
13071 Reviewed by Mark Rowe.
13073 Implement and document several WebKitFrame functions, some of which
13074 are necessary to support DRT.
13076 Correct NULL handling and improve run-time checks.
13078 * Api/webkitgtkframe.cpp:
13079 * Api/webkitgtkframe.h:
13080 * Api/webkitgtkprivate.cpp:
13082 2007-11-22 Alp Toker <alp@atoker.com>
13084 Whitespace fixes only.
13086 * Api/webkitgtkframe.cpp:
13087 * Api/webkitgtkpage.cpp:
13088 * Api/webkitgtkpage.h:
13089 * Api/webkitgtkprivate.h:
13090 * WebCoreSupport/ChromeClientGtk.cpp:
13091 * WebCoreSupport/ContextMenuClientGtk.cpp:
13092 * WebCoreSupport/ContextMenuClientGtk.h:
13093 * WebCoreSupport/DragClientGtk.h:
13094 * WebCoreSupport/EditorClientGtk.h:
13095 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13096 (WebKit::FrameLoaderClient::dispatchWillSendRequest):
13097 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
13098 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
13099 (WebKit::FrameLoaderClient::createFrame):
13100 (WebKit::FrameLoaderClient::createJavaAppletWidget):
13101 (WebKit::FrameLoaderClient::registerForIconNotification):
13102 (WebKit::FrameLoaderClient::setMainFrameDocumentReady):
13103 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
13104 (WebKit::FrameLoaderClient::frameLoadCompleted):
13105 (WebKit::FrameLoaderClient::saveViewStateToItem):
13106 (WebKit::FrameLoaderClient::restoreViewState):
13107 (WebKit::FrameLoaderClient::shouldGoToHistoryItem):
13108 (WebKit::FrameLoaderClient::setTitle):
13109 * WebCoreSupport/FrameLoaderClientGtk.h:
13111 2007-11-22 Michael Natterer <mitch@imendio.com>
13113 Reviewed by Alp Toker.
13115 http://bugs.webkit.org/show_bug.cgi?id=15984
13116 Implement "navigation-requested" signal for WebKit Gtk
13118 * Api/webkitgtknetworkrequest.h: fix parent class member.
13120 * Api/webkitgtknetworkrequest.cpp
13121 * Api/webkitgtkprivate.h: basic implementation featuring an
13122 "url" member and API.
13124 * Api/webkitgtkdefines.h: added network request typedefs.
13126 * Api/webkitgtkpage.h: fix enum name:
13127 s/WEBKIT_NAVIGATION_REQUEST_RESPONSE/WebKitNavigationRequestResponse/
13128 and sanitized enum values.
13130 * Api/webkitgtkpage.cpp: made "navigation-requested" a signal.
13132 * Api/webkitgtk-marshal.list: added INT:OBJECT,OBJECT
13134 * WebCoreSupport/FrameLoaderClientGtk.cpp: emit the new signal in
13135 dispatchDecidePolicyForNavigationAction().
13137 2007-11-18 Christian Dywan <christian@twotoasts.de>
13141 http://bugs.webkit.org/show_bug.cgi?id=15891
13142 [GTK] Javascript console and dialogs are not implemented
13144 Correct script-prompt to return NULL when cancelled.
13146 Small changes to avoid compiler warnings.
13148 * Api/webkitgtkpage.cpp:
13150 2007-11-17 Timothy Hatcher <timothy@apple.com>
13152 Reviewed by Mark Rowe.
13154 Bug 13470: i18n: The Web Inspector is not localizable
13155 http://bugs.webkit.org/show_bug.cgi?id=13470
13157 * WebCoreSupport/InspectorClientGtk.cpp:
13158 (WebKit::InspectorClient::localizedStringsURL): Empty stub.
13159 * WebCoreSupport/InspectorClientGtk.h: Add localizedStringsURL.
13161 2007-11-13 Mark Rowe <mrowe@apple.com>
13163 Gtk build fix. Replace incorrect use of the LOG macro with g_print.
13165 * Api/webkitgtkpage.cpp:
13167 2007-11-13 Christian Dywan <christian@twotoasts.de>
13171 http://bugs.webkit.org/show_bug.cgi?id=15891
13172 [GTK] Javascript console and dialogs are not implemented
13174 Implement signals for script dialogs and console messages.
13176 * Api/webkitgtk-marshal.list:
13177 * Api/webkitgtkpage.cpp:
13178 * Api/webkitgtkpage.h:
13179 * WebCoreSupport/ChromeClientGtk.cpp:
13180 (WebKit::ChromeClient::addMessageToConsole):
13181 (WebKit::ChromeClient::runJavaScriptAlert):
13182 (WebKit::ChromeClient::runJavaScriptConfirm):
13183 (WebKit::ChromeClient::runJavaScriptPrompt):
13185 2007-11-11 Alp Toker <alp@atoker.com>
13187 Reviewed by Anders.
13189 Initialize m_userAgent.
13191 Fix typos in GDK_WINDOWING conditionals.
13193 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13194 (WebKit::FrameLoaderClient::FrameLoaderClient):
13195 (WebKit::agentPlatform):
13197 2007-11-11 Alp Toker <alp@atoker.com>
13199 Reviewed by Mark Rowe.
13201 Mention Safari in the UserAgent string to improve site compatibility.
13203 Also bump the hard-coded AppleWebKit version number.
13205 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13206 (WebKit::composeUserAgent):
13208 2007-11-09 Xan Lopez <xan@gnome.org>
13212 Fix http://bugs.webkit.org/show_bug.cgi?id=15926
13213 [GTK] WebKitPage map handler is redundant.
13215 * Api/webkitgtkpage.cpp:
13216 The map handler for WebKitPage is redundant, GtkContainer does
13217 the same (and more correctly).
13219 2007-11-08 Alp Toker <alp@atoker.com>
13221 Reviewed by Mark Rowe.
13223 http://bugs.webkit.org/show_bug.cgi?id=15653
13224 [GTK] Text editor does not handle common keystrokes
13226 Handle more keystrokes in EditorClientGtk. Note that this is a
13227 temporary measure pending a proper solution using GtkBindingSet (see
13228 http://bugs.webkit.org/show_bug.cgi?id=15911).
13230 * WebCoreSupport/EditorClientGtk.cpp:
13231 (WebKit::EditorClient::handleKeypress):
13233 2007-11-08 Kevin McCullough <kmccullough@apple.com>
13237 - windowObjectCleared() is no longer const. It needs to setup the
13238 script debugger and cannot be const to do so.
13240 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13241 (WebKit::FrameLoaderClient::windowObjectCleared):
13242 * WebCoreSupport/FrameLoaderClientGtk.h:
13244 2007-11-06 Rodney Dawes <dobey@wayofthemonkey.com>
13246 Fix http://bugs.webkit.org/attachment.cgi?id=17043&action=view
13247 Bug 15766: [GTK] WebKit sometimes spews binary data as text/plain into iframes
13249 FrameLoaderClient::objectContentType needs to check with the MIMETypeRegistry
13250 to determine whether the given MIME type is displayable as an image or non-image.
13252 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13253 (FrameLoaderClient::objectContentType): Change logic to match that in
13254 the Windows and Mac ports.
13256 2007-11-05 Christian Dywan <christian@twotoasts.de>
13258 Reviewed by Maciej.
13260 http://bugs.webkit.org/show_bug.cgi?id=15409
13261 FrameLoaderClientGtk hardcodes data, including platform to Linux i686
13263 Compute a proper user agent string.
13265 Patch includes fixes by Alp.
13267 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13268 (WebKit::agentPlatform):
13270 (WebKit::composeUserAgent):
13271 (WebKit::FrameLoaderClient::userAgent):
13272 * WebCoreSupport/FrameLoaderClientGtk.h:
13274 2007-11-05 Mark Rowe <mrowe@apple.com>
13276 Rubber-stamped by Alp Toker.
13278 Remove unused m_firstData member from FrameLoaderClientGtk.
13280 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13281 * WebCoreSupport/FrameLoaderClientGtk.h:
13283 2007-11-05 Mark Rowe <mrowe@apple.com>
13285 Reviewed by Alp Toker.
13287 Fix http://bugs.webkit.org/show_bug.cgi?id=15842
13288 Bug 15842: [Gtk] about:blank doesn't work
13290 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13291 (WebKit::FrameLoaderClient::finishedLoading): Set the encoding on the frame loader to
13292 get work done that is normally done when the first bit of data is received, even in the
13293 case of a document with no data (like about:blank).
13295 2007-11-03 Alp Toker <alp@atoker.com>
13297 Reviewed by Mark Rowe.
13299 Restore correct double and triple click behaviour
13301 We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
13302 recent refactoring.
13304 * Api/webkitgtkpage.cpp:
13306 2007-11-03 Alp Toker <alp@atoker.com>
13308 Reviewed by Mark Rowe.
13310 Frame scrolling and invalidation fixes
13312 Make upward scroll events have a positive delta to match other ports.
13314 Fix the invalidation rect offset for frames so that scrolling works properly.
13316 Avoid allocating negative sizes to widgets to avoid GTK+ warnings.
13318 Allow tabbing to all widgets and links.
13320 Fix event returns, improving the focus situation and correcting scroll wheel
13323 * Api/webkitgtkpage.cpp:
13324 * WebCoreSupport/ChromeClientGtk.cpp:
13326 2007-10-29 Alp Toker <alp@atoker.com>
13328 Reviewed by Maciej.
13330 Do not allow control to reach end of non-void functions
13332 * Api/webkitgtksettings.cpp:
13334 2007-10-28 Lars Lindner <lars.lindner@gmail.com>
13338 http://bugs.webkit.org/show_bug.cgi?id=15466
13339 [gtk] widget does not take focus on mouse click
13341 Grab widget focus in mouse press callback.
13343 * Api/webkitgtkpage.cpp:
13345 2007-10-25 Alp Toker <alp@atoker.com>
13349 http://bugs.webkit.org/show_bug.cgi?id=15686
13350 GtkLauncher aborts on launch due to uninitialized threading subsystem
13352 Re-enable database support in the GTK+ port, with a fix.
13354 Initialize GLib threading as early as possible.
13356 * Api/webkitgtkglobal.cpp:
13358 2007-10-25 Alp Toker <alp@atoker.com>
13360 Unreviewed fix to make the GTK+ port run.
13362 http://bugs.webkit.org/show_bug.cgi?id=15686
13363 GtkLauncher aborts on launch due to uninitialized threading subsystem
13365 http://bugs.webkit.org/show_bug.cgi?id=15688
13366 [GTK] Make it possible to disable database support
13368 Make database path initialization conditional on database support
13371 * Api/webkitgtkglobal.cpp:
13373 2007-10-24 Mark Rowe <mrowe@apple.com>
13375 Gtk build fix. Track WebCore changes in r27004.
13377 * Api/webkitgtkglobal.cpp:
13379 2007-10-22 Alp Toker <alp@atoker.com>
13381 Reviewed by Mark Rowe.
13383 http://bugs.webkit.org/show_bug.cgi?id=15611
13384 [GTK] Text selection behaviour different in Debug and Release builds
13386 http://bugs.webkit.org/show_bug.cgi?id=15578
13387 [GTK] Text editor caret does not blink
13389 Never allow control to reach the end of non-void functions.
13391 Return more sensible values, or in some cases, nulls.
13393 * Api/webkitgtksettings.cpp:
13394 * Api/webkitgtksettings.h:
13395 * WebCoreSupport/DragClientGtk.cpp:
13396 (WebKit::DragClient::actionMaskForDrag):
13397 (WebKit::DragClient::dragSourceActionMaskForPoint):
13398 (WebKit::DragClient::createDragImageForLink):
13400 2007-10-20 Mark Rowe <mrowe@apple.com>
13404 Gtk changes needed to enable HTML 5 client-side database storage.
13406 * Api/webkitgtkglobal.cpp: Set a default database path based on the user data directory.
13407 This should become configurable by client applications in the future.
13409 2007-10-20 Mark Rowe <mrowe@apple.com>
13413 Don't allow control characters to be inserted into editable regions.
13415 * WebCoreSupport/EditorClientGtk.cpp:
13416 (WebKit::EditorClient::handleKeypress):
13418 2007-10-19 Alp Toker <alp@atoker.com>
13420 Reviewed by Oliver.
13422 GTK+ build fix enabling the new local database storage feature.
13423 There is also a prospective Qt build fix.
13425 * WebCoreSupport/ChromeClientGtk.cpp:
13426 (WebKit::ChromeClient::runDatabaseSizeLimitPrompt):
13427 * WebCoreSupport/ChromeClientGtk.h:
13429 2007-10-14 Jan Michael Alonzo <jmalonzo@unpluggable.com>
13433 http://bugs.webkit.org/show_bug.cgi?id=15299
13434 Fix "hovering_over_link" signal not emitted when consecutive links
13437 * WebCoreSupport/ChromeClientGtk.cpp:
13438 (WebKit::ChromeClient::mouseDidMoveOverElement):
13439 * WebCoreSupport/ChromeClientGtk.h:
13440 - Remove m_didSendLinkSignal as it is superseded by m_hoveredLinkURL
13442 2007-10-10 Alice Liu <alice.liu@apple.com>
13444 Reviewed by Geoff Garen.
13446 changes to keep the build from breaking
13448 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13449 (WebKit::FrameLoaderClient::createFrame):
13450 * WebCoreSupport/FrameLoaderClientGtk.h:
13452 2007-10-03 Alp Toker <alp@atoker.com>
13456 http://bugs.webkit.org/show_bug.cgi?id=14726
13457 [gtk] API design. Mapping the WebView delegates to signals.
13459 Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
13461 * Api/webkitgtkdefines.h:
13462 * Api/webkitgtkframe.cpp:
13463 * Api/webkitgtkframe.h:
13464 * Api/webkitgtkglobal.cpp:
13465 * Api/webkitgtkglobal.h:
13466 * Api/webkitgtknetworkrequest.h:
13467 * Api/webkitgtkpage.cpp:
13468 * Api/webkitgtkpage.h:
13469 * Api/webkitgtkprivate.cpp:
13472 (WebKit::getFrameFromPage):
13473 (WebKit::getPageFromFrame):
13476 * Api/webkitgtkprivate.h:
13477 * Api/webkitgtksettings.cpp:
13478 * Api/webkitgtksettings.h:
13479 * WebCoreSupport/ChromeClientGtk.cpp:
13480 (WebKit::ChromeClient::ChromeClient):
13481 (WebKit::ChromeClient::createWindow):
13482 (WebKit::ChromeClient::addMessageToConsole):
13483 (WebKit::ChromeClient::runJavaScriptAlert):
13484 (WebKit::ChromeClient::runJavaScriptConfirm):
13485 (WebKit::ChromeClient::runJavaScriptPrompt):
13486 * WebCoreSupport/ChromeClientGtk.h:
13487 (WebKit::ChromeClient::webPage):
13488 * WebCoreSupport/EditorClientGtk.cpp:
13489 (WebKit::EditorClient::EditorClient):
13490 * WebCoreSupport/EditorClientGtk.h:
13491 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13492 (WebKit::FrameLoaderClient::FrameLoaderClient):
13493 (WebKit::FrameLoaderClient::postProgressStartedNotification):
13494 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
13495 (WebKit::FrameLoaderClient::postProgressFinishedNotification):
13496 (WebKit::FrameLoaderClient::createFrame):
13497 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
13498 (WebKit::FrameLoaderClient::setTitle):
13499 * WebCoreSupport/FrameLoaderClientGtk.h:
13500 (WebKit::FrameLoaderClient::webFrame):
13502 2007-10-02 Cosimo Cecchi <cosimoc@svn.gnome.org>
13506 http://bugs.webkit.org/show_bug.cgi?id=15299
13507 Fix "hovering_over_link" signal being fired every time mouse moves.
13509 * WebCoreSupport/ChromeClientGtk.cpp:
13510 (WebKit::ChromeClient::ChromeClient):
13511 (WebKit::ChromeClient::mouseDidMoveOverElement):
13512 * WebCoreSupport/ChromeClientGtk.h:
13514 2007-09-21 Sean Egan <seanegan@gmail.com>
13518 Add an "execute_script" method to programmatically call Javascript
13519 http://bugs.webkit.org/show_bug.cgi?id=15255
13521 * Api/webkitgtkpage.cpp:
13522 * Api/webkitgtkpage.h:
13524 2007-09-29 Lars Lindner <lars.lindner@gmail.com>
13528 ChromeClientGtk.cpp does not implement mouseDidMoveOverElement()
13529 http://bugs.webkit.org/show_bug.cgi?id=15299
13531 Implementing "hovering_over_link" signal.
13533 * WebCoreSupport/ChromeClientGtk.cpp:
13534 (WebKit::ChromeClient::mouseDidMoveOverElement):
13536 2007-09-26 Mark Rowe <mrowe@apple.com>
13540 * WebCoreSupport/FrameLoaderClientGtk.cpp: Check for empty URL instead of invalid URL.
13542 2007-09-17 Holger Hans Peter Freyther <zecke@selfish.org>
13546 WebKitGtkPage and WebKitGtkFrame have a dependency on each other. To
13547 allow client code to include both headers the typedef's for
13548 WebKitGtkFrame, WebKitGtkPage, WebKitGtkFrameData and WebKitGtkNetworkRequest
13549 are moved into webkitgtkdefines.h and included by both webkitgtkpage.h and
13552 * Api/webkitgtkdefines.h:
13553 * Api/webkitgtkframe.h:
13554 * Api/webkitgtkpage.h:
13556 2007-09-17 Cyril Brulebois <cyril.brulebois@enst-bretagne.fr>
13558 Reviewed by Mark, some Coding Style changes by Holger.
13560 This is from http://bugs.webkit.org/show_bug.cgi?id=14812.
13562 Add title and location to WebKitGtkFramePrivate, add
13563 webkit_gtk_frame_get_location to the WebKitGtkFrame API as well
13564 as a title_changed callback, implement
13565 webkit_gtk_frame_get_title and webkit_gtk_frame_get_location.
13567 Initial patch by Diego Escalante Urrelo.
13569 * Api/webkitgtkframe.cpp:
13570 * Api/webkitgtkframe.h:
13571 * Api/webkitgtkprivate.h:
13573 2007-09-15 Holger Hans Peter Freyther <zecke@selfish.org>
13577 Use the new WebCore::String::fromUTF8 function to convert
13578 from the Gtk+ representation of a string to WebCore::String.
13580 * WebCoreSupport/ChromeClientGtk.cpp:
13581 (WebKit::ChromeClient::runJavaScriptPrompt):
13583 2007-09-10 Nigel Tao <nigeltao@gnome.org>
13585 Reviewed by Mark Rowe.
13587 Fix a typo where webkit_gtk_page_can_copy was declared twice,
13588 rather than webkit_gtk_page_can_paste.
13590 * Api/webkitgtkpage.h:
13592 2007-09-08 Brady Eidson <beidson@apple.com>
13596 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13597 (WebKit::FrameLoaderClient::registerForIconNotification):
13598 * WebCoreSupport/FrameLoaderClientGtk.h:
13600 2007-09-08 Brady Eidson <beidson@apple.com>
13604 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13605 (WebKit::FrameLoaderClient::registerForIconNotification):
13606 * WebCoreSupport/FrameLoaderClientGtk.h:
13608 2007-09-05 Geoffrey Garen <ggaren@apple.com>
13610 Reviewed by Darin Adler, Maciej Stachowiak, Mark Rowe, Tim Hatcher.
13612 Fixed <rdar://problem/5326009> Make non-browser WebKit clients have no
13613 memory cache, or a very tiny one
13615 Keep the GTK build working with an empty stub.
13617 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13618 (WebKit::FrameLoaderClient::didPerformFirstNavigation):
13619 * WebCoreSupport/FrameLoaderClientGtk.h:
13621 2007-09-01 Oliver Hunt <oliver@apple.com>
13625 <rdar://problem/5344848> IME is incorrectly used for key events when on non-editable regions
13627 EditorClient::setInputMethodState stub
13629 * WebCoreSupport/EditorClientGtk.cpp:
13630 (WebKit::EditorClient::setInputMethodState):
13631 * WebCoreSupport/EditorClientGtk.h:
13633 2007-08-18 Holger Hans Peter Freyther <zecke@selfish.org>
13635 Build fix. Add const to the first parameter of createPlugin
13637 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13639 2007-08-17 Anders Carlsson <andersca@apple.com>
13643 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13644 (WebKit::FrameLoaderClient::createPlugin):
13645 * WebCoreSupport/FrameLoaderClientGtk.h:
13647 2007-08-11 Holger Hans Peter Freyther <zecke@selfish.org>
13651 To not hit the needsLayout() assert of Frame::paint for subframes we need to
13652 make sure they are layed out. Use the newly created FrameView::layoutIfNeededRecursive
13655 * Api/webkitgtkpage.cpp:
13657 2007-08-11 Holger Hans Peter Freyther <zecke@selfish.org>
13661 Fix text selection by setting a DragClient when creating the Page. Now
13662 that we have a DragClient we can free the Page when WebKitGtkPage gets
13665 * Api/webkitgtkpage.cpp:
13666 * WebCoreSupport/DragClientGtk.cpp: Added.
13667 (WebKit::DragClient::willPerformDragDestinationAction):
13668 (WebKit::DragClient::willPerformDragSourceAction):
13669 (WebKit::DragClient::actionMaskForDrag):
13670 (WebKit::DragClient::dragSourceActionMaskForPoint):
13671 (WebKit::DragClient::startDrag):
13672 (WebKit::DragClient::createDragImageForLink):
13673 * WebCoreSupport/DragClientGtk.h: Added.
13675 2007-08-10 Holger Hans Peter Freyther <zecke@selfish.org>
13677 Reviewed by Anders.
13679 Make WebKitGtkPage a GtkContainer to avoid a size_allocate
13680 race of GtkScrollBar and GtkLayout.
13682 * Api/webkitgtk-marshal.list:
13683 * Api/webkitgtkframe.cpp:
13684 * Api/webkitgtkpage.cpp:
13685 * Api/webkitgtkpage.h:
13686 * Api/webkitgtkprivate.h:
13688 2007-08-10 Holger Hans Peter Freyther <zecke@selfish.org>
13692 Minor changes to the WebKit::EditorClient to allow removing
13693 of text from TextFields. Remove the selectWordBeforeMenuEvent method
13694 which is not used and not within WebCore::EditorClient.
13696 * WebCoreSupport/EditorClientGtk.cpp:
13697 (WebKit::EditorClient::shouldDeleteRange):
13698 (WebKit::EditorClient::shouldBeginEditing):
13699 (WebKit::EditorClient::shouldEndEditing):
13700 (WebKit::EditorClient::shouldApplyStyle):
13701 (WebKit::EditorClient::shouldInsertNode):
13702 * WebCoreSupport/EditorClientGtk.h:
13704 2007-08-10 Holger Hans Peter Freyther <zecke@selfish.org>
13708 Rename the namespace from WebKitGtk to WebKit. Move the various *Client
13709 classes into the WebKit namespace. Change the class names to not contain Gtk.
13710 The file names have to contain the Gtk suffix to not clash with files in WebCore (e.g.
13711 bridge/EditorClient.h).
13714 * Api/webkitgtkframe.cpp:
13715 * Api/webkitgtkpage.cpp:
13716 * Api/webkitgtkprivate.cpp:
13717 * Api/webkitgtkprivate.h:
13719 * WebCoreSupport/ChromeClientGtk.cpp:
13720 (WebKit::ChromeClient::ChromeClient):
13721 (WebKit::ChromeClient::chromeDestroyed):
13722 (WebKit::ChromeClient::windowRect):
13723 (WebKit::ChromeClient::setWindowRect):
13724 (WebKit::ChromeClient::pageRect):
13725 (WebKit::ChromeClient::scaleFactor):
13726 (WebKit::ChromeClient::focus):
13727 (WebKit::ChromeClient::unfocus):
13728 (WebKit::ChromeClient::createWindow):
13729 (WebKit::ChromeClient::createModalDialog):
13730 (WebKit::ChromeClient::show):
13731 (WebKit::ChromeClient::canRunModal):
13732 (WebKit::ChromeClient::runModal):
13733 (WebKit::ChromeClient::setToolbarsVisible):
13734 (WebKit::ChromeClient::toolbarsVisible):
13735 (WebKit::ChromeClient::setStatusbarVisible):
13736 (WebKit::ChromeClient::statusbarVisible):
13737 (WebKit::ChromeClient::setScrollbarsVisible):
13738 (WebKit::ChromeClient::scrollbarsVisible):
13739 (WebKit::ChromeClient::setMenubarVisible):
13740 (WebKit::ChromeClient::menubarVisible):
13741 (WebKit::ChromeClient::setResizable):
13742 (WebKit::ChromeClient::closeWindowSoon):
13743 (WebKit::ChromeClient::canTakeFocus):
13744 (WebKit::ChromeClient::takeFocus):
13745 (WebKit::ChromeClient::canRunBeforeUnloadConfirmPanel):
13746 (WebKit::ChromeClient::runBeforeUnloadConfirmPanel):
13747 (WebKit::ChromeClient::runJavaScriptAlert):
13748 (WebKit::ChromeClient::runJavaScriptConfirm):
13749 (WebKit::ChromeClient::setStatusbarText):
13750 (WebKit::ChromeClient::shouldInterruptJavaScript):
13751 (WebKit::ChromeClient::tabsToLinks):
13752 (WebKit::ChromeClient::windowResizerRect):
13753 (WebKit::ChromeClient::addToDirtyRegion):
13754 (WebKit::ChromeClient::scrollBackingStore):
13755 (WebKit::ChromeClient::updateBackingStore):
13756 (WebKit::ChromeClient::mouseDidMoveOverElement):
13757 (WebKit::ChromeClient::setToolTip):
13758 * WebCoreSupport/ChromeClientGtk.h:
13759 * WebCoreSupport/ContextMenuClientGtk.cpp:
13760 (WebKit::ContextMenuClient::contextMenuDestroyed):
13761 (WebKit::ContextMenuClient::getCustomMenuFromDefaultItems):
13762 (WebKit::ContextMenuClient::contextMenuItemSelected):
13763 (WebKit::ContextMenuClient::downloadURL):
13764 (WebKit::ContextMenuClient::copyImageToClipboard):
13765 (WebKit::ContextMenuClient::searchWithGoogle):
13766 (WebKit::ContextMenuClient::lookUpInDictionary):
13767 (WebKit::ContextMenuClient::speak):
13768 * WebCoreSupport/ContextMenuClientGtk.h:
13769 * WebCoreSupport/EditorClientGtk.cpp:
13770 (WebKit::EditorClient::shouldDeleteRange):
13771 (WebKit::EditorClient::shouldShowDeleteInterface):
13772 (WebKit::EditorClient::isContinuousSpellCheckingEnabled):
13773 (WebKit::EditorClient::isGrammarCheckingEnabled):
13774 (WebKit::EditorClient::spellCheckerDocumentTag):
13775 (WebKit::EditorClient::shouldBeginEditing):
13776 (WebKit::EditorClient::shouldEndEditing):
13777 (WebKit::EditorClient::shouldInsertText):
13778 (WebKit::EditorClient::shouldChangeSelectedRange):
13779 (WebKit::EditorClient::shouldApplyStyle):
13780 (WebKit::EditorClient::shouldMoveRangeAfterDelete):
13781 (WebKit::EditorClient::didBeginEditing):
13782 (WebKit::EditorClient::respondToChangedContents):
13783 (WebKit::EditorClient::respondToChangedSelection):
13784 (WebKit::EditorClient::didEndEditing):
13785 (WebKit::EditorClient::didWriteSelectionToPasteboard):
13786 (WebKit::EditorClient::didSetSelectionTypesForPasteboard):
13787 (WebKit::EditorClient::selectWordBeforeMenuEvent):
13788 (WebKit::EditorClient::isEditable):
13789 (WebKit::EditorClient::registerCommandForUndo):
13790 (WebKit::EditorClient::registerCommandForRedo):
13791 (WebKit::EditorClient::clearUndoRedoOperations):
13792 (WebKit::EditorClient::canUndo):
13793 (WebKit::EditorClient::canRedo):
13794 (WebKit::EditorClient::undo):
13795 (WebKit::EditorClient::redo):
13796 (WebKit::EditorClient::shouldInsertNode):
13797 (WebKit::EditorClient::pageDestroyed):
13798 (WebKit::EditorClient::smartInsertDeleteEnabled):
13799 (WebKit::EditorClient::toggleContinuousSpellChecking):
13800 (WebKit::EditorClient::toggleGrammarChecking):
13801 (WebKit::EditorClient::handleInputMethodKeypress):
13802 (WebKit::EditorClient::EditorClient):
13803 (WebKit::EditorClient::textFieldDidBeginEditing):
13804 (WebKit::EditorClient::textFieldDidEndEditing):
13805 (WebKit::EditorClient::textDidChangeInTextField):
13806 (WebKit::EditorClient::doTextFieldCommandFromEvent):
13807 (WebKit::EditorClient::textWillBeDeletedInTextField):
13808 (WebKit::EditorClient::textDidChangeInTextArea):
13809 (WebKit::EditorClient::ignoreWordInSpellDocument):
13810 (WebKit::EditorClient::learnWord):
13811 (WebKit::EditorClient::checkSpellingOfString):
13812 (WebKit::EditorClient::checkGrammarOfString):
13813 (WebKit::EditorClient::updateSpellingUIWithGrammarString):
13814 (WebKit::EditorClient::updateSpellingUIWithMisspelledWord):
13815 (WebKit::EditorClient::showSpellingUI):
13816 (WebKit::EditorClient::spellingUIIsShowing):
13817 * WebCoreSupport/EditorClientGtk.h:
13818 * WebCoreSupport/FrameLoaderClientGtk.cpp:
13819 (WebKit::FrameLoaderClient::FrameLoaderClient):
13820 (WebKit::FrameLoaderClient::userAgent):
13821 (WebKit::FrameLoaderClient::createDocumentLoader):
13822 (WebKit::FrameLoaderClient::committedLoad):
13823 (WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
13824 (WebKit::FrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
13825 (WebKit::FrameLoaderClient::dispatchWillSendRequest):
13826 (WebKit::FrameLoaderClient::assignIdentifierToInitialRequest):
13827 (WebKit::FrameLoaderClient::postProgressStartedNotification):
13828 (WebKit::FrameLoaderClient::postProgressFinishedNotification):
13829 (WebKit::FrameLoaderClient::frameLoaderDestroyed):
13830 (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):
13831 (WebKit::FrameLoaderClient::createPlugin):
13832 (WebKit::FrameLoaderClient::redirectDataToPlugin):
13833 (WebKit::FrameLoaderClient::createJavaAppletWidget):
13834 (WebKit::FrameLoaderClient::overrideMediaType):
13835 (WebKit::FrameLoaderClient::windowObjectCleared):
13836 (WebKit::FrameLoaderClient::setMainFrameDocumentReady):
13837 (WebKit::FrameLoaderClient::hasWebView):
13838 (WebKit::FrameLoaderClient::hasFrameView):
13839 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
13840 (WebKit::FrameLoaderClient::frameLoadCompleted):
13841 (WebKit::FrameLoaderClient::saveViewStateToItem):
13842 (WebKit::FrameLoaderClient::restoreViewState):
13843 (WebKit::FrameLoaderClient::privateBrowsingEnabled):
13844 (WebKit::FrameLoaderClient::makeDocumentView):
13845 (WebKit::FrameLoaderClient::makeRepresentation):
13846 (WebKit::FrameLoaderClient::forceLayout):
13847 (WebKit::FrameLoaderClient::forceLayoutForNonHTML):
13848 (WebKit::FrameLoaderClient::setCopiesOnScroll):
13849 (WebKit::FrameLoaderClient::detachedFromParent1):
13850 (WebKit::FrameLoaderClient::detachedFromParent2):
13851 (WebKit::FrameLoaderClient::detachedFromParent3):
13852 (WebKit::FrameLoaderClient::detachedFromParent4):
13853 (WebKit::FrameLoaderClient::loadedFromCachedPage):
13854 (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents):
13855 (WebKit::FrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
13856 (WebKit::FrameLoaderClient::dispatchDidCancelClientRedirect):
13857 (WebKit::FrameLoaderClient::dispatchWillPerformClientRedirect):
13858 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
13859 (WebKit::FrameLoaderClient::dispatchWillClose):
13860 (WebKit::FrameLoaderClient::dispatchDidReceiveIcon):
13861 (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
13862 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
13863 (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
13864 (WebKit::FrameLoaderClient::dispatchDidFinishDocumentLoad):
13865 (WebKit::FrameLoaderClient::dispatchDidFirstLayout):
13866 (WebKit::FrameLoaderClient::dispatchShow):
13867 (WebKit::FrameLoaderClient::cancelPolicyCheck):
13868 (WebKit::FrameLoaderClient::dispatchDidLoadMainResource):
13869 (WebKit::FrameLoaderClient::revertToProvisionalState):
13870 (WebKit::FrameLoaderClient::clearUnarchivingState):
13871 (WebKit::FrameLoaderClient::willChangeTitle):
13872 (WebKit::FrameLoaderClient::didChangeTitle):
13873 (WebKit::FrameLoaderClient::finishedLoading):
13874 (WebKit::FrameLoaderClient::finalSetupForReplace):
13875 (WebKit::FrameLoaderClient::setDefersLoading):
13876 (WebKit::FrameLoaderClient::isArchiveLoadPending):
13877 (WebKit::FrameLoaderClient::cancelPendingArchiveLoad):
13878 (WebKit::FrameLoaderClient::clearArchivedResources):
13879 (WebKit::FrameLoaderClient::canHandleRequest):
13880 (WebKit::FrameLoaderClient::canShowMIMEType):
13881 (WebKit::FrameLoaderClient::representationExistsForURLScheme):
13882 (WebKit::FrameLoaderClient::generatedMIMETypeForURLScheme):
13883 (WebKit::FrameLoaderClient::provisionalLoadStarted):
13884 (WebKit::FrameLoaderClient::didFinishLoad):
13885 (WebKit::FrameLoaderClient::setDocumentViewFromCachedPage):
13886 (WebKit::FrameLoaderClient::dispatchDidReceiveContentLength):
13887 (WebKit::FrameLoaderClient::dispatchDidFinishLoading):
13888 (WebKit::FrameLoaderClient::dispatchDidFailLoading):
13889 (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
13890 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
13891 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
13892 (WebKit::FrameLoaderClient::download):
13893 (WebKit::FrameLoaderClient::cancelledError):
13894 (WebKit::FrameLoaderClient::blockedError):
13895 (WebKit::FrameLoaderClient::cannotShowURLError):
13896 (WebKit::FrameLoaderClient::interruptForPolicyChangeError):
13897 (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
13898 (WebKit::FrameLoaderClient::fileDoesNotExistError):
13899 (WebKit::FrameLoaderClient::shouldFallBack):
13900 (WebKit::FrameLoaderClient::willUseArchive):
13901 (WebKit::FrameLoaderClient::saveDocumentViewToCachedPage):
13902 (WebKit::FrameLoaderClient::canCachePage):
13903 (WebKit::FrameLoaderClient::dispatchCreatePage):
13904 (WebKit::FrameLoaderClient::dispatchUnableToImplementPolicy):
13905 * WebCoreSupport/FrameLoaderClientGtk.h:
13906 * WebCoreSupport/InspectorClientGtk.cpp:
13907 (WebKit::InspectorClient::inspectorDestroyed):
13908 (WebKit::InspectorClient::createPage):
13909 (WebKit::InspectorClient::showWindow):
13910 (WebKit::InspectorClient::closeWindow):
13911 (WebKit::InspectorClient::attachWindow):
13912 (WebKit::InspectorClient::detachWindow):
13913 (WebKit::InspectorClient::highlight):
13914 (WebKit::InspectorClient::hideHighlight):
13915 * WebCoreSupport/InspectorClientGtk.h:
13917 2007-08-10 Holger Hans Peter Freyther <zecke@selfish.org>
13921 As of http://bugs.webkit.org/show_bug.cgi?id=14727 move the
13922 various *ClientGdk.{cpp,h} files from WebCore to WebKit/gtk/WebCoreSupport and
13923 rename it from Gdk to Gtk.
13925 * Api/webkitgtkdefines.h:
13926 * Api/webkitgtkframe.cpp:
13927 * Api/webkitgtkframe.h:
13928 * Api/webkitgtkglobal.cpp:
13929 * Api/webkitgtkglobal.h:
13930 * Api/webkitgtknetworkrequest.cpp:
13931 * Api/webkitgtknetworkrequest.h:
13932 * Api/webkitgtkpage.cpp:
13933 * Api/webkitgtkpage.h:
13934 * Api/webkitgtkprivate.cpp:
13935 * Api/webkitgtkprivate.h:
13936 * Api/webkitgtksettings.cpp:
13937 * Api/webkitgtksettings.h:
13938 * WebCoreSupport/ChromeClientGtk.cpp: Renamed from WebKit/gtk/WebCoreSupport/ChromeClientGdk.cpp.
13939 (WebKitGtk::ChromeClientGtk::ChromeClientGtk):
13940 (WebKitGtk::ChromeClientGtk::chromeDestroyed):
13941 (WebKitGtk::ChromeClientGtk::windowRect):
13942 (WebKitGtk::ChromeClientGtk::setWindowRect):
13943 (WebKitGtk::ChromeClientGtk::pageRect):
13944 (WebKitGtk::ChromeClientGtk::scaleFactor):
13945 (WebKitGtk::ChromeClientGtk::focus):
13946 (WebKitGtk::ChromeClientGtk::unfocus):
13947 (WebKitGtk::ChromeClientGtk::createWindow):
13948 (WebKitGtk::ChromeClientGtk::createModalDialog):
13949 (WebKitGtk::ChromeClientGtk::show):
13950 (WebKitGtk::ChromeClientGtk::canRunModal):
13951 (WebKitGtk::ChromeClientGtk::runModal):
13952 (WebKitGtk::ChromeClientGtk::setToolbarsVisible):
13953 (WebKitGtk::ChromeClientGtk::toolbarsVisible):
13954 (WebKitGtk::ChromeClientGtk::setStatusbarVisible):
13955 (WebKitGtk::ChromeClientGtk::statusbarVisible):
13956 (WebKitGtk::ChromeClientGtk::setScrollbarsVisible):
13957 (WebKitGtk::ChromeClientGtk::scrollbarsVisible):
13958 (WebKitGtk::ChromeClientGtk::setMenubarVisible):
13959 (WebKitGtk::ChromeClientGtk::menubarVisible):
13960 (WebKitGtk::ChromeClientGtk::setResizable):
13961 (WebKitGtk::ChromeClientGtk::closeWindowSoon):
13962 (WebKitGtk::ChromeClientGtk::canTakeFocus):
13963 (WebKitGtk::ChromeClientGtk::takeFocus):
13964 (WebKitGtk::ChromeClientGtk::canRunBeforeUnloadConfirmPanel):
13965 (WebKitGtk::ChromeClientGtk::runBeforeUnloadConfirmPanel):
13966 (WebKitGtk::ChromeClientGtk::addMessageToConsole):
13967 (WebKitGtk::ChromeClientGtk::runJavaScriptAlert):
13968 (WebKitGtk::ChromeClientGtk::runJavaScriptConfirm):
13969 (WebKitGtk::ChromeClientGtk::runJavaScriptPrompt):
13970 (WebKitGtk::ChromeClientGtk::setStatusbarText):
13971 (WebKitGtk::ChromeClientGtk::shouldInterruptJavaScript):
13972 (WebKitGtk::ChromeClientGtk::tabsToLinks):
13973 (WebKitGtk::ChromeClientGtk::windowResizerRect):
13974 (WebKitGtk::ChromeClientGtk::addToDirtyRegion):
13975 (WebKitGtk::ChromeClientGtk::scrollBackingStore):
13976 (WebKitGtk::ChromeClientGtk::updateBackingStore):
13977 (WebKitGtk::ChromeClientGtk::mouseDidMoveOverElement):
13978 (WebKitGtk::ChromeClientGtk::setToolTip):
13979 * WebCoreSupport/ChromeClientGtk.h: Renamed from WebKit/gtk/WebCoreSupport/ChromeClientGdk.h.
13980 (WebKitGtk::ChromeClientGtk::webPage):
13981 * WebCoreSupport/ContextMenuClientGtk.cpp: Renamed from WebCore/page/gdk/ContextMenuClientGdk.cpp.
13982 (WebCore::ContextMenuClientGtk::contextMenuDestroyed):
13983 (WebCore::ContextMenuClientGtk::getCustomMenuFromDefaultItems):
13984 (WebCore::ContextMenuClientGtk::contextMenuItemSelected):
13985 (WebCore::ContextMenuClientGtk::downloadURL):
13986 (WebCore::ContextMenuClientGtk::copyImageToClipboard):
13987 (WebCore::ContextMenuClientGtk::searchWithGoogle):
13988 (WebCore::ContextMenuClientGtk::lookUpInDictionary):
13989 (WebCore::ContextMenuClientGtk::speak):
13990 (WebCore::ContextMenuClientGtk::stopSpeaking):
13991 * WebCoreSupport/ContextMenuClientGtk.h: Renamed from WebCore/page/gdk/ContextMenuClientGdk.h.
13992 * WebCoreSupport/EditorClientGtk.cpp: Renamed from WebCore/platform/gdk/EditorClientGdk.cpp.
13993 (WebCore::EditorClientGtk::shouldDeleteRange):
13994 (WebCore::EditorClientGtk::shouldShowDeleteInterface):
13995 (WebCore::EditorClientGtk::isContinuousSpellCheckingEnabled):
13996 (WebCore::EditorClientGtk::isGrammarCheckingEnabled):
13997 (WebCore::EditorClientGtk::spellCheckerDocumentTag):
13998 (WebCore::EditorClientGtk::shouldBeginEditing):
13999 (WebCore::EditorClientGtk::shouldEndEditing):
14000 (WebCore::EditorClientGtk::shouldInsertText):
14001 (WebCore::EditorClientGtk::shouldChangeSelectedRange):
14002 (WebCore::EditorClientGtk::shouldApplyStyle):
14003 (WebCore::EditorClientGtk::shouldMoveRangeAfterDelete):
14004 (WebCore::EditorClientGtk::didBeginEditing):
14005 (WebCore::EditorClientGtk::respondToChangedContents):
14006 (WebCore::EditorClientGtk::respondToChangedSelection):
14007 (WebCore::EditorClientGtk::didEndEditing):
14008 (WebCore::EditorClientGtk::didWriteSelectionToPasteboard):
14009 (WebCore::EditorClientGtk::didSetSelectionTypesForPasteboard):
14010 (WebCore::EditorClientGtk::selectWordBeforeMenuEvent):
14011 (WebCore::EditorClientGtk::isEditable):
14012 (WebCore::EditorClientGtk::registerCommandForUndo):
14013 (WebCore::EditorClientGtk::registerCommandForRedo):
14014 (WebCore::EditorClientGtk::clearUndoRedoOperations):
14015 (WebCore::EditorClientGtk::canUndo):
14016 (WebCore::EditorClientGtk::canRedo):
14017 (WebCore::EditorClientGtk::undo):
14018 (WebCore::EditorClientGtk::redo):
14019 (WebCore::EditorClientGtk::shouldInsertNode):
14020 (WebCore::EditorClientGtk::pageDestroyed):
14021 (WebCore::EditorClientGtk::smartInsertDeleteEnabled):
14022 (WebCore::EditorClientGtk::toggleContinuousSpellChecking):
14023 (WebCore::EditorClientGtk::toggleGrammarChecking):
14024 (WebCore::EditorClientGtk::handleKeypress):
14025 (WebCore::EditorClientGtk::handleInputMethodKeypress):
14026 (WebCore::EditorClientGtk::EditorClientGtk):
14027 (WebCore::EditorClientGtk::textFieldDidBeginEditing):
14028 (WebCore::EditorClientGtk::textFieldDidEndEditing):
14029 (WebCore::EditorClientGtk::textDidChangeInTextField):
14030 (WebCore::EditorClientGtk::doTextFieldCommandFromEvent):
14031 (WebCore::EditorClientGtk::textWillBeDeletedInTextField):
14032 (WebCore::EditorClientGtk::textDidChangeInTextArea):
14033 (WebCore::EditorClientGtk::ignoreWordInSpellDocument):
14034 (WebCore::EditorClientGtk::learnWord):
14035 (WebCore::EditorClientGtk::checkSpellingOfString):
14036 (WebCore::EditorClientGtk::checkGrammarOfString):
14037 (WebCore::EditorClientGtk::updateSpellingUIWithGrammarString):
14038 (WebCore::EditorClientGtk::updateSpellingUIWithMisspelledWord):
14039 (WebCore::EditorClientGtk::showSpellingUI):
14040 (WebCore::EditorClientGtk::spellingUIIsShowing):
14041 (WebCore::EditorClientGtk::getGuessesForWord):
14042 * WebCoreSupport/EditorClientGtk.h: Renamed from WebCore/platform/gdk/EditorClientGdk.h.
14043 * WebCoreSupport/FrameLoaderClientGtk.cpp: Renamed from WebCore/loader/gdk/FrameLoaderClientGdk.cpp.
14044 (WebCore::FrameLoaderClientGtk::FrameLoaderClientGtk):
14045 (WebCore::FrameLoaderClientGtk::userAgent):
14046 (WebCore::FrameLoaderClientGtk::createDocumentLoader):
14047 (WebCore::FrameLoaderClientGtk::dispatchWillSubmitForm):
14048 (WebCore::FrameLoaderClientGtk::committedLoad):
14049 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveAuthenticationChallenge):
14050 (WebCore::FrameLoaderClientGtk::dispatchDidCancelAuthenticationChallenge):
14051 (WebCore::FrameLoaderClientGtk::dispatchWillSendRequest):
14052 (WebCore::FrameLoaderClientGtk::assignIdentifierToInitialRequest):
14053 (WebCore::FrameLoaderClientGtk::postProgressStartedNotification):
14054 (WebCore::FrameLoaderClientGtk::postProgressEstimateChangedNotification):
14055 (WebCore::FrameLoaderClientGtk::postProgressFinishedNotification):
14056 (WebCore::FrameLoaderClientGtk::frameLoaderDestroyed):
14057 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveResponse):
14058 (WebCore::FrameLoaderClientGtk::dispatchDecidePolicyForMIMEType):
14059 (WebCore::FrameLoaderClientGtk::dispatchDecidePolicyForNewWindowAction):
14060 (WebCore::FrameLoaderClientGtk::dispatchDecidePolicyForNavigationAction):
14061 (WebCore::FrameLoaderClientGtk::createPlugin):
14062 (WebCore::FrameLoaderClientGtk::createFrame):
14063 (WebCore::FrameLoaderClientGtk::redirectDataToPlugin):
14064 (WebCore::FrameLoaderClientGtk::createJavaAppletWidget):
14065 (WebCore::FrameLoaderClientGtk::objectContentType):
14066 (WebCore::FrameLoaderClientGtk::overrideMediaType):
14067 (WebCore::FrameLoaderClientGtk::windowObjectCleared):
14068 (WebCore::FrameLoaderClientGtk::setMainFrameDocumentReady):
14069 (WebCore::FrameLoaderClientGtk::hasWebView):
14070 (WebCore::FrameLoaderClientGtk::hasFrameView):
14071 (WebCore::FrameLoaderClientGtk::dispatchDidFinishLoad):
14072 (WebCore::FrameLoaderClientGtk::frameLoadCompleted):
14073 (WebCore::FrameLoaderClientGtk::saveViewStateToItem):
14074 (WebCore::FrameLoaderClientGtk::restoreViewState):
14075 (WebCore::FrameLoaderClientGtk::shouldGoToHistoryItem):
14076 (WebCore::FrameLoaderClientGtk::privateBrowsingEnabled):
14077 (WebCore::FrameLoaderClientGtk::makeDocumentView):
14078 (WebCore::FrameLoaderClientGtk::makeRepresentation):
14079 (WebCore::FrameLoaderClientGtk::forceLayout):
14080 (WebCore::FrameLoaderClientGtk::forceLayoutForNonHTML):
14081 (WebCore::FrameLoaderClientGtk::setCopiesOnScroll):
14082 (WebCore::FrameLoaderClientGtk::detachedFromParent1):
14083 (WebCore::FrameLoaderClientGtk::detachedFromParent2):
14084 (WebCore::FrameLoaderClientGtk::detachedFromParent3):
14085 (WebCore::FrameLoaderClientGtk::detachedFromParent4):
14086 (WebCore::FrameLoaderClientGtk::loadedFromCachedPage):
14087 (WebCore::FrameLoaderClientGtk::dispatchDidHandleOnloadEvents):
14088 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveServerRedirectForProvisionalLoad):
14089 (WebCore::FrameLoaderClientGtk::dispatchDidCancelClientRedirect):
14090 (WebCore::FrameLoaderClientGtk::dispatchWillPerformClientRedirect):
14091 (WebCore::FrameLoaderClientGtk::dispatchDidChangeLocationWithinPage):
14092 (WebCore::FrameLoaderClientGtk::dispatchWillClose):
14093 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveIcon):
14094 (WebCore::FrameLoaderClientGtk::dispatchDidStartProvisionalLoad):
14095 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveTitle):
14096 (WebCore::FrameLoaderClientGtk::dispatchDidCommitLoad):
14097 (WebCore::FrameLoaderClientGtk::dispatchDidFinishDocumentLoad):
14098 (WebCore::FrameLoaderClientGtk::dispatchDidFirstLayout):
14099 (WebCore::FrameLoaderClientGtk::dispatchShow):
14100 (WebCore::FrameLoaderClientGtk::cancelPolicyCheck):
14101 (WebCore::FrameLoaderClientGtk::dispatchDidLoadMainResource):
14102 (WebCore::FrameLoaderClientGtk::revertToProvisionalState):
14103 (WebCore::FrameLoaderClientGtk::clearUnarchivingState):
14104 (WebCore::FrameLoaderClientGtk::willChangeTitle):
14105 (WebCore::FrameLoaderClientGtk::didChangeTitle):
14106 (WebCore::FrameLoaderClientGtk::finishedLoading):
14107 (WebCore::FrameLoaderClientGtk::finalSetupForReplace):
14108 (WebCore::FrameLoaderClientGtk::setDefersLoading):
14109 (WebCore::FrameLoaderClientGtk::isArchiveLoadPending):
14110 (WebCore::FrameLoaderClientGtk::cancelPendingArchiveLoad):
14111 (WebCore::FrameLoaderClientGtk::clearArchivedResources):
14112 (WebCore::FrameLoaderClientGtk::canHandleRequest):
14113 (WebCore::FrameLoaderClientGtk::canShowMIMEType):
14114 (WebCore::FrameLoaderClientGtk::representationExistsForURLScheme):
14115 (WebCore::FrameLoaderClientGtk::generatedMIMETypeForURLScheme):
14116 (WebCore::FrameLoaderClientGtk::provisionalLoadStarted):
14117 (WebCore::FrameLoaderClientGtk::didFinishLoad):
14118 (WebCore::FrameLoaderClientGtk::prepareForDataSourceReplacement):
14119 (WebCore::FrameLoaderClientGtk::setTitle):
14120 (WebCore::FrameLoaderClientGtk::setDocumentViewFromCachedPage):
14121 (WebCore::FrameLoaderClientGtk::dispatchDidReceiveContentLength):
14122 (WebCore::FrameLoaderClientGtk::dispatchDidFinishLoading):
14123 (WebCore::FrameLoaderClientGtk::dispatchDidFailLoading):
14124 (WebCore::FrameLoaderClientGtk::dispatchDidLoadResourceFromMemoryCache):
14125 (WebCore::FrameLoaderClientGtk::dispatchDidFailProvisionalLoad):
14126 (WebCore::FrameLoaderClientGtk::dispatchDidFailLoad):
14127 (WebCore::FrameLoaderClientGtk::download):
14128 (WebCore::FrameLoaderClientGtk::cancelledError):
14129 (WebCore::FrameLoaderClientGtk::blockedError):
14130 (WebCore::FrameLoaderClientGtk::cannotShowURLError):
14131 (WebCore::FrameLoaderClientGtk::interruptForPolicyChangeError):
14132 (WebCore::FrameLoaderClientGtk::cannotShowMIMETypeError):
14133 (WebCore::FrameLoaderClientGtk::fileDoesNotExistError):
14134 (WebCore::FrameLoaderClientGtk::shouldFallBack):
14135 (WebCore::FrameLoaderClientGtk::willUseArchive):
14136 (WebCore::FrameLoaderClientGtk::saveDocumentViewToCachedPage):
14137 (WebCore::FrameLoaderClientGtk::canCachePage):
14138 (WebCore::FrameLoaderClientGtk::dispatchCreatePage):
14139 (WebCore::FrameLoaderClientGtk::dispatchUnableToImplementPolicy):
14140 * WebCoreSupport/FrameLoaderClientGtk.h: Renamed from WebCore/loader/gdk/FrameLoaderClientGdk.h.
14141 (WebCore::FrameLoaderClientGtk::~FrameLoaderClientGtk):
14142 (WebCore::FrameLoaderClientGtk::webFrame):
14143 * WebCoreSupport/InspectorClientGtk.cpp: Renamed from WebCore/page/gdk/InspectorClientGdk.cpp.
14144 (WebCore::InspectorClientGtk::inspectorDestroyed):
14145 (WebCore::InspectorClientGtk::createPage):
14146 (WebCore::InspectorClientGtk::showWindow):
14147 (WebCore::InspectorClientGtk::closeWindow):
14148 (WebCore::InspectorClientGtk::attachWindow):
14149 (WebCore::InspectorClientGtk::detachWindow):
14150 (WebCore::InspectorClientGtk::highlight):
14151 (WebCore::InspectorClientGtk::hideHighlight):
14152 (WebCore::InspectorClientGtk::inspectedURLChanged):
14153 * WebCoreSupport/InspectorClientGtk.h: Renamed from WebCore/page/gdk/InspectorClientGdk.h.
14155 2007-08-10 Holger Hans Peter Freyther <zecke@selfish.org>
14159 * Api/webkitgtkframe.cpp:
14161 2007-08-10 Holger Hans Peter Freyther <zecke@selfish.org>
14165 Remove the create_frame virtual method of WebKitGtkPage. This method was inspired
14166 by the Qt port but to be useful for reimplementations WebKitGtkFrameData would need
14167 to export/expose WebCore types. WebView doesn't offer such a method so I decided to
14169 Add a internal constructor to WebKitGtkFrame to be used for constructing Sub-Frames. This
14170 is currently used by FrameLoaderClientGdk::createFrame.
14172 * Api/webkitgtkframe.cpp:
14173 * Api/webkitgtkframedata.cpp: Removed.
14174 * Api/webkitgtkframedata.h: Removed.
14175 * Api/webkitgtkpage.cpp:
14176 * Api/webkitgtkpage.h:
14177 * Api/webkitgtkprivate.h:
14179 2007-08-10 Holger Hans Peter Freyther <zecke@selfish.org>
14183 Follow the changes of ScrollView in WebCore and call setContainingWindow, set the
14184 GtkAdjustment of the GtkLayout and reimplement the set_scroll_adjustments method and pass
14185 the GtkAdjustments to ScrollView.
14186 This makes having one GdkWindow for the complete FrameTree possible.
14189 * gtk/Api/webkitgtkframe.cpp:
14190 * gtk/Api/webkitgtkpage.cpp:
14192 2007-08-08 Holger Hans Peter Freyther <zecke@selfish.org>
14196 We only need to set the Settings of the Page once so do it in
14197 WebKitGtkPage instead of WebKitGtkFrame.
14199 * gtk/Api/webkitgtkframe.cpp:
14200 * gtk/Api/webkitgtkpage.cpp:
14202 2007-08-08 Holger Hans Peter Freyther <zecke@selfish.org>
14206 Instead of reimplementing the general event method, reimplement
14207 the specific mouse, expose, keyboard event methods.
14209 Call the finalize implementation of the base class from WebKitGtkPage
14210 and WebKitGtkFrame.
14212 * gtk/Api/webkitgtkframe.cpp:
14213 * gtk/Api/webkitgtkpage.cpp:
14215 2007-08-08 Holger Hans Peter Freyther <zecke@selfish.org>
14219 Remove the custom painting in favor of the Widget::paint
14222 * gtk/Api/webkitgtkpage.cpp:
14224 2007-08-08 Holger Hans Peter Freyther <zecke@selfish.org>
14228 Moved code from class FrameGdk into WebKitGtkFrame. Update the
14229 webkitgrkprivate.h header file to not include FrameGdk.h.
14231 * gtk/Api/webkitgtkframe.cpp:
14232 * gtk/Api/webkitgtkprivate.h:
14234 2007-08-08 Holger Hans Peter Freyther <zecke@selfish.org>
14238 Change variable names to follow the Coding-Style. Replace occurences
14239 of a_b with aB and place the '*' correctly.
14241 * gtk/Api/webkitgtkframe.cpp:
14242 * gtk/Api/webkitgtkpage.cpp:
14243 * gtk/Api/webkitgtkprivate.h:
14245 2007-08-08 Holger Hans Peter Freyther <zecke@selfish.org>
14249 Reimplement GtkWidget::event and handle the keyboard and mouse
14250 events inside WebKitGtkPage.
14252 * gtk/Api/webkitgtkpage.cpp:
14253 (FrameGdkExposeData::frame_gdk_expose_child):
14254 (FrameGdkExposeData::webkit_gtk_page_rendering_area_handle_gdk_event):
14255 (FrameGdkExposeData::webkit_gtk_page_register_rendering_area_events):
14256 (FrameGdkExposeData::webkit_gtk_page_class_init):
14258 2007-08-07 Xan Lopez <xan@gnome.org>
14260 Reviewed by Mark Rowe.
14262 http://bugs.webkit.org/show_bug.cgi?id=14815
14263 [gtk] API implementation: reload
14265 * gtk/Api/webkitgtkpage.cpp: Implement the webkit_gtk_page_reload()
14268 2007-07-30 Diego Escalante Urrelo <diegoe@gnome.org>
14272 http://bugs.webkit.org/show_bug.cgi?id=14806
14273 Implement can_go_backward and can_go_forward in webkitgtkpage.cpp
14275 * gtk/Api/webkitgtkpage.cpp: Implement webkit_gtk_page_can_go_backward() and
14276 webkit_gtk_page_can_go_forward() functions.
14278 2007-07-30 Diego Escalante Urrelo <diegoe@gnome.org>
14280 Reviewed by Alp Toker.
14282 http://bugs.webkit.org/show_bug.cgi?id=14810
14283 Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp
14285 This is the proper fix for #14810.
14287 * gtk/Api/webkitgtkframe.cpp:
14288 * gtk/Api/webkitgtkpage.cpp: Fix the marshaller type of the "load_finished" signal and
14289 correct the class_offset parameters.
14291 2007-07-29 Diego Escalante Urrelo <diegoe@gnome.org>
14293 Reviewed by Alp Toker.
14295 http://bugs.webkit.org/show_bug.cgi?id=14810
14296 Bad n_params on load_finished's g_signal_new in webkitgtkpage.cpp
14298 * gtk/Api/webkitgtkpage.cpp: Use a correct n_params value and the corresponding types for
14299 them in the "load_finished" signal.
14301 2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
14305 Add the first API and partial implementation of the WebKit/Gtk port as
14306 of http://bugs.webkit.org/show_bug.cgi?id=14678.
14308 The delegates of WebView will be modeled as signals. Delegates like the
14309 WebPolicyDelegate will be implemented as signals with default handlers.
14311 Start moving files to WebKit/gtk/WebCoreSupport.
14315 * gtk/Api/headers.pri: Added.
14316 * gtk/Api/webkitgtk-marshal.list: Added.
14317 * gtk/Api/webkitgtkdefines.h: Added.
14318 * gtk/Api/webkitgtkframe.cpp: Added.
14319 * gtk/Api/webkitgtkframe.h: Added.
14320 * gtk/Api/webkitgtkframedata.cpp: Added.
14321 * gtk/Api/webkitgtkframedata.h: Added.
14322 * gtk/Api/webkitgtkglobal.cpp: Added.
14323 * gtk/Api/webkitgtkglobal.h: Added.
14324 * gtk/Api/webkitgtknetworkrequest.cpp: Added.
14325 * gtk/Api/webkitgtknetworkrequest.h: Added.
14326 * gtk/Api/webkitgtkpage.cpp: Added.
14327 * gtk/Api/webkitgtkpage.h: Added.
14328 * gtk/Api/webkitgtkprivate.cpp: Added.
14329 * gtk/Api/webkitgtkprivate.h: Added.
14330 * gtk/Api/webkitgtksettings.cpp: Added.
14331 * gtk/Api/webkitgtksettings.h: Added.
14332 * gtk/WebCoreSupport: Added.
14333 * gtk/WebCoreSupport/ChromeClientGdk.cpp: Added.
14334 (WebCore::ChromeClientGdk::ChromeClientGdk):
14335 (WebCore::ChromeClientGdk::chromeDestroyed):
14336 (WebCore::ChromeClientGdk::windowRect):
14337 (WebCore::ChromeClientGdk::setWindowRect):
14338 (WebCore::ChromeClientGdk::pageRect):
14339 (WebCore::ChromeClientGdk::scaleFactor):
14340 (WebCore::ChromeClientGdk::focus):
14341 (WebCore::ChromeClientGdk::unfocus):
14342 (WebCore::ChromeClientGdk::createWindow):
14343 (WebCore::ChromeClientGdk::createModalDialog):
14344 (WebCore::ChromeClientGdk::show):
14345 (WebCore::ChromeClientGdk::canRunModal):
14346 (WebCore::ChromeClientGdk::runModal):
14347 (WebCore::ChromeClientGdk::setToolbarsVisible):
14348 (WebCore::ChromeClientGdk::toolbarsVisible):
14349 (WebCore::ChromeClientGdk::setStatusbarVisible):
14350 (WebCore::ChromeClientGdk::statusbarVisible):
14351 (WebCore::ChromeClientGdk::setScrollbarsVisible):
14352 (WebCore::ChromeClientGdk::scrollbarsVisible):
14353 (WebCore::ChromeClientGdk::setMenubarVisible):
14354 (WebCore::ChromeClientGdk::menubarVisible):
14355 (WebCore::ChromeClientGdk::setResizable):
14356 (WebCore::ChromeClientGdk::closeWindowSoon):
14357 (WebCore::ChromeClientGdk::canTakeFocus):
14358 (WebCore::ChromeClientGdk::takeFocus):
14359 (WebCore::ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
14360 (WebCore::ChromeClientGdk::runBeforeUnloadConfirmPanel):
14361 (WebCore::ChromeClientGdk::addMessageToConsole):
14362 (WebCore::ChromeClientGdk::runJavaScriptAlert):
14363 (WebCore::ChromeClientGdk::runJavaScriptConfirm):
14364 (WebCore::ChromeClientGdk::runJavaScriptPrompt):
14365 (WebCore::ChromeClientGdk::setStatusbarText):
14366 (WebCore::ChromeClientGdk::shouldInterruptJavaScript):
14367 (WebCore::ChromeClientGdk::tabsToLinks):
14368 (WebCore::ChromeClientGdk::windowResizerRect):
14369 (WebCore::ChromeClientGdk::addToDirtyRegion):
14370 (WebCore::ChromeClientGdk::scrollBackingStore):
14371 (WebCore::ChromeClientGdk::updateBackingStore):
14372 (WebCore::ChromeClientGdk::mouseDidMoveOverElement):
14373 (WebCore::ChromeClientGdk::setToolTip):
14374 (WebCore::ChromeClientGdk::print):
14375 * gtk/WebCoreSupport/ChromeClientGdk.h: Added.