1 # Copyright (c) 2009, Google Inc. All rights reserved.
3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are
7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer
11 # in the documentation and/or other materials provided with the
13 # * Neither the name of Google Inc. nor the names of its
14 # contributors may be used to endorse or promote products derived from
15 # this software without specific prior written permission.
17 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
18 # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
19 # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
20 # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
21 # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
22 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
23 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 # WebKit's Python module for committer and reviewer validation
34 def __init__(self, name, email_or_emails, irc_nickname=None):
36 if isinstance(email_or_emails, str):
37 self.emails = [email_or_emails]
39 self.emails = email_or_emails
40 self.irc_nickname = irc_nickname
41 self.can_review = False
43 def bugzilla_email(self):
44 # FIXME: We're assuming the first email is a valid bugzilla email,
45 # which might not be right.
49 return '"%s" <%s>' % (self.full_name, self.emails[0])
52 class Reviewer(Committer):
54 def __init__(self, name, email_or_emails, irc_nickname=None):
55 Committer.__init__(self, name, email_or_emails, irc_nickname)
56 self.can_review = True
59 # This is intended as a canonical, machine-readable list of all non-reviewer
60 # committers for WebKit. If your name is missing here and you are a committer,
61 # please add it. No review needed. All reviewers are committers, so this list
62 # is only of committers who are not reviewers.
65 committers_unable_to_review = [
66 Committer("Aaron Boodman", "aa@chromium.org", "aboodman"),
67 Committer("Abhishek Arya", "inferno@chromium.org", "inferno-sec"),
68 Committer("Adam Langley", "agl@chromium.org", "agl"),
69 Committer("Albert J. Wong", "ajwong@chromium.org"),
70 Committer("Alejandro G. Castro", ["alex@igalia.com", "alex@webkit.org"]),
71 Committer("Alexander Kellett", ["lypanov@mac.com", "a-lists001@lypanov.net", "lypanov@kde.org"], "lypanov"),
72 Committer("Alexander Pavlov", "apavlov@chromium.org"),
73 Committer("Andre Boule", "aboule@apple.com"),
74 Committer("Andrei Popescu", "andreip@google.com", "andreip"),
75 Committer("Andrew Wellington", ["andrew@webkit.org", "proton@wiretapped.net"], "proton"),
76 Committer("Andrey Kosyakov", "caseq@chromium.org", "caseq"),
77 Committer("Andras Becsi", "abecsi@webkit.org", "bbandix"),
78 Committer("Andy Estes", "aestes@apple.com", "estes"),
79 Committer("Anthony Ricaud", "rik@webkit.org", "rik"),
80 Committer("Anton Muhin", "antonm@chromium.org", "antonm"),
81 Committer("Balazs Kelemen", "kbalazs@webkit.org", "kbalazs"),
82 Committer("Ben Murdoch", "benm@google.com", "benm"),
83 Committer("Benjamin C Meyer", ["ben@meyerhome.net", "ben@webkit.org"], "icefox"),
84 Committer("Benjamin Otte", ["otte@gnome.org", "otte@webkit.org"], "otte"),
85 Committer("Benjamin Poulain", ["benjamin.poulain@nokia.com", "ikipou@gmail.com"]),
86 Committer("Brent Fulgham", "bfulgham@webkit.org", "bfulgham"),
87 Committer("Brett Wilson", "brettw@chromium.org", "brettx"),
88 Committer("Brian Weinstein", "bweinstein@apple.com", "bweinstein"),
89 Committer("Cameron McCormack", "cam@webkit.org", "heycam"),
90 Committer("Carol Szabo", "carol.szabo@nokia.com"),
91 Committer("Chang Shu", "Chang.Shu@nokia.com"),
92 Committer("Chris Evans", "cevans@google.com"),
93 Committer("Chris Petersen", "cpetersen@apple.com", "cpetersen"),
94 Committer("Chris Rogers", "crogers@google.com", "crogers"),
95 Committer("Christian Dywan", ["christian@twotoasts.de", "christian@webkit.org"]),
96 Committer("Collin Jackson", "collinj@webkit.org"),
97 Committer("David Smith", ["catfish.man@gmail.com", "dsmith@webkit.org"], "catfishman"),
98 Committer("Dean Jackson", "dino@apple.com", "dino"),
99 Committer("Diego Gonzalez", ["diegohcg@webkit.org", "diego.gonzalez@openbossa.org"], "diegohcg"),
100 Committer("Dirk Pranke", "dpranke@chromium.org"),
101 Committer("Drew Wilson", "atwilson@chromium.org", "atwilson"),
102 Committer("Eli Fidler", "eli@staikos.net", "QBin"),
103 Committer("Enrica Casucci", "enrica@apple.com"),
104 Committer("Erik Arvidsson", "arv@chromium.org", "arv"),
105 Committer("Eric Roman", "eroman@chromium.org", "eroman"),
106 Committer("Evan Martin", "evan@chromium.org", "evmar"),
107 Committer("Evan Stade", "estade@chromium.org", "estade"),
108 Committer("Fady Samuel", "fsamuel@chromium.org", "fsamuel"),
109 Committer("Feng Qian", "feng@chromium.org"),
110 Committer("Fumitoshi Ukai", "ukai@chromium.org", "ukai"),
111 Committer("Gabor Loki", "loki@webkit.org", "loki04"),
112 Committer("Girish Ramakrishnan", ["girish@forwardbias.in", "ramakrishnan.girish@gmail.com"]),
113 Committer("Graham Dennis", ["Graham.Dennis@gmail.com", "gdennis@webkit.org"]),
114 Committer("Greg Bolsinga", "bolsinga@apple.com"),
115 Committer("Gyuyoung Kim", ["gyuyoung.kim@samsung.com", "gyuyoung@gmail.com", "gyuyoung@webkit.org"], "gyuyoung"),
116 Committer("Hans Wennborg", "hans@chromium.org", "hwennborg"),
117 Committer("Hayato Ito", "hayato@chromium.org", "hayato"),
118 Committer("Hin-Chung Lam", ["hclam@google.com", "hclam@chromium.org"]),
119 Committer("Ilya Tikhonovsky", "loislo@chromium.org", "loislo"),
120 Committer("Jakob Petsovits", ["jpetsovits@rim.com", "jpetso@gmx.at"], "jpetso"),
121 Committer("Jakub Wieczorek", "jwieczorek@webkit.org", "fawek"),
122 Committer("James Hawkins", ["jhawkins@chromium.org", "jhawkins@google.com"], "jhawkins"),
123 Committer("Jay Civelli", "jcivelli@chromium.org", "jcivelli"),
124 Committer("Jens Alfke", ["snej@chromium.org", "jens@apple.com"]),
125 Committer("Jer Noble", "jer.noble@apple.com", "jernoble"),
126 Committer("Jeremy Moskovich", ["playmobil@google.com", "jeremy@chromium.org"], "jeremymos"),
127 Committer("Jessie Berlin", ["jberlin@webkit.org", "jberlin@apple.com"]),
128 Committer("Jesus Sanchez-Palencia", ["jesus@webkit.org", "jesus.palencia@openbossa.org"], "jeez_"),
129 Committer("Jocelyn Turcotte", "jocelyn.turcotte@nokia.com", "jturcotte"),
130 Committer("Jochen Eisinger", "jochen@chromium.org", "jochen__"),
131 Committer("John Abd-El-Malek", "jam@chromium.org", "jam"),
132 Committer("John Gregg", ["johnnyg@google.com", "johnnyg@chromium.org"], "johnnyg"),
133 Committer("Joost de Valk", ["joost@webkit.org", "webkit-dev@joostdevalk.nl"], "Altha"),
134 Committer("Julie Parent", ["jparent@google.com", "jparent@chromium.org"], "jparent"),
135 Committer("Julien Chaffraix", ["jchaffraix@webkit.org", "julien.chaffraix@gmail.com"]),
136 Committer("Jungshik Shin", "jshin@chromium.org"),
137 Committer("Justin Schuh", "jschuh@chromium.org", "jschuh"),
138 Committer("Keishi Hattori", "keishi@webkit.org", "keishi"),
139 Committer("Kelly Norton", "knorton@google.com"),
140 Committer("Kent Hansen", "kent.hansen@nokia.com", "khansen"),
141 Committer("Kimmo Kinnunen", ["kimmo.t.kinnunen@nokia.com", "kimmok@iki.fi", "ktkinnun@webkit.org"], "kimmok"),
142 Committer("Kinuko Yasuda", "kinuko@chromium.org", "kinuko"),
143 Committer("Krzysztof Kowalczyk", "kkowalczyk@gmail.com"),
144 Committer("Kwang Yul Seo", ["kwangyul.seo@gmail.com", "skyul@company100.net", "kseo@webkit.org"], "kwangseo"),
145 Committer("Leandro Pereira", ["leandro@profusion.mobi", "leandro@webkit.org"], "acidx"),
146 Committer("Levi Weintraub", "lweintraub@apple.com"),
147 Committer("Lucas De Marchi", ["lucas.demarchi@profusion.mobi", "demarchi@webkit.org"], "demarchi"),
148 Committer("Luiz Agostini", ["luiz@webkit.org", "luiz.agostini@openbossa.org"], "lca"),
149 Committer("Mads Ager", "ager@chromium.org"),
150 Committer("Marcus Voltis Bulach", "bulach@chromium.org"),
151 Committer("Mario Sanchez Prada", ["msanchez@igalia.com", "mario@webkit.org"], "msanchez"),
152 Committer("Matt Delaney", "mdelaney@apple.com"),
153 Committer("Matt Lilek", ["webkit@mattlilek.com", "pewtermoose@webkit.org"]),
154 Committer("Matt Perry", "mpcomplete@chromium.org"),
155 Committer("Maxime Britto", ["maxime.britto@gmail.com", "britto@apple.com"]),
156 Committer("Maxime Simon", ["simon.maxime@gmail.com", "maxime.simon@webkit.org"], "maxime.simon"),
157 Committer("Michael Nordman", "michaeln@google.com", "michaeln"),
158 Committer("Michael Saboff", "msaboff@apple.com"),
159 Committer("Michelangelo De Simone", "michelangelo@webkit.org", "michelangelo"),
160 Committer("Mihai Parparita", "mihaip@chromium.org", "mihaip"),
161 Committer("Mike Belshe", ["mbelshe@chromium.org", "mike@belshe.com"]),
162 Committer("Mike Fenton", ["mifenton@rim.com", "mike.fenton@torchmobile.com"], "mfenton"),
163 Committer("Mike Thole", ["mthole@mikethole.com", "mthole@apple.com"]),
164 Committer("Mikhail Naganov", "mnaganov@chromium.org"),
165 Committer("MORITA Hajime", "morrita@google.com", "morrita"),
166 Committer("Nico Weber", ["thakis@chromium.org", "thakis@google.com"], "thakis"),
167 Committer("Noam Rosenthal", "noam.rosenthal@nokia.com", "noamr"),
168 Committer("Pam Greene", "pam@chromium.org", "pamg"),
169 Committer("Patrick Gansterer", ["paroga@paroga.com", "paroga@webkit.org"], "paroga"),
170 Committer("Pavel Podivilov", "podivilov@chromium.org", "podivilov"),
171 Committer("Peter Kasting", ["pkasting@google.com", "pkasting@chromium.org"], "pkasting"),
172 Committer("Philippe Normand", ["pnormand@igalia.com", "philn@webkit.org"], "philn-tp"),
173 Committer("Pierre d'Herbemont", ["pdherbemont@free.fr", "pdherbemont@apple.com"], "pdherbemont"),
174 Committer("Pierre-Olivier Latour", "pol@apple.com", "pol"),
175 Committer("Renata Hodovan", "reni@webkit.org", "reni"),
176 Committer("Robert Hogan", ["robert@webkit.org", "robert@roberthogan.net", "lists@roberthogan.net"], "mwenge"),
177 Committer("Roland Steiner", "rolandsteiner@chromium.org"),
178 Committer("Ryosuke Niwa", "rniwa@webkit.org", "rniwa"),
179 Committer("Satish Sampath", "satish@chromium.org"),
180 Committer("Scott Violet", "sky@chromium.org", "sky"),
181 Committer("Stephen White", "senorblanco@chromium.org", "senorblanco"),
182 Committer("Tony Gentilcore", "tonyg@chromium.org", "tonyg-cr"),
183 Committer("Trey Matteson", "trey@usa.net", "trey"),
184 Committer("Tristan O'Tierney", ["tristan@otierney.net", "tristan@apple.com"]),
185 Committer("Vangelis Kokkevis", "vangelis@chromium.org", "vangelis"),
186 Committer("Victor Wang", "victorw@chromium.org", "victorw"),
187 Committer("Vitaly Repeshko", "vitalyr@chromium.org"),
188 Committer("William Siegrist", "wsiegrist@apple.com", "wms"),
189 Committer("Xiaomei Ji", "xji@chromium.org", "xji"),
190 Committer("Yael Aharon", "yael.aharon@nokia.com"),
191 Committer("Yaar Schnitman", ["yaar@chromium.org", "yaar@google.com"]),
192 Committer("Yong Li", ["yong.li.webkit@gmail.com", "yong.li@torchmobile.com"], "yong"),
193 Committer("Yongjun Zhang", "yongjun.zhang@nokia.com"),
194 Committer("Yuta Kitamura", "yutak@chromium.org", "yutak"),
195 Committer("Yuzo Fujishima", "yuzo@google.com", "yuzo"),
196 Committer("Zhenyao Mo", "zmo@google.com", "zhenyao"),
197 Committer("Zoltan Herczeg", "zherczeg@webkit.org", "zherczeg"),
198 Committer("Zoltan Horvath", ["zoltan@webkit.org", "hzoltan@inf.u-szeged.hu", "horvath.zoltan.6@stud.u-szeged.hu"], "zoltan"),
202 # This is intended as a canonical, machine-readable list of all reviewers for
203 # WebKit. If your name is missing here and you are a reviewer, please add it.
208 Reviewer("Ada Chan", "adachan@apple.com", "chanada"),
209 Reviewer("Adam Barth", "abarth@webkit.org", "abarth"),
210 Reviewer("Adam Roben", "aroben@apple.com", "aroben"),
211 Reviewer("Adam Treat", ["treat@kde.org", "treat@webkit.org", "atreat@rim.com"], "manyoso"),
212 Reviewer("Adele Peterson", "adele@apple.com", "adele"),
213 Reviewer("Alexey Proskuryakov", ["ap@webkit.org", "ap@apple.com"], "ap"),
214 Reviewer("Alice Liu", "alice.liu@apple.com", "aliu"),
215 Reviewer("Alp Toker", ["alp@nuanti.com", "alp@atoker.com", "alp@webkit.org"], "alp"),
216 Reviewer("Anders Carlsson", ["andersca@apple.com", "acarlsson@apple.com"], "andersca"),
217 Reviewer("Andreas Kling", ["kling@webkit.org", "andreas.kling@nokia.com"], "kling"),
218 Reviewer("Antonio Gomes", ["tonikitoo@webkit.org", "agomes@rim.com"], "tonikitoo"),
219 Reviewer("Antti Koivisto", ["koivisto@iki.fi", "antti@apple.com", "antti.j.koivisto@nokia.com"], "anttik"),
220 Reviewer("Ariya Hidayat", ["ariya.hidayat@gmail.com", "ariya@sencha.com", "ariya@webkit.org"], "ariya"),
221 Reviewer("Beth Dakin", "bdakin@apple.com", "dethbakin"),
222 Reviewer("Brady Eidson", "beidson@apple.com", "bradee-oh"),
223 Reviewer("Cameron Zwarich", ["zwarich@apple.com", "cwzwarich@apple.com", "cwzwarich@webkit.org"]),
224 Reviewer("Chris Blumenberg", "cblu@apple.com", "cblu"),
225 Reviewer("Chris Marrin", "cmarrin@apple.com", "cmarrin"),
226 Reviewer("Chris Fleizach", "cfleizach@apple.com", "cfleizach"),
227 Reviewer("Chris Jerdonek", "cjerdonek@webkit.org", "cjerdonek"),
228 Reviewer(u"Csaba Osztrogon\u00e1c", "ossy@webkit.org", "ossy"),
229 Reviewer("Dan Bernstein", ["mitz@webkit.org", "mitz@apple.com"], "mitzpettel"),
230 Reviewer("Daniel Bates", "dbates@webkit.org", "dydz"),
231 Reviewer("Darin Adler", "darin@apple.com", "darin"),
232 Reviewer("Darin Fisher", ["fishd@chromium.org", "darin@chromium.org"], "fishd"),
233 Reviewer("David Harrison", "harrison@apple.com", "harrison"),
234 Reviewer("David Hyatt", "hyatt@apple.com", "hyatt"),
235 Reviewer("David Kilzer", ["ddkilzer@webkit.org", "ddkilzer@apple.com"], "ddkilzer"),
236 Reviewer("David Levin", "levin@chromium.org", "dave_levin"),
237 Reviewer("Dimitri Glazkov", "dglazkov@chromium.org", "dglazkov"),
238 Reviewer("Dirk Schulze", "krit@webkit.org", "krit"),
239 Reviewer("Dmitry Titov", "dimich@chromium.org", "dimich"),
240 Reviewer("Don Melton", "gramps@apple.com", "gramps"),
241 Reviewer("Dumitru Daniliuc", "dumi@chromium.org", "dumi"),
242 Reviewer("Eric Carlson", "eric.carlson@apple.com"),
243 Reviewer("Eric Seidel", "eric@webkit.org", "eseidel"),
244 Reviewer("Gavin Barraclough", "barraclough@apple.com", "gbarra"),
245 Reviewer("Geoffrey Garen", "ggaren@apple.com", "ggaren"),
246 Reviewer("George Staikos", ["staikos@kde.org", "staikos@webkit.org"]),
247 Reviewer("Gustavo Noronha Silva", ["gns@gnome.org", "kov@webkit.org", "gustavo.noronha@collabora.co.uk"], "kov"),
248 Reviewer("Holger Freyther", ["zecke@selfish.org", "zecke@webkit.org"], "zecke"),
249 Reviewer("James Robinson", ["jamesr@chromium.org", "jamesr@google.com"], "jamesr"),
250 Reviewer("Jan Alonzo", ["jmalonzo@gmail.com", "jmalonzo@webkit.org"], "janm"),
251 Reviewer("Jeremy Orlow", "jorlow@chromium.org", "jorlow"),
252 Reviewer("Jian Li", "jianli@chromium.org", "jianli"),
253 Reviewer("John Sullivan", "sullivan@apple.com", "sullivan"),
254 Reviewer("Jon Honeycutt", "jhoneycutt@apple.com", "jhoneycutt"),
255 Reviewer("Joseph Pecoraro", ["joepeck@webkit.org", "pecoraro@apple.com"], "JoePeck"),
256 Reviewer("Justin Garcia", "justin.garcia@apple.com", "justing"),
257 Reviewer("Ken Kocienda", "kocienda@apple.com"),
258 Reviewer("Kenneth Rohde Christiansen", ["kenneth@webkit.org", "kenneth.christiansen@openbossa.org", "kenneth.christiansen@gmail.com"], "kenne"),
259 Reviewer("Kenneth Russell", "kbr@google.com", "kbr_google"),
260 Reviewer("Kent Tamura", "tkent@chromium.org", "tkent"),
261 Reviewer("Kevin Decker", "kdecker@apple.com", "superkevin"),
262 Reviewer("Kevin McCullough", "kmccullough@apple.com", "maculloch"),
263 Reviewer("Kevin Ollivier", ["kevino@theolliviers.com", "kevino@webkit.org"], "kollivier"),
264 Reviewer("Lars Knoll", ["lars@trolltech.com", "lars@kde.org", "lars.knoll@nokia.com"], "lars"),
265 Reviewer("Laszlo Gombos", "laszlo.1.gombos@nokia.com", "lgombos"),
266 Reviewer("Maciej Stachowiak", "mjs@apple.com", "othermaciej"),
267 Reviewer("Mark Rowe", "mrowe@apple.com", "bdash"),
268 Reviewer("Martin Robinson", ["mrobinson@webkit.org", "mrobinson@igalia.com", "martin.james.robinson@gmail.com"], "mrobinson"),
269 Reviewer("Nate Chapin", "japhet@chromium.org", "japhet"),
270 Reviewer("Nikolas Zimmermann", ["zimmermann@kde.org", "zimmermann@physik.rwth-aachen.de", "zimmermann@webkit.org"], "wildfox"),
271 Reviewer("Ojan Vafai", "ojan@chromium.org", "ojan"),
272 Reviewer("Oliver Hunt", "oliver@apple.com", "olliej"),
273 Reviewer("Pavel Feldman", "pfeldman@chromium.org", "pfeldman"),
274 Reviewer("Richard Williamson", "rjw@apple.com", "rjw"),
275 Reviewer("Rob Buis", ["rwlbuis@gmail.com", "rwlbuis@webkit.org"], "rwlbuis"),
276 Reviewer("Sam Weinig", ["sam@webkit.org", "weinig@apple.com"], "weinig"),
277 Reviewer("Shinichiro Hamaji", "hamaji@chromium.org", "hamaji"),
278 Reviewer("Simon Fraser", "simon.fraser@apple.com", "smfr"),
279 Reviewer("Simon Hausmann", ["hausmann@webkit.org", "hausmann@kde.org", "simon.hausmann@nokia.com"], "tronical"),
280 Reviewer("Stephanie Lewis", "slewis@apple.com", "sundiamonde"),
281 Reviewer("Steve Block", "steveblock@google.com", "steveblock"),
282 Reviewer("Steve Falkenburg", "sfalken@apple.com", "sfalken"),
283 Reviewer("Tim Omernick", "timo@apple.com"),
284 Reviewer("Timothy Hatcher", ["timothy@apple.com", "timothy@hatcher.name"], "xenon"),
285 Reviewer("Tony Chang", "tony@chromium.org", "tony^work"),
286 Reviewer(u"Tor Arne Vestb\u00f8", ["vestbo@webkit.org", "tor.arne.vestbo@nokia.com"], "torarne"),
287 Reviewer("Vicki Murley", "vicki@apple.com"),
288 Reviewer("Xan Lopez", ["xan.lopez@gmail.com", "xan@gnome.org", "xan@webkit.org"], "xan"),
289 Reviewer("Yury Semikhatsky", "yurys@chromium.org", "yurys"),
290 Reviewer("Zack Rusin", "zack@kde.org", "zackr"),
296 # Committers and reviewers are passed in to allow easy testing
299 committers=committers_unable_to_review,
300 reviewers=reviewers_list):
301 self._committers = committers + reviewers
302 self._reviewers = reviewers
303 self._committers_by_email = {}
305 def committers(self):
306 return self._committers
309 return self._reviewers
311 def _email_to_committer_map(self):
312 if not len(self._committers_by_email):
313 for committer in self._committers:
314 for email in committer.emails:
315 self._committers_by_email[email] = committer
316 return self._committers_by_email
318 def committer_by_name(self, name):
319 # This could be made into a hash lookup if callers need it to be fast.
320 for committer in self.committers():
321 if committer.full_name == name:
324 def committer_by_email(self, email):
325 return self._email_to_committer_map().get(email)
327 def reviewer_by_email(self, email):
328 committer = self.committer_by_email(email)
329 if committer and not committer.can_review: