2 * Copyright (C) 2012 Russell King
3 * Rewritten from the dovefb driver, and Armada510 manuals.
5 * This program is free software; you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 2 as
7 * published by the Free Software Foundation.
10 #include <linux/component.h>
11 #include <linux/of_device.h>
12 #include <linux/platform_device.h>
14 #include <drm/drm_atomic.h>
15 #include <drm/drm_crtc_helper.h>
16 #include <drm/drm_plane_helper.h>
17 #include <drm/drm_atomic_helper.h>
18 #include "armada_crtc.h"
19 #include "armada_drm.h"
20 #include "armada_fb.h"
21 #include "armada_gem.h"
22 #include "armada_hw.h"
23 #include "armada_trace.h"
33 static const uint32_t armada_primary_formats[] = {
51 * A note about interlacing. Let's consider HDMI 1920x1080i.
52 * The timing parameters we have from X are:
53 * Hact HsyA HsyI Htot Vact VsyA VsyI Vtot
54 * 1920 2448 2492 2640 1080 1084 1094 1125
55 * Which get translated to:
56 * Hact HsyA HsyI Htot Vact VsyA VsyI Vtot
57 * 1920 2448 2492 2640 540 542 547 562
59 * This is how it is defined by CEA-861-D - line and pixel numbers are
60 * referenced to the rising edge of VSYNC and HSYNC. Total clocks per
61 * line: 2640. The odd frame, the first active line is at line 21, and
62 * the even frame, the first active line is 584.
64 * LN: 560 561 562 563 567 568 569
65 * DE: ~~~|____________________________//__________________________
66 * HSYNC: ____|~|_____|~|_____|~|_____|~|_//__|~|_____|~|_____|~|_____
67 * VSYNC: _________________________|~~~~~~//~~~~~~~~~~~~~~~|__________
68 * 22 blanking lines. VSYNC at 1320 (referenced to the HSYNC rising edge).
70 * LN: 1123 1124 1125 1 5 6 7
71 * DE: ~~~|____________________________//__________________________
72 * HSYNC: ____|~|_____|~|_____|~|_____|~|_//__|~|_____|~|_____|~|_____
73 * VSYNC: ____________________|~~~~~~~~~~~//~~~~~~~~~~|_______________
76 * The Armada LCD Controller line and pixel numbers are, like X timings,
77 * referenced to the top left of the active frame.
79 * So, translating these to our LCD controller:
80 * Odd frame, 563 total lines, VSYNC at line 543-548, pixel 1128.
81 * Even frame, 562 total lines, VSYNC at line 542-547, pixel 2448.
82 * Note: Vsync front porch remains constant!
85 * vtotal = mode->crtc_vtotal + 1;
86 * vbackporch = mode->crtc_vsync_start - mode->crtc_vdisplay + 1;
87 * vhorizpos = mode->crtc_hsync_start - mode->crtc_htotal / 2
89 * vtotal = mode->crtc_vtotal;
90 * vbackporch = mode->crtc_vsync_start - mode->crtc_vdisplay;
91 * vhorizpos = mode->crtc_hsync_start;
93 * vfrontporch = mode->crtc_vtotal - mode->crtc_vsync_end;
95 * So, we need to reprogram these registers on each vsync event:
96 * LCD_SPU_V_PORCH, LCD_SPU_ADV_REG, LCD_SPUT_V_H_TOTAL
98 * Note: we do not use the frame done interrupts because these appear
99 * to happen too early, and lead to jitter on the display (presumably
100 * they occur at the end of the last active line, before the vsync back
101 * porch, which we're reprogramming.)
105 armada_drm_crtc_update_regs(struct armada_crtc *dcrtc, struct armada_regs *regs)
107 while (regs->offset != ~0) {
108 void __iomem *reg = dcrtc->base + regs->offset;
113 val &= readl_relaxed(reg);
114 writel_relaxed(val | regs->val, reg);
119 #define dpms_blanked(dpms) ((dpms) != DRM_MODE_DPMS_ON)
121 static void armada_drm_crtc_update(struct armada_crtc *dcrtc)
125 dumb_ctrl = dcrtc->cfg_dumb_ctrl;
127 if (!dpms_blanked(dcrtc->dpms))
128 dumb_ctrl |= CFG_DUMB_ENA;
131 * When the dumb interface isn't in DUMB24_RGB888_0 mode, it might
132 * be using SPI or GPIO. If we set this to DUMB_BLANK, we will
133 * force LCD_D[23:0] to output blank color, overriding the GPIO or
134 * SPI usage. So leave it as-is unless in DUMB24_RGB888_0 mode.
136 if (dpms_blanked(dcrtc->dpms) &&
137 (dumb_ctrl & DUMB_MASK) == DUMB24_RGB888_0) {
138 dumb_ctrl &= ~DUMB_MASK;
139 dumb_ctrl |= DUMB_BLANK;
143 * The documentation doesn't indicate what the normal state of
144 * the sync signals are. Sebastian Hesselbart kindly probed
145 * these signals on his board to determine their state.
147 * The non-inverted state of the sync signals is active high.
148 * Setting these bits makes the appropriate signal active low.
150 if (dcrtc->crtc.mode.flags & DRM_MODE_FLAG_NCSYNC)
151 dumb_ctrl |= CFG_INV_CSYNC;
152 if (dcrtc->crtc.mode.flags & DRM_MODE_FLAG_NHSYNC)
153 dumb_ctrl |= CFG_INV_HSYNC;
154 if (dcrtc->crtc.mode.flags & DRM_MODE_FLAG_NVSYNC)
155 dumb_ctrl |= CFG_INV_VSYNC;
157 if (dcrtc->dumb_ctrl != dumb_ctrl) {
158 dcrtc->dumb_ctrl = dumb_ctrl;
159 writel_relaxed(dumb_ctrl, dcrtc->base + LCD_SPU_DUMB_CTRL);
163 void armada_drm_plane_calc_addrs(u32 *addrs, struct drm_framebuffer *fb,
166 const struct drm_format_info *format = fb->format;
167 unsigned int num_planes = format->num_planes;
168 u32 addr = drm_fb_obj(fb)->dev_addr;
174 addrs[0] = addr + fb->offsets[0] + y * fb->pitches[0] +
180 for (i = 1; i < num_planes; i++)
181 addrs[i] = addr + fb->offsets[i] + y * fb->pitches[i] +
187 static unsigned armada_drm_crtc_calc_fb(struct drm_framebuffer *fb,
188 int x, int y, struct armada_regs *regs, bool interlaced)
190 unsigned pitch = fb->pitches[0];
191 u32 addrs[3], addr_odd, addr_even;
194 DRM_DEBUG_DRIVER("pitch %u x %d y %d bpp %d\n",
195 pitch, x, y, fb->format->cpp[0] * 8);
197 armada_drm_plane_calc_addrs(addrs, fb, x, y);
199 addr_odd = addr_even = addrs[0];
206 /* write offset, base, and pitch */
207 armada_reg_queue_set(regs, i, addr_odd, LCD_CFG_GRA_START_ADDR0);
208 armada_reg_queue_set(regs, i, addr_even, LCD_CFG_GRA_START_ADDR1);
209 armada_reg_queue_mod(regs, i, pitch, 0xffff, LCD_CFG_GRA_PITCH);
214 static void armada_drm_plane_work_call(struct armada_crtc *dcrtc,
215 struct armada_plane_work *work,
216 void (*fn)(struct armada_crtc *, struct armada_plane_work *))
218 struct armada_plane *dplane = drm_to_armada_plane(work->plane);
219 struct drm_pending_vblank_event *event;
220 struct drm_framebuffer *fb;
224 drm_crtc_vblank_put(&dcrtc->crtc);
229 struct drm_device *dev = dcrtc->crtc.dev;
232 spin_lock_irqsave(&dev->event_lock, flags);
234 drm_crtc_send_vblank_event(&dcrtc->crtc, event);
236 __armada_drm_queue_unref_work(dev, fb);
237 spin_unlock_irqrestore(&dev->event_lock, flags);
240 if (work->need_kfree)
243 wake_up(&dplane->frame_wait);
246 static void armada_drm_plane_work_run(struct armada_crtc *dcrtc,
247 struct drm_plane *plane)
249 struct armada_plane *dplane = drm_to_armada_plane(plane);
250 struct armada_plane_work *work = xchg(&dplane->work, NULL);
252 /* Handle any pending frame work. */
254 armada_drm_plane_work_call(dcrtc, work, work->fn);
257 int armada_drm_plane_work_queue(struct armada_crtc *dcrtc,
258 struct armada_plane_work *work)
260 struct armada_plane *plane = drm_to_armada_plane(work->plane);
263 ret = drm_crtc_vblank_get(&dcrtc->crtc);
267 ret = cmpxchg(&plane->work, NULL, work) ? -EBUSY : 0;
269 drm_crtc_vblank_put(&dcrtc->crtc);
274 int armada_drm_plane_work_wait(struct armada_plane *plane, long timeout)
276 return wait_event_timeout(plane->frame_wait, !plane->work, timeout);
279 void armada_drm_plane_work_cancel(struct armada_crtc *dcrtc,
280 struct armada_plane *dplane)
282 struct armada_plane_work *work = xchg(&dplane->work, NULL);
285 armada_drm_plane_work_call(dcrtc, work, work->cancel);
288 static void armada_drm_crtc_complete_frame_work(struct armada_crtc *dcrtc,
289 struct armada_plane_work *work)
293 spin_lock_irqsave(&dcrtc->irq_lock, flags);
294 armada_drm_crtc_update_regs(dcrtc, work->regs);
295 spin_unlock_irqrestore(&dcrtc->irq_lock, flags);
298 static struct armada_plane_work *
299 armada_drm_crtc_alloc_plane_work(struct drm_plane *plane)
301 struct armada_plane_work *work;
304 work = kzalloc(sizeof(*work), GFP_KERNEL);
309 work->fn = armada_drm_crtc_complete_frame_work;
310 work->need_kfree = true;
311 armada_reg_queue_end(work->regs, i);
316 static void armada_drm_vblank_off(struct armada_crtc *dcrtc)
319 * Tell the DRM core that vblank IRQs aren't going to happen for
320 * a while. This cleans up any pending vblank events for us.
322 drm_crtc_vblank_off(&dcrtc->crtc);
323 armada_drm_plane_work_run(dcrtc, dcrtc->crtc.primary);
326 /* The mode_config.mutex will be held for this call */
327 static void armada_drm_crtc_dpms(struct drm_crtc *crtc, int dpms)
329 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
331 if (dpms_blanked(dcrtc->dpms) != dpms_blanked(dpms)) {
332 if (dpms_blanked(dpms))
333 armada_drm_vblank_off(dcrtc);
334 else if (!IS_ERR(dcrtc->clk))
335 WARN_ON(clk_prepare_enable(dcrtc->clk));
337 armada_drm_crtc_update(dcrtc);
338 if (!dpms_blanked(dpms))
339 drm_crtc_vblank_on(&dcrtc->crtc);
340 else if (!IS_ERR(dcrtc->clk))
341 clk_disable_unprepare(dcrtc->clk);
342 } else if (dcrtc->dpms != dpms) {
348 * Prepare for a mode set. Turn off overlay to ensure that we don't end
349 * up with the overlay size being bigger than the active screen size.
350 * We rely upon X refreshing this state after the mode set has completed.
352 * The mode_config.mutex will be held for this call
354 static void armada_drm_crtc_prepare(struct drm_crtc *crtc)
356 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
357 struct drm_plane *plane;
361 * If we have an overlay plane associated with this CRTC, disable
362 * it before the modeset to avoid its coordinates being outside
363 * the new mode parameters.
365 plane = dcrtc->plane;
367 drm_plane_force_disable(plane);
368 WARN_ON(!armada_drm_plane_work_wait(drm_to_armada_plane(plane),
372 /* Wait for pending flips to complete */
373 armada_drm_plane_work_wait(drm_to_armada_plane(dcrtc->crtc.primary),
374 MAX_SCHEDULE_TIMEOUT);
376 drm_crtc_vblank_off(crtc);
378 val = dcrtc->dumb_ctrl & ~CFG_DUMB_ENA;
379 if (val != dcrtc->dumb_ctrl) {
380 dcrtc->dumb_ctrl = val;
381 writel_relaxed(val, dcrtc->base + LCD_SPU_DUMB_CTRL);
385 /* The mode_config.mutex will be held for this call */
386 static void armada_drm_crtc_commit(struct drm_crtc *crtc)
388 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
390 dcrtc->dpms = DRM_MODE_DPMS_ON;
391 armada_drm_crtc_update(dcrtc);
392 drm_crtc_vblank_on(crtc);
395 /* The mode_config.mutex will be held for this call */
396 static bool armada_drm_crtc_mode_fixup(struct drm_crtc *crtc,
397 const struct drm_display_mode *mode, struct drm_display_mode *adj)
399 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
402 /* We can't do interlaced modes if we don't have the SPU_ADV_REG */
403 if (!dcrtc->variant->has_spu_adv_reg &&
404 adj->flags & DRM_MODE_FLAG_INTERLACE)
407 /* Check whether the display mode is possible */
408 ret = dcrtc->variant->compute_clock(dcrtc, adj, NULL);
415 /* These are locked by dev->vbl_lock */
416 static void armada_drm_crtc_disable_irq(struct armada_crtc *dcrtc, u32 mask)
418 if (dcrtc->irq_ena & mask) {
419 dcrtc->irq_ena &= ~mask;
420 writel(dcrtc->irq_ena, dcrtc->base + LCD_SPU_IRQ_ENA);
424 static void armada_drm_crtc_enable_irq(struct armada_crtc *dcrtc, u32 mask)
426 if ((dcrtc->irq_ena & mask) != mask) {
427 dcrtc->irq_ena |= mask;
428 writel(dcrtc->irq_ena, dcrtc->base + LCD_SPU_IRQ_ENA);
429 if (readl_relaxed(dcrtc->base + LCD_SPU_IRQ_ISR) & mask)
430 writel(0, dcrtc->base + LCD_SPU_IRQ_ISR);
434 static void armada_drm_crtc_irq(struct armada_crtc *dcrtc, u32 stat)
436 void __iomem *base = dcrtc->base;
437 struct drm_plane *ovl_plane;
439 if (stat & DMA_FF_UNDERFLOW)
440 DRM_ERROR("video underflow on crtc %u\n", dcrtc->num);
441 if (stat & GRA_FF_UNDERFLOW)
442 DRM_ERROR("graphics underflow on crtc %u\n", dcrtc->num);
444 if (stat & VSYNC_IRQ)
445 drm_crtc_handle_vblank(&dcrtc->crtc);
447 ovl_plane = dcrtc->plane;
449 armada_drm_plane_work_run(dcrtc, ovl_plane);
451 spin_lock(&dcrtc->irq_lock);
452 if (stat & GRA_FRAME_IRQ && dcrtc->interlaced) {
453 int i = stat & GRA_FRAME_IRQ0 ? 0 : 1;
456 writel_relaxed(dcrtc->v[i].spu_v_porch, base + LCD_SPU_V_PORCH);
457 writel_relaxed(dcrtc->v[i].spu_v_h_total,
458 base + LCD_SPUT_V_H_TOTAL);
460 val = readl_relaxed(base + LCD_SPU_ADV_REG);
461 val &= ~(ADV_VSYNC_L_OFF | ADV_VSYNC_H_OFF | ADV_VSYNCOFFEN);
462 val |= dcrtc->v[i].spu_adv_reg;
463 writel_relaxed(val, base + LCD_SPU_ADV_REG);
466 if (stat & DUMB_FRAMEDONE && dcrtc->cursor_update) {
467 writel_relaxed(dcrtc->cursor_hw_pos,
468 base + LCD_SPU_HWC_OVSA_HPXL_VLN);
469 writel_relaxed(dcrtc->cursor_hw_sz,
470 base + LCD_SPU_HWC_HPXL_VLN);
471 armada_updatel(CFG_HWC_ENA,
472 CFG_HWC_ENA | CFG_HWC_1BITMOD | CFG_HWC_1BITENA,
473 base + LCD_SPU_DMA_CTRL0);
474 dcrtc->cursor_update = false;
475 armada_drm_crtc_disable_irq(dcrtc, DUMB_FRAMEDONE_ENA);
478 spin_unlock(&dcrtc->irq_lock);
480 if (stat & GRA_FRAME_IRQ)
481 armada_drm_plane_work_run(dcrtc, dcrtc->crtc.primary);
484 static irqreturn_t armada_drm_irq(int irq, void *arg)
486 struct armada_crtc *dcrtc = arg;
487 u32 v, stat = readl_relaxed(dcrtc->base + LCD_SPU_IRQ_ISR);
490 * Reading the ISR appears to clear bits provided CLEAN_SPU_IRQ_ISR
491 * is set. Writing has some other effect to acknowledge the IRQ -
492 * without this, we only get a single IRQ.
494 writel_relaxed(0, dcrtc->base + LCD_SPU_IRQ_ISR);
496 trace_armada_drm_irq(&dcrtc->crtc, stat);
498 /* Mask out those interrupts we haven't enabled */
499 v = stat & dcrtc->irq_ena;
501 if (v & (VSYNC_IRQ|GRA_FRAME_IRQ|DUMB_FRAMEDONE)) {
502 armada_drm_crtc_irq(dcrtc, stat);
508 static uint32_t armada_drm_crtc_calculate_csc(struct armada_crtc *dcrtc)
510 struct drm_display_mode *adj = &dcrtc->crtc.mode;
513 if (dcrtc->csc_yuv_mode == CSC_YUV_CCIR709)
514 val |= CFG_CSC_YUV_CCIR709;
515 if (dcrtc->csc_rgb_mode == CSC_RGB_STUDIO)
516 val |= CFG_CSC_RGB_STUDIO;
519 * In auto mode, set the colorimetry, based upon the HDMI spec.
520 * 1280x720p, 1920x1080p and 1920x1080i use ITU709, others use
521 * ITU601. It may be more appropriate to set this depending on
522 * the source - but what if the graphic frame is YUV and the
523 * video frame is RGB?
525 if ((adj->hdisplay == 1280 && adj->vdisplay == 720 &&
526 !(adj->flags & DRM_MODE_FLAG_INTERLACE)) ||
527 (adj->hdisplay == 1920 && adj->vdisplay == 1080)) {
528 if (dcrtc->csc_yuv_mode == CSC_AUTO)
529 val |= CFG_CSC_YUV_CCIR709;
533 * We assume we're connected to a TV-like device, so the YUV->RGB
534 * conversion should produce a limited range. We should set this
535 * depending on the connectors attached to this CRTC, and what
536 * kind of device they report being connected.
538 if (dcrtc->csc_rgb_mode == CSC_AUTO)
539 val |= CFG_CSC_RGB_STUDIO;
544 /* The mode_config.mutex will be held for this call */
545 static void armada_drm_crtc_mode_set_nofb(struct drm_crtc *crtc)
547 struct drm_display_mode *adj = &crtc->state->adjusted_mode;
548 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
549 struct armada_regs regs[17];
550 uint32_t lm, rm, tm, bm, val, sclk;
553 bool interlaced = !!(adj->flags & DRM_MODE_FLAG_INTERLACE);
556 rm = adj->crtc_hsync_start - adj->crtc_hdisplay;
557 lm = adj->crtc_htotal - adj->crtc_hsync_end;
558 bm = adj->crtc_vsync_start - adj->crtc_vdisplay;
559 tm = adj->crtc_vtotal - adj->crtc_vsync_end;
561 DRM_DEBUG_DRIVER("H: %d %d %d %d lm %d rm %d\n",
563 adj->crtc_hsync_start,
565 adj->crtc_htotal, lm, rm);
566 DRM_DEBUG_DRIVER("V: %d %d %d %d tm %d bm %d\n",
568 adj->crtc_vsync_start,
570 adj->crtc_vtotal, tm, bm);
573 * If we are blanked, we would have disabled the clock. Re-enable
574 * it so that compute_clock() does the right thing.
576 if (!IS_ERR(dcrtc->clk) && dpms_blanked(dcrtc->dpms))
577 WARN_ON(clk_prepare_enable(dcrtc->clk));
579 /* Now compute the divider for real */
580 dcrtc->variant->compute_clock(dcrtc, adj, &sclk);
582 armada_reg_queue_set(regs, i, sclk, LCD_CFG_SCLK_DIV);
584 if (interlaced ^ dcrtc->interlaced) {
585 if (adj->flags & DRM_MODE_FLAG_INTERLACE)
586 drm_crtc_vblank_get(&dcrtc->crtc);
588 drm_crtc_vblank_put(&dcrtc->crtc);
589 dcrtc->interlaced = interlaced;
592 spin_lock_irqsave(&dcrtc->irq_lock, flags);
594 /* Even interlaced/progressive frame */
595 dcrtc->v[1].spu_v_h_total = adj->crtc_vtotal << 16 |
597 dcrtc->v[1].spu_v_porch = tm << 16 | bm;
598 val = adj->crtc_hsync_start;
599 dcrtc->v[1].spu_adv_reg = val << 20 | val | ADV_VSYNCOFFEN |
600 dcrtc->variant->spu_adv_reg;
603 /* Odd interlaced frame */
604 dcrtc->v[0].spu_v_h_total = dcrtc->v[1].spu_v_h_total +
606 dcrtc->v[0].spu_v_porch = dcrtc->v[1].spu_v_porch + 1;
607 val = adj->crtc_hsync_start - adj->crtc_htotal / 2;
608 dcrtc->v[0].spu_adv_reg = val << 20 | val | ADV_VSYNCOFFEN |
609 dcrtc->variant->spu_adv_reg;
611 dcrtc->v[0] = dcrtc->v[1];
614 val = adj->crtc_vdisplay << 16 | adj->crtc_hdisplay;
616 armada_reg_queue_set(regs, i, val, LCD_SPU_V_H_ACTIVE);
617 armada_reg_queue_set(regs, i, (lm << 16) | rm, LCD_SPU_H_PORCH);
618 armada_reg_queue_set(regs, i, dcrtc->v[0].spu_v_porch, LCD_SPU_V_PORCH);
619 armada_reg_queue_set(regs, i, dcrtc->v[0].spu_v_h_total,
622 if (dcrtc->variant->has_spu_adv_reg) {
623 armada_reg_queue_mod(regs, i, dcrtc->v[0].spu_adv_reg,
624 ADV_VSYNC_L_OFF | ADV_VSYNC_H_OFF |
625 ADV_VSYNCOFFEN, LCD_SPU_ADV_REG);
628 val = adj->flags & DRM_MODE_FLAG_NVSYNC ? CFG_VSYNC_INV : 0;
629 armada_reg_queue_mod(regs, i, val, CFG_VSYNC_INV, LCD_SPU_DMA_CTRL1);
631 val = dcrtc->spu_iopad_ctrl | armada_drm_crtc_calculate_csc(dcrtc);
632 armada_reg_queue_set(regs, i, val, LCD_SPU_IOPAD_CONTROL);
633 armada_reg_queue_end(regs, i);
635 armada_drm_crtc_update_regs(dcrtc, regs);
636 spin_unlock_irqrestore(&dcrtc->irq_lock, flags);
639 /* The mode_config.mutex will be held for this call */
640 static void armada_drm_crtc_disable(struct drm_crtc *crtc)
642 armada_drm_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
644 /* Disable our primary plane when we disable the CRTC. */
645 crtc->primary->funcs->disable_plane(crtc->primary, NULL);
648 static void armada_drm_crtc_atomic_begin(struct drm_crtc *crtc,
649 struct drm_crtc_state *old_crtc_state)
651 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
652 struct armada_plane *dplane;
654 DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name);
656 /* Wait 100ms for any plane works to complete */
657 dplane = drm_to_armada_plane(crtc->primary);
658 if (WARN_ON(armada_drm_plane_work_wait(dplane, HZ / 10) == 0))
659 armada_drm_plane_work_cancel(dcrtc, dplane);
662 dcrtc->regs = dcrtc->atomic_regs;
665 static void armada_drm_crtc_atomic_flush(struct drm_crtc *crtc,
666 struct drm_crtc_state *old_crtc_state)
668 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
671 DRM_DEBUG_KMS("[CRTC:%d:%s]\n", crtc->base.id, crtc->name);
673 armada_reg_queue_end(dcrtc->regs, dcrtc->regs_idx);
675 spin_lock_irqsave(&dcrtc->irq_lock, flags);
676 armada_drm_crtc_update_regs(dcrtc, dcrtc->regs);
677 spin_unlock_irqrestore(&dcrtc->irq_lock, flags);
680 static const struct drm_crtc_helper_funcs armada_crtc_helper_funcs = {
681 .dpms = armada_drm_crtc_dpms,
682 .prepare = armada_drm_crtc_prepare,
683 .commit = armada_drm_crtc_commit,
684 .mode_fixup = armada_drm_crtc_mode_fixup,
685 .mode_set = drm_helper_crtc_mode_set,
686 .mode_set_nofb = armada_drm_crtc_mode_set_nofb,
687 .mode_set_base = drm_helper_crtc_mode_set_base,
688 .disable = armada_drm_crtc_disable,
689 .atomic_begin = armada_drm_crtc_atomic_begin,
690 .atomic_flush = armada_drm_crtc_atomic_flush,
693 static void armada_load_cursor_argb(void __iomem *base, uint32_t *pix,
694 unsigned stride, unsigned width, unsigned height)
699 addr = SRAM_HWC32_RAM1;
700 for (y = 0; y < height; y++) {
701 uint32_t *p = &pix[y * stride];
704 for (x = 0; x < width; x++, p++) {
707 val = (val & 0xff00ff00) |
708 (val & 0x000000ff) << 16 |
709 (val & 0x00ff0000) >> 16;
712 base + LCD_SPU_SRAM_WRDAT);
713 writel_relaxed(addr | SRAM_WRITE,
714 base + LCD_SPU_SRAM_CTRL);
715 readl_relaxed(base + LCD_SPU_HWC_OVSA_HPXL_VLN);
717 if ((addr & 0x00ff) == 0)
719 if ((addr & 0x30ff) == 0)
720 addr = SRAM_HWC32_RAM2;
725 static void armada_drm_crtc_cursor_tran(void __iomem *base)
729 for (addr = 0; addr < 256; addr++) {
730 /* write the default value */
731 writel_relaxed(0x55555555, base + LCD_SPU_SRAM_WRDAT);
732 writel_relaxed(addr | SRAM_WRITE | SRAM_HWC32_TRAN,
733 base + LCD_SPU_SRAM_CTRL);
737 static int armada_drm_crtc_cursor_update(struct armada_crtc *dcrtc, bool reload)
739 uint32_t xoff, xscr, w = dcrtc->cursor_w, s;
740 uint32_t yoff, yscr, h = dcrtc->cursor_h;
744 * Calculate the visible width and height of the cursor,
745 * screen position, and the position in the cursor bitmap.
747 if (dcrtc->cursor_x < 0) {
748 xoff = -dcrtc->cursor_x;
751 } else if (dcrtc->cursor_x + w > dcrtc->crtc.mode.hdisplay) {
753 xscr = dcrtc->cursor_x;
754 w = max_t(int, dcrtc->crtc.mode.hdisplay - dcrtc->cursor_x, 0);
757 xscr = dcrtc->cursor_x;
760 if (dcrtc->cursor_y < 0) {
761 yoff = -dcrtc->cursor_y;
764 } else if (dcrtc->cursor_y + h > dcrtc->crtc.mode.vdisplay) {
766 yscr = dcrtc->cursor_y;
767 h = max_t(int, dcrtc->crtc.mode.vdisplay - dcrtc->cursor_y, 0);
770 yscr = dcrtc->cursor_y;
773 /* On interlaced modes, the vertical cursor size must be halved */
775 if (dcrtc->interlaced) {
781 if (!dcrtc->cursor_obj || !h || !w) {
782 spin_lock_irq(&dcrtc->irq_lock);
783 armada_drm_crtc_disable_irq(dcrtc, DUMB_FRAMEDONE_ENA);
784 dcrtc->cursor_update = false;
785 armada_updatel(0, CFG_HWC_ENA, dcrtc->base + LCD_SPU_DMA_CTRL0);
786 spin_unlock_irq(&dcrtc->irq_lock);
790 spin_lock_irq(&dcrtc->irq_lock);
791 para1 = readl_relaxed(dcrtc->base + LCD_SPU_SRAM_PARA1);
792 armada_updatel(CFG_CSB_256x32, CFG_CSB_256x32 | CFG_PDWN256x32,
793 dcrtc->base + LCD_SPU_SRAM_PARA1);
794 spin_unlock_irq(&dcrtc->irq_lock);
797 * Initialize the transparency if the SRAM was powered down.
798 * We must also reload the cursor data as well.
800 if (!(para1 & CFG_CSB_256x32)) {
801 armada_drm_crtc_cursor_tran(dcrtc->base);
805 if (dcrtc->cursor_hw_sz != (h << 16 | w)) {
806 spin_lock_irq(&dcrtc->irq_lock);
807 armada_drm_crtc_disable_irq(dcrtc, DUMB_FRAMEDONE_ENA);
808 dcrtc->cursor_update = false;
809 armada_updatel(0, CFG_HWC_ENA, dcrtc->base + LCD_SPU_DMA_CTRL0);
810 spin_unlock_irq(&dcrtc->irq_lock);
814 struct armada_gem_object *obj = dcrtc->cursor_obj;
816 /* Set the top-left corner of the cursor image */
818 pix += yoff * s + xoff;
819 armada_load_cursor_argb(dcrtc->base, pix, s, w, h);
822 /* Reload the cursor position, size and enable in the IRQ handler */
823 spin_lock_irq(&dcrtc->irq_lock);
824 dcrtc->cursor_hw_pos = yscr << 16 | xscr;
825 dcrtc->cursor_hw_sz = h << 16 | w;
826 dcrtc->cursor_update = true;
827 armada_drm_crtc_enable_irq(dcrtc, DUMB_FRAMEDONE_ENA);
828 spin_unlock_irq(&dcrtc->irq_lock);
833 static void cursor_update(void *data)
835 armada_drm_crtc_cursor_update(data, true);
838 static int armada_drm_crtc_cursor_set(struct drm_crtc *crtc,
839 struct drm_file *file, uint32_t handle, uint32_t w, uint32_t h)
841 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
842 struct armada_gem_object *obj = NULL;
845 /* If no cursor support, replicate drm's return value */
846 if (!dcrtc->variant->has_spu_adv_reg)
849 if (handle && w > 0 && h > 0) {
850 /* maximum size is 64x32 or 32x64 */
851 if (w > 64 || h > 64 || (w > 32 && h > 32))
854 obj = armada_gem_object_lookup(file, handle);
858 /* Must be a kernel-mapped object */
860 drm_gem_object_put_unlocked(&obj->obj);
864 if (obj->obj.size < w * h * 4) {
865 DRM_ERROR("buffer is too small\n");
866 drm_gem_object_put_unlocked(&obj->obj);
871 if (dcrtc->cursor_obj) {
872 dcrtc->cursor_obj->update = NULL;
873 dcrtc->cursor_obj->update_data = NULL;
874 drm_gem_object_put_unlocked(&dcrtc->cursor_obj->obj);
876 dcrtc->cursor_obj = obj;
879 ret = armada_drm_crtc_cursor_update(dcrtc, true);
881 obj->update_data = dcrtc;
882 obj->update = cursor_update;
888 static int armada_drm_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
890 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
893 /* If no cursor support, replicate drm's return value */
894 if (!dcrtc->variant->has_spu_adv_reg)
899 ret = armada_drm_crtc_cursor_update(dcrtc, false);
904 static void armada_drm_crtc_destroy(struct drm_crtc *crtc)
906 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
907 struct armada_private *priv = crtc->dev->dev_private;
909 if (dcrtc->cursor_obj)
910 drm_gem_object_put_unlocked(&dcrtc->cursor_obj->obj);
912 priv->dcrtc[dcrtc->num] = NULL;
913 drm_crtc_cleanup(&dcrtc->crtc);
915 if (!IS_ERR(dcrtc->clk))
916 clk_disable_unprepare(dcrtc->clk);
918 writel_relaxed(0, dcrtc->base + LCD_SPU_IRQ_ENA);
920 of_node_put(dcrtc->crtc.port);
926 * The mode_config lock is held here, to prevent races between this
929 static int armada_drm_crtc_page_flip(struct drm_crtc *crtc,
930 struct drm_framebuffer *fb, struct drm_pending_vblank_event *event,
931 uint32_t page_flip_flags, struct drm_modeset_acquire_ctx *ctx)
933 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
934 struct drm_plane *plane = crtc->primary;
935 const struct drm_plane_helper_funcs *plane_funcs;
936 struct drm_plane_state *state;
937 struct armada_plane_work *work;
940 /* Construct new state for the primary plane */
941 state = drm_atomic_helper_plane_duplicate_state(plane);
945 drm_atomic_set_fb_for_plane(state, fb);
947 work = armada_drm_crtc_alloc_plane_work(plane);
953 /* Make sure we can get vblank interrupts */
954 ret = drm_crtc_vblank_get(crtc);
959 * If we have another work pending, we can't process this flip.
960 * The modeset locks protect us from another user queuing a work
961 * while we're setting up.
963 if (drm_to_armada_plane(plane)->work) {
969 work->old_fb = plane->state->fb;
972 * Hold a ref on the new fb while it's being displayed by the
973 * hardware. The old fb refcount will be released in the worker.
975 drm_framebuffer_get(state->fb);
977 /* Point of no return */
978 swap(plane->state, state);
981 dcrtc->regs = work->regs;
983 plane_funcs = plane->helper_private;
984 plane_funcs->atomic_update(plane, state);
985 armada_reg_queue_end(dcrtc->regs, dcrtc->regs_idx);
987 /* Queue the work - this should never fail */
988 WARN_ON(armada_drm_plane_work_queue(dcrtc, work));
992 * Finally, if the display is blanked, we won't receive an
993 * interrupt, so complete it now.
995 if (dpms_blanked(dcrtc->dpms))
996 armada_drm_plane_work_run(dcrtc, plane);
999 drm_crtc_vblank_put(crtc);
1003 drm_atomic_helper_plane_destroy_state(plane, state);
1008 armada_drm_crtc_set_property(struct drm_crtc *crtc,
1009 struct drm_property *property, uint64_t val)
1011 struct armada_private *priv = crtc->dev->dev_private;
1012 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
1013 bool update_csc = false;
1015 if (property == priv->csc_yuv_prop) {
1016 dcrtc->csc_yuv_mode = val;
1018 } else if (property == priv->csc_rgb_prop) {
1019 dcrtc->csc_rgb_mode = val;
1026 val = dcrtc->spu_iopad_ctrl |
1027 armada_drm_crtc_calculate_csc(dcrtc);
1028 writel_relaxed(val, dcrtc->base + LCD_SPU_IOPAD_CONTROL);
1034 /* These are called under the vbl_lock. */
1035 static int armada_drm_crtc_enable_vblank(struct drm_crtc *crtc)
1037 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
1038 unsigned long flags;
1040 spin_lock_irqsave(&dcrtc->irq_lock, flags);
1041 armada_drm_crtc_enable_irq(dcrtc, VSYNC_IRQ_ENA);
1042 spin_unlock_irqrestore(&dcrtc->irq_lock, flags);
1046 static void armada_drm_crtc_disable_vblank(struct drm_crtc *crtc)
1048 struct armada_crtc *dcrtc = drm_to_armada_crtc(crtc);
1049 unsigned long flags;
1051 spin_lock_irqsave(&dcrtc->irq_lock, flags);
1052 armada_drm_crtc_disable_irq(dcrtc, VSYNC_IRQ_ENA);
1053 spin_unlock_irqrestore(&dcrtc->irq_lock, flags);
1056 static const struct drm_crtc_funcs armada_crtc_funcs = {
1057 .reset = drm_atomic_helper_crtc_reset,
1058 .cursor_set = armada_drm_crtc_cursor_set,
1059 .cursor_move = armada_drm_crtc_cursor_move,
1060 .destroy = armada_drm_crtc_destroy,
1061 .set_config = drm_crtc_helper_set_config,
1062 .page_flip = armada_drm_crtc_page_flip,
1063 .set_property = armada_drm_crtc_set_property,
1064 .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
1065 .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
1066 .enable_vblank = armada_drm_crtc_enable_vblank,
1067 .disable_vblank = armada_drm_crtc_disable_vblank,
1070 int armada_drm_plane_prepare_fb(struct drm_plane *plane,
1071 struct drm_plane_state *state)
1073 DRM_DEBUG_KMS("[PLANE:%d:%s] [FB:%d]\n",
1074 plane->base.id, plane->name,
1075 state->fb ? state->fb->base.id : 0);
1078 * Take a reference on the new framebuffer - we want to
1079 * hold on to it while the hardware is displaying it.
1082 drm_framebuffer_get(state->fb);
1086 void armada_drm_plane_cleanup_fb(struct drm_plane *plane,
1087 struct drm_plane_state *old_state)
1089 DRM_DEBUG_KMS("[PLANE:%d:%s] [FB:%d]\n",
1090 plane->base.id, plane->name,
1091 old_state->fb ? old_state->fb->base.id : 0);
1094 drm_framebuffer_put(old_state->fb);
1097 int armada_drm_plane_atomic_check(struct drm_plane *plane,
1098 struct drm_plane_state *state)
1100 if (state->fb && !WARN_ON(!state->crtc)) {
1101 struct drm_crtc *crtc = state->crtc;
1102 struct drm_crtc_state crtc_state = {
1104 .enable = crtc->enabled,
1108 return drm_atomic_helper_check_plane_state(state, &crtc_state,
1112 state->visible = false;
1117 static unsigned int armada_drm_primary_update_state(
1118 struct drm_plane_state *state, struct armada_regs *regs)
1120 struct armada_plane *dplane = drm_to_armada_plane(state->plane);
1121 struct armada_crtc *dcrtc = drm_to_armada_crtc(state->crtc);
1122 struct armada_framebuffer *dfb = drm_fb_to_armada_fb(state->fb);
1124 unsigned int idx = 0;
1127 val = CFG_GRA_FMT(dfb->fmt) | CFG_GRA_MOD(dfb->mod);
1128 if (dfb->fmt > CFG_420)
1129 val |= CFG_PALETTE_ENA;
1132 if (drm_rect_width(&state->src) >> 16 != drm_rect_width(&state->dst))
1133 val |= CFG_GRA_HSMOOTH;
1134 if (dcrtc->interlaced)
1135 val |= CFG_GRA_FTOGGLE;
1137 was_disabled = !(dplane->state.ctrl0 & CFG_GRA_ENA);
1139 armada_reg_queue_mod(regs, idx,
1140 0, CFG_PDWN64x66, LCD_SPU_SRAM_PARA1);
1142 dplane->state.ctrl0 = val;
1143 dplane->state.src_hw = armada_rect_hw_fp(&state->src);
1144 dplane->state.dst_hw = armada_rect_hw(&state->dst);
1145 dplane->state.dst_yx = armada_rect_yx(&state->dst);
1147 idx += armada_drm_crtc_calc_fb(&dfb->fb, state->src.x1 >> 16,
1148 state->src.y1 >> 16, regs + idx,
1150 armada_reg_queue_set(regs, idx, dplane->state.dst_yx,
1151 LCD_SPU_GRA_OVSA_HPXL_VLN);
1152 armada_reg_queue_set(regs, idx, dplane->state.src_hw,
1153 LCD_SPU_GRA_HPXL_VLN);
1154 armada_reg_queue_set(regs, idx, dplane->state.dst_hw,
1155 LCD_SPU_GZM_HPXL_VLN);
1156 armada_reg_queue_mod(regs, idx, dplane->state.ctrl0, CFG_GRAFORMAT |
1157 CFG_GRA_MOD(CFG_SWAPRB | CFG_SWAPUV |
1158 CFG_SWAPYU | CFG_YUV2RGB) |
1159 CFG_PALETTE_ENA | CFG_GRA_FTOGGLE |
1160 CFG_GRA_HSMOOTH | CFG_GRA_ENA,
1163 dplane->state.vsync_update = !was_disabled;
1164 dplane->state.changed = true;
1169 static void armada_drm_primary_plane_atomic_update(struct drm_plane *plane,
1170 struct drm_plane_state *old_state)
1172 struct drm_plane_state *state = plane->state;
1173 struct armada_crtc *dcrtc;
1174 struct armada_regs *regs;
1176 DRM_DEBUG_KMS("[PLANE:%d:%s]\n", plane->base.id, plane->name);
1178 if (!state->fb || WARN_ON(!state->crtc))
1181 DRM_DEBUG_KMS("[PLANE:%d:%s] is on [CRTC:%d:%s] with [FB:%d] visible %u->%u\n",
1182 plane->base.id, plane->name,
1183 state->crtc->base.id, state->crtc->name,
1185 old_state->visible, state->visible);
1187 dcrtc = drm_to_armada_crtc(state->crtc);
1188 regs = dcrtc->regs + dcrtc->regs_idx;
1190 dcrtc->regs_idx += armada_drm_primary_update_state(state, regs);
1193 static void armada_drm_primary_plane_atomic_disable(struct drm_plane *plane,
1194 struct drm_plane_state *old_state)
1196 struct armada_plane *dplane = drm_to_armada_plane(plane);
1197 struct armada_crtc *dcrtc;
1198 struct armada_regs *regs;
1199 unsigned int idx = 0;
1201 DRM_DEBUG_KMS("[PLANE:%d:%s]\n", plane->base.id, plane->name);
1203 if (!old_state->crtc)
1206 DRM_DEBUG_KMS("[PLANE:%d:%s] was on [CRTC:%d:%s] with [FB:%d]\n",
1207 plane->base.id, plane->name,
1208 old_state->crtc->base.id, old_state->crtc->name,
1209 old_state->fb->base.id);
1211 dplane->state.ctrl0 &= ~CFG_GRA_ENA;
1213 dcrtc = drm_to_armada_crtc(old_state->crtc);
1214 regs = dcrtc->regs + dcrtc->regs_idx;
1216 /* Disable plane and power down most RAMs and FIFOs */
1217 armada_reg_queue_mod(regs, idx, 0, CFG_GRA_ENA, LCD_SPU_DMA_CTRL0);
1218 armada_reg_queue_mod(regs, idx, CFG_PDWN256x32 | CFG_PDWN256x24 |
1219 CFG_PDWN256x8 | CFG_PDWN32x32 | CFG_PDWN64x66,
1220 0, LCD_SPU_SRAM_PARA1);
1222 dcrtc->regs_idx += idx;
1225 static const struct drm_plane_helper_funcs armada_primary_plane_helper_funcs = {
1226 .prepare_fb = armada_drm_plane_prepare_fb,
1227 .cleanup_fb = armada_drm_plane_cleanup_fb,
1228 .atomic_check = armada_drm_plane_atomic_check,
1229 .atomic_update = armada_drm_primary_plane_atomic_update,
1230 .atomic_disable = armada_drm_primary_plane_atomic_disable,
1233 static const struct drm_plane_funcs armada_primary_plane_funcs = {
1234 .update_plane = drm_plane_helper_update,
1235 .disable_plane = drm_plane_helper_disable,
1236 .destroy = drm_primary_helper_destroy,
1237 .reset = drm_atomic_helper_plane_reset,
1238 .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
1239 .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
1242 int armada_drm_plane_init(struct armada_plane *plane)
1246 for (i = 0; i < ARRAY_SIZE(plane->works); i++)
1247 plane->works[i].plane = &plane->base;
1249 init_waitqueue_head(&plane->frame_wait);
1254 static const struct drm_prop_enum_list armada_drm_csc_yuv_enum_list[] = {
1255 { CSC_AUTO, "Auto" },
1256 { CSC_YUV_CCIR601, "CCIR601" },
1257 { CSC_YUV_CCIR709, "CCIR709" },
1260 static const struct drm_prop_enum_list armada_drm_csc_rgb_enum_list[] = {
1261 { CSC_AUTO, "Auto" },
1262 { CSC_RGB_COMPUTER, "Computer system" },
1263 { CSC_RGB_STUDIO, "Studio" },
1266 static int armada_drm_crtc_create_properties(struct drm_device *dev)
1268 struct armada_private *priv = dev->dev_private;
1270 if (priv->csc_yuv_prop)
1273 priv->csc_yuv_prop = drm_property_create_enum(dev, 0,
1274 "CSC_YUV", armada_drm_csc_yuv_enum_list,
1275 ARRAY_SIZE(armada_drm_csc_yuv_enum_list));
1276 priv->csc_rgb_prop = drm_property_create_enum(dev, 0,
1277 "CSC_RGB", armada_drm_csc_rgb_enum_list,
1278 ARRAY_SIZE(armada_drm_csc_rgb_enum_list));
1280 if (!priv->csc_yuv_prop || !priv->csc_rgb_prop)
1286 static int armada_drm_crtc_create(struct drm_device *drm, struct device *dev,
1287 struct resource *res, int irq, const struct armada_variant *variant,
1288 struct device_node *port)
1290 struct armada_private *priv = drm->dev_private;
1291 struct armada_crtc *dcrtc;
1292 struct armada_plane *primary;
1296 ret = armada_drm_crtc_create_properties(drm);
1300 base = devm_ioremap_resource(dev, res);
1302 return PTR_ERR(base);
1304 dcrtc = kzalloc(sizeof(*dcrtc), GFP_KERNEL);
1306 DRM_ERROR("failed to allocate Armada crtc\n");
1310 if (dev != drm->dev)
1311 dev_set_drvdata(dev, dcrtc);
1313 dcrtc->variant = variant;
1315 dcrtc->num = drm->mode_config.num_crtc;
1316 dcrtc->clk = ERR_PTR(-EINVAL);
1317 dcrtc->csc_yuv_mode = CSC_AUTO;
1318 dcrtc->csc_rgb_mode = CSC_AUTO;
1319 dcrtc->cfg_dumb_ctrl = DUMB24_RGB888_0;
1320 dcrtc->spu_iopad_ctrl = CFG_VSCALE_LN_EN | CFG_IOPAD_DUMB24;
1321 spin_lock_init(&dcrtc->irq_lock);
1322 dcrtc->irq_ena = CLEAN_SPU_IRQ_ISR;
1324 /* Initialize some registers which we don't otherwise set */
1325 writel_relaxed(0x00000001, dcrtc->base + LCD_CFG_SCLK_DIV);
1326 writel_relaxed(0x00000000, dcrtc->base + LCD_SPU_BLANKCOLOR);
1327 writel_relaxed(dcrtc->spu_iopad_ctrl,
1328 dcrtc->base + LCD_SPU_IOPAD_CONTROL);
1329 writel_relaxed(0x00000000, dcrtc->base + LCD_SPU_SRAM_PARA0);
1330 writel_relaxed(CFG_PDWN256x32 | CFG_PDWN256x24 | CFG_PDWN256x8 |
1331 CFG_PDWN32x32 | CFG_PDWN16x66 | CFG_PDWN32x66 |
1332 CFG_PDWN64x66, dcrtc->base + LCD_SPU_SRAM_PARA1);
1333 writel_relaxed(0x2032ff81, dcrtc->base + LCD_SPU_DMA_CTRL1);
1334 writel_relaxed(dcrtc->irq_ena, dcrtc->base + LCD_SPU_IRQ_ENA);
1335 readl_relaxed(dcrtc->base + LCD_SPU_IRQ_ISR);
1336 writel_relaxed(0, dcrtc->base + LCD_SPU_IRQ_ISR);
1338 ret = devm_request_irq(dev, irq, armada_drm_irq, 0, "armada_drm_crtc",
1343 if (dcrtc->variant->init) {
1344 ret = dcrtc->variant->init(dcrtc, dev);
1349 /* Ensure AXI pipeline is enabled */
1350 armada_updatel(CFG_ARBFAST_ENA, 0, dcrtc->base + LCD_SPU_DMA_CTRL0);
1352 priv->dcrtc[dcrtc->num] = dcrtc;
1354 dcrtc->crtc.port = port;
1356 primary = kzalloc(sizeof(*primary), GFP_KERNEL);
1362 ret = armada_drm_plane_init(primary);
1368 drm_plane_helper_add(&primary->base,
1369 &armada_primary_plane_helper_funcs);
1371 ret = drm_universal_plane_init(drm, &primary->base, 0,
1372 &armada_primary_plane_funcs,
1373 armada_primary_formats,
1374 ARRAY_SIZE(armada_primary_formats),
1376 DRM_PLANE_TYPE_PRIMARY, NULL);
1382 ret = drm_crtc_init_with_planes(drm, &dcrtc->crtc, &primary->base, NULL,
1383 &armada_crtc_funcs, NULL);
1387 drm_crtc_helper_add(&dcrtc->crtc, &armada_crtc_helper_funcs);
1389 drm_object_attach_property(&dcrtc->crtc.base, priv->csc_yuv_prop,
1390 dcrtc->csc_yuv_mode);
1391 drm_object_attach_property(&dcrtc->crtc.base, priv->csc_rgb_prop,
1392 dcrtc->csc_rgb_mode);
1394 return armada_overlay_plane_create(drm, 1 << dcrtc->num);
1397 primary->base.funcs->destroy(&primary->base);
1405 armada_lcd_bind(struct device *dev, struct device *master, void *data)
1407 struct platform_device *pdev = to_platform_device(dev);
1408 struct drm_device *drm = data;
1409 struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
1410 int irq = platform_get_irq(pdev, 0);
1411 const struct armada_variant *variant;
1412 struct device_node *port = NULL;
1417 if (!dev->of_node) {
1418 const struct platform_device_id *id;
1420 id = platform_get_device_id(pdev);
1424 variant = (const struct armada_variant *)id->driver_data;
1426 const struct of_device_id *match;
1427 struct device_node *np, *parent = dev->of_node;
1429 match = of_match_device(dev->driver->of_match_table, dev);
1433 np = of_get_child_by_name(parent, "ports");
1436 port = of_get_child_by_name(parent, "port");
1439 dev_err(dev, "no port node found in %pOF\n", parent);
1443 variant = match->data;
1446 return armada_drm_crtc_create(drm, dev, res, irq, variant, port);
1450 armada_lcd_unbind(struct device *dev, struct device *master, void *data)
1452 struct armada_crtc *dcrtc = dev_get_drvdata(dev);
1454 armada_drm_crtc_destroy(&dcrtc->crtc);
1457 static const struct component_ops armada_lcd_ops = {
1458 .bind = armada_lcd_bind,
1459 .unbind = armada_lcd_unbind,
1462 static int armada_lcd_probe(struct platform_device *pdev)
1464 return component_add(&pdev->dev, &armada_lcd_ops);
1467 static int armada_lcd_remove(struct platform_device *pdev)
1469 component_del(&pdev->dev, &armada_lcd_ops);
1473 static const struct of_device_id armada_lcd_of_match[] = {
1475 .compatible = "marvell,dove-lcd",
1476 .data = &armada510_ops,
1480 MODULE_DEVICE_TABLE(of, armada_lcd_of_match);
1482 static const struct platform_device_id armada_lcd_platform_ids[] = {
1484 .name = "armada-lcd",
1485 .driver_data = (unsigned long)&armada510_ops,
1487 .name = "armada-510-lcd",
1488 .driver_data = (unsigned long)&armada510_ops,
1492 MODULE_DEVICE_TABLE(platform, armada_lcd_platform_ids);
1494 struct platform_driver armada_lcd_platform_driver = {
1495 .probe = armada_lcd_probe,
1496 .remove = armada_lcd_remove,
1498 .name = "armada-lcd",
1499 .owner = THIS_MODULE,
1500 .of_match_table = armada_lcd_of_match,
1502 .id_table = armada_lcd_platform_ids,