src/intel/vulkan/gen8_cmd_buffer.c

   1 /*
   2  * Copyright © 2015 Intel Corporation
   3  *
   4  * Permission is hereby granted, free of charge, to any person obtaining a
   5  * copy of this software and associated documentation files (the "Software"),
   6  * to deal in the Software without restriction, including without limitation
   7  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   8  * and/or sell copies of the Software, and to permit persons to whom the
   9  * Software is furnished to do so, subject to the following conditions:
  10  *
  11  * The above copyright notice and this permission notice (including the next
  12  * paragraph) shall be included in all copies or substantial portions of the
  13  * Software.
  14  *
  15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  18  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  19  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  20  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
  21  * IN THE SOFTWARE.
  22  */
  23
  24 #include <assert.h>
  25 #include <stdbool.h>
  26 #include <string.h>
  27 #include <unistd.h>
  28 #include <fcntl.h>
  29
  30 #include "anv_private.h"
  31
  32 #include "genxml/gen_macros.h"
  33 #include "genxml/genX_pack.h"
  34
  35 #if GEN_GEN == 8
  36 void
  37 gen8_cmd_buffer_emit_viewport(struct anv_cmd_buffer *cmd_buffer)
  38 {
  39    uint32_t count = cmd_buffer->state.dynamic.viewport.count;
  40    const VkViewport *viewports = cmd_buffer->state.dynamic.viewport.viewports;
  41    struct anv_state sf_clip_state =
  42       anv_cmd_buffer_alloc_dynamic_state(cmd_buffer, count * 64, 64);
  43    struct anv_state cc_state =
  44       anv_cmd_buffer_alloc_dynamic_state(cmd_buffer, count * 8, 32);
  45
  46    for (uint32_t i = 0; i < count; i++) {
  47       const VkViewport *vp = &viewports[i];
  48
  49       /* The gen7 state struct has just the matrix and guardband fields, the
  50        * gen8 struct adds the min/max viewport fields. */
  51       struct GENX(SF_CLIP_VIEWPORT) sf_clip_viewport = {
  52          .ViewportMatrixElementm00 = vp->width / 2,
  53          .ViewportMatrixElementm11 = vp->height / 2,
  54          .ViewportMatrixElementm22 = 1.0,
  55          .ViewportMatrixElementm30 = vp->x + vp->width / 2,
  56          .ViewportMatrixElementm31 = vp->y + vp->height / 2,
  57          .ViewportMatrixElementm32 = 0.0,
  58          .XMinClipGuardband = -1.0f,
  59          .XMaxClipGuardband = 1.0f,
  60          .YMinClipGuardband = -1.0f,
  61          .YMaxClipGuardband = 1.0f,
  62          .XMinViewPort = vp->x,
  63          .XMaxViewPort = vp->x + vp->width - 1,
  64          .YMinViewPort = vp->y,
  65          .YMaxViewPort = vp->y + vp->height - 1,
  66       };
  67
  68       struct GENX(CC_VIEWPORT) cc_viewport = {
  69          .MinimumDepth = vp->minDepth,
  70          .MaximumDepth = vp->maxDepth
  71       };
  72
  73       GENX(SF_CLIP_VIEWPORT_pack)(NULL, sf_clip_state.map + i * 64,
  74                                  &sf_clip_viewport);
  75       GENX(CC_VIEWPORT_pack)(NULL, cc_state.map + i * 8, &cc_viewport);
  76    }
  77
  78    if (!cmd_buffer->device->info.has_llc) {
  79       anv_state_clflush(sf_clip_state);
  80       anv_state_clflush(cc_state);
  81    }
  82
  83    anv_batch_emit(&cmd_buffer->batch,
  84                   GENX(3DSTATE_VIEWPORT_STATE_POINTERS_CC), cc) {
  85       cc.CCViewportPointer = cc_state.offset;
  86    }
  87    anv_batch_emit(&cmd_buffer->batch,
  88                   GENX(3DSTATE_VIEWPORT_STATE_POINTERS_SF_CLIP), clip) {
  89       clip.SFClipViewportPointer = sf_clip_state.offset;
  90    }
  91 }
  92 #endif
  93
  94 static void
  95 __emit_genx_sf_state(struct anv_cmd_buffer *cmd_buffer)
  96 {
  97       uint32_t sf_dw[GENX(3DSTATE_SF_length)];
  98       struct GENX(3DSTATE_SF) sf = {
  99          GENX(3DSTATE_SF_header),
 100          .LineWidth = cmd_buffer->state.dynamic.line_width,
 101       };
 102       GENX(3DSTATE_SF_pack)(NULL, sf_dw, &sf);
 103       /* FIXME: gen9.fs */
 104       anv_batch_emit_merge(&cmd_buffer->batch, sf_dw,
 105                            cmd_buffer->state.pipeline->gen8.sf);
 106 }
 107
 108 #include "genxml/gen9_pack.h"
 109 static void
 110 __emit_gen9_sf_state(struct anv_cmd_buffer *cmd_buffer)
 111 {
 112       uint32_t sf_dw[GENX(3DSTATE_SF_length)];
 113       struct GEN9_3DSTATE_SF sf = {
 114          GEN9_3DSTATE_SF_header,
 115          .LineWidth = cmd_buffer->state.dynamic.line_width,
 116       };
 117       GEN9_3DSTATE_SF_pack(NULL, sf_dw, &sf);
 118       /* FIXME: gen9.fs */
 119       anv_batch_emit_merge(&cmd_buffer->batch, sf_dw,
 120                            cmd_buffer->state.pipeline->gen8.sf);
 121 }
 122
 123 static void
 124 __emit_sf_state(struct anv_cmd_buffer *cmd_buffer)
 125 {
 126    if (cmd_buffer->device->info.is_cherryview)
 127       __emit_gen9_sf_state(cmd_buffer);
 128    else
 129       __emit_genx_sf_state(cmd_buffer);
 130 }
 131
 132 void
 133 genX(cmd_buffer_flush_dynamic_state)(struct anv_cmd_buffer *cmd_buffer)
 134 {
 135    struct anv_pipeline *pipeline = cmd_buffer->state.pipeline;
 136
 137    if (cmd_buffer->state.dirty & (ANV_CMD_DIRTY_PIPELINE |
 138                                   ANV_CMD_DIRTY_DYNAMIC_LINE_WIDTH)) {
 139       __emit_sf_state(cmd_buffer);
 140    }
 141
 142    if (cmd_buffer->state.dirty & (ANV_CMD_DIRTY_PIPELINE |
 143                                   ANV_CMD_DIRTY_DYNAMIC_DEPTH_BIAS)){
 144       uint32_t raster_dw[GENX(3DSTATE_RASTER_length)];
 145       struct GENX(3DSTATE_RASTER) raster = {
 146          GENX(3DSTATE_RASTER_header),
 147          .GlobalDepthOffsetConstant = cmd_buffer->state.dynamic.depth_bias.bias,
 148          .GlobalDepthOffsetScale = cmd_buffer->state.dynamic.depth_bias.slope,
 149          .GlobalDepthOffsetClamp = cmd_buffer->state.dynamic.depth_bias.clamp
 150       };
 151       GENX(3DSTATE_RASTER_pack)(NULL, raster_dw, &raster);
 152       anv_batch_emit_merge(&cmd_buffer->batch, raster_dw,
 153                            pipeline->gen8.raster);
 154    }
 155
 156    /* Stencil reference values moved from COLOR_CALC_STATE in gen8 to
 157     * 3DSTATE_WM_DEPTH_STENCIL in gen9. That means the dirty bits gets split
 158     * across different state packets for gen8 and gen9. We handle that by
 159     * using a big old #if switch here.
 160     */
 161 #if GEN_GEN == 8
 162    if (cmd_buffer->state.dirty & (ANV_CMD_DIRTY_DYNAMIC_BLEND_CONSTANTS |
 163                                   ANV_CMD_DIRTY_DYNAMIC_STENCIL_REFERENCE)) {
 164       struct anv_dynamic_state *d = &cmd_buffer->state.dynamic;
 165       struct anv_state cc_state =
 166          anv_cmd_buffer_alloc_dynamic_state(cmd_buffer,
 167                                             GENX(COLOR_CALC_STATE_length) * 4,
 168                                             64);
 169       struct GENX(COLOR_CALC_STATE) cc = {
 170          .BlendConstantColorRed = cmd_buffer->state.dynamic.blend_constants[0],
 171          .BlendConstantColorGreen = cmd_buffer->state.dynamic.blend_constants[1],
 172          .BlendConstantColorBlue = cmd_buffer->state.dynamic.blend_constants[2],
 173          .BlendConstantColorAlpha = cmd_buffer->state.dynamic.blend_constants[3],
 174          .StencilReferenceValue = d->stencil_reference.front & 0xff,
 175          .BackFaceStencilReferenceValue = d->stencil_reference.back & 0xff,
 176       };
 177       GENX(COLOR_CALC_STATE_pack)(NULL, cc_state.map, &cc);
 178
 179       if (!cmd_buffer->device->info.has_llc)
 180          anv_state_clflush(cc_state);
 181
 182       anv_batch_emit(&cmd_buffer->batch, GENX(3DSTATE_CC_STATE_POINTERS), ccp) {
 183          ccp.ColorCalcStatePointer        = cc_state.offset;
 184          ccp.ColorCalcStatePointerValid   = true;
 185       }
 186    }
 187
 188    if (cmd_buffer->state.dirty & (ANV_CMD_DIRTY_PIPELINE |
 189                                   ANV_CMD_DIRTY_DYNAMIC_STENCIL_COMPARE_MASK |
 190                                   ANV_CMD_DIRTY_DYNAMIC_STENCIL_WRITE_MASK)) {
 191       uint32_t wm_depth_stencil_dw[GENX(3DSTATE_WM_DEPTH_STENCIL_length)];
 192       struct anv_dynamic_state *d = &cmd_buffer->state.dynamic;
 193
 194       struct GENX(3DSTATE_WM_DEPTH_STENCIL wm_depth_stencil) = {
 195          GENX(3DSTATE_WM_DEPTH_STENCIL_header),
 196
 197          .StencilTestMask = d->stencil_compare_mask.front & 0xff,
 198          .StencilWriteMask = d->stencil_write_mask.front & 0xff,
 199
 200          .BackfaceStencilTestMask = d->stencil_compare_mask.back & 0xff,
 201          .BackfaceStencilWriteMask = d->stencil_write_mask.back & 0xff,
 202       };
 203       GENX(3DSTATE_WM_DEPTH_STENCIL_pack)(NULL, wm_depth_stencil_dw,
 204                                           &wm_depth_stencil);
 205
 206       anv_batch_emit_merge(&cmd_buffer->batch, wm_depth_stencil_dw,
 207                            pipeline->gen8.wm_depth_stencil);
 208    }
 209 #else
 210    if (cmd_buffer->state.dirty & ANV_CMD_DIRTY_DYNAMIC_BLEND_CONSTANTS) {
 211       struct anv_state cc_state =
 212          anv_cmd_buffer_alloc_dynamic_state(cmd_buffer,
 213                                             GEN9_COLOR_CALC_STATE_length * 4,
 214                                             64);
 215       struct GEN9_COLOR_CALC_STATE cc = {
 216          .BlendConstantColorRed = cmd_buffer->state.dynamic.blend_constants[0],
 217          .BlendConstantColorGreen = cmd_buffer->state.dynamic.blend_constants[1],
 218          .BlendConstantColorBlue = cmd_buffer->state.dynamic.blend_constants[2],
 219          .BlendConstantColorAlpha = cmd_buffer->state.dynamic.blend_constants[3],
 220       };
 221       GEN9_COLOR_CALC_STATE_pack(NULL, cc_state.map, &cc);
 222
 223       if (!cmd_buffer->device->info.has_llc)
 224          anv_state_clflush(cc_state);
 225
 226       anv_batch_emit(&cmd_buffer->batch, GEN9_3DSTATE_CC_STATE_POINTERS, ccp) {
 227          ccp.ColorCalcStatePointer = cc_state.offset;
 228          ccp.ColorCalcStatePointerValid = true;
 229       }
 230    }
 231
 232    if (cmd_buffer->state.dirty & (ANV_CMD_DIRTY_PIPELINE |
 233                                   ANV_CMD_DIRTY_DYNAMIC_STENCIL_COMPARE_MASK |
 234                                   ANV_CMD_DIRTY_DYNAMIC_STENCIL_WRITE_MASK |
 235                                   ANV_CMD_DIRTY_DYNAMIC_STENCIL_REFERENCE)) {
 236       uint32_t dwords[GEN9_3DSTATE_WM_DEPTH_STENCIL_length];
 237       struct anv_dynamic_state *d = &cmd_buffer->state.dynamic;
 238       struct GEN9_3DSTATE_WM_DEPTH_STENCIL wm_depth_stencil = {
 239          GEN9_3DSTATE_WM_DEPTH_STENCIL_header,
 240
 241          .StencilTestMask = d->stencil_compare_mask.front & 0xff,
 242          .StencilWriteMask = d->stencil_write_mask.front & 0xff,
 243
 244          .BackfaceStencilTestMask = d->stencil_compare_mask.back & 0xff,
 245          .BackfaceStencilWriteMask = d->stencil_write_mask.back & 0xff,
 246
 247          .StencilReferenceValue = d->stencil_reference.front & 0xff,
 248          .BackfaceStencilReferenceValue = d->stencil_reference.back & 0xff,
 249       };
 250       GEN9_3DSTATE_WM_DEPTH_STENCIL_pack(NULL, dwords, &wm_depth_stencil);
 251
 252       anv_batch_emit_merge(&cmd_buffer->batch, dwords,
 253                            pipeline->gen9.wm_depth_stencil);
 254    }
 255 #endif
 256
 257    if (cmd_buffer->state.dirty & (ANV_CMD_DIRTY_PIPELINE |
 258                                   ANV_CMD_DIRTY_INDEX_BUFFER)) {
 259       anv_batch_emit(&cmd_buffer->batch, GENX(3DSTATE_VF), vf) {
 260          vf.IndexedDrawCutIndexEnable  = pipeline->primitive_restart;
 261          vf.CutIndex                   = cmd_buffer->state.restart_index;
 262       }
 263    }
 264
 265    cmd_buffer->state.dirty = 0;
 266 }
 267
 268 void genX(CmdBindIndexBuffer)(
 269     VkCommandBuffer                             commandBuffer,
 270     VkBuffer                                    _buffer,
 271     VkDeviceSize                                offset,
 272     VkIndexType                                 indexType)
 273 {
 274    ANV_FROM_HANDLE(anv_cmd_buffer, cmd_buffer, commandBuffer);
 275    ANV_FROM_HANDLE(anv_buffer, buffer, _buffer);
 276
 277    static const uint32_t vk_to_gen_index_type[] = {
 278       [VK_INDEX_TYPE_UINT16]                    = INDEX_WORD,
 279       [VK_INDEX_TYPE_UINT32]                    = INDEX_DWORD,
 280    };
 281
 282    static const uint32_t restart_index_for_type[] = {
 283       [VK_INDEX_TYPE_UINT16]                    = UINT16_MAX,
 284       [VK_INDEX_TYPE_UINT32]                    = UINT32_MAX,
 285    };
 286
 287    cmd_buffer->state.restart_index = restart_index_for_type[indexType];
 288
 289    anv_batch_emit(&cmd_buffer->batch, GENX(3DSTATE_INDEX_BUFFER), ib) {
 290       ib.IndexFormat                = vk_to_gen_index_type[indexType];
 291       ib.MemoryObjectControlState   = GENX(MOCS);
 292       ib.BufferStartingAddress      =
 293          (struct anv_address) { buffer->bo, buffer->offset + offset };
 294       ib.BufferSize                 = buffer->size - offset;
 295    }
 296
 297    cmd_buffer->state.dirty |= ANV_CMD_DIRTY_INDEX_BUFFER;
 298 }
 299
 300 static VkResult
 301 flush_compute_descriptor_set(struct anv_cmd_buffer *cmd_buffer)
 302 {
 303    struct anv_device *device = cmd_buffer->device;
 304    struct anv_pipeline *pipeline = cmd_buffer->state.compute_pipeline;
 305    struct anv_state surfaces = { 0, }, samplers = { 0, };
 306    VkResult result;
 307
 308    result = anv_cmd_buffer_emit_samplers(cmd_buffer,
 309                                          MESA_SHADER_COMPUTE, &samplers);
 310    if (result != VK_SUCCESS)
 311       return result;
 312    result = anv_cmd_buffer_emit_binding_table(cmd_buffer,
 313                                               MESA_SHADER_COMPUTE, &surfaces);
 314    if (result != VK_SUCCESS)
 315       return result;
 316
 317    struct anv_state push_state = anv_cmd_buffer_cs_push_constants(cmd_buffer);
 318
 319    const struct brw_cs_prog_data *cs_prog_data = get_cs_prog_data(pipeline);
 320    const struct brw_stage_prog_data *prog_data = &cs_prog_data->base;
 321
 322    unsigned local_id_dwords = cs_prog_data->local_invocation_id_regs * 8;
 323    unsigned push_constant_data_size =
 324       (prog_data->nr_params + local_id_dwords) * 4;
 325    unsigned reg_aligned_constant_size = ALIGN(push_constant_data_size, 32);
 326    unsigned push_constant_regs = reg_aligned_constant_size / 32;
 327
 328    if (push_state.alloc_size) {
 329       anv_batch_emit(&cmd_buffer->batch, GENX(MEDIA_CURBE_LOAD), curbe) {
 330          curbe.CURBETotalDataLength    = push_state.alloc_size;
 331          curbe.CURBEDataStartAddress   = push_state.offset;
 332       }
 333    }
 334
 335    assert(prog_data->total_shared <= 64 * 1024);
 336    uint32_t slm_size = 0;
 337    if (prog_data->total_shared > 0) {
 338       /* slm_size is in 4k increments, but must be a power of 2. */
 339       slm_size = 4 * 1024;
 340       while (slm_size < prog_data->total_shared)
 341          slm_size <<= 1;
 342       slm_size /= 4 * 1024;
 343    }
 344
 345    struct anv_state state =
 346       anv_state_pool_emit(&device->dynamic_state_pool,
 347                           GENX(INTERFACE_DESCRIPTOR_DATA), 64,
 348                           .KernelStartPointer = pipeline->cs_simd,
 349                           .KernelStartPointerHigh = 0,
 350                           .BindingTablePointer = surfaces.offset,
 351                           .BindingTableEntryCount = 0,
 352                           .SamplerStatePointer = samplers.offset,
 353                           .SamplerCount = 0,
 354                           .ConstantIndirectURBEntryReadLength = push_constant_regs,
 355                           .ConstantURBEntryReadOffset = 0,
 356                           .BarrierEnable = cs_prog_data->uses_barrier,
 357                           .SharedLocalMemorySize = slm_size,
 358                           .NumberofThreadsinGPGPUThreadGroup =
 359                              pipeline->cs_thread_width_max);
 360
 361    uint32_t size = GENX(INTERFACE_DESCRIPTOR_DATA_length) * sizeof(uint32_t);
 362    anv_batch_emit(&cmd_buffer->batch,
 363                   GENX(MEDIA_INTERFACE_DESCRIPTOR_LOAD), mid) {
 364       mid.InterfaceDescriptorTotalLength        = size;
 365       mid.InterfaceDescriptorDataStartAddress   = state.offset;
 366    }
 367
 368    return VK_SUCCESS;
 369 }
 370
 371 void
 372 genX(cmd_buffer_flush_compute_state)(struct anv_cmd_buffer *cmd_buffer)
 373 {
 374    struct anv_pipeline *pipeline = cmd_buffer->state.compute_pipeline;
 375    const struct brw_cs_prog_data *cs_prog_data = get_cs_prog_data(pipeline);
 376    MAYBE_UNUSED VkResult result;
 377
 378    assert(pipeline->active_stages == VK_SHADER_STAGE_COMPUTE_BIT);
 379
 380    genX(cmd_buffer_config_l3)(cmd_buffer, pipeline);
 381
 382    genX(flush_pipeline_select_gpgpu)(cmd_buffer);
 383
 384    if (cmd_buffer->state.compute_dirty & ANV_CMD_DIRTY_PIPELINE)
 385       anv_batch_emit_batch(&cmd_buffer->batch, &pipeline->batch);
 386
 387    if ((cmd_buffer->state.descriptors_dirty & VK_SHADER_STAGE_COMPUTE_BIT) ||
 388        (cmd_buffer->state.compute_dirty & ANV_CMD_DIRTY_PIPELINE)) {
 389       result = flush_compute_descriptor_set(cmd_buffer);
 390       assert(result == VK_SUCCESS);
 391       cmd_buffer->state.descriptors_dirty &= ~VK_SHADER_STAGE_COMPUTE_BIT;
 392    }
 393
 394    cmd_buffer->state.compute_dirty = 0;
 395 }
 396
 397 void genX(CmdSetEvent)(
 398     VkCommandBuffer                             commandBuffer,
 399     VkEvent                                     _event,
 400     VkPipelineStageFlags                        stageMask)
 401 {
 402    ANV_FROM_HANDLE(anv_cmd_buffer, cmd_buffer, commandBuffer);
 403    ANV_FROM_HANDLE(anv_event, event, _event);
 404
 405    anv_batch_emit(&cmd_buffer->batch, GENX(PIPE_CONTROL), pc) {
 406       pc.DestinationAddressType  = DAT_PPGTT,
 407       pc.PostSyncOperation       = WriteImmediateData,
 408       pc.Address = (struct anv_address) {
 409          &cmd_buffer->device->dynamic_state_block_pool.bo,
 410          event->state.offset
 411       };
 412       pc.ImmediateData           = VK_EVENT_SET;
 413    }
 414 }
 415
 416 void genX(CmdResetEvent)(
 417     VkCommandBuffer                             commandBuffer,
 418     VkEvent                                     _event,
 419     VkPipelineStageFlags                        stageMask)
 420 {
 421    ANV_FROM_HANDLE(anv_cmd_buffer, cmd_buffer, commandBuffer);
 422    ANV_FROM_HANDLE(anv_event, event, _event);
 423
 424    anv_batch_emit(&cmd_buffer->batch, GENX(PIPE_CONTROL), pc) {
 425       pc.DestinationAddressType  = DAT_PPGTT;
 426       pc.PostSyncOperation       = WriteImmediateData;
 427       pc.Address = (struct anv_address) {
 428          &cmd_buffer->device->dynamic_state_block_pool.bo,
 429          event->state.offset
 430       };
 431       pc.ImmediateData           = VK_EVENT_RESET;
 432    }
 433 }
 434
 435 void genX(CmdWaitEvents)(
 436     VkCommandBuffer                             commandBuffer,
 437     uint32_t                                    eventCount,
 438     const VkEvent*                              pEvents,
 439     VkPipelineStageFlags                        srcStageMask,
 440     VkPipelineStageFlags                        destStageMask,
 441     uint32_t                                    memoryBarrierCount,
 442     const VkMemoryBarrier*                      pMemoryBarriers,
 443     uint32_t                                    bufferMemoryBarrierCount,
 444     const VkBufferMemoryBarrier*                pBufferMemoryBarriers,
 445     uint32_t                                    imageMemoryBarrierCount,
 446     const VkImageMemoryBarrier*                 pImageMemoryBarriers)
 447 {
 448    ANV_FROM_HANDLE(anv_cmd_buffer, cmd_buffer, commandBuffer);
 449    for (uint32_t i = 0; i < eventCount; i++) {
 450       ANV_FROM_HANDLE(anv_event, event, pEvents[i]);
 451
 452       anv_batch_emit(&cmd_buffer->batch, GENX(MI_SEMAPHORE_WAIT), sem) {
 453          sem.WaitMode            = PollingMode,
 454          sem.CompareOperation    = COMPARE_SAD_EQUAL_SDD,
 455          sem.SemaphoreDataDword  = VK_EVENT_SET,
 456          sem.SemaphoreAddress = (struct anv_address) {
 457             &cmd_buffer->device->dynamic_state_block_pool.bo,
 458             event->state.offset
 459          };
 460       }
 461    }
 462
 463    genX(CmdPipelineBarrier)(commandBuffer, srcStageMask, destStageMask,
 464                             false, /* byRegion */
 465                             memoryBarrierCount, pMemoryBarriers,
 466                             bufferMemoryBarrierCount, pBufferMemoryBarriers,
 467                             imageMemoryBarrierCount, pImageMemoryBarriers);
 468 }