8 sys.stderr.write("usage: java-layers.py DEPENDENCY_FILE SOURCE_DIRECTORIES...\n")
10 sys.stderr.write("Enforces layering between java packages. Scans\n")
11 sys.stderr.write("DIRECTORY and prints errors when the packages violate\n")
12 sys.stderr.write("the rules defined in the DEPENDENCY_FILE.\n")
13 sys.stderr.write("\n")
14 sys.stderr.write("Prints a warning when an unknown package is encountered\n")
15 sys.stderr.write("on the assumption that it should fit somewhere into the\n")
16 sys.stderr.write("layering.\n")
17 sys.stderr.write("\n")
18 sys.stderr.write("DEPENDENCY_FILE format\n")
19 sys.stderr.write(" - # starts comment\n")
20 sys.stderr.write(" - Lines consisting of two java package names: The\n")
21 sys.stderr.write(" first package listed must not contain any references\n")
22 sys.stderr.write(" to any classes present in the second package, or any\n")
23 sys.stderr.write(" of its dependencies.\n")
24 sys.stderr.write(" - Lines consisting of one java package name: The\n")
25 sys.stderr.write(" packge is assumed to be a high level package and\n")
26 sys.stderr.write(" nothing may depend on it.\n")
27 sys.stderr.write(" - Lines consisting of a dash (+) followed by one java\n")
28 sys.stderr.write(" package name: The package is considered a low level\n")
29 sys.stderr.write(" package and may not import any of the other packages\n")
30 sys.stderr.write(" listed in the dependency file.\n")
31 sys.stderr.write(" - Lines consisting of a plus (-) followed by one java\n")
32 sys.stderr.write(" package name: The package is considered \'legacy\'\n")
33 sys.stderr.write(" and excluded from errors.\n")
34 sys.stderr.write("\n")
38 def __init__(self, filename, lineno, lower, top, lowlevel, legacy):
39 self.filename = filename
43 self.lowlevel = lowlevel
46 self.transitive = set()
48 def matches(self, imp):
49 for d in self.transitive:
55 def __init__(self, deps):
56 def recurse(obj, dep, visited):
59 sys.stderr.write("%s:%d: Circular dependency found:\n"
60 % (dep.filename, dep.lineno))
62 sys.stderr.write("%s:%d: Dependency: %s\n"
63 % (v.filename, v.lineno, v.lower))
67 for upper in dep.uppers:
68 obj.transitive.add(upper)
70 recurse(obj, deps[upper], visited)
72 self.parts = [(dep.lower.split('.'),dep) for dep in deps.itervalues()]
73 # transitive closure of dependencies
74 for dep in deps.itervalues():
76 # disallow everything from the low level components
77 for dep in deps.itervalues():
79 for d in deps.itervalues():
80 if dep != d and not d.legacy:
81 dep.transitive.add(d.lower)
82 # disallow the 'top' components everywhere but in their own package
83 for dep in deps.itervalues():
84 if dep.top and not dep.legacy:
85 for d in deps.itervalues():
86 if dep != d and not d.legacy:
87 d.transitive.add(dep.lower)
88 for dep in deps.itervalues():
89 dep.transitive = set([x+"." for x in dep.transitive])
91 for dep in deps.itervalues():
92 print "-->", dep.lower, "-->", dep.transitive
94 # Lookup the dep object for the given package. If pkg is a subpackage
95 # of one with a rule, that one will be returned. If no matches are found,
97 def lookup(self, pkg):
98 # Returns the number of parts that match
99 def compare_parts(parts, pkg):
100 if len(parts) > len(pkg):
103 for i in range(0, len(parts)):
104 if parts[i] != pkg[i]:
111 for (parts,dep) in self.parts:
112 x = compare_parts(parts, pkg)
118 def parse_dependency_file(filename):
121 lines = f.readlines()
127 lines = [lineno(x,n) for x in lines]
128 lines = [(n,s.split("#")[0].strip()) for (n,s) in lines]
129 lines = [(n,s) for (n,s) in lines if len(s) > 0]
130 lines = [(n,s.split()) for (n,s) in lines]
132 for n,words in lines:
142 elif lower[0] == '-':
146 sys.stderr.write(("%s:%d: Package '%s' already defined on"
147 + " line %d.\n") % (filename, n, lower, deps[lower].lineno))
150 deps[lower] = Dependency(filename, n, lower, top, lowlevel, legacy)
151 elif len(words) == 2:
157 sys.stderr.write(("%s:%d: Can't add dependency to top level package "
158 + "'%s'\n") % (filename, n, lower))
161 dep = Dependency(filename, n, lower, False, False, False)
163 dep.uppers.append(upper)
165 sys.stderr.write("%s:%d: Too many words on line starting at \'%s\'\n" % (
166 filename, n, words[2]))
168 return Dependencies(deps)
170 def find_java_files(srcs):
175 result.extend([fn for fn in [s.strip() for s in f.readlines()]
179 for root, dirs, files in os.walk(d):
180 result.extend([os.sep.join((root,f)) for f in files
181 if f.lower().endswith(".java")])
184 COMMENTS = re.compile("//.*?\n|/\*.*?\*/", re.S)
185 PACKAGE = re.compile("package\s+(.*)")
186 IMPORT = re.compile("import\s+(.*)")
188 def examine_java_file(deps, filename):
190 # Yes, this is a crappy java parser. Write a better one if you want to.
194 text = COMMENTS.sub("", text)
195 index = text.find("{")
197 sys.stderr.write(("%s: Error: Unable to parse java. Can't find class "
198 + "declaration.\n") % filename)
202 statements = [s.strip() for s in text.split(";")]
203 # First comes the package declaration. Then iterate while we see import
204 # statements. Anything else is either bad syntax that we don't care about
205 # because the compiler will fail, or the beginning of the class declaration.
206 m = PACKAGE.match(statements[0])
208 sys.stderr.write(("%s: Error: Unable to parse java. Missing package "
209 + "statement.\n") % filename)
214 for statement in statements[1:]:
215 m = IMPORT.match(statement)
218 imports.append(m.group(1))
222 print "'%s' --> %s" % (pkg, imports)
223 dep = deps.lookup(pkg)
225 sys.stderr.write(("%s: Error: Package does not appear in dependency file: "
226 + "%s\n") % (filename, pkg))
231 sys.stderr.write("%s: Illegal import in package '%s' of '%s'\n"
232 % (filename, pkg, imp))
240 deps = parse_dependency_file(argv[1])
245 java = find_java_files(argv[2:])
246 for filename in java:
247 examine_java_file(deps, filename)
250 sys.stderr.write("%s: Using this file as dependency file.\n" % argv[1])
255 if __name__ == "__main__":