OSDN Git Service

android/hal-audio: Use hal-utils helpers for unaligned access
[android-x86/external-bluetooth-bluez.git] / android / hal-audio.c
index 946a835..e70351e 100644 (file)
@@ -35,7 +35,7 @@
 #include "hal-log.h"
 #include "hal-msg.h"
 #include "hal-audio.h"
-#include "../src/shared/util.h"
+#include "hal-utils.h"
 
 #define FIXED_A2DP_PLAYBACK_LATENCY_MS 25
 
@@ -96,8 +96,12 @@ extern int clock_nanosleep(clockid_t clock_id, int flags,
                                        struct timespec *remain);
 #endif
 
-static const audio_codec_get_t audio_codecs[] = {
-               codec_sbc,
+static struct {
+       const audio_codec_get_t get_codec;
+       bool loaded;
+} audio_codecs[] = {
+               { .get_codec = codec_aptx, .loaded = false },
+               { .get_codec = codec_sbc, .loaded = false },
 };
 
 #define NUM_CODECS (sizeof(audio_codecs) / sizeof(audio_codecs[0]))
@@ -282,8 +286,7 @@ static int audio_ipc_cmd(uint8_t service_id, uint8_t opcode, uint16_t len,
                        goto failed;
        }
 
-       if (rsp_len)
-               *rsp_len = cmd.len;
+       *rsp_len = cmd.len;
 
        return AUDIO_STATUS_SUCCESS;
 
@@ -337,7 +340,7 @@ static int ipc_close_cmd(uint8_t endpoint_id)
        return result;
 }
 
-static int ipc_open_stream_cmd(uint8_t endpoint_id, uint16_t *mtu, int *fd,
+static int ipc_open_stream_cmd(uint8_t *endpoint_id, uint16_t *mtu, int *fd,
                                                struct audio_preset **caps)
 {
        char buf[BLUEZ_AUDIO_MTU];
@@ -352,13 +355,14 @@ static int ipc_open_stream_cmd(uint8_t endpoint_id, uint16_t *mtu, int *fd,
        if (!caps)
                return AUDIO_STATUS_FAILED;
 
-       cmd.id = endpoint_id;
+       cmd.id = *endpoint_id;
 
        result = audio_ipc_cmd(AUDIO_SERVICE_ID, AUDIO_OP_OPEN_STREAM,
                                sizeof(cmd), &cmd, &rsp_len, rsp, fd);
        if (result == AUDIO_STATUS_SUCCESS) {
                size_t buf_len = sizeof(struct audio_preset) +
                                        rsp->preset[0].len;
+               *endpoint_id = rsp->id;
                *mtu = rsp->mtu;
                *caps = malloc(buf_len);
                memcpy(*caps, &rsp->preset, buf_len);
@@ -414,28 +418,53 @@ static int ipc_suspend_stream_cmd(uint8_t endpoint_id)
        return result;
 }
 
-static int register_endpoints(void)
+struct register_state {
+       struct audio_endpoint *ep;
+       bool error;
+};
+
+static void register_endpoint(const struct audio_codec *codec,
+                                               struct register_state *state)
 {
-       struct audio_endpoint *ep = &audio_endpoints[0];
-       size_t i;
+       struct audio_endpoint *ep = state->ep;
 
-       for (i = 0; i < NUM_CODECS; i++, ep++) {
-               const struct audio_codec *codec = audio_codecs[i]();
+       /* don't even try to register more endpoints if one failed */
+       if (state->error)
+               return;
 
-               if (!codec)
-                       return AUDIO_STATUS_FAILED;
+       ep->id = ipc_open_cmd(codec);
 
-               ep->id = ipc_open_cmd(codec);
+       if (!ep->id) {
+               state->error = true;
+               error("Failed to register endpoint");
+               return;
+       }
 
-               if (!ep->id)
-                       return AUDIO_STATUS_FAILED;
+       ep->codec = codec;
+       ep->codec_data = NULL;
+       ep->fd = -1;
 
-               ep->codec = codec;
-               ep->codec_data = NULL;
-               ep->fd = -1;
+       state->ep++;
+}
+
+static int register_endpoints(void)
+{
+       struct register_state state;
+       unsigned int i;
+
+       state.ep = &audio_endpoints[0];
+       state.error = false;
+
+       for (i = 0; i < NUM_CODECS; i++) {
+               const struct audio_codec *codec = audio_codecs[i].get_codec();
+
+               if (!audio_codecs[i].loaded)
+                       continue;
+
+               register_endpoint(codec, &state);
        }
 
-       return AUDIO_STATUS_SUCCESS;
+       return state.error ? AUDIO_STATUS_FAILED : AUDIO_STATUS_SUCCESS;
 }
 
 static void unregister_endpoints(void)
@@ -452,20 +481,39 @@ static void unregister_endpoints(void)
        }
 }
 
-static bool open_endpoint(struct audio_endpoint *ep,
+static bool open_endpoint(struct audio_endpoint **epp,
                                                struct audio_input_config *cfg)
 {
        struct audio_preset *preset;
+       struct audio_endpoint *ep = *epp;
        const struct audio_codec *codec;
        uint16_t mtu;
        uint16_t payload_len;
        int fd;
+       size_t i;
+       uint8_t ep_id = 0;
+
+       if (ep)
+               ep_id = ep->id;
 
-       if (ipc_open_stream_cmd(ep->id, &mtu, &fd, &preset) !=
+       if (ipc_open_stream_cmd(&ep_id, &mtu, &fd, &preset) !=
                                                        AUDIO_STATUS_SUCCESS)
                return false;
 
-       DBG("mtu=%u", mtu);
+       DBG("ep_id=%d mtu=%u", ep_id, mtu);
+
+       for (i = 0; i < MAX_AUDIO_ENDPOINTS; i++)
+               if (audio_endpoints[i].id == ep_id) {
+                       ep = &audio_endpoints[i];
+                       break;
+               }
+
+       if (!ep) {
+               error("Cound not find opened endpoint");
+               goto failed;
+       }
+
+       *epp = ep;
 
        payload_len = mtu;
        if (ep->codec->use_rtp)
@@ -540,10 +588,10 @@ static void downmix_to_mono(struct a2dp_stream_out *out, const uint8_t *buffer,
        frames = bytes / (2 * sizeof(int16_t));
 
        for (i = 0; i < frames; i++) {
-               int16_t l = le16_to_cpu(get_unaligned(&input[i * 2]));
-               int16_t r = le16_to_cpu(get_unaligned(&input[i * 2 + 1]));
+               int16_t l = get_le16(&input[i * 2]);
+               int16_t r = get_le16(&input[i * 2 + 1]);
 
-               put_unaligned(cpu_to_le16((l + r) / 2), &output[i]);
+               put_le16((l + r) / 2, &output[i]);
        }
 }
 
@@ -689,8 +737,12 @@ static bool write_data(struct a2dp_stream_out *out, const void *buffer,
                        }
                }
 
-               /* in resync mode we'll just drop mediapackets */
-               if (!ep->resync) {
+               /* we send data only in case codec encoded some data, i.e. some
+                * codecs do internal buffering and output data only if full
+                * frame can be encoded
+                * in resync mode we'll just drop mediapackets
+                */
+               if (written > 0 && !ep->resync) {
                        /* wait some time for socket to be ready for write,
                         * but we'll just skip writing data if timeout occurs
                         */
@@ -1090,10 +1142,10 @@ static int audio_open_output_stream(struct audio_hw_device *dev,
        out->stream.write = out_write;
        out->stream.get_render_position = out_get_render_position;
 
-       /* TODO: for now we always use endpoint 0 */
-       out->ep = &audio_endpoints[0];
+       /* We want to autoselect opened endpoint */
+       out->ep = NULL;
 
-       if (!open_endpoint(out->ep, &out->cfg))
+       if (!open_endpoint(&out->ep, &out->cfg))
                goto fail;
 
        DBG("rate=%d channels=%d format=%d", out->cfg.rate,
@@ -1251,11 +1303,24 @@ static int audio_dump(const audio_hw_device_t *device, int fd)
 static int audio_close(hw_device_t *device)
 {
        struct a2dp_audio_dev *a2dp_dev = (struct a2dp_audio_dev *)device;
+       unsigned int i;
 
        DBG("");
 
        unregister_endpoints();
 
+       for (i = 0; i < NUM_CODECS; i++) {
+               const struct audio_codec *codec = audio_codecs[i].get_codec();
+
+               if (!audio_codecs[i].loaded)
+                       continue;
+
+               if (codec->unload)
+                       codec->unload();
+
+               audio_codecs[i].loaded = false;
+       }
+
        shutdown(listen_sk, SHUT_RDWR);
        shutdown(audio_sk, SHUT_RDWR);
 
@@ -1320,14 +1385,12 @@ static void *ipc_handler(void *data)
                /* Check if socket is still alive. Empty while loop.*/
                while (poll(&pfd, 1, -1) < 0 && errno == EINTR);
 
-               if (pfd.revents & (POLLHUP | POLLERR | POLLNVAL)) {
-                       info("Audio HAL: Socket closed");
+               info("Audio HAL: Socket closed");
 
-                       pthread_mutex_lock(&sk_mutex);
-                       close(audio_sk);
-                       audio_sk = -1;
-                       pthread_mutex_unlock(&sk_mutex);
-               }
+               pthread_mutex_lock(&sk_mutex);
+               close(audio_sk);
+               audio_sk = -1;
+               pthread_mutex_unlock(&sk_mutex);
        }
 
        /* audio_sk is closed at this point, just cleanup endpoints states */
@@ -1395,6 +1458,7 @@ static int audio_open(const hw_module_t *module, const char *name,
                                                        hw_device_t **device)
 {
        struct a2dp_audio_dev *a2dp_dev;
+       size_t i;
        int err;
 
        DBG("");
@@ -1433,6 +1497,15 @@ static int audio_open(const hw_module_t *module, const char *name,
        a2dp_dev->dev.close_input_stream = audio_close_input_stream;
        a2dp_dev->dev.dump = audio_dump;
 
+       for (i = 0; i < NUM_CODECS; i++) {
+               const struct audio_codec *codec = audio_codecs[i].get_codec();
+
+               if (codec->load && !codec->load())
+                       continue;
+
+               audio_codecs[i].loaded = true;
+       }
+
        /*
         * Note that &a2dp_dev->dev.common is the same pointer as a2dp_dev.
         * This results from the structure of following structs:a2dp_audio_dev,