Merge "Camera: Switch 'cancelPictureFail' to 'cancelPictureNOP'" into oc-dev

[android-x86/hardware-interfaces.git] / camera / provider / 2.4 / vts / functional / VtsHalCameraProviderV2_4TargetTest.cpp

diff --git a/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp b/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp
index 2673afd..6f04efc 100644 (file)
--- a/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp
+++ b/camera/provider/2.4/vts/functional/VtsHalCameraProviderV2_4TargetTest.cpp
@@ -57,13 +57,14 @@ using ::android::IGraphicBufferConsumer;
 using ::android::BufferQueue;
 using ::android::BufferItemConsumer;
 using ::android::Surface;
-using ::android::CameraParameters;
 using ::android::hardware::graphics::common::V1_0::BufferUsage;
 using ::android::hardware::graphics::common::V1_0::PixelFormat;
 using ::android::hardware::camera::common::V1_0::Status;
 using ::android::hardware::camera::common::V1_0::CameraDeviceStatus;
 using ::android::hardware::camera::common::V1_0::TorchMode;
 using ::android::hardware::camera::common::V1_0::TorchModeStatus;
+using ::android::hardware::camera::common::V1_0::helper::CameraParameters;
+using ::android::hardware::camera::common::V1_0::helper::Size;
 using ::android::hardware::camera::provider::V2_4::ICameraProvider;
 using ::android::hardware::camera::provider::V2_4::ICameraProviderCallback;
 using ::android::hardware::camera::device::V3_2::ICameraDevice;
@@ -658,7 +659,7 @@ public:
             const std::vector<AvailableStream> &streamSizes,
             int32_t format, AvailableStream &result);
     static Status isAutoFocusModeAvailable(
-            ::android::CameraParameters &cameraParams, const char *mode) ;
+            CameraParameters &cameraParams, const char *mode) ;
 
 protected:
 
@@ -1687,7 +1688,7 @@ TEST_F(CameraHidlTest, autoFocus) {
                 openCameraDevice(name, provider.second, &device1 /*out*/);
                 ASSERT_NE(nullptr, device1.get());
 
-                ::android::CameraParameters cameraParams;
+                CameraParameters cameraParams;
                 getParameters(device1, &cameraParams /*out*/);
 
                 if (Status::OK != isAutoFocusModeAvailable(cameraParams,
@@ -1752,7 +1753,7 @@ TEST_F(CameraHidlTest, cancelAutoFocus) {
                 openCameraDevice(name, provider.second, &device1 /*out*/);
                 ASSERT_NE(nullptr, device1.get());
 
-                ::android::CameraParameters cameraParams;
+                CameraParameters cameraParams;
                 getParameters(device1, &cameraParams /*out*/);
 
                 if (Status::OK != isAutoFocusModeAvailable(cameraParams,
@@ -1803,7 +1804,7 @@ TEST_F(CameraHidlTest, sendCommandFaceDetection) {
                 openCameraDevice(name, provider.second, &device1 /*out*/);
                 ASSERT_NE(nullptr, device1.get());
 
-                ::android::CameraParameters cameraParams;
+                CameraParameters cameraParams;
                 getParameters(device1, &cameraParams /*out*/);
 
                 int32_t hwFaces = cameraParams.getInt(
@@ -1869,7 +1870,7 @@ TEST_F(CameraHidlTest, sendCommandSmoothZoom) {
                 openCameraDevice(name, provider.second, &device1 /*out*/);
                 ASSERT_NE(nullptr, device1.get());
 
-                ::android::CameraParameters cameraParams;
+                CameraParameters cameraParams;
                 getParameters(device1, &cameraParams /*out*/);
 
                 const char *smoothZoomStr = cameraParams.get(
@@ -1923,7 +1924,7 @@ TEST_F(CameraHidlTest, getSetParameters) {
                 openCameraDevice(name, provider.second, &device1 /*out*/);
                 ASSERT_NE(nullptr, device1.get());
 
-                ::android::CameraParameters cameraParams;
+                CameraParameters cameraParams;
                 getParameters(device1, &cameraParams /*out*/);
 
                 int32_t width, height;
@@ -1954,10 +1955,10 @@ TEST_F(CameraHidlTest, getSetParameters) {
                 ASSERT_TRUE((nullptr == effect) || (strcmp(
                         CameraParameters::EFFECT_NONE, effect) == 0));
 
-                ::android::Vector<::android::Size> previewSizes;
+                ::android::Vector<Size> previewSizes;
                 cameraParams.getSupportedPreviewSizes(previewSizes);
                 ASSERT_FALSE(previewSizes.empty());
-                ::android::Vector<::android::Size> pictureSizes;
+                ::android::Vector<Size> pictureSizes;
                 cameraParams.getSupportedPictureSizes(pictureSizes);
                 ASSERT_FALSE(pictureSizes.empty());
                 const char *previewFormats = cameraParams.get(
@@ -2632,8 +2633,7 @@ TEST_F(CameraHidlTest, configureStreamsZSLInputOutputs) {
                         Stream inputStream = {streamId++, StreamType::INPUT,
                                 static_cast<uint32_t> (input.width),
                                 static_cast<uint32_t> (input.height),
-                                static_cast<PixelFormat> (input.format),
-                                0, 0,
+                                static_cast<PixelFormat> (input.format), 0, 0,
                                 StreamRotation::ROTATION_0};
                         Stream outputStream = {streamId++, StreamType::OUTPUT,
                                 static_cast<uint32_t> (outputIter.width),
@@ -2646,11 +2646,11 @@ TEST_F(CameraHidlTest, configureStreamsZSLInputOutputs) {
                                 inputStream, zslStream, outputStream};
                         StreamConfiguration config = {streams,
                                 StreamConfigurationMode::NORMAL_MODE};
-                        ret = session->configureStreams(config, [streamId] (Status s,
-                                HalStreamConfiguration halConfig) {
-                            ASSERT_EQ(Status::OK, s);
-                            ASSERT_EQ(3u, halConfig.streams.size());
-                        });
+                        ret = session->configureStreams(config,
+                                                    [](Status s, HalStreamConfiguration halConfig) {
+                                                        ASSERT_EQ(Status::OK, s);
+                                                        ASSERT_EQ(3u, halConfig.streams.size());
+                                                    });
                         ASSERT_TRUE(ret.isOk());
                     }
                 }
@@ -2714,11 +2714,11 @@ TEST_F(CameraHidlTest, configureStreamsPreviewStillOutputs) {
                                 previewStream, blobStream};
                         StreamConfiguration config = {streams,
                                 StreamConfigurationMode::NORMAL_MODE};
-                        ret = session->configureStreams(config, [streamId] (Status s,
-                                HalStreamConfiguration halConfig) {
-                            ASSERT_EQ(Status::OK, s);
-                            ASSERT_EQ(2u, halConfig.streams.size());
-                        });
+                        ret = session->configureStreams(config,
+                                                    [](Status s, HalStreamConfiguration halConfig) {
+                                                        ASSERT_EQ(Status::OK, s);
+                                                        ASSERT_EQ(2u, halConfig.streams.size());
+                                                    });
                         ASSERT_TRUE(ret.isOk());
                     }
                 }
@@ -2787,7 +2787,7 @@ TEST_F(CameraHidlTest, configureStreamsConstrainedOutputs) {
                 streams[0] = stream;
                 config = {streams,
                         StreamConfigurationMode::CONSTRAINED_HIGH_SPEED_MODE};
-                ret = session->configureStreams(config, [streamId] (Status s,
+                ret = session->configureStreams(config, [] (Status s,
                         HalStreamConfiguration) {
                     ASSERT_TRUE((Status::ILLEGAL_ARGUMENT == s) ||
                                 (Status::INTERNAL_ERROR == s));
@@ -2803,7 +2803,7 @@ TEST_F(CameraHidlTest, configureStreamsConstrainedOutputs) {
                 streams[0] = stream;
                 config = {streams,
                         StreamConfigurationMode::CONSTRAINED_HIGH_SPEED_MODE};
-                ret = session->configureStreams(config, [streamId] (Status s,
+                ret = session->configureStreams(config, [] (Status s,
                         HalStreamConfiguration) {
                     ASSERT_EQ(Status::ILLEGAL_ARGUMENT, s);
                 });
@@ -2818,7 +2818,7 @@ TEST_F(CameraHidlTest, configureStreamsConstrainedOutputs) {
                 streams[0] = stream;
                 config = {streams,
                         StreamConfigurationMode::CONSTRAINED_HIGH_SPEED_MODE};
-                ret = session->configureStreams(config, [streamId] (Status s,
+                ret = session->configureStreams(config, [] (Status s,
                         HalStreamConfiguration) {
                     ASSERT_EQ(Status::ILLEGAL_ARGUMENT, s);
                 });
@@ -2883,11 +2883,11 @@ TEST_F(CameraHidlTest, configureStreamsVideoStillOutputs) {
                                 videoStream, blobStream};
                         StreamConfiguration config = {streams,
                                 StreamConfigurationMode::NORMAL_MODE};
-                        ret = session->configureStreams(config, [streamId] (
-                                Status s, HalStreamConfiguration halConfig) {
-                            ASSERT_EQ(Status::OK, s);
-                            ASSERT_EQ(2u, halConfig.streams.size());
-                        });
+                        ret = session->configureStreams(config,
+                                                    [](Status s, HalStreamConfiguration halConfig) {
+                                                        ASSERT_EQ(Status::OK, s);
+                                                        ASSERT_EQ(2u, halConfig.streams.size());
+                                                    });
                         ASSERT_TRUE(ret.isOk());
                     }
                 }
@@ -3106,10 +3106,7 @@ TEST_F(CameraHidlTest, processCaptureRequestInvalidSinglePreview) {
                             numRequestProcessed = n;
                         });
                 ASSERT_TRUE(ret.isOk());
-                // b/64041692: Temporariy accept ILLEGAL_ARGUMENT or INTERNAL_ERROR
-                // It will be changed to only accept ILLEGAL_ARGUMENT in next release
-                ASSERT_TRUE(status == Status::ILLEGAL_ARGUMENT ||
-                        status == Status::INTERNAL_ERROR);
+                ASSERT_EQ(Status::ILLEGAL_ARGUMENT, status);
                 ASSERT_EQ(numRequestProcessed, 0u);
 
                 ret = session->close();
@@ -3170,10 +3167,7 @@ TEST_F(CameraHidlTest, processCaptureRequestInvalidBuffer) {
                             numRequestProcessed = n;
                         });
                 ASSERT_TRUE(ret.isOk());
-                // b/64041692: Temporariy accept ILLEGAL_ARGUMENT or INTERNAL_ERROR
-                // It will be changed to only accept ILLEGAL_ARGUMENT in next release
-                ASSERT_TRUE(status == Status::ILLEGAL_ARGUMENT ||
-                        status == Status::INTERNAL_ERROR);
+                ASSERT_EQ(Status::ILLEGAL_ARGUMENT, status);
                 ASSERT_EQ(numRequestProcessed, 0u);
 
                 ret = session->close();
@@ -3525,7 +3519,7 @@ Status CameraHidlTest::findLargestSize(
 
 // Check whether the camera device supports specific focus mode.
 Status CameraHidlTest::isAutoFocusModeAvailable(
-        ::android::CameraParameters &cameraParams,
+        CameraParameters &cameraParams,
         const char *mode) {
     ::android::String8 focusModes(cameraParams.get(
             CameraParameters::KEY_SUPPORTED_FOCUS_MODES));