OSDN Git Service

net: dsa: bcm_sf2_cfp: fix an incorrect NULL check on list iterator
[uclinux-h8/linux.git] / drivers / net / dsa / bcm_sf2_cfp.c
index a7e2fcf..edbe5e7 100644 (file)
@@ -567,14 +567,14 @@ static void bcm_sf2_cfp_slice_ipv6(struct bcm_sf2_priv *priv,
 static struct cfp_rule *bcm_sf2_cfp_rule_find(struct bcm_sf2_priv *priv,
                                              int port, u32 location)
 {
-       struct cfp_rule *rule = NULL;
+       struct cfp_rule *rule;
 
        list_for_each_entry(rule, &priv->cfp.rules_list, next) {
                if (rule->port == port && rule->fs.location == location)
-                       break;
+                       return rule;
        }
 
-       return rule;
+       return NULL;
 }
 
 static int bcm_sf2_cfp_rule_cmp(struct bcm_sf2_priv *priv, int port,