scm: git: override "path_encoding" method in adapter (#5251).

[redminele/redmine.git] / lib / redmine / scm / adapters / git_adapter.rb

diff --git a/lib/redmine/scm/adapters/git_adapter.rb b/lib/redmine/scm/adapters/git_adapter.rb
index 543246a..ad04b62 100644 (file)
--- a/lib/redmine/scm/adapters/git_adapter.rb
+++ b/lib/redmine/scm/adapters/git_adapter.rb
@@ -1,16 +1,16 @@
-# redMine - project management software
-# Copyright (C) 2006-2007  Jean-Philippe Lang
+# Redmine - project management software
+# Copyright (C) 2006-2011  Jean-Philippe Lang
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
 # as published by the Free Software Foundation; either version 2
 # of the License, or (at your option) any later version.
-# 
+#
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
-# 
+#
 # You should have received a copy of the GNU General Public License
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
@@ -22,8 +22,6 @@ module Redmine
     module Adapters
       class GitAdapter < AbstractAdapter
 
-        SCM_GIT_REPORT_LAST_COMMIT = true
-
         # Git executable name
         GIT_BIN = Redmine::Configuration['scm_git_command'] || "git"
 
@@ -65,7 +63,10 @@ module Redmine
         def initialize(url, root_url=nil, login=nil, password=nil, path_encoding=nil)
           super
           @path_encoding = path_encoding.blank? ? 'UTF-8' : path_encoding
-          @flag_report_last_commit = SCM_GIT_REPORT_LAST_COMMIT
+        end
+
+        def path_encoding
+          @path_encoding
         end
 
         def info
@@ -115,17 +116,13 @@ module Redmine
             Entry.new(:path => '', :kind => 'dir')
           else
             # Search for the entry in the parent directory
-            es = entries_git(search_path, identifier)
+            es = entries(search_path, identifier,
+                         options = {:report_last_commit => false})
             es ? es.detect {|e| e.name == search_name} : nil
           end
         end
 
         def entries(path=nil, identifier=nil, options={})
-          entries_git(path, identifier,
-                      {:report_last_commit => @flag_report_last_commit})
-        end
-
-        def entries_git(path=nil, identifier=nil, options={})
           path ||= ''
           p = scm_iconv(@path_encoding, 'UTF-8', path)
           entries = Entries.new
@@ -160,7 +157,6 @@ module Redmine
         rescue ScmCommandAborted
           nil
         end
-        private :entries_git
 
         def lastrev(path, rev)
           return nil if path.nil?
@@ -191,7 +187,7 @@ module Redmine
         end
 
         def revisions(path, identifier_from, identifier_to, options={})
-          revisions = Revisions.new
+          revs = Revisions.new
           cmd_args = %w|log --no-color --encoding=UTF-8 --raw --date=iso --pretty=fuller|
           cmd_args << "--reverse" if options[:reverse]
           cmd_args << "--all" if options[:all]
@@ -225,7 +221,7 @@ module Redmine
                   if block_given?
                     yield revision
                   else
-                    revisions << revision
+                    revs << revision
                   end
                   changeset = {}
                   files = []
@@ -271,18 +267,18 @@ module Redmine
                 :time       => Time.parse(changeset[:date]),
                 :message    => changeset[:description],
                 :paths      => files
-              })
-
+                 })
               if block_given?
                 yield revision
               else
-                revisions << revision
+                revs << revision
               end
             end
           end
-          revisions
-        rescue ScmCommandAborted
-          revisions
+          revs
+        rescue ScmCommandAborted => e
+          logger.error("git log #{from_to.to_s} error: #{e.message}")
+          revs
         end
 
         def diff(path, identifier_from, identifier_to=nil)