Fixed a possible use-after-free bug in initialization code.

[lamexp/LameXP.git] / src / Encoder_Wave.cpp

diff --git a/src/Encoder_Wave.cpp b/src/Encoder_Wave.cpp
index 859986a..4b60fb2 100644 (file)
--- a/src/Encoder_Wave.cpp
+++ b/src/Encoder_Wave.cpp
@@ -1,11 +1,12 @@
 ///////////////////////////////////////////////////////////////////////////////
 // LameXP - Audio Encoder Front-End
-// Copyright (C) 2004-2011 LoRd_MuldeR <MuldeR2@GMX.de>
+// Copyright (C) 2004-2015 LoRd_MuldeR <MuldeR2@GMX.de>
 //
 // This program is free software; you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation; either version 2 of the License, or
-// (at your option) any later version.
+// (at your option) any later version, but always including the *additional*
+// restrictions defined in the "License.txt" file.
 //
 // This program is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -25,12 +26,99 @@
 #include "Model_Settings.h"
 
 #include <QDir>
+
+//Windows includes
+#define NOMINMAX
+#define WIN32_LEAN_AND_MEAN
+#include <Windows.h>
 #include <Shellapi.h>
 
-#define max(a,b) (((a) > (b)) ? (a) : (b))
-#define min(a,b) (((a) < (b)) ? (a) : (b))
 #define FIX_SEPARATORS(STR) for(int i = 0; STR[i]; i++) { if(STR[i] == L'/') STR[i] = L'\\'; }
 
+///////////////////////////////////////////////////////////////////////////////
+// Encoder Info
+///////////////////////////////////////////////////////////////////////////////
+
+class WaveEncoderInfo : public AbstractEncoderInfo
+{
+public:
+       virtual bool isModeSupported(int mode) const
+       {
+               switch(mode)
+               {
+               case SettingsModel::VBRMode:
+               case SettingsModel::ABRMode:
+                       return false;
+                       break;
+               case SettingsModel::CBRMode:
+                       return true;
+                       break;
+               default:
+                       MUTILS_THROW("Bad RC mode specified!");
+               }
+       }
+
+       virtual int valueCount(int mode) const
+       {
+               switch(mode)
+               {
+               case SettingsModel::VBRMode:
+               case SettingsModel::ABRMode:
+               case SettingsModel::CBRMode:
+                       return 0;
+                       break;
+               default:
+                       MUTILS_THROW("Bad RC mode specified!");
+               }
+       }
+
+       virtual int valueAt(int mode, int index) const
+       {
+               switch(mode)
+               {
+               case SettingsModel::VBRMode:
+               case SettingsModel::ABRMode:
+               case SettingsModel::CBRMode:
+                       return -1;
+                       break;
+               default:
+                       MUTILS_THROW("Bad RC mode specified!");
+               }
+       }
+
+       virtual int valueType(int mode) const
+       {
+               switch(mode)
+               {
+               case SettingsModel::VBRMode:
+               case SettingsModel::ABRMode:
+               case SettingsModel::CBRMode:
+                       return TYPE_UNCOMPRESSED;
+                       break;
+               default:
+                       MUTILS_THROW("Bad RC mode specified!");
+               }
+       }
+
+       virtual const char *description(void) const
+       {
+               static const char* s_description = "Wave Audio (PCM)";
+               return s_description;
+       }
+
+       virtual const char *extension(void) const
+       {
+               static const char* s_extension = "wav";
+               return s_extension;
+       }
+}
+static const g_waveEncoderInfo;
+
+///////////////////////////////////////////////////////////////////////////////
+// Encoder implementation
+///////////////////////////////////////////////////////////////////////////////
+
+
 WaveEncoder::WaveEncoder(void)
 {
 }
@@ -39,7 +127,7 @@ WaveEncoder::~WaveEncoder(void)
 {
 }
 
-bool WaveEncoder::encode(const QString &sourceFile, const AudioFileModel &metaInfo, const QString &outputFile, volatile bool *abortFlag)
+bool WaveEncoder::encode(const QString &sourceFile, const AudioFileModel_MetaInfo &metaInfo, const unsigned int duration, const QString &outputFile, volatile bool *abortFlag)
 {
        SHFILEOPSTRUCTW fileOperation;
        memset(&fileOperation, 0, sizeof(SHFILEOPSTRUCTW));
@@ -66,14 +154,14 @@ bool WaveEncoder::encode(const QString &sourceFile, const AudioFileModel &metaIn
        size_t srcLen = wcslen(reinterpret_cast<const wchar_t*>(sourceFile.utf16())) + 3;
        wchar_t *srcBuffer = new wchar_t[srcLen];
        memset(srcBuffer, 0, srcLen * sizeof(wchar_t));
-       wcscpy_s(srcBuffer, srcLen, reinterpret_cast<const wchar_t*>(sourceFile.utf16()));
+       wcsncpy_s(srcBuffer, srcLen, reinterpret_cast<const wchar_t*>(sourceFile.utf16()), _TRUNCATE);
        FIX_SEPARATORS (srcBuffer);
        fileOperation.pFrom = srcBuffer;
 
        size_t outLen = wcslen(reinterpret_cast<const wchar_t*>(outputFile.utf16())) + 3;
        wchar_t *outBuffer = new wchar_t[outLen];
        memset(outBuffer, 0, outLen * sizeof(wchar_t));
-       wcscpy_s(outBuffer, outLen, reinterpret_cast<const wchar_t*>(outputFile.utf16()));
+       wcsncpy_s(outBuffer, outLen, reinterpret_cast<const wchar_t*>(outputFile.utf16()), _TRUNCATE);
        FIX_SEPARATORS (outBuffer);
        fileOperation.pTo = outBuffer;
 
@@ -89,11 +177,6 @@ bool WaveEncoder::encode(const QString &sourceFile, const AudioFileModel &metaIn
        return (result == 0 && fileOperation.fAnyOperationsAborted == false);
 }
 
-QString WaveEncoder::extension(void)
-{
-       return "wav";
-}
-
 bool WaveEncoder::isFormatSupported(const QString &containerType, const QString &containerProfile, const QString &formatType, const QString &formatProfile, const QString &formatVersion)
 {
        if(containerType.compare("Wave", Qt::CaseInsensitive) == 0)
@@ -105,3 +188,8 @@ bool WaveEncoder::isFormatSupported(const QString &containerType, const QString
        }
        return false;
 }
+
+const AbstractEncoderInfo *WaveEncoder::getEncoderInfo(void)
+{
+       return &g_waveEncoderInfo;
+}