fix undefined behavior in strto* via FILE buffer pointer abuse

[android-x86/external-musl-libc.git] / src / stdlib / strtol.c

diff --git a/src/stdlib/strtol.c b/src/stdlib/strtol.c
index d82ecf7..bfefea6 100644 (file)
--- a/src/stdlib/strtol.c
+++ b/src/stdlib/strtol.c
@@ -7,15 +7,8 @@
 
 static unsigned long long strtox(const char *s, char **p, int base, unsigned long long lim)
 {
-       /* FIXME: use a helper function or macro to setup the FILE */
        FILE f;
-       f.flags = 0;
-       f.buf = f.rpos = (void *)s;
-       if ((size_t)s > (size_t)-1/2)
-               f.rend = (void *)-1;
-       else
-               f.rend = (unsigned char *)s+(size_t)-1/2;
-       f.lock = -1;
+       sh_fromstring(&f, s);
        shlim(&f, 0);
        unsigned long long y = __intscan(&f, base, 1, lim);
        if (p) {