OSDN Git Service

modetest: add the ability to specify fill patterns on the commandline
[android-x86/external-libdrm.git] / tests / modetest / modetest.c
index f0ed56b..e66be66 100644 (file)
@@ -37,7 +37,6 @@
  * TODO: use cairo to write the mode info on the selected output once
  *       the mode has been programmed, along with possible test patterns.
  */
-#include "config.h"
 
 #include <assert.h>
 #include <ctype.h>
 #include <inttypes.h>
 #include <unistd.h>
 #include <string.h>
+#include <strings.h>
 #include <errno.h>
-#include <sys/poll.h>
+#include <poll.h>
 #include <sys/time.h>
+#ifdef HAVE_SYS_SELECT_H
+#include <sys/select.h>
+#endif
 
 #include "xf86drm.h"
 #include "xf86drmMode.h"
 #include "drm_fourcc.h"
-#include "libkms.h"
+
+#include "util/common.h"
+#include "util/format.h"
+#include "util/kms.h"
+#include "util/pattern.h"
 
 #include "buffers.h"
+#include "cursor.h"
+
+static enum util_fill_pattern primary_fill = UTIL_PATTERN_SMPTE;
+static enum util_fill_pattern secondary_fill = UTIL_PATTERN_TILES;
 
 struct crtc {
        drmModeCrtc *crtc;
@@ -74,6 +85,7 @@ struct connector {
        drmModeConnector *connector;
        drmModeObjectProperties *props;
        drmModePropertyRes **props_info;
+       char *name;
 };
 
 struct fb {
@@ -101,72 +113,25 @@ struct device {
        int fd;
 
        struct resources *resources;
-       struct kms_driver *kms;
 
        struct {
                unsigned int width;
                unsigned int height;
 
                unsigned int fb_id;
-               struct kms_bo *bo;
+               struct bo *bo;
+               struct bo *cursor_bo;
        } mode;
-};
-
-#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
 
-struct type_name {
-       int type;
-       const char *name;
+       int use_atomic;
+       drmModeAtomicReq *req;
 };
 
-#define type_name_fn(res) \
-const char * res##_str(int type) {                     \
-       unsigned int i;                                 \
-       for (i = 0; i < ARRAY_SIZE(res##_names); i++) { \
-               if (res##_names[i].type == type)        \
-                       return res##_names[i].name;     \
-       }                                               \
-       return "(invalid)";                             \
+static inline int64_t U642I64(uint64_t val)
+{
+       return (int64_t)*((int64_t *)&val);
 }
 
-struct type_name encoder_type_names[] = {
-       { DRM_MODE_ENCODER_NONE, "none" },
-       { DRM_MODE_ENCODER_DAC, "DAC" },
-       { DRM_MODE_ENCODER_TMDS, "TMDS" },
-       { DRM_MODE_ENCODER_LVDS, "LVDS" },
-       { DRM_MODE_ENCODER_TVDAC, "TVDAC" },
-};
-
-static type_name_fn(encoder_type)
-
-struct type_name connector_status_names[] = {
-       { DRM_MODE_CONNECTED, "connected" },
-       { DRM_MODE_DISCONNECTED, "disconnected" },
-       { DRM_MODE_UNKNOWNCONNECTION, "unknown" },
-};
-
-static type_name_fn(connector_status)
-
-struct type_name connector_type_names[] = {
-       { DRM_MODE_CONNECTOR_Unknown, "unknown" },
-       { DRM_MODE_CONNECTOR_VGA, "VGA" },
-       { DRM_MODE_CONNECTOR_DVII, "DVI-I" },
-       { DRM_MODE_CONNECTOR_DVID, "DVI-D" },
-       { DRM_MODE_CONNECTOR_DVIA, "DVI-A" },
-       { DRM_MODE_CONNECTOR_Composite, "composite" },
-       { DRM_MODE_CONNECTOR_SVIDEO, "s-video" },
-       { DRM_MODE_CONNECTOR_LVDS, "LVDS" },
-       { DRM_MODE_CONNECTOR_Component, "component" },
-       { DRM_MODE_CONNECTOR_9PinDIN, "9-pin DIN" },
-       { DRM_MODE_CONNECTOR_DisplayPort, "DP" },
-       { DRM_MODE_CONNECTOR_HDMIA, "HDMI-A" },
-       { DRM_MODE_CONNECTOR_HDMIB, "HDMI-B" },
-       { DRM_MODE_CONNECTOR_TV, "TV" },
-       { DRM_MODE_CONNECTOR_eDP, "eDP" },
-};
-
-static type_name_fn(connector_type)
-
 #define bit_name_fn(res)                                       \
 const char * res##_str(int type) {                             \
        unsigned int i;                                         \
@@ -211,6 +176,15 @@ static const char *mode_flag_names[] = {
 
 static bit_name_fn(mode_flag)
 
+static void dump_fourcc(uint32_t fourcc)
+{
+       printf(" %c%c%c%c",
+               fourcc,
+               fourcc >> 8,
+               fourcc >> 16,
+               fourcc >> 24);
+}
+
 static void dump_encoders(struct device *dev)
 {
        drmModeEncoder *encoder;
@@ -226,7 +200,7 @@ static void dump_encoders(struct device *dev)
                printf("%d\t%d\t%s\t0x%08x\t0x%08x\n",
                       encoder->encoder_id,
                       encoder->crtc_id,
-                      encoder_type_str(encoder->encoder_type),
+                      util_lookup_encoder_type_name(encoder->encoder_type),
                       encoder->possible_crtcs,
                       encoder->possible_clones);
        }
@@ -235,7 +209,7 @@ static void dump_encoders(struct device *dev)
 
 static void dump_mode(drmModeModeInfo *mode)
 {
-       printf("  %s %d %d %d %d %d %d %d %d %d",
+       printf("  %s %d %d %d %d %d %d %d %d %d %d",
               mode->name,
               mode->vrefresh,
               mode->hdisplay,
@@ -245,7 +219,8 @@ static void dump_mode(drmModeModeInfo *mode)
               mode->vdisplay,
               mode->vsync_start,
               mode->vsync_end,
-              mode->vtotal);
+              mode->vtotal,
+              mode->clock);
 
        printf(" flags: ");
        mode_flag_str(mode->flags);
@@ -261,8 +236,10 @@ static void dump_blob(struct device *dev, uint32_t blob_id)
        drmModePropertyBlobPtr blob;
 
        blob = drmModeGetPropertyBlob(dev->fd, blob_id);
-       if (!blob)
+       if (!blob) {
+               printf("\n");
                return;
+       }
 
        blob_data = blob->data;
 
@@ -276,6 +253,91 @@ static void dump_blob(struct device *dev, uint32_t blob_id)
        drmModeFreePropertyBlob(blob);
 }
 
+static const char *modifier_to_string(uint64_t modifier)
+{
+       switch (modifier) {
+       case DRM_FORMAT_MOD_INVALID:
+               return "INVALID";
+       case DRM_FORMAT_MOD_LINEAR:
+               return "LINEAR";
+       case I915_FORMAT_MOD_X_TILED:
+               return "X_TILED";
+       case I915_FORMAT_MOD_Y_TILED:
+               return "Y_TILED";
+       case I915_FORMAT_MOD_Yf_TILED:
+               return "Yf_TILED";
+       case I915_FORMAT_MOD_Y_TILED_CCS:
+               return "Y_TILED_CCS";
+       case I915_FORMAT_MOD_Yf_TILED_CCS:
+               return "Yf_TILED_CCS";
+       case DRM_FORMAT_MOD_SAMSUNG_64_32_TILE:
+               return "SAMSUNG_64_32_TILE";
+       case DRM_FORMAT_MOD_VIVANTE_TILED:
+               return "VIVANTE_TILED";
+       case DRM_FORMAT_MOD_VIVANTE_SUPER_TILED:
+               return "VIVANTE_SUPER_TILED";
+       case DRM_FORMAT_MOD_VIVANTE_SPLIT_TILED:
+               return "VIVANTE_SPLIT_TILED";
+       case DRM_FORMAT_MOD_VIVANTE_SPLIT_SUPER_TILED:
+               return "VIVANTE_SPLIT_SUPER_TILED";
+       case DRM_FORMAT_MOD_NVIDIA_TEGRA_TILED:
+               return "NVIDIA_TEGRA_TILED";
+       case DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK(0):
+               return "NVIDIA_16BX2_BLOCK(0)";
+       case DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK(1):
+               return "NVIDIA_16BX2_BLOCK(1)";
+       case DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK(2):
+               return "NVIDIA_16BX2_BLOCK(2)";
+       case DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK(3):
+               return "NVIDIA_16BX2_BLOCK(3)";
+       case DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK(4):
+               return "NVIDIA_16BX2_BLOCK(4)";
+       case DRM_FORMAT_MOD_NVIDIA_16BX2_BLOCK(5):
+               return "NVIDIA_16BX2_BLOCK(5)";
+       case DRM_FORMAT_MOD_BROADCOM_VC4_T_TILED:
+               return "MOD_BROADCOM_VC4_T_TILED";
+       case DRM_FORMAT_MOD_QCOM_COMPRESSED:
+               return "QCOM_COMPRESSED";
+       default:
+               return "(UNKNOWN MODIFIER)";
+       }
+}
+
+static void dump_in_formats(struct device *dev, uint32_t blob_id)
+{
+       uint32_t i, j;
+       drmModePropertyBlobPtr blob;
+       struct drm_format_modifier_blob *header;
+       uint32_t *formats;
+       struct drm_format_modifier *modifiers;
+
+       printf("\t\tin_formats blob decoded:\n");
+       blob = drmModeGetPropertyBlob(dev->fd, blob_id);
+       if (!blob) {
+               printf("\n");
+               return;
+       }
+
+       header = blob->data;
+       formats = (uint32_t *) ((char *) header + header->formats_offset);
+       modifiers = (struct drm_format_modifier *)
+               ((char *) header + header->modifiers_offset);
+
+       for (i = 0; i < header->count_formats; i++) {
+               printf("\t\t\t");
+               dump_fourcc(formats[i]);
+               printf(": ");
+               for (j = 0; j < header->count_modifiers; j++) {
+                       uint64_t mask = 1ULL << i;
+                       if (modifiers[j].formats & mask)
+                               printf(" %s", modifier_to_string(modifiers[j].modifier));
+               }
+               printf("\n");
+       }
+
+       drmModeFreePropertyBlob(blob);
+}
+
 static void dump_prop(struct device *dev, drmModePropertyPtr prop,
                      uint32_t prop_id, uint64_t value)
 {
@@ -291,32 +353,43 @@ static void dump_prop(struct device *dev, drmModePropertyPtr prop,
        printf("\t\tflags:");
        if (prop->flags & DRM_MODE_PROP_PENDING)
                printf(" pending");
-       if (prop->flags & DRM_MODE_PROP_RANGE)
-               printf(" range");
        if (prop->flags & DRM_MODE_PROP_IMMUTABLE)
                printf(" immutable");
-       if (prop->flags & DRM_MODE_PROP_ENUM)
+       if (drm_property_type_is(prop, DRM_MODE_PROP_SIGNED_RANGE))
+               printf(" signed range");
+       if (drm_property_type_is(prop, DRM_MODE_PROP_RANGE))
+               printf(" range");
+       if (drm_property_type_is(prop, DRM_MODE_PROP_ENUM))
                printf(" enum");
-       if (prop->flags & DRM_MODE_PROP_BITMASK)
+       if (drm_property_type_is(prop, DRM_MODE_PROP_BITMASK))
                printf(" bitmask");
-       if (prop->flags & DRM_MODE_PROP_BLOB)
+       if (drm_property_type_is(prop, DRM_MODE_PROP_BLOB))
                printf(" blob");
+       if (drm_property_type_is(prop, DRM_MODE_PROP_OBJECT))
+               printf(" object");
        printf("\n");
 
-       if (prop->flags & DRM_MODE_PROP_RANGE) {
+       if (drm_property_type_is(prop, DRM_MODE_PROP_SIGNED_RANGE)) {
+               printf("\t\tvalues:");
+               for (i = 0; i < prop->count_values; i++)
+                       printf(" %"PRId64, U642I64(prop->values[i]));
+               printf("\n");
+       }
+
+       if (drm_property_type_is(prop, DRM_MODE_PROP_RANGE)) {
                printf("\t\tvalues:");
                for (i = 0; i < prop->count_values; i++)
                        printf(" %"PRIu64, prop->values[i]);
                printf("\n");
        }
 
-       if (prop->flags & DRM_MODE_PROP_ENUM) {
+       if (drm_property_type_is(prop, DRM_MODE_PROP_ENUM)) {
                printf("\t\tenums:");
                for (i = 0; i < prop->count_enums; i++)
                        printf(" %s=%llu", prop->enums[i].name,
                               prop->enums[i].value);
                printf("\n");
-       } else if (prop->flags & DRM_MODE_PROP_BITMASK) {
+       } else if (drm_property_type_is(prop, DRM_MODE_PROP_BITMASK)) {
                printf("\t\tvalues:");
                for (i = 0; i < prop->count_enums; i++)
                        printf(" %s=0x%llx", prop->enums[i].name,
@@ -326,7 +399,7 @@ static void dump_prop(struct device *dev, drmModePropertyPtr prop,
                assert(prop->count_enums == 0);
        }
 
-       if (prop->flags & DRM_MODE_PROP_BLOB) {
+       if (drm_property_type_is(prop, DRM_MODE_PROP_BLOB)) {
                printf("\t\tblobs:\n");
                for (i = 0; i < prop->count_blobs; i++)
                        dump_blob(dev, prop->blob_ids[i]);
@@ -336,10 +409,15 @@ static void dump_prop(struct device *dev, drmModePropertyPtr prop,
        }
 
        printf("\t\tvalue:");
-       if (prop->flags & DRM_MODE_PROP_BLOB)
+       if (drm_property_type_is(prop, DRM_MODE_PROP_BLOB))
                dump_blob(dev, value);
+       else if (drm_property_type_is(prop, DRM_MODE_PROP_SIGNED_RANGE))
+               printf(" %"PRId64"\n", value);
        else
                printf(" %"PRIu64"\n", value);
+
+       if (strcmp(prop->name, "IN_FORMATS") == 0)
+               dump_in_formats(dev, value);
 }
 
 static void dump_connectors(struct device *dev)
@@ -347,18 +425,18 @@ static void dump_connectors(struct device *dev)
        int i, j;
 
        printf("Connectors:\n");
-       printf("id\tencoder\tstatus\t\ttype\tsize (mm)\tmodes\tencoders\n");
+       printf("id\tencoder\tstatus\t\tname\t\tsize (mm)\tmodes\tencoders\n");
        for (i = 0; i < dev->resources->res->count_connectors; i++) {
                struct connector *_connector = &dev->resources->connectors[i];
                drmModeConnector *connector = _connector->connector;
                if (!connector)
                        continue;
 
-               printf("%d\t%d\t%s\t%s\t%dx%d\t\t%d\t",
+               printf("%d\t%d\t%s\t%-15s\t%dx%d\t\t%d\t",
                       connector->connector_id,
                       connector->encoder_id,
-                      connector_status_str(connector->connection),
-                      connector_type_str(connector->connector_type),
+                      util_lookup_connector_status_name(connector->connection),
+                      _connector->name,
                       connector->mmWidth, connector->mmHeight,
                       connector->count_modes);
 
@@ -464,7 +542,7 @@ static void dump_planes(struct device *dev)
 
                printf("  formats:");
                for (j = 0; j < ovr->count_formats; j++)
-                       printf(" %4.4s", (char *)&ovr->formats[j]);
+                       dump_fourcc(ovr->formats[j]);
                printf("\n");
 
                if (plane->props) {
@@ -484,12 +562,13 @@ static void dump_planes(struct device *dev)
 
 static void free_resources(struct resources *res)
 {
+       int i;
+
        if (!res)
                return;
 
 #define free_resource(_res, __res, type, Type)                                 \
        do {                                                                    \
-               int i;                                                          \
                if (!(_res)->type##s)                                           \
                        break;                                                  \
                for (i = 0; i < (int)(_res)->__res->count_##type##s; ++i) {     \
@@ -502,7 +581,6 @@ static void free_resources(struct resources *res)
 
 #define free_properties(_res, __res, type)                                     \
        do {                                                                    \
-               int i;                                                          \
                for (i = 0; i < (int)(_res)->__res->count_##type##s; ++i) {     \
                        drmModeFreeObjectProperties(res->type##s[i].props);     \
                        free(res->type##s[i].props_info);                       \
@@ -514,6 +592,10 @@ static void free_resources(struct resources *res)
 
                free_resource(res, res, crtc, Crtc);
                free_resource(res, res, encoder, Encoder);
+
+               for (i = 0; i < res->res->count_connectors; i++)
+                       free(res->connectors[i].name);
+
                free_resource(res, res, connector, Connector);
                free_resource(res, res, fb, FB);
 
@@ -536,11 +618,11 @@ static struct resources *get_resources(struct device *dev)
        struct resources *res;
        int i;
 
-       res = malloc(sizeof *res);
+       res = calloc(1, sizeof(*res));
        if (res == 0)
                return NULL;
 
-       memset(res, 0, sizeof *res);
+       drmSetClientCap(dev->fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1);
 
        res->res = drmModeGetResources(dev->fd);
        if (!res->res) {
@@ -549,22 +631,16 @@ static struct resources *get_resources(struct device *dev)
                goto error;
        }
 
-       res->crtcs = malloc(res->res->count_crtcs * sizeof *res->crtcs);
-       res->encoders = malloc(res->res->count_encoders * sizeof *res->encoders);
-       res->connectors = malloc(res->res->count_connectors * sizeof *res->connectors);
-       res->fbs = malloc(res->res->count_fbs * sizeof *res->fbs);
+       res->crtcs = calloc(res->res->count_crtcs, sizeof(*res->crtcs));
+       res->encoders = calloc(res->res->count_encoders, sizeof(*res->encoders));
+       res->connectors = calloc(res->res->count_connectors, sizeof(*res->connectors));
+       res->fbs = calloc(res->res->count_fbs, sizeof(*res->fbs));
 
        if (!res->crtcs || !res->encoders || !res->connectors || !res->fbs)
                goto error;
 
-       memset(res->crtcs , 0, res->res->count_crtcs * sizeof *res->crtcs);
-       memset(res->encoders, 0, res->res->count_encoders * sizeof *res->encoders);
-       memset(res->connectors, 0, res->res->count_connectors * sizeof *res->connectors);
-       memset(res->fbs, 0, res->res->count_fbs * sizeof *res->fbs);
-
 #define get_resource(_res, __res, type, Type)                                  \
        do {                                                                    \
-               int i;                                                          \
                for (i = 0; i < (int)(_res)->__res->count_##type##s; ++i) {     \
                        (_res)->type##s[i].type =                               \
                                drmModeGet##Type(dev->fd, (_res)->__res->type##s[i]); \
@@ -580,9 +656,21 @@ static struct resources *get_resources(struct device *dev)
        get_resource(res, res, connector, Connector);
        get_resource(res, res, fb, FB);
 
+       /* Set the name of all connectors based on the type name and the per-type ID. */
+       for (i = 0; i < res->res->count_connectors; i++) {
+               struct connector *connector = &res->connectors[i];
+               drmModeConnector *conn = connector->connector;
+               int num;
+
+               num = asprintf(&connector->name, "%s-%u",
+                        util_lookup_connector_type_name(conn->connector_type),
+                        conn->connector_type_id);
+               if (num < 0)
+                       goto error;
+       }
+
 #define get_properties(_res, __res, type, Type)                                        \
        do {                                                                    \
-               int i;                                                          \
                for (i = 0; i < (int)(_res)->__res->count_##type##s; ++i) {     \
                        struct type *obj = &res->type##s[i];                    \
                        unsigned int j;                                         \
@@ -596,8 +684,8 @@ static struct resources *get_resources(struct device *dev)
                                        strerror(errno));                       \
                                continue;                                       \
                        }                                                       \
-                       obj->props_info = malloc(obj->props->count_props *      \
-                                                sizeof *obj->props_info);      \
+                       obj->props_info = calloc(obj->props->count_props,       \
+                                                sizeof(*obj->props_info));     \
                        if (!obj->props_info)                                   \
                                continue;                                       \
                        for (j = 0; j < obj->props->count_props; ++j)           \
@@ -619,12 +707,10 @@ static struct resources *get_resources(struct device *dev)
                return res;
        }
 
-       res->planes = malloc(res->plane_res->count_planes * sizeof *res->planes);
+       res->planes = calloc(res->plane_res->count_planes, sizeof(*res->planes));
        if (!res->planes)
                goto error;
 
-       memset(res->planes, 0, res->plane_res->count_planes * sizeof *res->planes);
-
        get_resource(res, plane_res, plane, Plane);
        get_properties(res, plane_res, plane, PLANE);
 
@@ -648,6 +734,21 @@ static int get_crtc_index(struct device *dev, uint32_t id)
        return -1;
 }
 
+static drmModeConnector *get_connector_by_name(struct device *dev, const char *name)
+{
+       struct connector *connector;
+       int i;
+
+       for (i = 0; i < dev->resources->res->count_connectors; i++) {
+               connector = &dev->resources->connectors[i];
+
+               if (strcmp(connector->name, name) == 0)
+                       return connector->connector;
+       }
+
+       return NULL;
+}
+
 static drmModeConnector *get_connector_by_id(struct device *dev, uint32_t id)
 {
        drmModeConnector *connector;
@@ -688,11 +789,13 @@ static drmModeEncoder *get_encoder_by_id(struct device *dev, uint32_t id)
  * can bind it with a free crtc.
  */
 struct pipe_arg {
+       const char **cons;
        uint32_t *con_ids;
        unsigned int num_cons;
        uint32_t crtc_id;
        char mode_str[64];
        char format_str[5];
+       unsigned int vrefresh;
        unsigned int fourcc;
        drmModeModeInfo *mode;
        struct crtc *crtc;
@@ -703,17 +806,23 @@ struct pipe_arg {
 };
 
 struct plane_arg {
+       uint32_t plane_id;  /* the id of plane to use */
        uint32_t crtc_id;  /* the id of CRTC to bind to */
        bool has_position;
        int32_t x, y;
        uint32_t w, h;
+       double scale;
        unsigned int fb_id;
+       unsigned int old_fb_id;
+       struct bo *bo;
+       struct bo *old_bo;
        char format_str[5]; /* need to leave room for terminating \0 */
        unsigned int fourcc;
 };
 
 static drmModeModeInfo *
-connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str)
+connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str,
+        const unsigned int vrefresh)
 {
        drmModeConnector *connector;
        drmModeModeInfo *mode;
@@ -725,8 +834,16 @@ connector_find_mode(struct device *dev, uint32_t con_id, const char *mode_str)
 
        for (i = 0; i < connector->count_modes; i++) {
                mode = &connector->modes[i];
-               if (!strcmp(mode->name, mode_str))
-                       return mode;
+               if (!strcmp(mode->name, mode_str)) {
+                       /* If the vertical refresh frequency is not specified then return the
+                        * first mode that match with the name. Else, return the mode that match
+                        * the name and the specified vertical refresh frequency.
+                        */
+                       if (vrefresh == 0)
+                               return mode;
+                       else if (mode->vrefresh == vrefresh)
+                               return mode;
+               }
        }
 
        return NULL;
@@ -788,11 +905,11 @@ static int pipe_find_crtc_and_mode(struct device *dev, struct pipe_arg *pipe)
 
        for (i = 0; i < (int)pipe->num_cons; i++) {
                mode = connector_find_mode(dev, pipe->con_ids[i],
-                                          pipe->mode_str);
+                                          pipe->mode_str, pipe->vrefresh);
                if (mode == NULL) {
                        fprintf(stderr,
-                               "failed to find mode \"%s\" for connector %u\n",
-                               pipe->mode_str, pipe->con_ids[i]);
+                               "failed to find mode \"%s\" for connector %s\n",
+                               pipe->mode_str, pipe->cons[i]);
                        return -EINVAL;
                }
        }
@@ -834,9 +951,10 @@ struct property_arg {
        char name[DRM_PROP_NAME_LEN+1];
        uint32_t prop_id;
        uint64_t value;
+       bool optional;
 };
 
-static void set_property(struct device *dev, struct property_arg *p)
+static bool set_property(struct device *dev, struct property_arg *p)
 {
        drmModeObjectProperties *props = NULL;
        drmModePropertyRes **props_info = NULL;
@@ -868,13 +986,13 @@ static void set_property(struct device *dev, struct property_arg *p)
        if (p->obj_type == 0) {
                fprintf(stderr, "Object %i not found, can't set property\n",
                        p->obj_id);
-                       return;
+               return false;
        }
 
        if (!props) {
                fprintf(stderr, "%s %i has no properties\n",
                        obj_type, p->obj_id);
-               return;
+               return false;
        }
 
        for (i = 0; i < (int)props->count_props; ++i) {
@@ -885,18 +1003,25 @@ static void set_property(struct device *dev, struct property_arg *p)
        }
 
        if (i == (int)props->count_props) {
-               fprintf(stderr, "%s %i has no %s property\n",
-                       obj_type, p->obj_id, p->name);
-               return;
+               if (!p->optional)
+                       fprintf(stderr, "%s %i has no %s property\n",
+                               obj_type, p->obj_id, p->name);
+               return false;
        }
 
        p->prop_id = props->props[i];
 
-       ret = drmModeObjectSetProperty(dev->fd, p->obj_id, p->obj_type,
-                                      p->prop_id, p->value);
+       if (!dev->use_atomic)
+               ret = drmModeObjectSetProperty(dev->fd, p->obj_id, p->obj_type,
+                                                                          p->prop_id, p->value);
+       else
+               ret = drmModeAtomicAddProperty(dev->req, p->obj_id, p->prop_id, p->value);
+
        if (ret < 0)
                fprintf(stderr, "failed to set %s %i property %s to %" PRIu64 ": %s\n",
                        obj_type, p->obj_id, p->name, p->value, strerror(errno));
+
+       return true;
 }
 
 /* -------------------------------------------------------------------------- */
@@ -930,12 +1055,161 @@ page_flip_handler(int fd, unsigned int frame,
        }
 }
 
+static bool format_support(const drmModePlanePtr ovr, uint32_t fmt)
+{
+       unsigned int i;
+
+       for (i = 0; i < ovr->count_formats; ++i) {
+               if (ovr->formats[i] == fmt)
+                       return true;
+       }
+
+       return false;
+}
+
+static void add_property(struct device *dev, uint32_t obj_id,
+                              const char *name, uint64_t value)
+{
+       struct property_arg p;
+
+       p.obj_id = obj_id;
+       strcpy(p.name, name);
+       p.value = value;
+
+       set_property(dev, &p);
+}
+
+static bool add_property_optional(struct device *dev, uint32_t obj_id,
+                                 const char *name, uint64_t value)
+{
+       struct property_arg p;
+
+       p.obj_id = obj_id;
+       strcpy(p.name, name);
+       p.value = value;
+       p.optional = true;
+
+       return set_property(dev, &p);
+}
+
+static void set_gamma(struct device *dev, unsigned crtc_id, unsigned fourcc)
+{
+       unsigned blob_id = 0;
+       /* TODO: support 1024-sized LUTs, when the use-case arises */
+       struct drm_color_lut gamma_lut[256];
+       int i, ret;
+
+       if (fourcc == DRM_FORMAT_C8) {
+               /* TODO: Add C8 support for more patterns */
+               util_smpte_c8_gamma(256, gamma_lut);
+               drmModeCreatePropertyBlob(dev->fd, gamma_lut, sizeof(gamma_lut), &blob_id);
+       } else {
+               for (i = 0; i < 256; i++) {
+                       gamma_lut[i].red =
+                       gamma_lut[i].green =
+                       gamma_lut[i].blue = i << 8;
+               }
+       }
+
+       add_property_optional(dev, crtc_id, "DEGAMMA_LUT", 0);
+       add_property_optional(dev, crtc_id, "CTM", 0);
+       if (!add_property_optional(dev, crtc_id, "GAMMA_LUT", blob_id)) {
+               uint16_t r[256], g[256], b[256];
+
+               for (i = 0; i < 256; i++) {
+                       r[i] = gamma_lut[i].red;
+                       g[i] = gamma_lut[i].green;
+                       b[i] = gamma_lut[i].blue;
+               }
+
+               ret = drmModeCrtcSetGamma(dev->fd, crtc_id, 256, r, g, b);
+               if (ret)
+                       fprintf(stderr, "failed to set gamma: %s\n", strerror(errno));
+       }
+}
+
+static int atomic_set_plane(struct device *dev, struct plane_arg *p,
+                                                       int pattern, bool update)
+{
+       uint32_t handles[4] = {0}, pitches[4] = {0}, offsets[4] = {0};
+       struct bo *plane_bo;
+       int crtc_x, crtc_y, crtc_w, crtc_h;
+       struct crtc *crtc = NULL;
+       unsigned int i;
+       unsigned int old_fb_id;
+
+       /* Find an unused plane which can be connected to our CRTC. Find the
+        * CRTC index first, then iterate over available planes.
+        */
+       for (i = 0; i < (unsigned int)dev->resources->res->count_crtcs; i++) {
+               if (p->crtc_id == dev->resources->res->crtcs[i]) {
+                       crtc = &dev->resources->crtcs[i];
+                       break;
+               }
+       }
+
+       if (!crtc) {
+               fprintf(stderr, "CRTC %u not found\n", p->crtc_id);
+               return -1;
+       }
+
+       if (!update)
+               fprintf(stderr, "testing %dx%d@%s on plane %u, crtc %u\n",
+                       p->w, p->h, p->format_str, p->plane_id, p->crtc_id);
+
+       plane_bo = p->old_bo;
+       p->old_bo = p->bo;
+
+       if (!plane_bo) {
+               plane_bo = bo_create(dev->fd, p->fourcc, p->w, p->h,
+                                    handles, pitches, offsets, pattern);
+
+               if (plane_bo == NULL)
+                       return -1;
+
+               if (drmModeAddFB2(dev->fd, p->w, p->h, p->fourcc,
+                       handles, pitches, offsets, &p->fb_id, 0)) {
+                       fprintf(stderr, "failed to add fb: %s\n", strerror(errno));
+                       return -1;
+               }
+       }
+
+       p->bo = plane_bo;
+
+       old_fb_id = p->fb_id;
+       p->old_fb_id = old_fb_id;
+
+       crtc_w = p->w * p->scale;
+       crtc_h = p->h * p->scale;
+       if (!p->has_position) {
+               /* Default to the middle of the screen */
+               crtc_x = (crtc->mode->hdisplay - crtc_w) / 2;
+               crtc_y = (crtc->mode->vdisplay - crtc_h) / 2;
+       } else {
+               crtc_x = p->x;
+               crtc_y = p->y;
+       }
+
+       add_property(dev, p->plane_id, "FB_ID", p->fb_id);
+       add_property(dev, p->plane_id, "CRTC_ID", p->crtc_id);
+       add_property(dev, p->plane_id, "SRC_X", 0);
+       add_property(dev, p->plane_id, "SRC_Y", 0);
+       add_property(dev, p->plane_id, "SRC_W", p->w << 16);
+       add_property(dev, p->plane_id, "SRC_H", p->h << 16);
+       add_property(dev, p->plane_id, "CRTC_X", crtc_x);
+       add_property(dev, p->plane_id, "CRTC_Y", crtc_y);
+       add_property(dev, p->plane_id, "CRTC_W", crtc_w);
+       add_property(dev, p->plane_id, "CRTC_H", crtc_h);
+
+       return 0;
+}
+
 static int set_plane(struct device *dev, struct plane_arg *p)
 {
        drmModePlane *ovr;
-       uint32_t handles[4], pitches[4], offsets[4] = {0}; /* we only use [0] */
-       uint32_t plane_id = 0;
-       struct kms_bo *plane_bo;
+       uint32_t handles[4] = {0}, pitches[4] = {0}, offsets[4] = {0};
+       uint32_t plane_id;
+       struct bo *plane_bo;
        uint32_t plane_flags = 0;
        int crtc_x, crtc_y, crtc_w, crtc_h;
        struct crtc *crtc = NULL;
@@ -958,16 +1232,27 @@ static int set_plane(struct device *dev, struct plane_arg *p)
                return -1;
        }
 
-       for (i = 0; i < dev->resources->plane_res->count_planes && !plane_id; i++) {
+       plane_id = p->plane_id;
+
+       for (i = 0; i < dev->resources->plane_res->count_planes; i++) {
                ovr = dev->resources->planes[i].plane;
                if (!ovr)
                        continue;
 
-               if ((ovr->possible_crtcs & (1 << pipe)) && !ovr->crtc_id)
+               if (plane_id && plane_id != ovr->plane_id)
+                       continue;
+
+               if (!format_support(ovr, p->fourcc))
+                       continue;
+
+               if ((ovr->possible_crtcs & (1 << pipe)) &&
+                   (ovr->crtc_id == 0 || ovr->crtc_id == p->crtc_id)) {
                        plane_id = ovr->plane_id;
+                       break;
+               }
        }
 
-       if (!plane_id) {
+       if (i == dev->resources->plane_res->count_planes) {
                fprintf(stderr, "no unused plane available for CRTC %u\n",
                        crtc->crtc->crtc_id);
                return -1;
@@ -976,11 +1261,13 @@ static int set_plane(struct device *dev, struct plane_arg *p)
        fprintf(stderr, "testing %dx%d@%s overlay plane %u\n",
                p->w, p->h, p->format_str, plane_id);
 
-       plane_bo = create_test_buffer(dev->kms, p->fourcc, p->w, p->h, handles,
-                                     pitches, offsets, PATTERN_TILES);
+       plane_bo = bo_create(dev->fd, p->fourcc, p->w, p->h, handles,
+                            pitches, offsets, secondary_fill);
        if (plane_bo == NULL)
                return -1;
 
+       p->bo = plane_bo;
+
        /* just use single plane format for now.. */
        if (drmModeAddFB2(dev->fd, p->w, p->h, p->fourcc,
                        handles, pitches, offsets, &p->fb_id, plane_flags)) {
@@ -988,16 +1275,16 @@ static int set_plane(struct device *dev, struct plane_arg *p)
                return -1;
        }
 
+       crtc_w = p->w * p->scale;
+       crtc_h = p->h * p->scale;
        if (!p->has_position) {
                /* Default to the middle of the screen */
-               crtc_x = (crtc->mode->hdisplay - p->w) / 2;
-               crtc_y = (crtc->mode->vdisplay - p->h) / 2;
+               crtc_x = (crtc->mode->hdisplay - crtc_w) / 2;
+               crtc_y = (crtc->mode->vdisplay - crtc_h) / 2;
        } else {
                crtc_x = p->x;
                crtc_y = p->y;
        }
-       crtc_w = p->w;
-       crtc_h = p->h;
 
        /* note src coords (last 4 args) are in Q16 format */
        if (drmModeSetPlane(dev->fd, plane_id, crtc->crtc->crtc_id, p->fb_id,
@@ -1013,17 +1300,144 @@ static int set_plane(struct device *dev, struct plane_arg *p)
        return 0;
 }
 
+static void atomic_set_planes(struct device *dev, struct plane_arg *p,
+                             unsigned int count, bool update)
+{
+       unsigned int i, pattern = primary_fill;
+
+       /* set up planes */
+       for (i = 0; i < count; i++) {
+               if (i > 0)
+                       pattern = secondary_fill;
+               else
+                       set_gamma(dev, p[i].crtc_id, p[i].fourcc);
+
+               if (atomic_set_plane(dev, &p[i], pattern, update))
+                       return;
+       }
+}
+
+static void atomic_clear_planes(struct device *dev, struct plane_arg *p, unsigned int count)
+{
+       unsigned int i;
+
+       for (i = 0; i < count; i++) {
+               add_property(dev, p[i].plane_id, "FB_ID", 0);
+               add_property(dev, p[i].plane_id, "CRTC_ID", 0);
+               add_property(dev, p[i].plane_id, "SRC_X", 0);
+               add_property(dev, p[i].plane_id, "SRC_Y", 0);
+               add_property(dev, p[i].plane_id, "SRC_W", 0);
+               add_property(dev, p[i].plane_id, "SRC_H", 0);
+               add_property(dev, p[i].plane_id, "CRTC_X", 0);
+               add_property(dev, p[i].plane_id, "CRTC_Y", 0);
+               add_property(dev, p[i].plane_id, "CRTC_W", 0);
+               add_property(dev, p[i].plane_id, "CRTC_H", 0);
+       }
+}
+
+static void atomic_clear_FB(struct device *dev, struct plane_arg *p, unsigned int count)
+{
+       unsigned int i;
+
+       for (i = 0; i < count; i++) {
+               if (p[i].fb_id) {
+                       drmModeRmFB(dev->fd, p[i].fb_id);
+                       p[i].fb_id = 0;
+               }
+               if (p[i].old_fb_id) {
+                       drmModeRmFB(dev->fd, p[i].old_fb_id);
+                       p[i].old_fb_id = 0;
+               }
+               if (p[i].bo) {
+                       bo_destroy(p[i].bo);
+                       p[i].bo = NULL;
+               }
+               if (p[i].old_bo) {
+                       bo_destroy(p[i].old_bo);
+                       p[i].old_bo = NULL;
+               }
+
+       }
+}
+
+static void clear_planes(struct device *dev, struct plane_arg *p, unsigned int count)
+{
+       unsigned int i;
+
+       for (i = 0; i < count; i++) {
+               if (p[i].fb_id)
+                       drmModeRmFB(dev->fd, p[i].fb_id);
+               if (p[i].bo)
+                       bo_destroy(p[i].bo);
+       }
+}
+
+static void atomic_set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int count)
+{
+       unsigned int i;
+       unsigned int j;
+       int ret;
+
+       for (i = 0; i < count; i++) {
+               struct pipe_arg *pipe = &pipes[i];
+
+               ret = pipe_find_crtc_and_mode(dev, pipe);
+               if (ret < 0)
+                       continue;
+       }
+
+       for (i = 0; i < count; i++) {
+               struct pipe_arg *pipe = &pipes[i];
+               uint32_t blob_id;
+
+               if (pipe->mode == NULL)
+                       continue;
+
+               printf("setting mode %s-%dHz on connectors ",
+                      pipe->mode_str, pipe->mode->vrefresh);
+               for (j = 0; j < pipe->num_cons; ++j) {
+                       printf("%s, ", pipe->cons[j]);
+                       add_property(dev, pipe->con_ids[j], "CRTC_ID", pipe->crtc->crtc->crtc_id);
+               }
+               printf("crtc %d\n", pipe->crtc->crtc->crtc_id);
+
+               drmModeCreatePropertyBlob(dev->fd, pipe->mode, sizeof(*pipe->mode), &blob_id);
+               add_property(dev, pipe->crtc->crtc->crtc_id, "MODE_ID", blob_id);
+               add_property(dev, pipe->crtc->crtc->crtc_id, "ACTIVE", 1);
+       }
+}
+
+static void atomic_clear_mode(struct device *dev, struct pipe_arg *pipes, unsigned int count)
+{
+       unsigned int i;
+       unsigned int j;
+
+       for (i = 0; i < count; i++) {
+               struct pipe_arg *pipe = &pipes[i];
+
+               if (pipe->mode == NULL)
+                       continue;
+
+               for (j = 0; j < pipe->num_cons; ++j)
+                       add_property(dev, pipe->con_ids[j], "CRTC_ID",0);
+
+               add_property(dev, pipe->crtc->crtc->crtc_id, "MODE_ID", 0);
+               add_property(dev, pipe->crtc->crtc->crtc_id, "ACTIVE", 0);
+       }
+}
+
 static void set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int count)
 {
-       uint32_t handles[4], pitches[4], offsets[4] = {0}; /* we only use [0] */
+       uint32_t handles[4] = {0}, pitches[4] = {0}, offsets[4] = {0};
        unsigned int fb_id;
-       struct kms_bo *bo;
+       struct bo *bo;
        unsigned int i;
        unsigned int j;
        int ret, x;
 
        dev->mode.width = 0;
        dev->mode.height = 0;
+       dev->mode.fb_id = 0;
 
        for (i = 0; i < count; i++) {
                struct pipe_arg *pipe = &pipes[i];
@@ -1037,12 +1451,14 @@ static void set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int co
                        dev->mode.height = pipe->mode->vdisplay;
        }
 
-       bo = create_test_buffer(dev->kms, pipes[0].fourcc,
-                               dev->mode.width, dev->mode.height,
-                               handles, pitches, offsets, PATTERN_SMPTE);
+       bo = bo_create(dev->fd, pipes[0].fourcc, dev->mode.width,
+                      dev->mode.height, handles, pitches, offsets,
+                      primary_fill);
        if (bo == NULL)
                return;
 
+       dev->mode.bo = bo;
+
        ret = drmModeAddFB2(dev->fd, dev->mode.width, dev->mode.height,
                            pipes[0].fourcc, handles, pitches, offsets, &fb_id, 0);
        if (ret) {
@@ -1051,6 +1467,8 @@ static void set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int co
                return;
        }
 
+       dev->mode.fb_id = fb_id;
+
        x = 0;
        for (i = 0; i < count; i++) {
                struct pipe_arg *pipe = &pipes[i];
@@ -1058,10 +1476,10 @@ static void set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int co
                if (pipe->mode == NULL)
                        continue;
 
-               printf("setting mode %s@%s on connectors ",
-                      pipe->mode_str, pipe->format_str);
+               printf("setting mode %s-%dHz@%s on connectors ",
+                      pipe->mode_str, pipe->mode->vrefresh, pipe->format_str);
                for (j = 0; j < pipe->num_cons; ++j)
-                       printf("%u, ", pipe->con_ids[j]);
+                       printf("%s, ", pipe->cons[j]);
                printf("crtc %d\n", pipe->crtc->crtc->crtc_id);
 
                ret = drmModeSetCrtc(dev->fd, pipe->crtc->crtc->crtc_id, fb_id,
@@ -1077,10 +1495,17 @@ static void set_mode(struct device *dev, struct pipe_arg *pipes, unsigned int co
                        fprintf(stderr, "failed to set mode: %s\n", strerror(errno));
                        return;
                }
+
+               set_gamma(dev, pipe->crtc->crtc->crtc_id, pipe->fourcc);
        }
+}
 
-       dev->mode.bo = bo;
-       dev->mode.fb_id = fb_id;
+static void clear_mode(struct device *dev)
+{
+       if (dev->mode.fb_id)
+               drmModeRmFB(dev->fd, dev->mode.fb_id);
+       if (dev->mode.bo)
+               bo_destroy(dev->mode.bo);
 }
 
 static void set_planes(struct device *dev, struct plane_arg *p, unsigned int count)
@@ -1093,18 +1518,63 @@ static void set_planes(struct device *dev, struct plane_arg *p, unsigned int cou
                        return;
 }
 
+static void set_cursors(struct device *dev, struct pipe_arg *pipes, unsigned int count)
+{
+       uint32_t handles[4] = {0}, pitches[4] = {0}, offsets[4] = {0};
+       struct bo *bo;
+       unsigned int i;
+       int ret;
+
+       /* maybe make cursor width/height configurable some day */
+       uint32_t cw = 64;
+       uint32_t ch = 64;
+
+       /* create cursor bo.. just using PATTERN_PLAIN as it has
+        * translucent alpha
+        */
+       bo = bo_create(dev->fd, DRM_FORMAT_ARGB8888, cw, ch, handles, pitches,
+                      offsets, UTIL_PATTERN_PLAIN);
+       if (bo == NULL)
+               return;
+
+       dev->mode.cursor_bo = bo;
+
+       for (i = 0; i < count; i++) {
+               struct pipe_arg *pipe = &pipes[i];
+               ret = cursor_init(dev->fd, handles[0],
+                               pipe->crtc->crtc->crtc_id,
+                               pipe->mode->hdisplay, pipe->mode->vdisplay,
+                               cw, ch);
+               if (ret) {
+                       fprintf(stderr, "failed to init cursor for CRTC[%u]\n",
+                                       pipe->crtc_id);
+                       return;
+               }
+       }
+
+       cursor_start();
+}
+
+static void clear_cursors(struct device *dev)
+{
+       cursor_stop();
+
+       if (dev->mode.cursor_bo)
+               bo_destroy(dev->mode.cursor_bo);
+}
+
 static void test_page_flip(struct device *dev, struct pipe_arg *pipes, unsigned int count)
 {
-       uint32_t handles[4], pitches[4], offsets[4] = {0}; /* we only use [0] */
+       uint32_t handles[4] = {0}, pitches[4] = {0}, offsets[4] = {0};
        unsigned int other_fb_id;
-       struct kms_bo *other_bo;
+       struct bo *other_bo;
        drmEventContext evctx;
        unsigned int i;
        int ret;
 
-       other_bo = create_test_buffer(dev->kms, pipes[0].fourcc,
-                                     dev->mode.width, dev->mode.height,
-                                     handles, pitches, offsets, PATTERN_PLAIN);
+       other_bo = bo_create(dev->fd, pipes[0].fourcc, dev->mode.width,
+                            dev->mode.height, handles, pitches, offsets,
+                            UTIL_PATTERN_PLAIN);
        if (other_bo == NULL)
                return;
 
@@ -1113,7 +1583,7 @@ static void test_page_flip(struct device *dev, struct pipe_arg *pipes, unsigned
                            &other_fb_id, 0);
        if (ret) {
                fprintf(stderr, "failed to add fb: %s\n", strerror(errno));
-               return;
+               goto err;
        }
 
        for (i = 0; i < count; i++) {
@@ -1127,7 +1597,7 @@ static void test_page_flip(struct device *dev, struct pipe_arg *pipes, unsigned
                                      pipe);
                if (ret) {
                        fprintf(stderr, "failed to page flip: %s\n", strerror(errno));
-                       return;
+                       goto err_rmfb;
                }
                gettimeofday(&pipe->start, NULL);
                pipe->swap_count = 0;
@@ -1140,7 +1610,7 @@ static void test_page_flip(struct device *dev, struct pipe_arg *pipes, unsigned
        evctx.version = DRM_EVENT_CONTEXT_VERSION;
        evctx.vblank_handler = NULL;
        evctx.page_flip_handler = page_flip_handler;
-       
+
        while (1) {
 #if 0
                struct pollfd pfd[2];
@@ -1160,7 +1630,6 @@ static void test_page_flip(struct device *dev, struct pipe_arg *pipes, unsigned
 #else
                struct timeval timeout = { .tv_sec = 3, .tv_usec = 0 };
                fd_set fds;
-               int ret;
 
                FD_ZERO(&fds);
                FD_SET(0, &fds);
@@ -1179,7 +1648,10 @@ static void test_page_flip(struct device *dev, struct pipe_arg *pipes, unsigned
                drmHandleEvent(dev->fd, &evctx);
        }
 
-       kms_bo_destroy(&other_bo);
+err_rmfb:
+       drmModeRmFB(dev->fd, other_fb_id);
+err:
+       bo_destroy(other_bo);
 }
 
 #define min(a, b)      ((a) < (b) ? (a) : (b))
@@ -1191,23 +1663,30 @@ static int parse_connector(struct pipe_arg *pipe, const char *arg)
        const char *p;
        char *endp;
 
+       pipe->vrefresh = 0;
        pipe->crtc_id = (uint32_t)-1;
        strcpy(pipe->format_str, "XR24");
 
        /* Count the number of connectors and allocate them. */
        pipe->num_cons = 1;
-       for (p = arg; isdigit(*p) || *p == ','; ++p) {
+       for (p = arg; *p && *p != ':' && *p != '@'; ++p) {
                if (*p == ',')
                        pipe->num_cons++;
        }
 
-       pipe->con_ids = malloc(pipe->num_cons * sizeof *pipe->con_ids);
-       if (pipe->con_ids == NULL)
+       pipe->con_ids = calloc(pipe->num_cons, sizeof(*pipe->con_ids));
+       pipe->cons = calloc(pipe->num_cons, sizeof(*pipe->cons));
+       if (pipe->con_ids == NULL || pipe->cons == NULL)
                return -1;
 
        /* Parse the connectors. */
        for (i = 0, p = arg; i < pipe->num_cons; ++i, p = endp + 1) {
-               pipe->con_ids[i] = strtoul(p, &endp, 10);
+               endp = strpbrk(p, ",@:");
+               if (!endp)
+                       break;
+
+               pipe->cons[i] = strndup(p, endp - p);
+
                if (*endp != ',')
                        break;
        }
@@ -1225,17 +1704,25 @@ static int parse_connector(struct pipe_arg *pipe, const char *arg)
 
        arg = endp + 1;
 
-       p = strchrnul(arg, '@');
+       /* Search for the vertical refresh or the format. */
+       p = strpbrk(arg, "-@");
+       if (p == NULL)
+               p = arg + strlen(arg);
        len = min(sizeof pipe->mode_str - 1, (unsigned int)(p - arg));
        strncpy(pipe->mode_str, arg, len);
        pipe->mode_str[len] = '\0';
 
+       if (*p == '-') {
+               pipe->vrefresh = strtoul(p + 1, &endp, 10);
+               p = endp;
+       }
+
        if (*p == '@') {
                strncpy(pipe->format_str, p + 1, 4);
                pipe->format_str[4] = '\0';
        }
 
-       pipe->fourcc = format_fourcc(pipe->format_str);
+       pipe->fourcc = util_format_fourcc(pipe->format_str);
        if (pipe->fourcc == 0)  {
                fprintf(stderr, "unknown format %s\n", pipe->format_str);
                return -1;
@@ -1248,8 +1735,11 @@ static int parse_plane(struct plane_arg *plane, const char *p)
 {
        char *end;
 
-       memset(plane, 0, sizeof *plane);
+       plane->plane_id = strtoul(p, &end, 10);
+       if (*end != '@')
+               return -EINVAL;
 
+       p = end + 1;
        plane->crtc_id = strtoul(p, &end, 10);
        if (*end != ':')
                return -EINVAL;
@@ -1271,17 +1761,23 @@ static int parse_plane(struct plane_arg *plane, const char *p)
                plane->has_position = true;
        }
 
-       if (*end == '@') {
+       if (*end == '*') {
                p = end + 1;
-               if (strlen(p) != 4)
+               plane->scale = strtod(p, &end);
+               if (plane->scale <= 0.0)
                        return -EINVAL;
+       } else {
+               plane->scale = 1.0;
+       }
 
-               strcpy(plane->format_str, p);
+       if (*end == '@') {
+               strncpy(plane->format_str, end + 1, 4);
+               plane->format_str[4] = '\0';
        } else {
                strcpy(plane->format_str, "XR24");
        }
 
-       plane->fourcc = format_fourcc(plane->format_str);
+       plane->fourcc = util_format_fourcc(plane->format_str);
        if (plane->fourcc == 0) {
                fprintf(stderr, "unknown format %s\n", plane->format_str);
                return -EINVAL;
@@ -1301,9 +1797,21 @@ static int parse_property(struct property_arg *p, const char *arg)
        return 0;
 }
 
+static void parse_fill_patterns(char *arg)
+{
+       char *fill = strtok(arg, ",");
+       if (!fill)
+               return;
+       primary_fill = util_pattern_enum(fill);
+       fill = strtok(NULL, ",");
+       if (!fill)
+               return;
+       secondary_fill = util_pattern_enum(fill);
+}
+
 static void usage(char *name)
 {
-       fprintf(stderr, "usage: %s [-cdefMmPpsvw]\n", name);
+       fprintf(stderr, "usage: %s [-acDdefMPpsCvw]\n", name);
 
        fprintf(stderr, "\n Query options:\n\n");
        fprintf(stderr, "\t-c\tlist connectors\n");
@@ -1312,14 +1820,18 @@ static void usage(char *name)
        fprintf(stderr, "\t-p\tlist CRTCs and planes (pipes)\n");
 
        fprintf(stderr, "\n Test options:\n\n");
-       fprintf(stderr, "\t-P <crtc_id>:<w>x<h>[+<x>+<y>][@<format>]\tset a plane\n");
-       fprintf(stderr, "\t-s <connector_id>[,<connector_id>][@<crtc_id>]:<mode>[@<format>]\tset a mode\n");
+       fprintf(stderr, "\t-P <plane_id>@<crtc_id>:<w>x<h>[+<x>+<y>][*<scale>][@<format>]\tset a plane\n");
+       fprintf(stderr, "\t-s <connector_id>[,<connector_id>][@<crtc_id>]:<mode>[-<vrefresh>][@<format>]\tset a mode\n");
+       fprintf(stderr, "\t-C\ttest hw cursor\n");
        fprintf(stderr, "\t-v\ttest vsynced page flipping\n");
        fprintf(stderr, "\t-w <obj_id>:<prop_name>:<value>\tset property\n");
+       fprintf(stderr, "\t-a \tuse atomic API\n");
+       fprintf(stderr, "\t-F pattern1,pattern2\tspecify fill patterns\n");
 
        fprintf(stderr, "\n Generic options:\n\n");
        fprintf(stderr, "\t-d\tdrop master after mode set\n");
        fprintf(stderr, "\t-M module\tuse the given driver\n");
+       fprintf(stderr, "\t-D device\tuse the given device\n");
 
        fprintf(stderr, "\n\tDefault is to dump all info.\n");
        exit(0);
@@ -1346,7 +1858,39 @@ static int page_flipping_supported(void)
 #endif
 }
 
-static char optstr[] = "cdefM:P:ps:vw:";
+static int cursor_supported(void)
+{
+       /*FIXME: generic ioctl needed? */
+       return 1;
+}
+
+static int pipe_resolve_connectors(struct device *dev, struct pipe_arg *pipe)
+{
+       drmModeConnector *connector;
+       unsigned int i;
+       uint32_t id;
+       char *endp;
+
+       for (i = 0; i < pipe->num_cons; i++) {
+               id = strtoul(pipe->cons[i], &endp, 10);
+               if (endp == pipe->cons[i]) {
+                       connector = get_connector_by_name(dev, pipe->cons[i]);
+                       if (!connector) {
+                               fprintf(stderr, "no connector named '%s'\n",
+                                       pipe->cons[i]);
+                               return -ENODEV;
+                       }
+
+                       id = connector->connector_id;
+               }
+
+               pipe->con_ids[i] = id;
+       }
+
+       return 0;
+}
+
+static char optstr[] = "acdD:efF:M:P:ps:Cvw:";
 
 int main(int argc, char **argv)
 {
@@ -1356,10 +1900,12 @@ int main(int argc, char **argv)
        int encoders = 0, connectors = 0, crtcs = 0, planes = 0, framebuffers = 0;
        int drop_master = 0;
        int test_vsync = 0;
-       const char *modules[] = { "i915", "radeon", "nouveau", "vmwgfx", "omapdrm", "exynos", "tilcdc", "msm" };
+       int test_cursor = 0;
+       int use_atomic = 0;
+       char *device = NULL;
        char *module = NULL;
        unsigned int i;
-       int count = 0, plane_count = 0;
+       unsigned int count = 0, plane_count = 0;
        unsigned int prop_count = 0;
        struct pipe_arg *pipe_args = NULL;
        struct plane_arg *plane_args = NULL;
@@ -1374,9 +1920,16 @@ int main(int argc, char **argv)
                args++;
 
                switch (c) {
+               case 'a':
+                       use_atomic = 1;
+                       break;
                case 'c':
                        connectors = 1;
                        break;
+               case 'D':
+                       device = optarg;
+                       args--;
+                       break;
                case 'd':
                        drop_master = 1;
                        break;
@@ -1386,6 +1939,9 @@ int main(int argc, char **argv)
                case 'f':
                        framebuffers = 1;
                        break;
+               case 'F':
+                       parse_fill_patterns(optarg);
+                       break;
                case 'M':
                        module = optarg;
                        /* Preserve the default behaviour of dumping all information. */
@@ -1398,6 +1954,7 @@ int main(int argc, char **argv)
                                fprintf(stderr, "memory allocation failed\n");
                                return 1;
                        }
+                       memset(&plane_args[plane_count], 0, sizeof(*plane_args));
 
                        if (parse_plane(&plane_args[plane_count], optarg) < 0)
                                usage(argv[0]);
@@ -1415,11 +1972,15 @@ int main(int argc, char **argv)
                                fprintf(stderr, "memory allocation failed\n");
                                return 1;
                        }
+                       memset(&pipe_args[count], 0, sizeof(*pipe_args));
 
                        if (parse_connector(&pipe_args[count], optarg) < 0)
                                usage(argv[0]);
 
-                       count++;                                      
+                       count++;
+                       break;
+               case 'C':
+                       test_cursor = 1;
                        break;
                case 'v':
                        test_vsync = 1;
@@ -1431,6 +1992,7 @@ int main(int argc, char **argv)
                                fprintf(stderr, "memory allocation failed\n");
                                return 1;
                        }
+                       memset(&prop_args[prop_count], 0, sizeof(*prop_args));
 
                        if (parse_property(&prop_args[prop_count], optarg) < 0)
                                usage(argv[0]);
@@ -1443,33 +2005,22 @@ int main(int argc, char **argv)
                }
        }
 
-       if (!args)
+       if (!args || (args == 1 && use_atomic))
                encoders = connectors = crtcs = planes = framebuffers = 1;
 
-       if (module) {
-               dev.fd = drmOpen(module, NULL);
-               if (dev.fd < 0) {
-                       fprintf(stderr, "failed to open device '%s'.\n", module);
-                       return 1;
-               }
-       } else {
-               for (i = 0; i < ARRAY_SIZE(modules); i++) {
-                       printf("trying to open device '%s'...", modules[i]);
-                       dev.fd = drmOpen(modules[i], NULL);
-                       if (dev.fd < 0) {
-                               printf("failed.\n");
-                       } else {
-                               printf("success.\n");
-                               break;
-                       }
-               }
+       dev.fd = util_open(device, module);
+       if (dev.fd < 0)
+               return -1;
 
-               if (dev.fd < 0) {
-                       fprintf(stderr, "no device found.\n");
-                       return 1;
-               }
+       ret = drmSetClientCap(dev.fd, DRM_CLIENT_CAP_ATOMIC, 1);
+       if (ret && use_atomic) {
+               fprintf(stderr, "no atomic modesetting support: %s\n", strerror(errno));
+               drmClose(dev.fd);
+               return -1;
        }
 
+       dev.use_atomic = use_atomic;
+
        if (test_vsync && !page_flipping_supported()) {
                fprintf(stderr, "page flipping not supported by drm.\n");
                return -1;
@@ -1480,12 +2031,25 @@ int main(int argc, char **argv)
                return -1;
        }
 
+       if (test_cursor && !cursor_supported()) {
+               fprintf(stderr, "hw cursor not supported by drm.\n");
+               return -1;
+       }
+
        dev.resources = get_resources(&dev);
        if (!dev.resources) {
                drmClose(dev.fd);
                return 1;
        }
 
+       for (i = 0; i < count; i++) {
+               if (pipe_resolve_connectors(&dev, &pipe_args[i]) < 0) {
+                       free_resources(dev.resources);
+                       drmClose(dev.fd);
+                       return 1;
+               }
+       }
+
 #define dump_resource(dev, res) if (res) dump_##res(dev)
 
        dump_resource(&dev, encoders);
@@ -1497,30 +2061,111 @@ int main(int argc, char **argv)
        for (i = 0; i < prop_count; ++i)
                set_property(&dev, &prop_args[i]);
 
-       if (count || plane_count) {
-               ret = kms_create(dev.fd, &dev.kms);
-               if (ret) {
-                       fprintf(stderr, "failed to create kms driver: %s\n",
-                               strerror(-ret));
-                       return 1;
+       if (dev.use_atomic) {
+               dev.req = drmModeAtomicAlloc();
+
+               if (count && plane_count) {
+                       uint64_t cap = 0;
+
+                       ret = drmGetCap(dev.fd, DRM_CAP_DUMB_BUFFER, &cap);
+                       if (ret || cap == 0) {
+                               fprintf(stderr, "driver doesn't support the dumb buffer API\n");
+                               return 1;
+                       }
+
+                       atomic_set_mode(&dev, pipe_args, count);
+                       atomic_set_planes(&dev, plane_args, plane_count, false);
+
+                       ret = drmModeAtomicCommit(dev.fd, dev.req, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+                       if (ret) {
+                               fprintf(stderr, "Atomic Commit failed [1]\n");
+                               return 1;
+                       }
+
+                       gettimeofday(&pipe_args->start, NULL);
+                       pipe_args->swap_count = 0;
+
+                       while (test_vsync) {
+                               drmModeAtomicFree(dev.req);
+                               dev.req = drmModeAtomicAlloc();
+                               atomic_set_planes(&dev, plane_args, plane_count, true);
+
+                               ret = drmModeAtomicCommit(dev.fd, dev.req, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+                               if (ret) {
+                                       fprintf(stderr, "Atomic Commit failed [2]\n");
+                                       return 1;
+                               }
+
+                               pipe_args->swap_count++;
+                               if (pipe_args->swap_count == 60) {
+                                       struct timeval end;
+                                       double t;
+
+                                       gettimeofday(&end, NULL);
+                                       t = end.tv_sec + end.tv_usec * 1e-6 -
+                                   (pipe_args->start.tv_sec + pipe_args->start.tv_usec * 1e-6);
+                                       fprintf(stderr, "freq: %.02fHz\n", pipe_args->swap_count / t);
+                                       pipe_args->swap_count = 0;
+                                       pipe_args->start = end;
+                               }
+                       }
+
+                       if (drop_master)
+                               drmDropMaster(dev.fd);
+
+                       getchar();
+
+                       drmModeAtomicFree(dev.req);
+                       dev.req = drmModeAtomicAlloc();
+
+                       atomic_clear_mode(&dev, pipe_args, count);
+                       atomic_clear_planes(&dev, plane_args, plane_count);
+                       ret = drmModeAtomicCommit(dev.fd, dev.req, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+                       if (ret) {
+                               fprintf(stderr, "Atomic Commit failed\n");
+                               return 1;
+                       }
+
+                       atomic_clear_FB(&dev, plane_args, plane_count);
                }
 
-               if (count)
-                       set_mode(&dev, pipe_args, count);
+               drmModeAtomicFree(dev.req);
+       } else {
+               if (count || plane_count) {
+                       uint64_t cap = 0;
+
+                       ret = drmGetCap(dev.fd, DRM_CAP_DUMB_BUFFER, &cap);
+                       if (ret || cap == 0) {
+                               fprintf(stderr, "driver doesn't support the dumb buffer API\n");
+                               return 1;
+                       }
+
+                       if (count)
+                               set_mode(&dev, pipe_args, count);
+
+                       if (plane_count)
+                               set_planes(&dev, plane_args, plane_count);
+
+                       if (test_cursor)
+                               set_cursors(&dev, pipe_args, count);
 
-               if (plane_count)
-                       set_planes(&dev, plane_args, plane_count);
+                       if (test_vsync)
+                               test_page_flip(&dev, pipe_args, count);
 
-               if (test_vsync)
-                       test_page_flip(&dev, pipe_args, count);
+                       if (drop_master)
+                               drmDropMaster(dev.fd);
 
-               if (drop_master)
-                       drmDropMaster(dev.fd);
+                       getchar();
 
-               kms_bo_destroy(&dev.mode.bo);
-               kms_destroy(&dev.kms);
+                       if (test_cursor)
+                               clear_cursors(&dev);
 
-               getchar();
+                       if (plane_count)
+                               clear_planes(&dev, plane_args, plane_count);
+
+                       if (count)
+                               clear_mode(&dev);
+               }
        }
 
        free_resources(dev.resources);