X-Git-Url: http://git.osdn.net/view?a=blobdiff_plain;f=libcore%2Farchive%2Fsrc%2Ftest%2Fjava%2Forg%2Fapache%2Fharmony%2Farchive%2Ftests%2Fjava%2Futil%2Fjar%2FJarInputStreamTest.java;h=151eabc910fe6b25a7609c9fa99bfccc735be175;hb=05c0836f27bd73d74e2b47ee86cd925fc5548ebc;hp=64e0e1aa1a92abf46b2d8b814a6f53a976fa05d9;hpb=b8f2972e3ceef7e6bd5ae9763257dfae6fe06349;p=android-x86%2Fdalvik.git diff --git a/libcore/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarInputStreamTest.java b/libcore/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarInputStreamTest.java index 64e0e1aa1..151eabc91 100644 --- a/libcore/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarInputStreamTest.java +++ b/libcore/archive/src/test/java/org/apache/harmony/archive/tests/java/util/jar/JarInputStreamTest.java @@ -179,7 +179,6 @@ public class JarInputStreamTest extends junit.framework.TestCase { method = "getNextJarEntry", args = {} ) - @KnownFailure("IOException not thrown when using getNextJarEntry() after close().") public void test_getNextJarEntry_Ex() throws Exception { final Set desired = new HashSet(Arrays .asList(new String[] { @@ -280,25 +279,17 @@ public class JarInputStreamTest extends junit.framework.TestCase { .getURL("Modified_Manifest_MainAttributes.jar"); InputStream is = new URL(modJarName).openConnection().getInputStream(); JarInputStream jin = new JarInputStream(is, true); - ZipEntry zipEntry = null; - final int indexofDSA = 2; - final int totalEntries = 4; - int count = 0; - while (count == 0 || zipEntry != null) { - count++; - try { - zipEntry = jin.getNextEntry(); - if (count == indexofDSA + 1) { - fail("Should throw Security Exception"); - } - } catch (SecurityException e) { - if (count != indexofDSA + 1) { - throw e; - } - } + assertEquals("META-INF/TESTROOT.SF", jin.getNextEntry().getName()); + assertEquals("META-INF/TESTROOT.DSA", jin.getNextEntry().getName()); + try { + jin.getNextEntry(); + fail(); + } catch (SecurityException expected) { } - assertEquals(totalEntries + 2, count); + assertEquals("META-INF/", jin.getNextEntry().getName()); + assertEquals("Test.class", jin.getNextEntry().getName()); + assertNull(jin.getNextEntry()); jin.close(); } @@ -542,7 +533,6 @@ public class JarInputStreamTest extends junit.framework.TestCase { method = "close", args = {} ) - @KnownFailure("The behaviour is different from RI, but not neccessarily wrong. However a strange exception message is given anyway!") public void test_closeAfterException() throws Exception { File resources = Support_Resources.createTempFolder(); Support_Resources.copyFile(resources, null, "Broken_entry.jar"); @@ -555,7 +545,7 @@ public class JarInputStreamTest extends junit.framework.TestCase { } catch (ZipException ee) { // expected } - jis.close(); // Android throws exception here, but RI throws when getNextEntry/read/skip are called. + jis.close(); try { jis.getNextEntry(); fail("IOException expected");