OSDN Git Service

hwmon: (mlxreg-fan) Fix out of bounds read on array fan->pwm
authorColin Ian King <colin.king@canonical.com>
Mon, 20 Sep 2021 18:09:21 +0000 (19:09 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 12 Oct 2021 14:22:38 +0000 (07:22 -0700)
commit000cc5bc49aafc83a131bab2becf9922f5eec658
treeb867604686d9f1146ea8bb5aa412477f5280647c
parent3fbbfc27f95530fccbcfb3a742af0bce6c59f656
hwmon: (mlxreg-fan) Fix out of bounds read on array fan->pwm

Array fan->pwm[] is MLXREG_FAN_MAX_PWM elements in size, however the
for-loop has a off-by-one error causing index i to be out of range
causing an out of bounds read on the array. Fix this by replacing
the <= operator with < in the for-loop.

Addresses-Coverity: ("Out-of-bounds read")
Reported-by: Vadim Pasternak <vadimp@nvidia.com>
Fixes: 35edbaab3bbf ("hwmon: (mlxreg-fan) Extend driver to support multiply cooling devices")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210920180921.16246-1-colin.king@canonical.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/mlxreg-fan.c