OSDN Git Service

hw/dma/xilinx_axi: Use object_initialize_child for correct ref. counting
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Fri, 23 Aug 2019 14:32:48 +0000 (16:32 +0200)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 3 Sep 2019 15:20:34 +0000 (16:20 +0100)
commit00b0fd4883f0ef46c2af9578f1c51a2cdaab245f
tree48193f9f02858cefe1dd71d8c1b0b8a5f77d6e27
parenteaa9a87828c318e60428ef1531a1cc46626c23fe
hw/dma/xilinx_axi: Use object_initialize_child for correct ref. counting

As explained in commit aff39be0ed97:

  Both functions, object_initialize() and object_property_add_child()
  increase the reference counter of the new object, so one of the
  references has to be dropped afterwards to get the reference
  counting right. Otherwise the child object will not be properly
  cleaned up when the parent gets destroyed.
  Thus let's use now object_initialize_child() instead to get the
  reference counting here right.

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20190823143249.8096-6-philmd@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/dma/xilinx_axidma.c