OSDN Git Service

drm/vc4_validate: Remove VLA usage
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 13 Mar 2018 14:31:51 +0000 (09:31 -0500)
committerEric Anholt <eric@anholt.net>
Fri, 16 Mar 2018 22:51:52 +0000 (15:51 -0700)
commit0126b23c552c2bf9aa62a6cabce8c10e983ef436
tree00c1ccf452341ceb3c40a35b5490c8cd1acc84a4
parent2f0e9d804935970a4ce0f58dd046b41881bfd8f3
drm/vc4_validate: Remove VLA usage

In preparation to enabling -Wvla, remove VLA. In this particular
case use macro ARRAY_SIZE so the length of array _bo_ can be
computed at preprocessing time.

The use of stack Variable Length Arrays needs to be avoided, as they
can be a vector for stack exhaustion, which can be both a runtime bug
or a security flaw. Also, in general, as code evolves it is easy to
lose track of how big a VLA can get. Thus, we can end up having runtime
failures that are hard to debug.

Also, fixed as part of the directive to remove all VLAs from
the kernel: https://lkml.org/lkml/2018/3/7/621

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20180313143151.GA27486@embeddedgus
drivers/gpu/drm/vc4/vc4_validate.c