OSDN Git Service

soc: qcom: ocmem: don't return NULL in of_get_ocmem
authorLuca Weiss <luca@z3ntu.xyz>
Sat, 30 Jan 2021 14:23:49 +0000 (15:23 +0100)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 2 Feb 2021 21:39:13 +0000 (15:39 -0600)
commit01f937ffc4686837d6c43dea80c6ade6cbd2940a
treec061c89ffb783579811cff10deef9b5e9c2955d0
parentaec8535edccb943adc067d184af1a3370f5b9568
soc: qcom: ocmem: don't return NULL in of_get_ocmem

If ocmem probe fails for whatever reason, of_get_ocmem returned NULL.
Without this, users must check for both NULL and IS_ERR on the returned
pointer - which didn't happen in drivers/gpu/drm/msm/adreno/adreno_gpu.c
leading to a NULL pointer dereference.

Reviewed-by: Brian Masney <masneyb@onstation.org>
Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver")
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Link: https://lore.kernel.org/r/20210130142349.53335-1-luca@z3ntu.xyz
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/soc/qcom/ocmem.c