OSDN Git Service

SMB: Validate negotiate (to protect against downgrade) even if signing off
authorSteve French <smfrench@gmail.com>
Thu, 21 Sep 2017 00:57:18 +0000 (19:57 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Oct 2017 07:41:45 +0000 (09:41 +0200)
commit02ef29f9cbb616bf41900c427830dc8bf3f52d99
tree15b6b62912216050f5dd2d7e20cd521660b2268c
parentc096b31f9d9a6fc479b85ab51b37c44eaf9529cf
SMB: Validate negotiate (to protect against downgrade) even if signing off

commit 0603c96f3af50e2f9299fa410c224ab1d465e0f9 upstream.

As long as signing is supported (ie not a guest user connection) and
connection is SMB3 or SMB3.02, then validate negotiate (protect
against man in the middle downgrade attacks).  We had been doing this
only when signing was required, not when signing was just enabled,
but this more closely matches recommended SMB3 behavior and is
better security.  Suggested by Metze.

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Acked-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/smb2pdu.c