OSDN Git Service

IB/usnic: Use struct_size() in kmalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 7 Jan 2019 17:39:54 +0000 (11:39 -0600)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 7 Jan 2019 18:43:03 +0000 (11:43 -0700)
commit02fc1848414e116b948ebd70e865b7539e5d7b8d
treeb8e8a133fea2b8b7b05fa3e0ba5f755faab582ed
parentb5c61b968def698c21e1aa8ae402cca393fe491f
IB/usnic: Use struct_size() in kmalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kmalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/usnic/usnic_uiom.c