OSDN Git Service

brcmsmac: split up wlc_phy_workarounds_nphy
authorArnd Bergmann <arnd@arndb.de>
Fri, 22 Sep 2017 21:29:13 +0000 (23:29 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 27 Oct 2017 07:50:29 +0000 (10:50 +0300)
commit0425f079590c1e10561642c265523e4ccec2d9c7
tree15145d749fdf4efb0c97f1969c921e6559b207a4
parent78ce6a9083c4f5ac1a73aa0b614c852db2d4e982
brcmsmac: split up wlc_phy_workarounds_nphy

The stack consumption in this driver is still relatively high, with one
remaining warning if the warning level is lowered to 1536 bytes:

drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c:17135:1: error: the frame size of 1880 bytes is larger than 1536 bytes [-Werror=frame-larger-than=]

The affected function is actually a collection of three separate implementations,
and each of them is fairly large by itself. Splitting them up is done easily
and improves readability at the same time.

I'm leaving the original indentation to make the review easier.

Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c