OSDN Git Service

Get rid of adjust_appendrel_attr_needed(), which has been broken ever since
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 11 Nov 2008 18:13:32 +0000 (18:13 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 11 Nov 2008 18:13:32 +0000 (18:13 +0000)
commit04366799694418ed899e95ce45143a699a75116e
treebb54fee3da6b1b10fef6fdeeb7b238fa9b69c6b0
parentccc9073f26b8504e5ce168738ffcc4c4c8d2fa0a
Get rid of adjust_appendrel_attr_needed(), which has been broken ever since
we extended the appendrel mechanism to support UNION ALL optimization.  The
reason nobody noticed was that we are not actually using attr_needed data for
appendrel children; hence it seems more reasonable to rip it out than fix it.
Back-patch to 8.2 because an Assert failure is possible in corner cases.
Per examination of an example from Jim Nasby.

In HEAD, also get rid of AppendRelInfo.col_mappings, which is quite inadequate
to represent UNION ALL situations; depend entirely on translated_vars instead.
src/backend/nodes/copyfuncs.c
src/backend/nodes/equalfuncs.c
src/backend/nodes/outfuncs.c
src/backend/optimizer/path/allpaths.c
src/backend/optimizer/prep/prepjointree.c
src/backend/optimizer/prep/prepunion.c
src/include/nodes/relation.h
src/include/optimizer/prep.h