OSDN Git Service

KVM: VMX: Don't use vcpu->run->internal.ndata as an array index
authorReiji Watanabe <reijiw@google.com>
Tue, 13 Apr 2021 15:47:40 +0000 (15:47 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 13 Apr 2021 22:23:41 +0000 (18:23 -0400)
commit04c4f2ee3f68c9a4bf1653d15f1a9a435ae33f7a
tree43993d21b858cc8b24c9f6cb909f2dd837fb3bcb
parent315f02c60d9425b38eb8ad7f21b8a35e40db23f9
KVM: VMX: Don't use vcpu->run->internal.ndata as an array index

__vmx_handle_exit() uses vcpu->run->internal.ndata as an index for
an array access.  Since vcpu->run is (can be) mapped to a user address
space with a writer permission, the 'ndata' could be updated by the
user process at anytime (the user process can set it to outside the
bounds of the array).
So, it is not safe that __vmx_handle_exit() uses the 'ndata' that way.

Fixes: 1aa561b1a4c0 ("kvm: x86: Add "last CPU" to some KVM_EXIT information")
Signed-off-by: Reiji Watanabe <reijiw@google.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
Message-Id: <20210413154739.490299-1-reijiw@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/vmx/vmx.c