OSDN Git Service

staging: vchiq_2835_arm: Make cache-line-size a required DT property
authorMichael Zoran <mzoran@crowfest.net>
Sat, 18 Feb 2017 11:22:01 +0000 (03:22 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Oct 2017 15:21:34 +0000 (17:21 +0200)
commit0500fcd885561a41d49ef635453247df41a80df5
treebc2f802b4c503f522e43d48de26e7463bfe240dc
parentb1b73cc0460837f328d091de2746040e30fbd808
staging: vchiq_2835_arm: Make cache-line-size a required DT property

[ Upstream commit 6cf1bf636a067eb308cb3a8322b9d6b1844a075d ]

The original github source allowed for the cache-line-size property
to be missing.  Since recent firmwares also require this property,
it makes sense to always require it in the driver as well.

If the cache-line-size property is missing, then the driver probe
should fail as no dev since the kernel and dt may be out of sync.
The fix is to add a check for the return value of of_property_read_u32.

Changes V2:
1. Add error message if cache-line-size is missing.
2. Simple check for non-zero return value from
   of_property_read_u32.

Signed-off-by: Michael Zoran <mzoran@crowfest.net>
Acked-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c