OSDN Git Service

drivers: net: sky2: Fix -Wstringop-truncation with W=1
authorAndrew Lunn <andrew@lunn.ch>
Tue, 10 Nov 2020 02:32:22 +0000 (03:32 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Nov 2020 01:42:24 +0000 (17:42 -0800)
commit0575bedd6a1575e3f585b5dd5621cdcd26978054
tree0f38954163869f6ac2fa910eb19f60b1a468b216
parent2492ae6bee24d0b7d2f51e5d0b87ec4f968a74b3
drivers: net: sky2: Fix -Wstringop-truncation with W=1

In function ‘strncpy’,
    inlined from ‘sky2_name’ at drivers/net/ethernet/marvell/sky2.c:4903:3,
    inlined from ‘sky2_probe’ at drivers/net/ethernet/marvell/sky2.c:5049:2:
./include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]

None of the device names are 16 characters long, so it was never an
issue. But replace the strncpy with an snprintf() to prevent the
theoretical overflow.

Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Link: https://lore.kernel.org/r/20201110023222.1479398-1-andrew@lunn.ch
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/sky2.c