OSDN Git Service

ice: Don't dereference NULL in ice_gnss_read error path
authorSimon Horman <horms@kernel.org>
Thu, 25 May 2023 10:52:58 +0000 (12:52 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Thu, 8 Jun 2023 15:38:56 +0000 (08:38 -0700)
commit05a1308a2e08e4a375bf60eb4c6c057a201d81fc
treedc3ed802c344bdbb8f68d7245957512666321695
parent6c0ec7ab5aaff3706657dd4946798aed483b9471
ice: Don't dereference NULL in ice_gnss_read error path

If pf is NULL in ice_gnss_read() then it will be dereferenced
in the error path by a call to dev_dbg(ice_pf_to_dev(pf), ...).

Avoid this by simply returning in this case.
If logging is desired an alternate approach might be to
use pr_err() before returning.

Flagged by Smatch as:

  .../ice_gnss.c:196 ice_gnss_read() error: we previously assumed 'pf' could be null (see line 131)

Fixes: 43113ff73453 ("ice: add TTY for GNSS module for E810T device")
Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_gnss.c