OSDN Git Service

drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity
authorMaxime Ripard <maxime@cerno.tech>
Thu, 29 Sep 2022 16:30:58 +0000 (18:30 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 10 Oct 2022 11:55:47 +0000 (13:55 +0200)
commit05e70e32f712e9fdf8a351caf97ba60fa8b71b44
tree999ad8507e279d984a26348f8c0c977b72356a47
parent542bbaa736026c99237d6d93e4fff46762a55ff7
drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity

We currently have two sets of TV properties.

The first one is there to deal with analog TV properties, creating
properties such as the TV mode, subconnectors, saturation, hue and so on.
It's created by calling the drm_mode_create_tv_properties() function.

The second one is there to deal with properties that might be useful on a
TV, creating the overscan margins for example. It's created by calling the
drm_mode_create_tv_margin_properties().

However, we also have a drm_atomic_helper_connector_tv_reset() function
that will reset the TV margin properties to their default values, and thus
is supposed to be called for the latter set. This creates an ambiguity due
to the inconsistent naming.

We can thus rename the drm_atomic_helper_connector_tv_reset() function to
drm_atomic_helper_connector_tv_margins_reset() to remove that ambiguity
and hopefully make it more obvious.

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
Link: https://lore.kernel.org/r/20220728-rpi-analog-tv-properties-v4-4-60d38873f782@cerno.tech
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
drivers/gpu/drm/drm_atomic_state_helper.c
drivers/gpu/drm/gud/gud_connector.c
drivers/gpu/drm/vc4/vc4_hdmi.c
include/drm/drm_atomic_state_helper.h