OSDN Git Service

dmaengine: rcar-dmac: refactor the error handling code of rcar_dmac_probe
authorDongliang Mu <mudongliangabcd@gmail.com>
Wed, 20 Oct 2021 14:35:33 +0000 (22:35 +0800)
committerVinod Koul <vkoul@kernel.org>
Mon, 25 Oct 2021 04:23:50 +0000 (09:53 +0530)
commit05f4fae9a2f5785d180b48ee93d7fa75425091c3
treef5c4013d346ca7377d9c86ea7a0cb1bb89372de2
parente7e1e880b114ca640a2f280b0d5d38aed98f98c6
dmaengine: rcar-dmac: refactor the error handling code of rcar_dmac_probe

In rcar_dmac_probe, if pm_runtime_resume_and_get fails, it forgets to
disable runtime PM. And of_dma_controller_free should only be invoked
after the success of of_dma_controller_register.

Fix this by refactoring the error handling code.

Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20211020143546.3436205-1-mudongliangabcd@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sh/rcar-dmac.c