OSDN Git Service

mtd: rawnand: denali: fix a race condition when DMA is kicked
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Thu, 13 Sep 2018 05:58:49 +0000 (14:58 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 29 Sep 2018 09:55:56 +0000 (02:55 -0700)
commit0639ddca2c8cfdfe9b443712914de9a824908d19
treef08c693dece52ea7a1595b88524c9c9a33ec2fde
parentf11b8aad34fa7b0ec1ca2a45d2d2a826ebf41c32
mtd: rawnand: denali: fix a race condition when DMA is kicked

commit cf51e4b9c34407bf0c3d9b582b7837e047e1df47 upstream.

I thought the read-back of the DMA_ENABLE register was unnecessary
(at least it is working on my boards), then deleted it in commit
586a2c52909d ("mtd: nand: denali: squash denali_enable_dma() helper
into caller").  Sorry, I was wrong - it caused a timing issue on
Cyclone5 SoCFPGAs.

Revive the register read-back, commenting why this is necessary.

Fixes: 586a2c52909d ("mtd: nand: denali: squash denali_enable_dma() helper into caller")
Cc: <stable@vger.kernel.org>
Reported-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/nand/raw/denali.c