OSDN Git Service

qga/win32: Use rundll for VSS installation
authorKonstantin Kostiuk <kkostiuk@redhat.com>
Fri, 3 Mar 2023 19:20:08 +0000 (21:20 +0200)
committerKonstantin Kostiuk <kkostiuk@redhat.com>
Wed, 8 Mar 2023 16:23:40 +0000 (18:23 +0200)
commit07ce178a2b0768eb9e712bb5ad0cf6dc7fcf0158
tree50e4290ed02fc22bbcce4b02519db1f40a6e84a9
parent88288c2a51faa7c795f053fc8b31b1c16ff804c5
qga/win32: Use rundll for VSS installation

The custom action uses cmd.exe to run VSS Service installation
and removal which causes an interactive command shell to spawn.
This shell can be used to execute any commands as a SYSTEM user.
Even if call qemu-ga.exe directly the interactive command shell
will be spawned as qemu-ga.exe is a console application and used
by users from the console as well as a service.

As VSS Service runs from DLL which contains the installer and
uninstaller code, it can be run directly by rundll32.exe without
any interactive command shell.

Add specific entry points for rundll which is just a wrapper
for COMRegister/COMUnregister functions with proper arguments.

resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2167423
fixes: CVE-2023-0664 (part 2 of 2)

Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Reviewed-by: Yan Vugenfirer <yvugenfi@redhat.com>
Reported-by: Brian Wiltse <brian.wiltse@live.com>
qga/installer/qemu-ga.wxs
qga/vss-win32/install.cpp
qga/vss-win32/qga-vss.def