OSDN Git Service

scsi: lpfc: Fix null ptr oops updating lpfc_devloss_tmo via sysfs attribute
authorJames Smart <jsmart2021@gmail.com>
Wed, 14 Aug 2019 23:56:45 +0000 (16:56 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 20 Aug 2019 02:41:09 +0000 (22:41 -0400)
commit07f50997d66c3273121dd6b8a7d433cdfb5395c1
tree5bd09c8a898b1e0b26249396c972f6f50ceb5539
parent6ede2ddd8bdd28bdaf43d15e70dc0ef38c5448db
scsi: lpfc: Fix null ptr oops updating lpfc_devloss_tmo via sysfs attribute

If an admin updates lpfc's devloss_tmo sysfs attribute, the kernel will
oops.

Coding of a loop allowed a new value (rport) to be set/checked for null
followed by an older value (remoteport) checked for null to allow progress
where the new value, even though null, will be referenced.

Rework the logic to validate and prevent any reference to the null ptr.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_attr.c