OSDN Git Service

irqchip/ingenic-tcu: Use correctly sized arguments for bit field
authorKees Cook <keescook@chromium.org>
Wed, 15 Dec 2021 23:24:57 +0000 (15:24 -0800)
committerMarc Zyngier <maz@kernel.org>
Thu, 16 Dec 2021 15:19:52 +0000 (15:19 +0000)
commit0859bbb07d06d1357734496ff198319f9bfcf1bf
tree9ba1041e4cea5a3cb7ddf8b493f37104fdc5645c
parentc10f2f8b5d8027c1ea77f777f2d16cb9043a6c09
irqchip/ingenic-tcu: Use correctly sized arguments for bit field

The find.h APIs are designed to be used only on unsigned long arguments.
This can technically result in a over-read, but it is harmless in this
case. Regardless, fix it to avoid the warning seen under -Warray-bounds,
which we'd like to enable globally:

In file included from ./include/linux/bitmap.h:9,
                 from ./include/linux/cpumask.h:12,
                 from ./include/linux/smp.h:13,
                 from ./include/linux/lockdep.h:14,
                 from ./include/linux/mutex.h:17,
                 from ./include/linux/notifier.h:14,
                 from ./include/linux/clk.h:14,
                 from drivers/irqchip/irq-ingenic-tcu.c:7:
drivers/irqchip/irq-ingenic-tcu.c: In function 'ingenic_tcu_intc_cascade':
./include/linux/find.h:40:23: warning: array subscript 'long unsigned int[0]' is partly outside array bounds of 'uint32_t[1]' {aka 'unsigned int[1]'} [-Warray-bounds]
   40 |                 val = *addr & GENMASK(size - 1, offset);
      |                       ^~~~~
drivers/irqchip/irq-ingenic-tcu.c:30:18: note: while referencing 'irq_reg'
   30 |         uint32_t irq_reg, irq_mask;
      |                  ^~~~~~~

Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20211215232457.2069969-1-keescook@chromium.org
drivers/irqchip/irq-ingenic-tcu.c