OSDN Git Service

uprobes: Kill write_opcode()->lock_page(new_page)
authorOleg Nesterov <oleg@redhat.com>
Sun, 29 Jul 2012 18:22:18 +0000 (20:22 +0200)
committerIngo Molnar <mingo@kernel.org>
Mon, 30 Jul 2012 09:27:19 +0000 (11:27 +0200)
commit089ba999dc881a7549d97c55ac9e0052d061867d
treee5278f9ecb3a7405545b940b9b64abeb2121b4cc
parentc517ee744b96e441d9c731e245f83c6d08dc0a19
uprobes: Kill write_opcode()->lock_page(new_page)

write_opcode() does lock_page(new_page) for no reason. Nobody
can see this page until __replace_page() exposes it under ptl
lock, and we do nothing with this page after pte_unmap_unlock().

If nothing else, the similar code in do_wp_page() doesn't lock
the new page for page_add_new_anon_rmap/set_pte_at_notify.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar.vnet.ibm.com>
Cc: Anton Arapov <anton@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20120729182218.GA20315@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/events/uprobes.c