OSDN Git Service

wifi: iwlwifi: mvm: remove setting of 'sta' parameter
authorTom Rix <trix@redhat.com>
Tue, 14 Mar 2023 17:49:27 +0000 (19:49 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 15 Mar 2023 12:25:14 +0000 (13:25 +0100)
commit093e71e26d67c2b0d194b34a7b56432bab049e90
tree98b7a11756e2a6ac79a5fde5040accc8fe486da3
parent6f71e90e65e9bb5d5e12199e19670bb4973a6e39
wifi: iwlwifi: mvm: remove setting of 'sta' parameter

cppcheck reports
[drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2686]: (warning) Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?

The setting of the 'sta' parameter is not needed.  In the if-check that sets it
to NULL, mvm_sta is also set to NULL.  Then the next statement checks if
mvm_sta is NULL and does an early return. So remove setting sta.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Gregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230314194113.711fe28cfdd6.I2f723f9d44f65720baaf3e84b72109759350a8f5@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/rs.c