OSDN Git Service

drm/msm: Fix error return checking
authorWen Yang <wen.yang99@zte.com.cn>
Thu, 29 Nov 2018 06:01:50 +0000 (14:01 +0800)
committerSean Paul <seanpaul@chromium.org>
Mon, 3 Dec 2018 13:46:14 +0000 (08:46 -0500)
commit098336deb946f37a70afc0979af388b615c378bf
tree77fe6a8a96a9807b347c53ca3512f75ac5b84eb5
parentd9a75a6201d9367a452de59d7759b708633f1a1f
drm/msm: Fix error return checking

The error checks on ret for a negative error return always fails because
the return value of iommu_map_sg() is unsigned and can never be negative.

Detected with Coccinelle:
drivers/gpu/drm/msm/msm_iommu.c:69:9-12: WARNING: Unsigned expression
compared with zero: ret < 0

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
CC: Rob Clark <robdclark@gmail.com>
CC: David Airlie <airlied@linux.ie>
CC: Julia Lawall <julia.lawall@lip6.fr>
CC: linux-arm-msm@vger.kernel.org
CC: dri-devel@lists.freedesktop.org
CC: freedreno@lists.freedesktop.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Sean Paul <seanpaul@chromium.org>
drivers/gpu/drm/msm/msm_iommu.c