OSDN Git Service

svcrdma: Hold private mutex while invoking rdma_accept()
authorChuck Lever <chuck.lever@oracle.com>
Tue, 9 Feb 2021 15:48:57 +0000 (10:48 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 15 Feb 2021 15:45:00 +0000 (10:45 -0500)
commit0ac24c320c4d89a9de6ec802591398b8675c7b3c
tree028e11f7256f1d549a261cd7292ed2126225021a
parentbd5ae9288d6451bd346a1b4a59d4fe7e62ba29b7
svcrdma: Hold private mutex while invoking rdma_accept()

RDMA core mutex locking was restructured by commit d114c6feedfe
("RDMA/cma: Add missing locking to rdma_accept()") [Aug 2020]. When
lock debugging is enabled, the RPC/RDMA server trips over the new
lockdep assertion in rdma_accept() because it doesn't call
rdma_accept() from its CM event handler.

As a temporary fix, have svc_rdma_accept() take the handler_mutex
explicitly. In the meantime, let's consider how to restructure the
RPC/RDMA transport to invoke rdma_accept() from the proper context.

Calls to svc_rdma_accept() are serialized with calls to
svc_rdma_free() by the generic RPC server layer.

Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/linux-rdma/20210209154014.GO4247@nvidia.com/
Fixes: d114c6feedfe ("RDMA/cma: Add missing locking to rdma_accept()")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
net/sunrpc/xprtrdma/svc_rdma_transport.c