OSDN Git Service

HID: core: fix dmesg flooding if report field larger than 32bit
authorJoshua Clayton <stillcompiling@gmail.com>
Mon, 12 Aug 2019 15:20:22 +0000 (09:20 -0600)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Wed, 18 Sep 2019 13:58:13 +0000 (15:58 +0200)
commit0af10eed9b7308187c7865024248b2a2a5aa382a
tree4c085429812605fff6a320afaee129c5e85c2b77
parentaaeabb121a6271775cef35ec3197e9ef124fdb2a
HID: core: fix dmesg flooding if report field larger than 32bit

Only warn once of oversize hid report value field

On HP spectre x360 convertible the message:
hid-sensor-hub 001F:8087:0AC2.0002: hid_field_extract() called with n (192) > 32! (kworker/1:2)
is continually printed many times per second, crowding out all else.
Protect dmesg by printing the warning only one time.

The size of the hid report field data structure should probably be increased.
The data structure is treated as a u32 in Linux, but an unlimited number
of bits in the USB hid spec, so there is some rearchitecture needed now that
devices are sending more than 32 bits.

Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/hid-core.c