OSDN Git Service

Clean up some minor problems exposed by further thought about Panon's bug
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 1 Jun 2001 02:41:36 +0000 (02:41 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 1 Jun 2001 02:41:36 +0000 (02:41 +0000)
commit0b370ea7c81228339da5a447057dbf5f874e0197
tree125c8590975f212a7caec6667f95f28d772bb928
parenta1d9d096f0f36afcdd4ca69afb41cd645b9834d2
Clean up some minor problems exposed by further thought about Panon's bug
report on old-style functions invoked by RI triggers.  We had a number of
other places that were being sloppy about which memory context FmgrInfo
subsidiary data will be allocated in.  Turns out none of them actually
cause a problem in 7.1, but this is for arcane reasons such as the fact
that old-style triggers aren't supported anyway.  To avoid getting burnt
later, I've restructured the trigger support so that we don't keep trigger
FmgrInfo structs in relcache memory.  Some other related cleanups too:
it's not really necessary to call fmgr_info at all while setting up
the index support info in relcache entries, because those ScanKeyEntry
structs are never used to invoke the functions.  This should speed up
relcache initialization a tiny bit.
16 files changed:
doc/src/sgml/trigger.sgml
src/backend/access/common/scankey.c
src/backend/access/index/indexam.c
src/backend/access/index/istrat.c
src/backend/catalog/index.c
src/backend/catalog/pg_operator.c
src/backend/commands/copy.c
src/backend/commands/trigger.c
src/backend/executor/execMain.c
src/backend/utils/cache/catcache.c
src/backend/utils/cache/relcache.c
src/backend/utils/fmgr/fmgr.c
src/include/access/skey.h
src/include/commands/trigger.h
src/include/nodes/execnodes.h
src/include/utils/rel.h