OSDN Git Service

regulator: twl-regulator: Fix off-by-one vsel setting in twl6030smps_set_voltage
authorAxel Lin <axel.lin@gmail.com>
Tue, 10 Apr 2012 15:07:52 +0000 (23:07 +0800)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Tue, 10 Apr 2012 16:28:52 +0000 (17:28 +0100)
commit0cb2f1239dd7acf72fb60adb53c1fdaa65b719a2
tree8226f9e3054e927dc50c38e8fabb3cb0ff82e4f4
parent19a8da2187249c02574ccffaf72637eb224d11c4
regulator: twl-regulator: Fix off-by-one vsel setting in twl6030smps_set_voltage

commit 268a1 "regulator: twl-regulator: Use DIV_ROUND_UP at appropriate places"
introduced an off-by-one bug for setting vsel.

The linear calculation code in twl6030smps_list_voltage() does subtract index
by 1 so we need the vsel++ after DIV_ROUND_UP.

The original code use this trick to differentiate if we are going to set the
voltage to 0 or the voltage falls within the linear calculation range.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/regulator/twl-regulator.c