OSDN Git Service

net: phy: abort loading yt8511 driver in unsupported modes
authorPeter Geis <pgwipeout@gmail.com>
Sat, 29 May 2021 11:05:56 +0000 (07:05 -0400)
committerJakub Kicinski <kuba@kernel.org>
Sun, 30 May 2021 21:24:38 +0000 (14:24 -0700)
commit0cc8bddb5b0665283baba6d89684630663c0ccbd
tree2f6316473747920bdcaf82e9f398751838b97bcd
parent546d6bad18c04926c4d0eba4222654a9a60ea830
net: phy: abort loading yt8511 driver in unsupported modes

While investigating the clang `ge` uninitialized variable report, it was
discovered the default switch would have unintended consequences. Due to
the switch to __phy_modify, the driver would modify the ID values in the
default scenario.

Fix this by promoting the interface mode switch and aborting when the
mode is not a supported RGMII mode.

This prevents the `ge` and `fe` variables from ever being used
uninitialized.

Fixes: 48e8c6f1612b ("net: phy: add driver for Motorcomm yt8511 phy")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/motorcomm.c