OSDN Git Service

drm/i915/guc: Assert we have the doorbell before setting it up
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 1 May 2018 07:52:03 +0000 (08:52 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 2 May 2018 16:33:32 +0000 (17:33 +0100)
commit0d4b78b3d2c0cb570abe086bce8c17ea3c474095
tree54f2ba78477859ad1f864e8535fbcfe505c48801
parent46e2068081e96472b1d7d2456fa0655aa148b32b
drm/i915/guc: Assert we have the doorbell before setting it up

As our early doorbell is split between early allocation and a late setup
after we have a channel to the GuC, it may happen due to a lapse of
programmer judgement that we try to setup an invalid doorbell. Make use
of our has_doorbell() function to check the doorbell does exist for the
client before we try and tell the guc about it. In doing so, we prevent
the compiler from warning about the otherwise unused function in some
configurations.

Reported-by: Matthias Kaehlcke <mka@chromium.org>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: MichaƂ Winiarski <michal.winiarski@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Michel Thierry <michel.thierry@intel.com>
Reviewed-by: Michel Thierry <michel.thierry@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180501075203.12458-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_guc_submission.c