OSDN Git Service

Revert "fbdev: vesafb: Allow to be built if COMPILE_TEST is enabled"
authorJavier Martinez Canillas <javierm@redhat.com>
Fri, 10 Jun 2022 08:54:50 +0000 (10:54 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Mon, 13 Jun 2022 17:21:12 +0000 (19:21 +0200)
commit0d4e57e5af39fef28de6c89b0b97741dedb4b72f
tree3b5bbb6f1a732a9e9c224d849f3d498aeec3f8a1
parent53b93c0ff71ac6f97c1ab2ad84ee8b540f40cb95
Revert "fbdev: vesafb: Allow to be built if COMPILE_TEST is enabled"

This reverts commit fa0e256450f27a7d85f65c63f05e6897954a1d53. The kernel
test robot reported that attempting to build the vesafb driver fails on
some architectures, because these don't define a `struct screen_info`.

This leads to linking errors, for example on parisc with allyesconfig:

  hppa-linux-ld: drivers/video/fbdev/vesafb.o: in function `vesafb_probe':
>> (.text+0x738): undefined reference to `screen_info'
>> hppa-linux-ld: (.text+0x73c): undefined reference to `screen_info'
   hppa-linux-ld: drivers/firmware/sysfb.o: in function `sysfb_init':
>> (.init.text+0x28): undefined reference to `screen_info'
>> hppa-linux-ld: (.init.text+0x30): undefined reference to `screen_info'
   hppa-linux-ld: (.init.text+0x78): undefined reference to `screen_info'

The goal of commit fa0e256450f2 ("fbdev: vesafb: Allow to be built if
COMPILE_TEST is enabled") was to have more build coverage for the driver
but it wrongly assumed that all architectures would define a screen_info.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20220610085450.1341880-1-javierm@redhat.com
drivers/video/fbdev/Kconfig