OSDN Git Service

nfc: llcp: fix possible use of uninitialized variable in nfc_llcp_send_connect()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sat, 13 May 2023 11:52:04 +0000 (13:52 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 May 2023 12:03:34 +0000 (13:03 +0100)
commit0d9b41daa5907756a31772d8af8ac5ff25cf17c1
treecabef066f507d9470e9e9fb15a175e6082095680
parentd1e4632b304c594d6f0d4cb7581350e5a6fc33b7
nfc: llcp: fix possible use of uninitialized variable in nfc_llcp_send_connect()

If sock->service_name is NULL, the local variable
service_name_tlv_length will not be assigned by nfc_llcp_build_tlv(),
later leading to using value frmo the stack.  Smatch warning:

  net/nfc/llcp_commands.c:442 nfc_llcp_send_connect() error: uninitialized symbol 'service_name_tlv_length'.

Fixes: de9e5aeb4f40 ("NFC: llcp: Fix usage of llcp_add_tlv()")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/nfc/llcp_commands.c