OSDN Git Service

net: fec: Fix PHY init after phy_reset_after_clk_enable()
authorMarek Vasut <marex@denx.de>
Tue, 6 Oct 2020 13:52:53 +0000 (15:52 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 9 Oct 2020 15:17:11 +0000 (08:17 -0700)
commit0da1ccbbefb662915228bc17e1c7d4ad28b3ddab
tree86ac4ca670c1aa1b239f12724b93200236eb1e26
parent3fdd47c3b40ac48e6e6e5904cf24d12e6e073a96
net: fec: Fix PHY init after phy_reset_after_clk_enable()

The phy_reset_after_clk_enable() does a PHY reset, which means the PHY
loses its register settings. The fec_enet_mii_probe() starts the PHY
and does the necessary calls to configure the PHY via PHY framework,
and loads the correct register settings into the PHY. Therefore,
fec_enet_mii_probe() should be called only after the PHY has been
reset, not before as it is now.

Fixes: 1b0a83ac04e3 ("net: fec: add phy_reset_after_clk_enable() support")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Richard Leitner <richard.leitner@skidata.com>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fec_main.c