OSDN Git Service

x86/mm: Don't free P4D table when it is folded at runtime
authorAndrey Ryabinin <aryabinin@virtuozzo.com>
Mon, 25 Jun 2018 10:24:27 +0000 (13:24 +0300)
committerIngo Molnar <mingo@kernel.org>
Tue, 26 Jun 2018 07:21:48 +0000 (09:21 +0200)
commit0e311d237d7f3022b7dafb639b42541bfb42fe94
treee85cd99eb616208781f58e1f9034f3d752f60639
parent236f0cd286b67291796362feeac4f342900cfa82
x86/mm: Don't free P4D table when it is folded at runtime

When the P4D page table layer is folded at runtime, the p4d_free()
should do nothing, the same as in <asm-generic/pgtable-nop4d.h>.

It seems this bug should cause double-free in efi_call_phys_epilog(),
but I don't know how to trigger that code path, so I can't confirm that
by testing.

Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org # 4.17
Fixes: 98219dda2ab5 ("x86/mm: Fold p4d page table layer at runtime")
Link: http://lkml.kernel.org/r/20180625102427.15015-1-aryabinin@virtuozzo.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/pgalloc.h