OSDN Git Service

drm/amd/pm: Replace one-element array with flexible-array in struct phm_acp_clock_vol...
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 7 Oct 2020 16:05:22 +0000 (11:05 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Oct 2020 18:43:29 +0000 (14:43 -0400)
commit0e319cfeb3c3e13088e78bfc379df15358f59fb0
tree019fbde58b6a874aca330d143b46bf1f34e5c088
parent737123d67e02fdd6597aaac168e0c17e984c4234
drm/amd/pm: Replace one-element array with flexible-array in struct phm_acp_clock_voltage_dependency_table

There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].

Refactor the code according to the use of a flexible-array member in
struct phm_acp_clock_voltage_dependency_table, instead of a one-element
array, and use the struct_size() helper to calculate the size for the
allocation.

Also, save some heap space as the original code is multiplying
table->numEntries by sizeof(struct phm_acp_clock_voltage_dependency_table)
when it should have multiplied it by sizeof(phm_acp_clock_voltage_dependency_record)
instead.

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9-rc1/process/deprecated.html#zero-length-and-one-element-arrays

Build-tested-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/5f7c5d3c.TyfOhg%2FA6JycL6ZN%25lkp@intel.com/
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/inc/hwmgr.h
drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c