OSDN Git Service

orangefs: don't mess with I_DIRTY_TIMES in orangefs_flush
authorMike Marshall <hubcap@omnibond.com>
Wed, 8 Apr 2020 13:05:45 +0000 (09:05 -0400)
committerMike Marshall <hubcap@omnibond.com>
Wed, 8 Apr 2020 13:39:11 +0000 (09:39 -0400)
commit0e393a9a8f2a450862964451715d68e9a96a9c34
treeb412f06fc4872a5a632d5f5b2df89b6e083110dc
parentec95f1dedc9c64ac5a8b0bdb7c276936c70fdedd
orangefs: don't mess with I_DIRTY_TIMES in orangefs_flush

Christoph Hellwig noticed that we were doing some unnecessary
work in orangefs_flush:

  orangefs_flush just writes out data on every close(2) call.  There is
  no need to change anything about the dirty state, especially as
  orangefs doesn't treat I_DIRTY_TIMES special in any way.  The code
  seems to come from partially open coding vfs_fsync.

He sent in a patch with the above commit message and also a
patch that was a reversion of another Orangefs patch I had
sent upstream a while ago. I had to fix his reversion patch
so that it would compile which caused his "don't mess with
I_DIRTY_TIMES" patch to fail to apply. So here I have just
remade his patch and applied it after the fixed reversion patch.

Signed-off-by: Mike Marshall <hubcap@omnibond.com>
fs/orangefs/file.c