OSDN Git Service

iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()
authorPan Bian <bianpan2016@163.com>
Sun, 23 Apr 2017 10:23:21 +0000 (18:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jul 2017 12:40:30 +0000 (14:40 +0200)
commit0e55856b8f2918f3a6b8caf3c72867ee88f816dd
tree6de1b89b34b1de032f1a27609b0e293c48f909ac
parentf0c31c674abdf563d2ad5d9ecfcad8d237f939f0
iommu/amd: Fix incorrect error handling in amd_iommu_bind_pasid()

commit 73dbd4a4230216b6a5540a362edceae0c9b4876b upstream.

In function amd_iommu_bind_pasid(), the control flow jumps
to label out_free when pasid_state->mm and mm is NULL. And
mmput(mm) is called.  In function mmput(mm), mm is
referenced without validation. This will result in a NULL
dereference bug. This patch fixes the bug.

Signed-off-by: Pan Bian <bianpan2016@163.com>
Fixes: f0aac63b873b ('iommu/amd: Don't hold a reference to mm_struct')
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iommu/amd_iommu_v2.c