OSDN Git Service

drm/i915: Simplify onion for bxt_ddi_phy_init()
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 7 Nov 2017 13:53:24 +0000 (13:53 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 7 Nov 2017 17:50:32 +0000 (17:50 +0000)
commit0e870bf872929a026c58a74608734b89a95dda74
tree12a06a97cfab34906f7ba8d9dd754e5e9d2517d8
parent2f59f1b33a84447247b21be60ecf05080ce2982a
drm/i915: Simplify onion for bxt_ddi_phy_init()

Older compilers (gcc-4.9) are not as able to track uninitialised
variables as well as more recent compilers. In particular,

drivers/gpu/drm/i915/intel_dpio_phy.c: In function ‘bxt_ddi_phy_init’:
drivers/gpu/drm/i915/intel_dpio_phy.c:482:25: warning: ‘was_enabled’ may be used uninitialized in this function [-Wmaybe-uninitialized]

In this case, we can rearrange code slightly to make the control flow
clearer to the reader, as well as the compiler. That is we only call
uninit using the same predicate as calling init

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171107135324.28300-1-chris@chris-wilson.co.uk
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
drivers/gpu/drm/i915/intel_dpio_phy.c