OSDN Git Service

mm/slub.c: init_on_free=1 should wipe freelist ptr for bulk allocations
authorAlexander Potapenko <glider@google.com>
Mon, 14 Oct 2019 21:11:57 +0000 (14:11 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 14 Oct 2019 22:04:01 +0000 (15:04 -0700)
commit0f181f9fbea8bc7ea2f7e13ae7f8c256b39e254c
treea6d1d1a674b791224d2430bae6d2fa69f10037b0
parent3c52b0af059e11a063970aed1ad143b9284a79c7
mm/slub.c: init_on_free=1 should wipe freelist ptr for bulk allocations

slab_alloc_node() already zeroed out the freelist pointer if
init_on_free was on.  Thibaut Sautereau noticed that the same needs to
be done for kmem_cache_alloc_bulk(), which performs the allocations
separately.

kmem_cache_alloc_bulk() is currently used in two places in the kernel,
so this change is unlikely to have a major performance impact.

SLAB doesn't require a similar change, as auto-initialization makes the
allocator store the freelist pointers off-slab.

Link: http://lkml.kernel.org/r/20191007091605.30530-1-glider@google.com
Fixes: 6471384af2a6 ("mm: security: introduce init_on_alloc=1 and init_on_free=1 boot options")
Signed-off-by: Alexander Potapenko <glider@google.com>
Reported-by: Thibaut Sautereau <thibaut@sautereau.fr>
Reported-by: Kees Cook <keescook@chromium.org>
Cc: Christoph Lameter <cl@linux.com>
Cc: Laura Abbott <labbott@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/slub.c