OSDN Git Service

media: v4l: omap_vout: vrfb: initialize DMA flags
authorArnd Bergmann <arnd@arndb.de>
Wed, 26 Jul 2017 15:23:07 +0000 (11:23 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 8 Aug 2017 10:35:10 +0000 (06:35 -0400)
commit0f59b2d0138b936d8d65ecbe193d512196199806
tree0021fb5d8a0e31c34a0a1ae8d0e3617c7923c173
parentf57cdbd34cb435ed3b7d38be6276f7f389e8d0e9
media: v4l: omap_vout: vrfb: initialize DMA flags

Passing uninitialized flags into device_prep_interleaved_dma is clearly
a bad idea, and we get a compiler warning for it:

drivers/media/platform/omap/omap_vout_vrfb.c: In function 'omap_vout_prepare_vrfb':
drivers/media/platform/omap/omap_vout_vrfb.c:273:5: error: 'flags' may be used uninitialized in this function [-Werror=maybe-uninitialized]

It seems that the OMAP dmaengine ignores the flags, but we should
pick the right ones anyway. This sets the flags I guessed based
on what other drivers used, and Peter confirmed that they are the
right ones.

Fixes: 6a1560ecaa8c ("media: v4l: omap_vout: vrfb: Convert to dmaengine")

Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/platform/omap/omap_vout_vrfb.c